GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1217
[CARBONDATA-1345] Update tablemeta cache after table schema has been changed
# Scenario
## Steps to reproduce
Start 2 spark-beeline as two different sessions, do the
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1217
@sraghunandan pls review this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r130503124
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -440,9 +510,17 @@ protected Expression getFilterPredicates
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r130501212
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
@@ -65,6 +65,31 @@ public PartitionInfo(List
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r130501996
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -303,6 +303,20 @@ public String getCarbonIndexFilePath
Github user xuchuanyin commented on the pull request:
https://github.com/apache/carbondata/commit/79feac96ae789851c5ad7306a7acaaba25d8e6c9#commitcomment-23407541
In
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala:
In
integration/spark2/src
Github user xuchuanyin commented on the pull request:
https://github.com/apache/carbondata/commit/79feac96ae789851c5ad7306a7acaaba25d8e6c9#commitcomment-23408394
In
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala:
In
integration/spark2/src
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1221
@zzcclp Title of PR or commit usually represents an action, like
`fixed`,`updated`,`Added`,`refactored`, etc.
---
If your project is set up for it, you can reply to this email and have your
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1227#discussion_r131138030
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -87,6 +87,10 @@ else if
(path.startsWith
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1227#discussion_r131137501
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java
---
@@ -312,18 +313,28 @@ public static
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1227#discussion_r131137046
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -713,16 +714,20 @@ object CommonUtil
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1227#discussion_r131294374
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java
---
@@ -312,18 +313,28 @@ public static
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1227#discussion_r131294865
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java
---
@@ -312,18 +313,28 @@ public static
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1227#discussion_r131295031
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -713,16 +714,20 @@ object CommonUtil
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1213#discussion_r131513710
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/AbsoluteTableIdentifier.java
---
@@ -99,8 +98,9 @@ public static
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1245
Would it be better to make a configuration (or read configuration from
spark) for thisï¼cc @jackylk
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1246
[CARBONDATA-1367] Change module dependency from spark1 to spark2
# Problems
When compiling Carbondata with profile spark-2.1,
`carbondata-examples-flink` will be compiled too. But this
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1246
This problem has already been solved by @chenliang613 in
https://github.com/apache/carbondata/pull/1232/commits/fd8299497f68c1e7307450e321e761913a817788
by moving `example-flink` from spark
Github user xuchuanyin closed the pull request at:
https://github.com/apache/carbondata/pull/1246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1239#discussion_r132685377
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
@@ -84,47 +92,66 @@
* @param
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1239#discussion_r132685712
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
@@ -84,47 +92,66 @@
* @param
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1253
[CARBONDATA-1373] Enhance update performance by increasing parallelism
# Scenario
Recently I have tested the update feature provided in Carbondata and found
its poor performance
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1253
@sraghunandan Do you mean partitionBy a customized partitioner or just
partitionedBy segmentIdï¼
partitionBy segmentId will forward all records of a segment to a single
partition
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1253
@sraghunandan I've implemented by using partitionBy as you suggested in
https://github.com/xuchuanyin/carbondata/pull/10/files, Is this OK?
I customize a partitioner and mak
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1261
[CARBONDATA-1373] Enhance update performance by increasing parallelism
# Scenario
Recently I have tested the update feature provided in Carbondata and found
its poor performance
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1261
Previous PR #1253 is closed, use this new PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1253
A new PR #1261 has been raised to solve this problem in a better way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user xuchuanyin closed the pull request at:
https://github.com/apache/carbondata/pull/1253
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1258#discussion_r133634143
--- Diff: docs/partition-guide.md ---
@@ -0,0 +1,124 @@
+
+
+### CarbonData Partition Table Guidance
+This guidance illustrates how
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1258#discussion_r133634053
--- Diff: docs/partition-guide.md ---
@@ -0,0 +1,124 @@
+
+
+### CarbonData Partition Table Guidance
+This guidance illustrates how
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1258#discussion_r133645471
--- Diff: docs/partition-guide.md ---
@@ -0,0 +1,124 @@
+
+
+### CarbonData Partition Table Guidance
+This guidance illustrates how
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1258#discussion_r133645214
--- Diff: docs/partition-guide.md ---
@@ -0,0 +1,124 @@
+
+
+### CarbonData Partition Table Guidance
+This guidance illustrates how
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1261
Test failed for `DataMapWriterSuite.scala:123` with message:
List("blocklet start 0", "add page data: blocklet 0, page 0", "add page
data: blocklet 0
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1261
retest this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1261
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1261
@sraghunandan @jackylk pls review this PR.
Besides, please pay attention to the previous comment
https://github.com/apache/carbondata/pull/1261#issuecomment-323000513, **there
may
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1261
@jackylk thks, reviews are fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1267#discussion_r134082911
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/CarbonDeleteFilesDataReader.java
---
@@ -216,6 +198,17 @@ public
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1276#discussion_r134376168
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -369,6 +369,14 @@ object CommonUtil
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1276#discussion_r134375904
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -369,6 +369,14 @@ object CommonUtil
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1301
[CARBONDATA-1434] Remove useless class para for metastore
The `RuntimeConfig` has not been used in Carbon*Metastore class, so remove
it.
You can merge this pull request into a Git
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1300
It seems that `decimal` related modification is not shown in the changes.
Do you mean `date`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1299#discussion_r136105752
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -351,7 +351,7 @@ object CommonUtil
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1302#discussion_r136224665
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingStrategy.java
---
@@ -112,10 +112,41 @@ public
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1298#discussion_r136225347
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -347,7 +347,7 @@ object CommonUtil
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1306
[CARBONDATA-1436] optimize concurrent control for datamap
# Scenario
`DataMapStoreManager` provides a synchronized interface `getDataMap` to
retrieve a table's `TableDataMap
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1306#discussion_r136254674
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
---
@@ -82,7 +90,6 @@ public TableDataMap
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1298#discussion_r136286067
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -347,7 +347,7 @@ object CommonUtil
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1330
hi @kushalsaha, I cannot understand the problem and modification, Can you
describe the problems in the corresponding issue?
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1335
@dhatchayani hi, can you provide detail error message? I cannot understand
why we should modify this.
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1354
I used numeric-no-dictionary column in SORT_COLUMN and did not find any
problems for now.
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1367
:+1: I came across the same idea yesterday: query from the specified
segment. Happy to see you have already worked on this.
Need to provide the related usage in document.
---
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1479
[CARBONDATA-1690][DATAMAP] Clear datamap when renaming table
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1484
[CARBONDATA-1700][DataLoad] Add TableProperties during (de)serialization of
TableSchema
Be sure to do all of the following checklist to help us incorporate
your contribution quickly
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1484
retest this please
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1489#discussion_r150408185
--- Diff: format/src/main/thrift/schema.thrift ---
@@ -187,15 +187,17 @@ struct ParentColumnTableRelation {
}
struct DataMapSchema
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1489#discussion_r150408117
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
---
@@ -144,23 +144,40 @@ private TableDataMap
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1484#discussion_r150432165
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchema.java
---
@@ -77,6 +78,7 @@
public
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1484
retest this please
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1489#discussion_r150433577
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
---
@@ -144,23 +144,40 @@ private TableDataMap
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1496
[CARBONDATA-1709][DataFrame] Support sort_columns option in dataframe writer
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1484
hi, @ravipesala can you review it?
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1496
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1496
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1496
retest this please
---
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1559
[CARBONDATA-1805][Dictionary] Optimize pruning for dictionary loading
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1559
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1496
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1496
@ravipesala hi, can you review it?
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1559
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1496
@jackylk done, please try again
---
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1593
[CARBONDATA-1837] Reusing origin row to reduce memory consumption
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1594
[CARBONDATA-1838] Refactor SortStepRowUtil to make it more readable
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1559
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1593
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1559
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1594
@jackylk can you review this?
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1593
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1559
retest this please
---
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1606
WIP:[CARBONDATA-1839] Fix bugs in compressing sort temp files
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1594#discussion_r154824658
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessorStepOnSpark.scala
---
@@ -128,7 +128,7
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1594#discussion_r154825080
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessorStepOnSpark.scala
---
@@ -138,7 +138,7
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1593
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1559
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1606
@jackylk Thanks for your review, since another PR #1594 has been merged,
I'll optimize this PR to reduce duplicate codes in writing sort temp files.
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1593#discussion_r155154423
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/row/CarbonRowBatch.java
---
@@ -61,4 +61,19 @@ public CarbonRow next
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1606
No, it is a little complex to reduce the duplicate code. I'll make a full
test as possible as I can.
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1559
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1496
@jackylk Can you review and merge this PR?
---
Github user xuchuanyin closed the pull request at:
https://github.com/apache/carbondata/pull/1606
---
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1632
[CARBONDATA-1839] [DataLoad]Fix bugs in compressing sort temp files
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1606
@jackylk I close this PR and raise #1632 instead.
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1632
retest this please
---
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1633
[CARBONDATA-1878] [DataMap] Fix bugs in unsafe datamap store
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1632
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1633
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1633
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1632
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1559
retest this please
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1559
retest this please
---
1 - 100 of 1832 matches
Mail list logo
