[GitHub] carbondata pull request #2160: [CARBONDATA-2335] Fix auto handoff for preagg...

2018-04-16 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2160


---

[GitHub] carbondata pull request #2160: [CARBONDATA-2335] Fix auto handoff for preagg...

2018-04-16 Thread kumarvishal09 
Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2160#discussion_r181716258
  
--- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala
 ---
@@ -110,6 +110,8 @@ object StreamSinkFactory {
 val segmentId = getStreamSegmentId(carbonTable)
 carbonLoadModel.setSegmentId(segmentId)
 
+val loadMetaEvent = new LoadMetadataEvent(carbonTable, false)
+OperationListenerBus.getInstance().fireEvent(loadMetaEvent, 
operationContext)
--- End diff --

Please add comments


---

[GitHub] carbondata pull request #2160: [CARBONDATA-2335] Fix auto handoff for preagg...

2018-04-16 Thread kumarvishal09 
Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2160#discussion_r181716090
  
--- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/streaming/CarbonAppendableStreamSink.scala
 ---
@@ -163,7 +162,7 @@ class CarbonAppendableStreamSink(
   /**
* if the directory size of current segment beyond the threshold, hand 
off new segment
*/
-  private def checkOrHandOffSegment(): Unit = {
+  private def checkOrHandOffSegment(operationContext: OperationContext): 
Unit = {
--- End diff --

No need to change method signature use the same operation context passed in 
CarbonAppendableStreamSink


---

[GitHub] carbondata pull request #2160: [CARBONDATA-2335] Fix auto handoff for preagg...

2018-04-11 Thread kunal642 
GitHub user kunal642 opened a pull request:

https://github.com/apache/carbondata/pull/2160

[CARBONDATA-2335] Fix auto handoff for preaggregate table with streaming

Solution: MetaListener was not called for auto handoff case therefore child 
load commands were not being created thus throwing NullPointerException.


Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/carbondata 
fix_auto_handoff_aggregate_load

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2160


commit f6bc57708f8d3da77d547640ea373e4e5c9b970a
Author: kunal642 
Date:   2018-04-11T14:56:01Z

fix auto handoff for preaggregate table with streaming




---