[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323761#comment-16323761
 ] 

ASF subversion and git services commented on CLOUDSTACK-9813:
-

Commit b176648f90e39d26404e8ecb85189d322163600a in cloudstack's branch 
refs/heads/master from [~fmaximus]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b176648 ]

CLOUDSTACK-9813: Extending Config Drive support (#2097)

Extending Config Drive support

* Added support for VMware
* Build configdrive.iso on ssvm
* Added support for VPC and Isolated Networks
* Moved implementation to new Service Provider
* UI fix: add support for urlencoded userdata
* Add support for building systemvm behind a proxy

Co-Authored-By: Raf Smeets 
Co-Authored-By: Frank Maximus 
Co-Authored-By: Sigert Goeminne 

> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323422#comment-16323422
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-357122837
 
 
   Trillian test result (tid-2114)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33858 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2114-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 64 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_vm_wrong_checksum | `Error` | 25.26 | test_templates.py
   ContextSuite context=TestCreateTemplateWithDirectDownload>:teardown | 
`Error` | 39.86 | test_templates.py
   test_07_resize_fail | `Failure` | 5.40 | test_volumes.py
   test_hostha_kvm_host_recovering | `Error` | 6.45 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323387#comment-16323387
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-357117456
 
 
   Trillian test result (tid-2113)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 32067 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2113-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_edit_template | `Failure` | 90.10 | test_templates.py
   test_07_resize_fail | `Failure` | 32.26 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322529#comment-16322529
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356986679
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322528#comment-16322528
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


DaanHoogland commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config 
Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356986393
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322527#comment-16322527
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356986381
 
 
   @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + 
vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322524#comment-16322524
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356986193
 
 
   @blueorangutan test matrix 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322503#comment-16322503
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356982513
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1645


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322438#comment-16322438
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356969326
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322437#comment-16322437
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356969278
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322194#comment-16322194
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


wido commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356933319
 
 
   I will take a last look at this later today and LGTM if OK!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322174#comment-16322174
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


krissterckx commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config 
Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356927103
 
 
   @DaanHoogland  @wido  can you pls (re)approve this PR if you are OK with it 
?  Thanks 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321622#comment-16321622
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356811456
 
 
   Trillian test result (tid-2110)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31238 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2110-vmware-55u3.zip
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_volume | `Failure` | 176.91 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321296#comment-16321296
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


krissterckx commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config 
Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356764190
 
 
   @rhtyd  can the 'requested changes' ask be removed ? This PR should be ready 
for merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320869#comment-16320869
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


krissterckx commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160769936
 
 

 ##
 File path: server/src/com/cloud/network/NetworkServiceImpl.java
 ##
 @@ -4198,20 +4201,36 @@ private PhysicalNetworkServiceProvider 
addDefaultBaremetalProvidersToPhysicalNet
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalUserdataProvider", null, null);
 } else if (dvo.getNetworkType() == NetworkType.Advanced) {
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalPxeProvider", null, null);
-enableBaremetalProvider("BaremetalPxeProvider");
+enableProvider("BaremetalPxeProvider");
 }
 
 return null;
 }
 
-private void enableBaremetalProvider(String providerName) {
+private void enableProvider(String providerName) {
 QueryBuilder q = 
QueryBuilder.create(PhysicalNetworkServiceProviderVO.class);
 q.and(q.entity().getProviderName(), SearchCriteria.Op.EQ, 
providerName);
 PhysicalNetworkServiceProviderVO provider = q.find();
 provider.setState(PhysicalNetworkServiceProvider.State.Enabled);
 _pNSPDao.update(provider.getId(), provider);
 }
 
+private PhysicalNetworkServiceProvider 
addConfigDriveToPhysicalNetwork(long physicalNetworkId) {
+PhysicalNetworkVO pvo = 
_physicalNetworkDao.findById(physicalNetworkId);
+DataCenterVO dvo = _dcDao.findById(pvo.getDataCenterId());
+if (dvo.getNetworkType() == NetworkType.Advanced) {
 
 Review comment:
   Got it and yes, agree. +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320785#comment-16320785
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356692244
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320779#comment-16320779
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356691946
 
 
   @blueorangutan test centos7 vmware-55u3


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320758#comment-16320758
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356688643
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1641


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320685#comment-16320685
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356675334
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320684#comment-16320684
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356675160
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320627#comment-16320627
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356663715
 
 
   @fmaximus please fix the conflicts


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320467#comment-16320467
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356641040
 
 
   @fmaximus failures can be compared against the baseline master branch test 
results in #2376 (I'll kick another round tonight). Given some failures, and 
that we're already past the cut/freeze, do you think the PR is stable and would 
be ready for merge in next 24 hours? We also lack additional code review lgtm 
and there are pending remarks and oustanding issues.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320061#comment-16320061
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


wido commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160644768
 
 

 ##
 File path: server/src/com/cloud/network/NetworkServiceImpl.java
 ##
 @@ -4198,20 +4201,36 @@ private PhysicalNetworkServiceProvider 
addDefaultBaremetalProvidersToPhysicalNet
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalUserdataProvider", null, null);
 } else if (dvo.getNetworkType() == NetworkType.Advanced) {
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalPxeProvider", null, null);
-enableBaremetalProvider("BaremetalPxeProvider");
+enableProvider("BaremetalPxeProvider");
 }
 
 return null;
 }
 
-private void enableBaremetalProvider(String providerName) {
+private void enableProvider(String providerName) {
 QueryBuilder q = 
QueryBuilder.create(PhysicalNetworkServiceProviderVO.class);
 q.and(q.entity().getProviderName(), SearchCriteria.Op.EQ, 
providerName);
 PhysicalNetworkServiceProviderVO provider = q.find();
 provider.setState(PhysicalNetworkServiceProvider.State.Enabled);
 _pNSPDao.update(provider.getId(), provider);
 }
 
+private PhysicalNetworkServiceProvider 
addConfigDriveToPhysicalNetwork(long physicalNetworkId) {
+PhysicalNetworkVO pvo = 
_physicalNetworkDao.findById(physicalNetworkId);
+DataCenterVO dvo = _dcDao.findById(pvo.getDataCenterId());
+if (dvo.getNetworkType() == NetworkType.Advanced) {
 
 Review comment:
   Indeed @DaanHoogland and @krissterckx leave the check in. Once I have the 
time to fully test it and verify it also works in Basic Networking I'll submit 
a PR for that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319974#comment-16319974
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


DaanHoogland commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160630824
 
 

 ##
 File path: server/src/com/cloud/network/NetworkServiceImpl.java
 ##
 @@ -4198,20 +4201,36 @@ private PhysicalNetworkServiceProvider 
addDefaultBaremetalProvidersToPhysicalNet
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalUserdataProvider", null, null);
 } else if (dvo.getNetworkType() == NetworkType.Advanced) {
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalPxeProvider", null, null);
-enableBaremetalProvider("BaremetalPxeProvider");
+enableProvider("BaremetalPxeProvider");
 }
 
 return null;
 }
 
-private void enableBaremetalProvider(String providerName) {
+private void enableProvider(String providerName) {
 QueryBuilder q = 
QueryBuilder.create(PhysicalNetworkServiceProviderVO.class);
 q.and(q.entity().getProviderName(), SearchCriteria.Op.EQ, 
providerName);
 PhysicalNetworkServiceProviderVO provider = q.find();
 provider.setState(PhysicalNetworkServiceProvider.State.Enabled);
 _pNSPDao.update(provider.getId(), provider);
 }
 
+private PhysicalNetworkServiceProvider 
addConfigDriveToPhysicalNetwork(long physicalNetworkId) {
+PhysicalNetworkVO pvo = 
_physicalNetworkDao.findById(physicalNetworkId);
+DataCenterVO dvo = _dcDao.findById(pvo.getDataCenterId());
+if (dvo.getNetworkType() == NetworkType.Advanced) {
 
 Review comment:
   @krissterckx leave it in, for @wido to remove hen he has test-time.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319167#comment-16319167
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160524430
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -513,6 +565,19 @@
 "NetworkACL": 'VpcVirtualRouter'
 }
 },
+"vpc_offering_configdrive": {
+"name": 'VPC offering ConfigDrive',
+"displaytext": 'VPC offering ConfigDrive',
+"supportedservices": 
'Dhcp,StaticNat,SourceNat,NetworkACL,UserData,Dns',
+"serviceProviderList": {
+"Dhcp": "VpcVirtualRouter",
+"StaticNat": "VpcVirtualRouter",
+"SourceNat": "VpcVirtualRouter",
+"NetworkACL": "VpcVirtualRouter",
+"UserData": "ConfigDrive",
+"Dns": "VpcVirtualRouter"
+}
+},
 
 Review comment:
   Yes, the test dsta should not be part of marvin library at all. We should 
stop doing that at least with new tests. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319046#comment-16319046
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356395209
 
 
   Trillian test result (tid-2094)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36912 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2094-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_07_resize_fail | `Failure` | 4.40 | test_volumes.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.78 | 
test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Error` | 633.21 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 633.43 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318582#comment-16318582
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


krissterckx commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160435009
 
 

 ##
 File path: server/src/com/cloud/network/NetworkServiceImpl.java
 ##
 @@ -4198,20 +4201,36 @@ private PhysicalNetworkServiceProvider 
addDefaultBaremetalProvidersToPhysicalNet
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalUserdataProvider", null, null);
 } else if (dvo.getNetworkType() == NetworkType.Advanced) {
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalPxeProvider", null, null);
-enableBaremetalProvider("BaremetalPxeProvider");
+enableProvider("BaremetalPxeProvider");
 }
 
 return null;
 }
 
-private void enableBaremetalProvider(String providerName) {
+private void enableProvider(String providerName) {
 QueryBuilder q = 
QueryBuilder.create(PhysicalNetworkServiceProviderVO.class);
 q.and(q.entity().getProviderName(), SearchCriteria.Op.EQ, 
providerName);
 PhysicalNetworkServiceProviderVO provider = q.find();
 provider.setState(PhysicalNetworkServiceProvider.State.Enabled);
 _pNSPDao.update(provider.getId(), provider);
 }
 
+private PhysicalNetworkServiceProvider 
addConfigDriveToPhysicalNetwork(long physicalNetworkId) {
+PhysicalNetworkVO pvo = 
_physicalNetworkDao.findById(physicalNetworkId);
+DataCenterVO dvo = _dcDao.findById(pvo.getDataCenterId());
+if (dvo.getNetworkType() == NetworkType.Advanced) {
 
 Review comment:
   @wido you suggest we remove the check ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318551#comment-16318551
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


wido commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160428915
 
 

 ##
 File path: server/src/com/cloud/network/NetworkServiceImpl.java
 ##
 @@ -4198,20 +4201,36 @@ private PhysicalNetworkServiceProvider 
addDefaultBaremetalProvidersToPhysicalNet
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalUserdataProvider", null, null);
 } else if (dvo.getNetworkType() == NetworkType.Advanced) {
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalPxeProvider", null, null);
-enableBaremetalProvider("BaremetalPxeProvider");
+enableProvider("BaremetalPxeProvider");
 }
 
 return null;
 }
 
-private void enableBaremetalProvider(String providerName) {
+private void enableProvider(String providerName) {
 QueryBuilder q = 
QueryBuilder.create(PhysicalNetworkServiceProviderVO.class);
 q.and(q.entity().getProviderName(), SearchCriteria.Op.EQ, 
providerName);
 PhysicalNetworkServiceProviderVO provider = q.find();
 provider.setState(PhysicalNetworkServiceProvider.State.Enabled);
 _pNSPDao.update(provider.getId(), provider);
 }
 
+private PhysicalNetworkServiceProvider 
addConfigDriveToPhysicalNetwork(long physicalNetworkId) {
+PhysicalNetworkVO pvo = 
_physicalNetworkDao.findById(physicalNetworkId);
+DataCenterVO dvo = _dcDao.findById(pvo.getDataCenterId());
+if (dvo.getNetworkType() == NetworkType.Advanced) {
 
 Review comment:
   Understood! Thanks, I'll test that when I get the chance, but that won't be 
very soon :(
   
   Don't wait with merging before my tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318542#comment-16318542
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


krissterckx commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160427278
 
 

 ##
 File path: server/src/com/cloud/network/NetworkServiceImpl.java
 ##
 @@ -4198,20 +4201,36 @@ private PhysicalNetworkServiceProvider 
addDefaultBaremetalProvidersToPhysicalNet
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalUserdataProvider", null, null);
 } else if (dvo.getNetworkType() == NetworkType.Advanced) {
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalPxeProvider", null, null);
-enableBaremetalProvider("BaremetalPxeProvider");
+enableProvider("BaremetalPxeProvider");
 }
 
 return null;
 }
 
-private void enableBaremetalProvider(String providerName) {
+private void enableProvider(String providerName) {
 QueryBuilder q = 
QueryBuilder.create(PhysicalNetworkServiceProviderVO.class);
 q.and(q.entity().getProviderName(), SearchCriteria.Op.EQ, 
providerName);
 PhysicalNetworkServiceProviderVO provider = q.find();
 provider.setState(PhysicalNetworkServiceProvider.State.Enabled);
 _pNSPDao.update(provider.getId(), provider);
 }
 
+private PhysicalNetworkServiceProvider 
addConfigDriveToPhysicalNetwork(long physicalNetworkId) {
+PhysicalNetworkVO pvo = 
_physicalNetworkDao.findById(physicalNetworkId);
+DataCenterVO dvo = _dcDao.findById(pvo.getDataCenterId());
+if (dvo.getNetworkType() == NetworkType.Advanced) {
 
 Review comment:
   No technical reason but there is very limited knowledge about Basic 
networking within Nuage team; it would be best that other community members 
further extend it. We could leave out the check but it might not just work like 
that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318460#comment-16318460
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


wido commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160414658
 
 

 ##
 File path: server/src/com/cloud/network/NetworkServiceImpl.java
 ##
 @@ -4198,20 +4201,36 @@ private PhysicalNetworkServiceProvider 
addDefaultBaremetalProvidersToPhysicalNet
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalUserdataProvider", null, null);
 } else if (dvo.getNetworkType() == NetworkType.Advanced) {
 addProviderToPhysicalNetwork(physicalNetworkId, 
"BaremetalPxeProvider", null, null);
-enableBaremetalProvider("BaremetalPxeProvider");
+enableProvider("BaremetalPxeProvider");
 }
 
 return null;
 }
 
-private void enableBaremetalProvider(String providerName) {
+private void enableProvider(String providerName) {
 QueryBuilder q = 
QueryBuilder.create(PhysicalNetworkServiceProviderVO.class);
 q.and(q.entity().getProviderName(), SearchCriteria.Op.EQ, 
providerName);
 PhysicalNetworkServiceProviderVO provider = q.find();
 provider.setState(PhysicalNetworkServiceProvider.State.Enabled);
 _pNSPDao.update(provider.getId(), provider);
 }
 
+private PhysicalNetworkServiceProvider 
addConfigDriveToPhysicalNetwork(long physicalNetworkId) {
+PhysicalNetworkVO pvo = 
_physicalNetworkDao.findById(physicalNetworkId);
+DataCenterVO dvo = _dcDao.findById(pvo.getDataCenterId());
+if (dvo.getNetworkType() == NetworkType.Advanced) {
 
 Review comment:
   Why wouldn't config-drive be supported in Basic Networking?
   
   It's a network provider, correct?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318393#comment-16318393
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


fmaximus commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160403836
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##
 @@ -281,6 +283,13 @@ public Long getTemplateId() {
 }
 
 public String getUserData() {
+if (userData != null) {
+try {
+userData = URLDecoder.decode(userData, "UTF-8");
 
 Review comment:
   The UI sends the userdata UrlEncoded.
   But you're correct that this shouldn't happen if the userdata isn't URL 
encoded in the first place.
   I'm going to move the code to UserVmManagerImpl.validateUserData(),
   and only to the URL decode if the userdata contains %


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318387#comment-16318387
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


krissterckx commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160401714
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -513,6 +565,19 @@
 "NetworkACL": 'VpcVirtualRouter'
 }
 },
+"vpc_offering_configdrive": {
+"name": 'VPC offering ConfigDrive',
+"displaytext": 'VPC offering ConfigDrive',
+"supportedservices": 
'Dhcp,StaticNat,SourceNat,NetworkACL,UserData,Dns',
+"serviceProviderList": {
+"Dhcp": "VpcVirtualRouter",
+"StaticNat": "VpcVirtualRouter",
+"SourceNat": "VpcVirtualRouter",
+"NetworkACL": "VpcVirtualRouter",
+"UserData": "ConfigDrive",
+"Dns": "VpcVirtualRouter"
+}
+},
 
 Review comment:
   @rhtyd are you saying that even for new generic component tests that are 
added (see test_configdrive.py being added), the policy is to add offering to 
the test itself rather than extending test_data , even when config drive 
becomes a new generic capability, added by this PR ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318231#comment-16318231
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


sgoeminn commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160371696
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixPrepareForMigrationCommandWrapper.java
 ##
 @@ -47,7 +47,7 @@ public Answer execute(final PrepareForMigrationCommand 
command, final CitrixReso
 String configDriveLabel = vm.getConfigDriveLabel();
 
 if (configDriveLabel == null)  {
-configDriveLabel = "config";
+configDriveLabel = "config-2";
 
 Review comment:
   @rhtyd it's added to be OpenStack compatible. In this way it works out of 
the box in combination with cloud-init. [design doc 
config-drive](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+ConfigDrive+for+Metadata%2C+Userdata+and+Password#UsingConfigDriveforMetadata,UserdataandPassword-OpenStack(cloud-init)compatibility(version2))


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318189#comment-16318189
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356240262
 
 
   I've left some outstanding comments, please see @fmaximus @krissterckx . 
Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318188#comment-16318188
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160365198
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -2186,6 +2371,33 @@
 "Dns": "VpcVirtualRouter"
 }
 },
+"vpc_offering_configdrive_withoutdns": {
 
 Review comment:
   @krissterckx can you please get them moved to a specific test. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318185#comment-16318185
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160364934
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -513,6 +565,19 @@
 "NetworkACL": 'VpcVirtualRouter'
 }
 },
+"vpc_offering_configdrive": {
+"name": 'VPC offering ConfigDrive',
+"displaytext": 'VPC offering ConfigDrive',
+"supportedservices": 
'Dhcp,StaticNat,SourceNat,NetworkACL,UserData,Dns',
+"serviceProviderList": {
+"Dhcp": "VpcVirtualRouter",
+"StaticNat": "VpcVirtualRouter",
+"SourceNat": "VpcVirtualRouter",
+"NetworkACL": "VpcVirtualRouter",
+"UserData": "ConfigDrive",
+"Dns": "VpcVirtualRouter"
+}
+},
 
 Review comment:
   @fmaximus can you move the test data to test itself? (for all the changes in 
test_data.py)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318184#comment-16318184
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160364847
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -49,6 +49,27 @@
 "forvirtualnetwork": "true",
 "vlan": "300"
 },
+"publiciprange1": {
+"gateway": "10.200.100.1",
+"netmask": "255.255.255.0",
+"startip": "10.200.100.101",
+"endip": "10.200.100.105",
+"forvirtualnetwork": "false"
+},
+"publiciprange2": {
+"gateway": "10.219.1.1",
+"netmask": "255.255.255.0",
+"startip": "10.219.1.2",
+"endip": "10.219.1.5",
+"forvirtualnetwork": "false"
+},
+"publiciprange3": {
+"gateway": "10.200.100.1",
+"netmask": "255.255.255.0",
+"startip": "10.200.100.2",
+"endip": "10.200.100.20",
+"forvirtualnetwork": "false"
+},
 
 Review comment:
   @fmaximus can you move the test data to test itself?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318182#comment-16318182
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160364763
 
 

 ##
 File path: tools/appliance/systemvmtemplate/scripts/configure_proxy.sh
 ##
 @@ -0,0 +1,38 @@
+#!/bin/bash
 
 Review comment:
   @fmaximus ^^


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318181#comment-16318181
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160364542
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixPrepareForMigrationCommandWrapper.java
 ##
 @@ -47,7 +47,7 @@ public Answer execute(final PrepareForMigrationCommand 
command, final CitrixReso
 String configDriveLabel = vm.getConfigDriveLabel();
 
 if (configDriveLabel == null)  {
-configDriveLabel = "config";
+configDriveLabel = "config-2";
 
 Review comment:
   Why was the config drive label changed with a `-2` suffix?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318072#comment-16318072
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356220778
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1632


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318003#comment-16318003
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356212529
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318000#comment-16318000
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-356212324
 
 
   Thanks @fmaximus the environment destroyed itself so management server logs 
cannot be shared/found. I'll rekick another test round without the cleanup flag 
(that auto-cleans on test finish) and help debug issues in next round.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316472#comment-16316472
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


fmaximus commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config 
Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355996429
 
 
   Test Failure analysis:
   
   Test | Cause
    | -
   test_ssvm.py | Marvin test incorrect: Test checks that system VM gateway is 
equal to the gateway of the public IP ranges. It just takes the first public IP 
range, but doesn't take forsystemvms flag into account. Marvin log shows that 2 
public ip ranges are present, the first one having forsystemvms=False.
   test_templates.py | Extract Template Failed with invalid 
URLhttp://192.168.100.10/userdata/8cec10dd-4dba-459e-a072-e5c34a8c092c.ova
   test_usage.py | Download template: No route to host
   test_vm_life_cycle.py | DetachIsoCmd fails with "Failed to detach iso".
   test_volumes.py | Extract Volume Failed with invalid 
URLhttp://192.168.100.10/userdata/6417246a-f94c-4e9c-a0ac-3a03daf7bb54.ova
   
   Can you provide the management server logs, to be able to find out the cause 
of DetachIsoCmd issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316242#comment-16316242
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


DaanHoogland commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160032397
 
 

 ##
 File path: core/src/com/cloud/agent/api/HandleConfigDriveIsoCommand.java
 ##
 @@ -0,0 +1,78 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.api;
+
+import java.util.List;
+
+import com.cloud.agent.api.to.DataStoreTO;
+
+public class HandleConfigDriveIsoCommand extends Command {
 
 Review comment:
   this is a much more sensible place to add javadoc.
 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316176#comment-16316176
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


krissterckx commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160127168
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -2186,6 +2371,33 @@
 "Dns": "VpcVirtualRouter"
 }
 },
+"vpc_offering_configdrive_withoutdns": {
 
 Review comment:
   @rhtyd i created CLOUDSTACK-10219 to track this. We will take this forward. 
I expect this not to happen for 4.11 probably though. Hope that's ok.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315188#comment-16315188
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355814239
 
 
   Higher than normal failures, can you check the failures @fmaximus ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315182#comment-16315182
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355814047
 
 
   Trillian test result (tid-2052)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 58531 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2052-vmware-55u3.zip
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_list_sec_storage_vm | `Failure` | 0.18 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.19 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 105.72 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 135.59 | test_ssvm.py
   test_04_extract_template | `Failure` | 142.45 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_10_attachAndDetach_iso | `Error` | 17.15 | test_vm_life_cycle.py
   test_06_download_detached_volume | `Failure` | 192.96 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 708.76 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315149#comment-16315149
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160045298
 
 

 ##
 File path: tools/marvin/marvin/config/test_data.py
 ##
 @@ -2186,6 +2371,33 @@
 "Dns": "VpcVirtualRouter"
 }
 },
+"vpc_offering_configdrive_withoutdns": {
 
 Review comment:
   General note wrt changes in `test_data.py` - please move to specific marvin 
test.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315148#comment-16315148
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: 
Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160045278
 
 

 ##
 File path: tools/appliance/systemvmtemplate/scripts/configure_proxy.sh
 ##
 @@ -0,0 +1,38 @@
+#!/bin/bash
 
 Review comment:
   This is not needed for the new system, look at building with packer and how 
to export http proxy.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314850#comment-16314850
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


DaanHoogland commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160032337
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
 ##
 @@ -149,6 +152,13 @@ public Long getId() {
 }
 
 public String getUserData() {
+if (userData != null) {
+try {
+userData = URLDecoder.decode(userData, "UTF-8");
 
 Review comment:
   should we really do this unconditionally? it might already be UTF-8!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314852#comment-16314852
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


DaanHoogland commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160032397
 
 

 ##
 File path: core/src/com/cloud/agent/api/HandleConfigDriveIsoCommand.java
 ##
 @@ -0,0 +1,78 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.api;
+
+import java.util.List;
+
+import com.cloud.agent.api.to.DataStoreTO;
+
+public class HandleConfigDriveIsoCommand extends Command {
 
 Review comment:
   this is a much more sinsible place to add javadoc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314849#comment-16314849
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


DaanHoogland commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160032281
 
 

 ##
 File path: api/src/com/cloud/network/NetworkModel.java
 ##
 @@ -79,12 +103,34 @@
 
 List listNetworksUsedByVm(long vmId, boolean isSystem);
 
+/**
 
 Review comment:
   I don't think these four javadoc additions add to the readability of the 
code. They say nothing beyond what the naming of the method and parameters 
already tell us.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314851#comment-16314851
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


DaanHoogland commented on a change in pull request #2097: [4.11] 
CLOUDSTACK-9813: Extending Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160032323
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##
 @@ -281,6 +283,13 @@ public Long getTemplateId() {
 }
 
 public String getUserData() {
+if (userData != null) {
+try {
+userData = URLDecoder.decode(userData, "UTF-8");
 
 Review comment:
   do we do this even if it is allready UTF-8?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314815#comment-16314815
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355766409
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314813#comment-16314813
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355766311
 
 
   Additional review requested. @wido are you lgtm on it.
   /cc @DaanHoogland @rafaelweingartner and others. I'll see if I can review 
tomorrow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314814#comment-16314814
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355766387
 
 
   @blueorangutan test centos7 vmware-55u3


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314811#comment-16314811
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355766311
 
 
   Additional review requested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314795#comment-16314795
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355765205
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1606


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314771#comment-16314771
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355762716
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314768#comment-16314768
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355762664
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313697#comment-16313697
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355640904
 
 
   Trillian test result (tid-2025)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37105 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2025-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 325.03 | 
test_privategw_acl.py
   test_hostha_kvm_host_fencing | `Error` | 650.21 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 658.54 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312631#comment-16312631
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355491535
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312628#comment-16312628
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355491478
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312626#comment-16312626
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355491124
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1586


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312560#comment-16312560
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355482611
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312559#comment-16312559
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355482507
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310947#comment-16310947
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355221267
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1566


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310771#comment-16310771
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355203867
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310765#comment-16310765
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355203745
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309265#comment-16309265
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-354955642
 
 
   @fmaximus please fix license issues, see Travis job1 failure:
   ```
   [INFO] 7487 resources included (use -debug for more details)
   [INFO] Rat check: Summary over all files. Unapproved: 1, unknown: 1, 
generated: 0, approved: 7360 licenses.
   [INFO] 

   [INFO] BUILD FAILURE
   [INFO] 

   [INFO] Total time: 7.066 s
   [INFO] Finished at: 2018-01-02T16:44:49Z
   [INFO] Final Memory: 42M/356M
   [INFO] 

   [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check 
(default-cli) on project cloudstack: Too many files with unapproved license: 1 
See RAT report in: /home/travis/build/apache/cloudstack/target/rat.txt -> [Help 
1]
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308344#comment-16308344
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


fmaximus commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config 
Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-354811387
 
 
   Rebased, and to answer the question about PR #2116 
   This PR is not dependent on it, even more:
   As I mentioned on that #2116, it would make that PR unnecessary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308013#comment-16308013
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-354762541
 
 
   @fmaximus can you fix the conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301543#comment-16301543
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353617473
 
 
   Per your request @fmaximus I've added `genisoimage` depdency in #2211. Once 
the templates are built, you can test them from 
http://dl.rohityadav.cloud/debian9. I'll notify you on this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301544#comment-16301544
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353617473
 
 
   Per your request @fmaximus I've added `genisoimage` dependency in #2211. 
Once the templates are built, you can test them from 
http://dl.rohityadav.cloud/debian9. I'll notify you on this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301155#comment-16301155
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353556869
 
 
   Ping - @fmaximus @krissterckx is this dependent on #2116 and possibly other 
PRs? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300233#comment-16300233
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353394933
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1454


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300211#comment-16300211
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353388458
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300210#comment-16300210
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353388375
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299807#comment-16299807
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353309616
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1450


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299763#comment-16299763
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353304042
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299762#comment-16299762
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353303926
 
 
   @fmaximus @krissterckx is this dependent on #2116 and possibly other PRs? 
I'll kick some tests shortly.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298868#comment-16298868
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353144379
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1447


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298826#comment-16298826
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353137492
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298824#comment-16298824
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353137269
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298361#comment-16298361
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353046171
 
 
   Fix conflicts please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298294#comment-16298294
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353034900
 
 
   @krissterckx I had started a thread on dev@ ML asking people to participate 
in PR review and pinging me if they want to get their PRs merged. Given we're 
only a few weeks away from freeze I'll be focusing on non-feature related PRs, 
limiting scope. But with that said, if people can review PRs, demonstrate 
stability and work with others any kind of PR may be include. I've re-added the 
milestone tagging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298293#comment-16298293
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353034900
 
 
   @krissterckx I had started a thread on dev@ ML asking people to participate 
in PR review and pinging me if they want to get their PRs merged. Given we're 
only a few weeks away from freeze I'll be focusing on non-feature related PRs, 
limiting scope. But with that said, if people can review PRs, demonstrate 
stability and work with others any kind of PR may be include.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298136#comment-16298136
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


krissterckx commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config 
Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-353004576
 
 
   Hi @rhtyd i see you removed 4.11 label from the PR. See discussion thread 
with @wido. 
   At Nuage we see lots of interest for adding configdrive support in 
CloudStack.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[Kris Sterckx (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150687#comment-16150687
 ] 

Kris Sterckx commented on CLOUDSTACK-9813:
--

Hi [~serverchief][~mlsorensen][~widodh]

Pls refer to 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+ConfigDrive+for+Metadata%2C+Userdata+and+Password#UsingConfigDriveforMetadata,UserdataandPassword-CopyingISOtoPrimaryStorage
 for the proposed approach of copying the iso to primary storage after 
generation on secondary storage (when available).

At this stage the design assumes the iso staying on the secondary storage (i.e. 
we are *copying*, not *moving*) for easier support of VM migration and other 
scenario's, without need for orchestrating copy operations from A to B to C and 
so-forth (in casu of VM migration, primary to secondary + secondary to 
primary).  We understand it is potentially an increment towards where we want 
to be eventually, but it lowers initial complexity and effort.

I would like also to call out that at Nuage we are no storage experts and also 
don't have all the infrastructure to test all the possible permutations (e.g. 
to start with, as we have no customers using XenServer, we don't have such 
infrastructure at hand in our lab). I would like to make the call for setting 
up a multi-disciplinary virtual team to finish off this Feature.  We can 
discuss this more in the dev call on Wednesday.

All upfront feedback welcome.
cheers,
Kris

> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[Frank Maximus (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103257#comment-16103257
 ] 

Frank Maximus commented on CLOUDSTACK-9813:
---

We are looking into the approach of moving the iso from secondary to primary 
storage.
We will update the design document, and send it out for review.

Regards,
Frank

> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ilya musayev (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101175#comment-16101175
 ] 

ilya musayev commented on CLOUDSTACK-9813:
--

Frank + Nuage Team, 

Apology for missing this thread and spec when it was created. 

I agree with Marcus - please consider extending your implementation - at the 
least - use secondary store as temporary staging ground. 

Regards
ilya

> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[Marcus Sorensen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098934#comment-16098934
 ] 

Marcus Sorensen commented on CLOUDSTACK-9813:
-

I apologize that there wasn't sufficient feedback with the initial design, but 
I'm glad you agree that we can't have secondary storage as a dependency for a 
running VM. As mentioned, there are also security issues in using secondary for 
configuration data.

I'm not sure it can be completely hypervisor agnostic, but perhaps it can be 
reworked such that the hypervisor plugin can choose to redirect to this 
secondary storage ISO creation if it needs to. I'd also suggest that the 
SSVM-leveraged implementation include moving the ISO to primary storage and 
deleting the ISO from secondary at some point.

> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[Frank Maximus (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098622#comment-16098622
 ] 

Frank Maximus commented on CLOUDSTACK-9813:
---

One of the reasons why we chose to use secondary storage, was that we then 
could use the ssvm to do the generation of the iso on a hypervisor agnostic way.
Otherwise for VMware the generation would have to happen on the management 
server, as there is no agent.
And that would also require an rpm/deb dependency to genisoimage in management 
server.

In the implementation on the PR, generation the iso is offloaded, in the same 
way as downloading images from the internet.
It is based upon the work of [~jayapal]. 

I acknowledge the issues with the approach we took,
but would have preferred this kind of feedback 4 months ago, 
when we posted the design document.

> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ilya musayev (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093767#comment-16093767
 ] 

ilya musayev commented on CLOUDSTACK-9813:
--

[~widodh]

Are we forgetting VmWare and Xen? VmWare will not migrate a VM with locally 
attached ISO - hence i supported primary storage initiative.  

For KVM - i do agree that creating few KB on the hypervisor is much better and 
a lot more secure. 




> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[Wido den Hollander (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087127#comment-16087127
 ] 

Wido den Hollander commented on CLOUDSTACK-9813:


Yes, I would not put this on Primary Storage.

A PrepareForMigrationCommand should be able to create this ISO, which is just a 
few KB, on the HV. That way it should work and keep data secure on just the HV.

> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[Marcus Sorensen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085975#comment-16085975
 ] 

Marcus Sorensen commented on CLOUDSTACK-9813:
-

It can be difficult for block-based primary storage to host the ISO, though a 
primary-storage hosted ISO would eliminate live migration issues. I was 
thinking the ISO would just be created on the fly in some host temp space 
during the PrepareForMigrationCommand, along with the creation of relevant 
network bridges and other setup on the destination. It also reduces the 
exposure of potentially sensitive configuration information to the host on 
which the VM resides rather than cluster-wide for primary or zone-wide for 
secondary.

> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[Wido den Hollander (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085293#comment-16085293
 ] 

Wido den Hollander commented on CLOUDSTACK-9813:




+10

I would prefer that as well. The only thing you have to worry about is the live 
migration of a VM.

But with a pre-migrate hook you can generate the ISO on the new hypervisor so 
that it's present when the VM migrates.

Wido



> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ilya musayev (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084849#comment-16084849
 ] 

ilya musayev commented on CLOUDSTACK-9813:
--

In ACS 4.6 - it appears we support config drive -but it does not have metadata 
support.
It does store the iso in the same place as disk files - which is primary store.

++ [~jayapal] as he was a lead on this initiative.. 

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=53740797

perhaps expand the support for metadata / userdata in the same context. 

> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[Marcus Sorensen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084775#comment-16084775
 ] 

Marcus Sorensen commented on CLOUDSTACK-9813:
-

Can we not rely on secondary storage for config drive? I'd much rather see
it generated dynamically into a temp space during VM start, or (less
desirable) even during VM create on primary storage (perhaps in a
configdrive) directory where the root disk resides.  It just seems like a
bad idea to rely on mounting and availability of secondary storage (which
by design is supposed to be out of band from running VMs) to have a healthy
VM. People put a lot of work into their primary storage for VM
availability, not as much for secondary storage.




> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[Marcus Sorensen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084763#comment-16084763
 ] 

Marcus Sorensen commented on CLOUDSTACK-9813:
-

Can we not rely on secondary storage for config drive? I'd much rather see it 
generated dynamically into a temp space or into primary storage alongside root 
disk during VM start.  It just seems like a bad idea to rely on mounting and 
availability of secondary storage (which by design is supposed to be out of 
band from running VMs) to have a healthy VM. People put a lot of work into 
their primary storage for VM availability, not as much for secondary storage

> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)