[jira] [Commented] (POOL-355) Add maxNumActive to pool config

2018-10-30 Thread Bruno P. Kinoshita (JIRA)
[ https://issues.apache.org/jira/browse/POOL-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668233#comment-16668233 ] Bruno P. Kinoshita commented on POOL-355: - I think the bump to Java 8 makes sense - and agree with

[jira] [Commented] (POOL-355) Add maxNumActive to pool config

2018-10-30 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668292#comment-16668292 ] Mark Thomas commented on POOL-355: -- I'd lean towards a WONTFIX for this. The maximum value of numActive on

[jira] [Commented] (POOL-355) Add maxNumActive to pool config

2018-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/POOL-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668618#comment-16668618 ] ASF GitHub Bot commented on POOL-355: - Github user graben closed the pull request at:

[jira] [Commented] (POOL-355) Add maxNumActive to pool config

2018-10-30 Thread Benjamin Graf (JIRA)
[ https://issues.apache.org/jira/browse/POOL-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668617#comment-16668617 ] Benjamin Graf commented on POOL-355: Well, every other tooling via numActive will possibly miss peaks

[jira] [Commented] (TEXT-127) Detect when a variable is unknown in StringSubstitutor

2018-10-30 Thread Don Jeba (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668692#comment-16668692 ] Don Jeba commented on TEXT-127: --- [~garydgregory] can you kindly review and comment on the PR

[GitHub] commons-lang issue #379: add tests for use ImmutableTriple as key in java.ut...

2018-10-30 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/379 [![Coverage Status](https://coveralls.io/builds/19807783/badge)](https://coveralls.io/builds/19807783) Coverage remained the same at 95.233% when pulling

[GitHub] commons-lang issue #378: add more test cases to use ImmutablePair class as k...

2018-10-30 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/378 [![Coverage Status](https://coveralls.io/builds/19808163/badge)](https://coveralls.io/builds/19808163) Coverage remained the same at 95.233% when pulling

[GitHub] commons-lang pull request #379: add tests for use ImmutableTriple as key in ...

2018-10-30 Thread apirom9
GitHub user apirom9 opened a pull request: https://github.com/apache/commons-lang/pull/379 add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap You can merge this

[GitHub] commons-lang pull request #378: add more test cases to use ImmutablePair cla...

2018-10-30 Thread apirom9
GitHub user apirom9 opened a pull request: https://github.com/apache/commons-lang/pull/378 add more test cases to use ImmutablePair class as key for java.util.HashMap and java.util… ….TreeMap You can merge this pull request into a Git repository by running: $ git pull

[GitHub] commons-lang issue #379: add tests for use ImmutableTriple as key in java.ut...

2018-10-30 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/379 @apirom9 does this pull request number #379 supersedes yours previous one, number #378? It looks to me like the tests from #378 are present in this pull request too? If so then we should close

[jira] [Updated] (TEXT-127) Add a toggle to throw an exception when a variable is unknown in StringSubstitutor

2018-10-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated TEXT-127: -- Summary: Add a toggle to throw an exception when a variable is unknown in StringSubstitutor (was:

[GitHub] commons-lang issue #379: add tests for use ImmutableTriple as key in java.ut...

2018-10-30 Thread apirom9
Github user apirom9 commented on the issue: https://github.com/apache/commons-lang/pull/379 @kinow Yes, it is. Sorry for my mistake, I already close pull request #378 Thank you Apirom ---

[GitHub] commons-lang pull request #378: add more test cases to use ImmutablePair cla...

2018-10-30 Thread apirom9
Github user apirom9 closed the pull request at: https://github.com/apache/commons-lang/pull/378 ---

[GitHub] commons-lang issue #378: add more test cases to use ImmutablePair class as k...

2018-10-30 Thread apirom9
Github user apirom9 commented on the issue: https://github.com/apache/commons-lang/pull/378 Close this pull request because changes already in pull request #379 ---

[jira] [Resolved] (TEXT-127) Add a toggle to throw an exception when a variable is unknown in StringSubstitutor

2018-10-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved TEXT-127. --- Resolution: Fixed Fix Version/s: 1.7 I applied a different patch that changes the instance

[jira] [Comment Edited] (TEXT-127) Add a toggle to throw an exception when a variable is unknown in StringSubstitutor

2018-10-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669452#comment-16669452 ] Gary Gregory edited comment on TEXT-127 at 10/31/18 12:21 AM: -- I applied a

[jira] [Resolved] (POOL-355) Add maxNumActive to pool config

2018-10-30 Thread Mark Struberg (JIRA)
[ https://issues.apache.org/jira/browse/POOL-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg resolved POOL-355. Resolution: Won't Fix Oki, closing as won't fix as discussed. [~graben] No worries, we will not