[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance
[
https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616005#comment-15616005
]
ASF GitHub Bot commented on LANG-1269:
--
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/198
> Wrong name or result of StringUtils::getJaroWinklerDistance
> ---
>
> Key: LANG-1269
> URL: https://issues.apache.org/jira/browse/LANG-1269
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3, 3.4
>Reporter: Jan Martin Keil
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>
> The name of the method StringUtils::getJaroWinklerDistance is misleading.
> Currently for equal strings {{1}} is returned, for completely different
> strings {{0}} is returned. That is a measure of similarity, not of a
> distance. A distance must be {{0}} for equal strings. I read on the issues
> LANG-591 and LANG-944, that it was decided to have a similar name to
> StringUtils::getLevenshteinDistance, but that requires also the change of the
> methods result.
> Could you please (1) rename the method to
> StringUtils::getJaroWinklerSimilarity or (2) change the method to return {{1
> - currentResult}}?
> First option has the disadvantage to lose the similar naming of the similar
> methods, second option implies the risk to unnoticed introduce bugs in
> depending code. So I think it is preferable to use the first option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance
[
https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597838#comment-15597838
]
ASF GitHub Bot commented on LANG-1269:
--
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/198
[](https://coveralls.io/builds/8459485)
Coverage increased (+0.02%) to 93.57% when pulling
**436d2801899827a2651b8b44d680aaf9e17acca7 on
PascalSchumacher:jarowinklerdistance_name** into
**8274993e293a79fc75829df398233915a6387a4b on apache:master**.
> Wrong name or result of StringUtils::getJaroWinklerDistance
> ---
>
> Key: LANG-1269
> URL: https://issues.apache.org/jira/browse/LANG-1269
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3, 3.4
>Reporter: Jan Martin Keil
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>
> The name of the method StringUtils::getJaroWinklerDistance is misleading.
> Currently for equal strings {{1}} is returned, for completely different
> strings {{0}} is returned. That is a measure of similarity, not of a
> distance. A distance must be {{0}} for equal strings. I read on the issues
> LANG-591 and LANG-944, that it was decided to have a similar name to
> StringUtils::getLevenshteinDistance, but that requires also the change of the
> methods result.
> Could you please (1) rename the method to
> StringUtils::getJaroWinklerSimilarity or (2) change the method to return {{1
> - currentResult}}?
> First option has the disadvantage to lose the similar naming of the similar
> methods, second option implies the risk to unnoticed introduce bugs in
> depending code. So I think it is preferable to use the first option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance
[
https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597837#comment-15597837
]
ASF GitHub Bot commented on LANG-1269:
--
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/198
[](https://coveralls.io/builds/8459485)
Coverage increased (+0.02%) to 93.57% when pulling
**436d2801899827a2651b8b44d680aaf9e17acca7 on
PascalSchumacher:jarowinklerdistance_name** into
**8274993e293a79fc75829df398233915a6387a4b on apache:master**.
> Wrong name or result of StringUtils::getJaroWinklerDistance
> ---
>
> Key: LANG-1269
> URL: https://issues.apache.org/jira/browse/LANG-1269
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3, 3.4
>Reporter: Jan Martin Keil
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>
> The name of the method StringUtils::getJaroWinklerDistance is misleading.
> Currently for equal strings {{1}} is returned, for completely different
> strings {{0}} is returned. That is a measure of similarity, not of a
> distance. A distance must be {{0}} for equal strings. I read on the issues
> LANG-591 and LANG-944, that it was decided to have a similar name to
> StringUtils::getLevenshteinDistance, but that requires also the change of the
> methods result.
> Could you please (1) rename the method to
> StringUtils::getJaroWinklerSimilarity or (2) change the method to return {{1
> - currentResult}}?
> First option has the disadvantage to lose the similar naming of the similar
> methods, second option implies the risk to unnoticed introduce bugs in
> depending code. So I think it is preferable to use the first option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance
[
https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597774#comment-15597774
]
ASF GitHub Bot commented on LANG-1269:
--
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/198
+1
> Wrong name or result of StringUtils::getJaroWinklerDistance
> ---
>
> Key: LANG-1269
> URL: https://issues.apache.org/jira/browse/LANG-1269
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3, 3.4
>Reporter: Jan Martin Keil
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>
> The name of the method StringUtils::getJaroWinklerDistance is misleading.
> Currently for equal strings {{1}} is returned, for completely different
> strings {{0}} is returned. That is a measure of similarity, not of a
> distance. A distance must be {{0}} for equal strings. I read on the issues
> LANG-591 and LANG-944, that it was decided to have a similar name to
> StringUtils::getLevenshteinDistance, but that requires also the change of the
> methods result.
> Could you please (1) rename the method to
> StringUtils::getJaroWinklerSimilarity or (2) change the method to return {{1
> - currentResult}}?
> First option has the disadvantage to lose the similar naming of the similar
> methods, second option implies the risk to unnoticed introduce bugs in
> depending code. So I think it is preferable to use the first option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance
[
https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597570#comment-15597570
]
ASF GitHub Bot commented on LANG-1269:
--
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/198
[](https://coveralls.io/builds/8458576)
Coverage increased (+0.004%) to 93.545% when pulling
**d2e6338a8ec46ebc80156ef9dcdd83dfe63ee8b5 on
PascalSchumacher:jarowinklerdistance_name** into
**91d6bd74fa358fdc8d7cb7681c76c509fd9a8e7d on apache:master**.
> Wrong name or result of StringUtils::getJaroWinklerDistance
> ---
>
> Key: LANG-1269
> URL: https://issues.apache.org/jira/browse/LANG-1269
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3, 3.4
>Reporter: Jan Martin Keil
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>
> The name of the method StringUtils::getJaroWinklerDistance is misleading.
> Currently for equal strings {{1}} is returned, for completely different
> strings {{0}} is returned. That is a measure of similarity, not of a
> distance. A distance must be {{0}} for equal strings. I read on the issues
> LANG-591 and LANG-944, that it was decided to have a similar name to
> StringUtils::getLevenshteinDistance, but that requires also the change of the
> methods result.
> Could you please (1) rename the method to
> StringUtils::getJaroWinklerSimilarity or (2) change the method to return {{1
> - currentResult}}?
> First option has the disadvantage to lose the similar naming of the similar
> methods, second option implies the risk to unnoticed introduce bugs in
> depending code. So I think it is preferable to use the first option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance
[
https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597562#comment-15597562
]
ASF GitHub Bot commented on LANG-1269:
--
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/198
LANG-1269: Wrong name or result of StringUtils#getJaroWinklerDistance
deprecat StringUtils#getJaroWinklerDistance and add
StringUtils#getJaroWinklerSimilarity instead
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang
jarowinklerdistance_name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #198
commit d2e6338a8ec46ebc80156ef9dcdd83dfe63ee8b5
Author: pascalschumacher
Date: 2016-10-22T09:55:32Z
LANG-1269: Wrong name or result of StringUtils#getJaroWinklerDistance
deprecat StringUtils#getJaroWinklerDistance and add
StringUtils#getJaroWinklerSimilarity instead
> Wrong name or result of StringUtils::getJaroWinklerDistance
> ---
>
> Key: LANG-1269
> URL: https://issues.apache.org/jira/browse/LANG-1269
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3, 3.4
>Reporter: Jan Martin Keil
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>
> The name of the method StringUtils::getJaroWinklerDistance is misleading.
> Currently for equal strings {{1}} is returned, for completely different
> strings {{0}} is returned. That is a measure of similarity, not of a
> distance. A distance must be {{0}} for equal strings. I read on the issues
> LANG-591 and LANG-944, that it was decided to have a similar name to
> StringUtils::getLevenshteinDistance, but that requires also the change of the
> methods result.
> Could you please (1) rename the method to
> StringUtils::getJaroWinklerSimilarity or (2) change the method to return {{1
> - currentResult}}?
> First option has the disadvantage to lose the similar naming of the similar
> methods, second option implies the risk to unnoticed introduce bugs in
> depending code. So I think it is preferable to use the first option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance
[
https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597540#comment-15597540
]
Pascal Schumacher commented on LANG-1269:
-
What about deprecating the current method (letting it stay as it is) and adding
renamed copy (getJaroWinklerSimilarity). This ensures that we do not break any
existing code. What do you think?
> Wrong name or result of StringUtils::getJaroWinklerDistance
> ---
>
> Key: LANG-1269
> URL: https://issues.apache.org/jira/browse/LANG-1269
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3, 3.4
>Reporter: Jan Martin Keil
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>
> The name of the method StringUtils::getJaroWinklerDistance is misleading.
> Currently for equal strings {{1}} is returned, for completely different
> strings {{0}} is returned. That is a measure of similarity, not of a
> distance. A distance must be {{0}} for equal strings. I read on the issues
> LANG-591 and LANG-944, that it was decided to have a similar name to
> StringUtils::getLevenshteinDistance, but that requires also the change of the
> methods result.
> Could you please (1) rename the method to
> StringUtils::getJaroWinklerSimilarity or (2) change the method to return {{1
> - currentResult}}?
> First option has the disadvantage to lose the similar naming of the similar
> methods, second option implies the risk to unnoticed introduce bugs in
> depending code. So I think it is preferable to use the first option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance
[
https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567947#comment-15567947
]
Bruno P. Kinoshita commented on LANG-1269:
--
Indeed Benedikt. I'll file a ticket for [text].
If methods like this are going to be deprecated (and maybe removed in the 4.x
release?) in [lang], then I'd think we should just add the @deprecated
annotation to the method. Other wise, I'd be inclined to leave the method name
as-is (so we keep binary compatibility), return 1 - currentResult as suggested
by [~jmkeil]; and maybe update the Javadocs as well.
> Wrong name or result of StringUtils::getJaroWinklerDistance
> ---
>
> Key: LANG-1269
> URL: https://issues.apache.org/jira/browse/LANG-1269
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3, 3.4
>Reporter: Jan Martin Keil
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>
> The name of the method StringUtils::getJaroWinklerDistance is misleading.
> Currently for equal strings {{1}} is returned, for completely different
> strings {{0}} is returned. That is a measure of similarity, not of a
> distance. A distance must be {{0}} for equal strings. I read on the issues
> LANG-591 and LANG-944, that it was decided to have a similar name to
> StringUtils::getLevenshteinDistance, but that requires also the change of the
> methods result.
> Could you please (1) rename the method to
> StringUtils::getJaroWinklerSimilarity or (2) change the method to return {{1
> - currentResult}}?
> First option has the disadvantage to lose the similar naming of the similar
> methods, second option implies the risk to unnoticed introduce bugs in
> depending code. So I think it is preferable to use the first option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance
[
https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15518833#comment-15518833
]
Benedikt Ritter commented on LANG-1269:
---
This probably also affects Commons Text
> Wrong name or result of StringUtils::getJaroWinklerDistance
> ---
>
> Key: LANG-1269
> URL: https://issues.apache.org/jira/browse/LANG-1269
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3, 3.4
>Reporter: Jan Martin Keil
>Priority: Minor
>
> The name of the method StringUtils::getJaroWinklerDistance is misleading.
> Currently for equal strings {{1}} is returned, for completely different
> strings {{0}} is returned. That is a measure of similarity, not of a
> distance. A distance must be {{0}} for equal strings. I read on the issues
> LANG-591 and LANG-944, that it was decided to have a similar name to
> StringUtils::getLevenshteinDistance, but that requires also the change of the
> methods result.
> Could you please (1) rename the method to
> StringUtils::getJaroWinklerSimilarity or (2) change the method to return {{1
> - currentResult}}?
> First option has the disadvantage to lose the similar naming of the similar
> methods, second option implies the risk to unnoticed introduce bugs in
> depending code. So I think it is preferable to use the first option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
