[jira] [Commented] (CB-11855) hasPhoneNumber does not work for iOS
[ https://issues.apache.org/jira/browse/CB-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267415#comment-16267415 ] ASF GitHub Bot commented on CB-11855: - maverickmishra commented on issue #134: CB-11855: (ios) Allow iOS to use hasPhoneNumber URL: https://github.com/apache/cordova-plugin-contacts/pull/134#issuecomment-347314455 This plugin is being deprecated. No more work will be done on this plugin by the Cordova development community. You can continue to use this plugin and it should work as-is in the future but any more arising issues will not be fixed by the Cordova community. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > hasPhoneNumber does not work for iOS > > > Key: CB-11855 > URL: https://issues.apache.org/jira/browse/CB-11855 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-contacts (DEPRECATED) >Affects Versions: 6.3.0 > Environment: osx, linux, ios >Reporter: Justin Ahn >Priority: Trivial > Labels: known_issue > Fix For: 6.3.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > hasPhoneNumber is an Android Only feature. I'm proposing extending it to > allow iOS to use this feature as well -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11855) hasPhoneNumber does not work for iOS
[
https://issues.apache.org/jira/browse/CB-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267416#comment-16267416
]
ASF GitHub Bot commented on CB-11855:
-
maverickmishra closed pull request #134: CB-11855: (ios) Allow iOS to use
hasPhoneNumber
URL: https://github.com/apache/cordova-plugin-contacts/pull/134
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/ios/CDVContacts.m b/src/ios/CDVContacts.m
index d5dd958..09b1e05 100644
--- a/src/ios/CDVContacts.m
+++ b/src/ios/CDVContacts.m
@@ -326,6 +326,7 @@ - (void)search:(CDVInvokedUrlCommand*)command
NSArray* foundRecords = nil;
// get the findOptions values
BOOL multiple = NO; // default is false
+BOOL hasPhoneNumber = NO; // default is false
NSString* filter = nil;
NSArray* desiredFields = nil;
if (![findOptions isKindOfClass:[NSNull class]]) {
@@ -337,6 +338,10 @@ - (void)search:(CDVInvokedUrlCommand*)command
multiple = [(NSNumber*)value boolValue];
// NSLog(@"multiple is: %d", multiple);
}
+value = [findOptions objectForKey:@"hasPhoneNumber"];
+if ([value isKindOfClass:[NSNumber class]]) {
+hasPhoneNumber = [(NSNumber*)value boolValue];
+}
desiredFields = [findOptions objectForKey:@"desiredFields"];
// return all fields if desired fields are not explicitly
defined
if (desiredFields == nil || desiredFields.count == 0) {
@@ -391,6 +396,11 @@ - (void)search:(CDVInvokedUrlCommand*)command
for (int i = 0; i < count; i++) {
CDVContact* newContact = [matches objectAtIndex:i];
NSDictionary* aContact = [newContact
toDictionary:returnFields];
+NSMutableArray *phoneNumberArray = [[NSMutableArray
alloc] init];
+phoneNumberArray = [aContact
valueForKey:@"phoneNumbers"];
+if (([phoneNumberArray isKindOfClass:[NSNull class]])
&& (hasPhoneNumber)) {
+ continue;
+}
[returnContacts addObject:aContact];
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> hasPhoneNumber does not work for iOS
>
>
> Key: CB-11855
> URL: https://issues.apache.org/jira/browse/CB-11855
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-contacts (DEPRECATED)
>Affects Versions: 6.3.0
> Environment: osx, linux, ios
>Reporter: Justin Ahn
>Priority: Trivial
> Labels: known_issue
> Fix For: 6.3.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> hasPhoneNumber is an Android Only feature. I'm proposing extending it to
> allow iOS to use this feature as well
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11855) hasPhoneNumber does not work for iOS
[ https://issues.apache.org/jira/browse/CB-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881049#comment-15881049 ] ASF GitHub Bot commented on CB-11855: - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/134 @soonahn it looks like the tests are hanging in this pull request, across all platforms, surprisingly! I think it may be because your branch is ~25 commits behind master. Can you rebase and force-push this up to your branch again? > hasPhoneNumber does not work for iOS > > > Key: CB-11855 > URL: https://issues.apache.org/jira/browse/CB-11855 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Affects Versions: 6.3.0 > Environment: osx, linux, ios >Reporter: Justin Ahn >Priority: Trivial > Labels: known_issue > Fix For: 6.3.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > hasPhoneNumber is an Android Only feature. I'm proposing extending it to > allow iOS to use this feature as well -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11855) hasPhoneNumber does not work for iOS
[ https://issues.apache.org/jira/browse/CB-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881032#comment-15881032 ] ASF GitHub Bot commented on CB-11855: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/134 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/134/commits/03bae62e725bb6bca4eece731d28b5e78d0326ab) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=windows-10-store/artifact/) | | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=ios-9.3/artifact/) | | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=ios-10.0/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/79//PLATFORM=android/artifact/) | > hasPhoneNumber does not work for iOS > > > Key: CB-11855 > URL: https://issues.apache.org/jira/browse/CB-11855 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Affects Versions: 6.3.0 > Environment: osx, linux, ios >Reporter: Justin Ahn >Priority: Trivial > Labels: known_issue > Fix For: 6.3.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > hasPhoneNumber is an Android Only feature. I'm proposing extending it to > allow iOS to use this feature as well -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11855) hasPhoneNumber does not work for iOS
[ https://issues.apache.org/jira/browse/CB-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880885#comment-15880885 ] ASF GitHub Bot commented on CB-11855: - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/134 Let there be tests > hasPhoneNumber does not work for iOS > > > Key: CB-11855 > URL: https://issues.apache.org/jira/browse/CB-11855 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Affects Versions: 6.3.0 > Environment: osx, linux, ios >Reporter: Justin Ahn >Priority: Trivial > Labels: known_issue > Fix For: 6.3.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > hasPhoneNumber is an Android Only feature. I'm proposing extending it to > allow iOS to use this feature as well -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11855) hasPhoneNumber does not work for iOS
[ https://issues.apache.org/jira/browse/CB-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497139#comment-15497139 ] ASF GitHub Bot commented on CB-11855: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/134 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/134/commits/03bae62e725bb6bca4eece731d28b5e78d0326ab) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=android/artifact/) | > hasPhoneNumber does not work for iOS > > > Key: CB-11855 > URL: https://issues.apache.org/jira/browse/CB-11855 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Contacts >Affects Versions: 6.3.0 > Environment: osx, linux, ios >Reporter: Justin Ahn >Priority: Trivial > Labels: known_issue > Fix For: 6.3.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > hasPhoneNumber is an Android Only feature. I'm proposing extending it to > allow iOS to use this feature as well -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11855) hasPhoneNumber does not work for iOS
[ https://issues.apache.org/jira/browse/CB-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496764#comment-15496764 ] ASF GitHub Bot commented on CB-11855: - GitHub user soonahn reopened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/134 CB-11855: (ios) Allow iOS to use hasPhoneNumber ### Platforms affected iOS ### What does this PR do? Fixes https://issues.apache.org/jira/browse/CB-11855 ### What testing has been done on this change? Tested on iOS 9.3 - iPhone 6. As well as iOS Simulator of iPhone 6S ### Checklist - [ Yes ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [ Yes ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ Yes ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ No ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/soonahn/cordova-plugin-contacts allow_ios_to_filter_for_phone_number_only Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #134 commit 85b52d354caeb41ed79269cc9dce690ef41917c8 Author: Justin Ahn Date: 2016-09-15T06:39:33Z Capturing the default like the multiple option, and then continuing through the array if there are no phone numbers for the user commit 03bae62e725bb6bca4eece731d28b5e78d0326ab Author: Justin Ahn Date: 2016-09-16T16:36:01Z adding the bool option as well > hasPhoneNumber does not work for iOS > > > Key: CB-11855 > URL: https://issues.apache.org/jira/browse/CB-11855 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Contacts >Affects Versions: 6.3.0 > Environment: osx, linux, ios >Reporter: Justin Ahn >Priority: Trivial > Labels: known_issue > Fix For: 6.3.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > hasPhoneNumber is an Android Only feature. I'm proposing extending it to > allow iOS to use this feature as well -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11855) hasPhoneNumber does not work for iOS
[ https://issues.apache.org/jira/browse/CB-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492580#comment-15492580 ] ASF GitHub Bot commented on CB-11855: - Github user soonahn closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/134 > hasPhoneNumber does not work for iOS > > > Key: CB-11855 > URL: https://issues.apache.org/jira/browse/CB-11855 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Contacts >Affects Versions: 6.3.0 > Environment: osx, linux, ios >Reporter: Justin Ahn >Priority: Trivial > Labels: known_issue > Fix For: 6.3.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > hasPhoneNumber is an Android Only feature. I'm proposing extending it to > allow iOS to use this feature as well -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11855) hasPhoneNumber does not work for iOS
[ https://issues.apache.org/jira/browse/CB-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492571#comment-15492571 ] ASF GitHub Bot commented on CB-11855: - GitHub user soonahn opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/134 CB-11855: (ios) Allow iOS to use hasPhoneNumber ### Platforms affected iOS ### What does this PR do? Fixes https://issues.apache.org/jira/browse/CB-11855 ### What testing has been done on this change? Tested on iOS 9.3 - iPhone 6. As well as iOS Simulator of iPhone 6S ### Checklist - [ Yes ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [ Yes ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ Yes ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ No ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/soonahn/cordova-plugin-contacts allow_ios_to_filter_for_phone_number_only Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #134 commit 85b52d354caeb41ed79269cc9dce690ef41917c8 Author: Justin Ahn Date: 2016-09-15T06:39:33Z Capturing the default like the multiple option, and then continuing through the array if there are no phone numbers for the user > hasPhoneNumber does not work for iOS > > > Key: CB-11855 > URL: https://issues.apache.org/jira/browse/CB-11855 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Contacts >Affects Versions: 6.3.0 > Environment: osx, linux, ios >Reporter: Justin Ahn >Priority: Trivial > Labels: known_issue > Fix For: 6.3.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > hasPhoneNumber is an Android Only feature. I'm proposing extending it to > allow iOS to use this feature as well -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
