[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338392#comment-16338392
 ] 

ASF GitHub Bot commented on CB-13392:
-

purplecabbage commented on issue #148: CB-13392(Android & iOS): Display app 
version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360305086
 
 
   This is how you attach an image to a comment ...
   
   
![35361925-1c20836a-0118-11e8-86e0-21b04057f5f1](https://user-images.githubusercontent.com/46134/35361964-48f332e8-0118-11e8-927d-33ff23a5e29f.png)
   
   Please remove the file from your pr.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338352#comment-16338352
 ] 

ASF GitHub Bot commented on CB-13392:
-

purplecabbage commented on issue #148: CB-13392(Android & iOS): Display app 
version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360296648
 
 
   github will let you add an image to the pr discussion thread
   
   
   @purplecabbage
   risingj.com
   
   On Wed, Jan 24, 2018 at 2:25 PM, Jonathan Corral 
   wrote:
   
   > *@johnlejardinnier* commented on this pull request.
   > --
   >
   > In README.md
   > 

   > :
   >
   > > +
   > +Now just configure your app version into the widget version attribute, 
like that :
   > +```xml
   > +...
   > +```
   > +
   > +
   > +## Prefix app version
   > +To set a prefix version add the following preference to `config.xml`:
   > +```xml
   > +
   > +```
   > +In this case you'll have `v1.0`
   > +
   > +
   > +## Customize app version
   >
   > For the screenshot, could i commit picture into the repo ?
   > Or i need to upload file on the web ?
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338338#comment-16338338
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163698117
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
+
+
+## Customize app version
 
 Review comment:
   For the screenshot, could i commit picture into the repo ?
   Or i need to upload file on the web ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338339#comment-16338339
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163698117
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
+
+
+## Customize app version
 
 Review comment:
   For the screenshot, could i commit picture into the repo ?
   Or do i need to upload file on the web ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338315#comment-16338315
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163695000
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   okay, thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338282#comment-16338282
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163688650
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   Sorry, I was not very clear:
   You write as if it was optional to configure the `version` attribute in 
`widget`, but as you wrote in your answer yourself this is required anyway - so 
you should reword your text so this matches this reality.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338276#comment-16338276
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163687942
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   Sorry, I was not very clear:


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338277#comment-16338277
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163687942
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   Sorry, I was not very clear:


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338272#comment-16338272
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163686411
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   I'm not sure to understand this part : `Is there a way to not do that?`
   
   The widget `version` attribute is required (cf. 
https://cordova.apache.org/docs/en/latest/config_ref/index.html).
   
   So, if i remove preference `ShowSplashScreenAppVersion`, the app version 
will be always displayed on splashscreen.
   Some users don't want this behaviour.
   
   What would i mean in the doc is that you need to add this preference to 
enable display app version.
   
   If i'm wrong, do not hesitate to be more explicit ;)
   Sorry, i need to improve my english.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338212#comment-16338212
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on issue #148: CB-13392(Android & iOS): Display app 
version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360272175
 
 
   Thanks all for your time and reviews :)
   For the moment i will update docs, following @janpio suggestions.
   So you will be able to merge this PR.
   Then when i will have some time, i will try to improve compatibility for 
Windows as asked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337377#comment-16337377
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on issue #148: CB-13392(Android & iOS): Display app version on 
splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360093045
 
 
   Very nice feature and a good addition to the splashscreen functionality. I 
left some comment on the docs part of it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337378#comment-16337378
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on issue #148: CB-13392(Android & iOS): Display app version on 
splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360093045
 
 
   Very nice feature and a good addition to the splashscreen functionality 
@johnlejardinnier. 
   I left some comment on the docs part of it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337370#comment-16337370
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163512040
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
+
+
+## Customize app version
 
 Review comment:
   What font will be used? Maybe add an example screenshot here so one can 
visualize what it will look like.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337369#comment-16337369
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163511948
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
+
+
+## Customize app version
+To customise the version color, size and horizontal position add the following 
preference to `config.xml`:
+```xml
+
+
+
 
 Review comment:
   How does this work - is it all the way left and right or with a padding? 
Should probably be documented.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337368#comment-16337368
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163511788
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
+
+
+## Customize app version
+To customise the version color, size and horizontal position add the following 
preference to `config.xml`:
 
 Review comment:
   ... the color, size and horizontal position of your version add ...
   preference => preferences


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337365#comment-16337365
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163511563
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
 
 Review comment:
   Suggestion:
   This will be combined with your `version` value to e.g. `v1.0`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337360#comment-16337360
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163511315
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   Is there a way to _not_ do that? I always thought the version was required - 
which would make calling this out a bit unnecessary. You could of course change 
the text in a way that just explains where it will be taking this value from.
   (Also: superfluous space before `:` at the end of the line)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337295#comment-16337295
 ] 

ASF GitHub Bot commented on CB-13392:
-

purplecabbage commented on issue #148: CB-13392(Android & iOS): Display app 
version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360078697
 
 
   I think this is a nice feature, thanks for contributing! 
   I agree with @kerrishotts that windows support should be there for 
consistency.  That is, if this feature is going into the splashscreen plugin 
... I also see no reason why this could not be its own plugin that depends on 
the splashscreen plugin ... and just adds this feature.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337285#comment-16337285
 ] 

ASF GitHub Bot commented on CB-13392:
-

purplecabbage commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163496852
 
 

 ##
 File path: src/ios/CDVSplashScreen.m
 ##
 @@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath 
ofObject:(id)object change:(NS
 [self updateImage];
 }
 
+- (UIColor *)colorFromHexString:(NSString *)hexString {
 
 Review comment:
   Statusbar handles all of this in js here: 
https://github.com/apache/cordova-plugin-statusbar/blob/master/www/statusbar.js#L75
   including shortcut css, like #345 => #334455


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328593#comment-16328593
 ] 

ASF GitHub Bot commented on CB-13392:
-

jcesarmobile commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r162008238
 
 

 ##
 File path: src/ios/CDVSplashScreen.m
 ##
 @@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath 
ofObject:(id)object change:(NS
 [self updateImage];
 }
 
+- (UIColor *)colorFromHexString:(NSString *)hexString {
 
 Review comment:
   statusbar plugin uses a similar code for this. It's in the plugin, not 
provided by Cordova. It also checks that the color is a string (it's not a 
problem here as it's a preference, so I think we can be sure that it's a 
string. But also checks the length and the #


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328574#comment-16328574
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r162004407
 
 

 ##
 File path: src/ios/CDVSplashScreen.m
 ##
 @@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath 
ofObject:(id)object change:(NS
 [self updateImage];
 }
 
+- (UIColor *)colorFromHexString:(NSString *)hexString {
 
 Review comment:
   For the moment i will not change this part because i don't know what is the 
better solution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328517#comment-16328517
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161989736
 
 

 ##
 File path: src/ios/CDVSplashScreen.m
 ##
 @@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath 
ofObject:(id)object change:(NS
 [self updateImage];
 }
 
+- (UIColor *)colorFromHexString:(NSString *)hexString {
+unsigned rgbValue = 0;
+NSScanner *scanner = [NSScanner scannerWithString:hexString];
+[scanner setScanLocation:1]; // bypass '#' character
+[scanner scanHexInt:];
+return [UIColor colorWithRed:((rgbValue & 0xFF) >> 16)/255.0 
green:((rgbValue & 0xFF00) >> 8)/255.0 blue:(rgbValue & 0xFF)/255.0 alpha:1.0];
+}
+
+-(UIImage*) drawText:(NSString*) text inImage:(UIImage*) image 
gravity:(NSString*) gravity fontSize:(CGFloat) fontSize fontColor:(NSString*) 
fontColor
+{
+
+UIFont *font = [UIFont boldSystemFontOfSize:fontSize];
+UIGraphicsBeginImageContext(image.size);
+[image drawInRect:CGRectMake(0,0,image.size.width,image.size.height)];
+
+UIScreen* mainScreen = [UIScreen mainScreen];
+CGFloat mainScreenHeight = mainScreen.bounds.size.height;
+CGFloat mainScreenWidth = mainScreen.bounds.size.width;
+
+CGSize textSize = [text sizeWithFont:font];
+CGFloat padding = 15.0;
+CGFloat position = mainScreenWidth - (textSize.width + padding);
+
+if([gravity isEqualToString:@"left"]) {
+position = padding;
+} else if ([gravity isEqualToString:@"center"]) {
+position = (mainScreenWidth / 2) - padding;
+}
+
+CGRect rect = CGRectMake(position, mainScreenHeight - 30.0, 
textSize.width, textSize.height);
+UIColor *color = [self colorFromHexString:fontColor];
+[color set];
+[text drawInRect:CGRectIntegral(rect) withFont:font];
+UIImage *newImage = UIGraphicsGetImageFromCurrentImageContext();
+UIGraphicsEndImageContext();
+
+return newImage;
+}
+
+
+-(NSString*) getAppVersion
+{
+NSString* version = [[[NSBundle mainBundle] infoDictionary] 
objectForKey:@"CFBundleShortVersionString"];
+
+if (version == nil) {
+  NSLog(@"CFBundleShortVersionString was nil, attempting CFBundleVersion");
+  version = [[[NSBundle mainBundle] infoDictionary] 
objectForKey:@"CFBundleVersion"];
+}
+
+
+if(version != nil) {
+version = [NSString stringWithFormat:@"v%@", version];
 
 Review comment:
   Here too, i'll use a preference.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328510#comment-16328510
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on issue #148: CB-13392(Android & iOS): Display app 
version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-358239026
 
 
   @kerrishotts Thank you so much for your review.
   I will make some changes, then i'll push a new commit as soon as possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328506#comment-16328506
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161987406
 
 

 ##
 File path: src/android/SplashScreen.java
 ##
 @@ -410,4 +428,60 @@ public void run() {
 }
 });
 }
+
+private String getAppVersion() {
+
+  String appVersion = null;
+
+  try {
+
+String packageName = cordova.getActivity().getPackageName();
+PackageManager packageManager = 
cordova.getActivity().getApplicationContext().getPackageManager();
+PackageInfo pi = packageManager.getPackageInfo(packageName, 0);
+
+appVersion = "v" + pi.versionName;
 
 Review comment:
   You're right, i will change that as a preference.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327411#comment-16327411
 ] 

ASF GitHub Bot commented on CB-13392:
-

kerrishotts commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161819364
 
 

 ##
 File path: src/android/SplashScreen.java
 ##
 @@ -410,4 +428,60 @@ public void run() {
 }
 });
 }
+
+private String getAppVersion() {
+
+  String appVersion = null;
+
+  try {
+
+String packageName = cordova.getActivity().getPackageName();
+PackageManager packageManager = 
cordova.getActivity().getApplicationContext().getPackageManager();
+PackageInfo pi = packageManager.getPackageInfo(packageName, 0);
+
+appVersion = "v" + pi.versionName;
 
 Review comment:
   Will everyone be OK with prefixing `v`? I could see some apps wanting to use 
"Version", a localized string, or even nothing at all. Feels like a preference 
(format string, perhaps?)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327413#comment-16327413
 ] 

ASF GitHub Bot commented on CB-13392:
-

kerrishotts commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161820219
 
 

 ##
 File path: src/ios/CDVSplashScreen.m
 ##
 @@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath 
ofObject:(id)object change:(NS
 [self updateImage];
 }
 
+- (UIColor *)colorFromHexString:(NSString *)hexString {
+unsigned rgbValue = 0;
+NSScanner *scanner = [NSScanner scannerWithString:hexString];
+[scanner setScanLocation:1]; // bypass '#' character
+[scanner scanHexInt:];
+return [UIColor colorWithRed:((rgbValue & 0xFF) >> 16)/255.0 
green:((rgbValue & 0xFF00) >> 8)/255.0 blue:(rgbValue & 0xFF)/255.0 alpha:1.0];
+}
+
+-(UIImage*) drawText:(NSString*) text inImage:(UIImage*) image 
gravity:(NSString*) gravity fontSize:(CGFloat) fontSize fontColor:(NSString*) 
fontColor
+{
+
+UIFont *font = [UIFont boldSystemFontOfSize:fontSize];
+UIGraphicsBeginImageContext(image.size);
+[image drawInRect:CGRectMake(0,0,image.size.width,image.size.height)];
+
+UIScreen* mainScreen = [UIScreen mainScreen];
+CGFloat mainScreenHeight = mainScreen.bounds.size.height;
+CGFloat mainScreenWidth = mainScreen.bounds.size.width;
+
+CGSize textSize = [text sizeWithFont:font];
+CGFloat padding = 15.0;
+CGFloat position = mainScreenWidth - (textSize.width + padding);
+
+if([gravity isEqualToString:@"left"]) {
+position = padding;
+} else if ([gravity isEqualToString:@"center"]) {
+position = (mainScreenWidth / 2) - padding;
+}
+
+CGRect rect = CGRectMake(position, mainScreenHeight - 30.0, 
textSize.width, textSize.height);
+UIColor *color = [self colorFromHexString:fontColor];
+[color set];
+[text drawInRect:CGRectIntegral(rect) withFont:font];
+UIImage *newImage = UIGraphicsGetImageFromCurrentImageContext();
+UIGraphicsEndImageContext();
+
+return newImage;
+}
+
+
+-(NSString*) getAppVersion
+{
+NSString* version = [[[NSBundle mainBundle] infoDictionary] 
objectForKey:@"CFBundleShortVersionString"];
+
+if (version == nil) {
+  NSLog(@"CFBundleShortVersionString was nil, attempting CFBundleVersion");
+  version = [[[NSBundle mainBundle] infoDictionary] 
objectForKey:@"CFBundleVersion"];
+}
+
+
+if(version != nil) {
+version = [NSString stringWithFormat:@"v%@", version];
 
 Review comment:
   Will everyone be OK with prefixing `v`? I could see some apps wanting to use 
"Version", a localized string, or even nothing at all. Feels like a preference 
(format string, perhaps?)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327412#comment-16327412
 ] 

ASF GitHub Bot commented on CB-13392:
-

kerrishotts commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161825874
 
 

 ##
 File path: src/ios/CDVSplashScreen.m
 ##
 @@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath 
ofObject:(id)object change:(NS
 [self updateImage];
 }
 
+- (UIColor *)colorFromHexString:(NSString *)hexString {
 
 Review comment:
   Does Cordova not export any methods to handle color parsing in preferences? 
(I don't know -- have't looked). If it does, I'd suggest using those, rather 
than building your own. If not, a few thoughts:
   
   1. Would it make sense to support the case where the user forgets "#"?
   2. Would it make sense to support the backgroundColor pref case where it 
uses "0x" instead?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327414#comment-16327414
 ] 

ASF GitHub Bot commented on CB-13392:
-

kerrishotts commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161818781
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,23 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+ Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+To customise the version color, size and position add the following preference 
to `config.xml`:
+```xml
+
+
+
+```
+**Note**: those values are defaults.
+For the horizontal gravity, you may choose between `left`, `center` and 
`right`.
+For the vertical gravity, you don't have choice, text is placed at the bottom 
of the splashscreen.
 
 Review comment:
   This is just begging for a preference, because _someone_ out there is 
inevitably going to need to position the version separately...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327410#comment-16327410
 ] 

ASF GitHub Bot commented on CB-13392:
-

kerrishotts commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161820527
 
 

 ##
 File path: src/ios/CDVSplashScreen.m
 ##
 @@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath 
ofObject:(id)object change:(NS
 [self updateImage];
 }
 
+- (UIColor *)colorFromHexString:(NSString *)hexString {
+unsigned rgbValue = 0;
+NSScanner *scanner = [NSScanner scannerWithString:hexString];
+[scanner setScanLocation:1]; // bypass '#' character
+[scanner scanHexInt:];
+return [UIColor colorWithRed:((rgbValue & 0xFF) >> 16)/255.0 
green:((rgbValue & 0xFF00) >> 8)/255.0 blue:(rgbValue & 0xFF)/255.0 alpha:1.0];
+}
+
+-(UIImage*) drawText:(NSString*) text inImage:(UIImage*) image 
gravity:(NSString*) gravity fontSize:(CGFloat) fontSize fontColor:(NSString*) 
fontColor
+{
+
+UIFont *font = [UIFont boldSystemFontOfSize:fontSize];
+UIGraphicsBeginImageContext(image.size);
+[image drawInRect:CGRectMake(0,0,image.size.width,image.size.height)];
+
+UIScreen* mainScreen = [UIScreen mainScreen];
+CGFloat mainScreenHeight = mainScreen.bounds.size.height;
+CGFloat mainScreenWidth = mainScreen.bounds.size.width;
+
+CGSize textSize = [text sizeWithFont:font];
+CGFloat padding = 15.0;
+CGFloat position = mainScreenWidth - (textSize.width + padding);
+
+if([gravity isEqualToString:@"left"]) {
+position = padding;
+} else if ([gravity isEqualToString:@"center"]) {
+position = (mainScreenWidth / 2) - padding;
+}
+
+CGRect rect = CGRectMake(position, mainScreenHeight - 30.0, 
textSize.width, textSize.height);
 
 Review comment:
   Curious -- what's this look like on an iPhone X? Does this clear the home 
screen indicator?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327409#comment-16327409
 ] 

ASF GitHub Bot commented on CB-13392:
-

kerrishotts commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161819016
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,23 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+ Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+To customise the version color, size and position add the following preference 
to `config.xml`:
+```xml
+
+
+
+```
+**Note**: those values are defaults.
+For the horizontal gravity, you may choose between `left`, `center` and 
`right`.
+For the vertical gravity, you don't have choice, text is placed at the bottom 
of the splashscreen.
 
 Review comment:
   Note: not saying this needs to _be_ a preference -- just that if there's a 
good reason for it not being a preference that it should be called out -- 
otherwise someone is definitely going to ask for it as a feature.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327384#comment-16327384
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on issue #148: CB-13392(Android & iOS): Display app 
version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-358030465
 
 
   @macdonst Thanks a lot !
   Sorry i've closed previous PR because it was not made properly (Not reported 
on JIRA and wrong commit name).
   Now it's clean.
   
   Thank you for the tip, this is my first contribution.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327347#comment-16327347
 ] 

ASF GitHub Bot commented on CB-13392:
-

macdonst commented on issue #148: CB-13392(Android & iOS): Display app version 
on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-358022454
 
 
   @infil00p ah, now I see you already reviewed an earlier version of this PR.
   
   @johnlejardinnier in the future, you can just push a new commit to the PR 
branch so you don't have to close and re-open a new one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327342#comment-16327342
 ] 

ASF GitHub Bot commented on CB-13392:
-

macdonst commented on issue #148: CB-13392(Android & iOS): Display app version 
on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-358021107
 
 
   @johnlejardinnier Pretty cool PR. I've specifically called out some folks to 
review your PR. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327208#comment-16327208
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier opened a new pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148
 
 
   
   
   ### Platforms affected
   Android and iOS
   
   ### What does this PR do?
   This is a feature to display the app version on the splashscreen.
   Documentation has been updated up to use this feature.
   
   ### What testing has been done on this change?
   Sorry there are no tests for this feature so i couldn't check items below.
   Do no hesitate to join me if you need further informations.
   Thanks.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

[Jonathan Corral (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199542#comment-16199542
 ] 

Jonathan Corral commented on CB-13392:
--

PR : https://github.com/apache/cordova-plugin-splashscreen/pull/134

> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org