[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363266#comment-16363266 ] ASF GitHub Bot commented on CB-13861: - janpio closed pull request #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363249#comment-16363249 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365446627 #254 is now in a state to be tested and reviewed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362975#comment-16362975 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365388649 See https://github.com/apache/cordova-windows/pull/254 as a replacement. Would be nice if you could check that out and run it locally to see if the tests succeed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362944#comment-16362944 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365383160 Problem is that `prepare` is not available on the command line... so I had to implement that. Will open an issue and PR later. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362940#comment-16362940 ] ASF GitHub Bot commented on CB-13861: - purplecabbage commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365382091 Yeah, I believe prepare is the right place for this to happen. Consider this pr dead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362827#comment-16362827 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365357575 So I installed my branch which is giving me errors on running the test. On `cordova platform add ...` it creates a `CordovaApp.Windows10.jsproj` file with: ``` UAP 10.0.16299.0 10.0.10240.0 14.0 100 ``` So it updates the `TargetPlatformVersion` to the current version somewhere. Yes, there is some code for that in `prepare.js` and this is actually executed during `cordova platform add ...`. Which means that the tests should probably/maybe do something similar instead of this PR here, right? This PR is only making it possible to run the tests with a very specific setup. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362736#comment-16362736 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365348748 Can confirm, I currently only have `10.0.16299.0` (newest) installed. These tests only succeed if I change it to that version. Let me confirm that I can actually build an app without updating this value when I install the branch I am currently working on. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362729#comment-16362729 ] ASF GitHub Bot commented on CB-13861: - brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345897 > Is this maybe related to the actually installed local versions of Windows SDK? I would think so > Could you both please check which ones you have installed? I will check sometime later This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362727#comment-16362727 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345308 Unfortunately I can not confirm that changing the value to `...10586...` fixes the issue: ``` C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Microsoft\VisualStudio\v15.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(84,3): error : "10.0.10586.0" is not a supported value for TargetPlatformVersion. Please change it on the Project Property page. [C:\Projects\Cordova\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj] ``` Is this maybe related to the actually installed local versions of Windows SDK? Could you both please check which ones you have installed? (When creating an actual project, this value is replaced by the highest available I think, so this might really only be an issue with `npm test`/`npm run test-e2e` but not in actual usage.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362725#comment-16362725 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365344461 I can now confirm this error message with (only) Visual Studio 2017 installed: ``` C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Microsoft\VisualStudio\v15.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(84,3): error : "10.0.10240.0" is not a supported value for TargetPlatformVersion. Please change it on the Project Property page. [C:\Projects\Cordova\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362474#comment-16362474 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666 The error message you posted contains `VisualStudio\v14.0` which is Visual Studio 2015. https://issues.apache.org/jira/browse/CB-13861 specifically mentions Visual Studio 2017. What is the connection here? Do you also have the same problem on a machine with VS17? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362472#comment-16362472 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666 The error message you posted contains `VisualStudio\v14.0` which is Visual Studio 2015. https://issues.apache.org/jira/browse/CB-13861 specifically mentions Visual Studio 2017. What is the connection here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360843#comment-16360843 ] ASF GitHub Bot commented on CB-13861: - brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364948542 > What should I look for the "before" state? Without the proposed change I get the following _error_ output if I do `npm run test-e2e` in my workarea: ``` C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(82,3): error : "10.0.10240.0" is not a supported value for TargetPlatformVersion. Please change it on the Project Property page. [C:\Users\brodybits\Documents\cbwork\cordova-windows\testcreate ?? ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360842#comment-16360842 ] ASF GitHub Bot commented on CB-13861: - brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364948542 > What should I look for the "before" state? Without the proposed change I get the following output if I do `npm run test-e2e` in my workarea: ``` C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(82,3): error : "10.0.10240.0" is not a supported value for TargetPlatformVersion. Please change it on the Project Property page. [C:\Users\brodybits\Documents\cbwork\cordova-windows\testcreate ?? ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360800#comment-16360800 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364938297 This turned out to be a bigger problem than expected. It is not a blocking issue at https://issues.apache.org/jira/browse/CB-13870 What errors were you trying to solve by changing `TargetPlatformVersion` @purplecabbage and @brodybits? What should I look for the "before" state? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360032#comment-16360032 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364770895 None right now, just setting up to test/release tomorrow and wanted to make sure I know which combination is known good ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360018#comment-16360018 ] ASF GitHub Bot commented on CB-13861: - brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364769143 > Ouch. We might want to look into that later ;) @janpio what are your results? Any different? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360017#comment-16360017 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364768966 Ouch. We might want to look into that later ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360007#comment-16360007 ] ASF GitHub Bot commented on CB-13861: - brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364767817 If I would do `cordova platform add https://github.com/apache/cordova-windows` in a new project then do `cordova requirements windows` I get the following output: ```sh Requirements check results for windows: Windows OS: not installed Error: Cannot read property 'os' of undefined (node:5776) UnhandledPromiseRejectionWarning: CordovaError: Some of requirements check failed at C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\src\cli.js:414:27 at _fulfilled (C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:787:54) at self.promiseDispatch.done (C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:816:30) at Promise.promise.promiseDispatch (C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:749:13) at C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:557:44 at flush (C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:108:17) at process._tickCallback (internal/process/next_tick.js:150:11) (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1) (node:5776) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. ``` Same result if I would do `cordova platform add https://github.com/apache/cordova-windows#CB-13861` then `cordova requirements windows`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360002#comment-16360002 ] ASF GitHub Bot commented on CB-13861: - janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364766938 What does `cordova requirements windows` return for you? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359685#comment-16359685 ] ASF GitHub Bot commented on CB-13861: - brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364709203 Works for me on both Visual Studio 2015 and Visual Studio 2017. Ship it! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13861) Update TargetPlatformVersion to 10.0.10586.0
[ https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359133#comment-16359133 ] ASF GitHub Bot commented on CB-13861: - purplecabbage opened a new pull request #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250 Update TargetPlatformVersion to 10.0.10586.0 ### Platforms affected cordova-windows (windows 10 projects) ### What does this PR do? Updates TargetPlatformVersion to 10.0.10586.0 ### What testing has been done on this change? works for me! ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update TargetPlatformVersion to 10.0.10586.0 > > > Key: CB-13861 > URL: https://issues.apache.org/jira/browse/CB-13861 > Project: Apache Cordova > Issue Type: Bug >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen >Priority: Major > > For VS2017 Windows 10 projects we need to update TargetPlatformVersion to > 10.0.10586.0 > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
