[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482344#comment-16482344 ] ASF GitHub Bot commented on CB-14098: - shazron closed pull request #21: CB-14098: Remove unused res folder URL: https://github.com/apache/cordova-app-hello-world/pull/21 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/template_src/res/README.md b/template_src/res/README.md deleted file mode 100644 index bffb33b..000 --- a/template_src/res/README.md +++ /dev/null @@ -1,29 +0,0 @@ - - -Note that these image resources are not copied into a project when a project -is created with the CLI. Although there are default image resources in a -newly-created project, those come from the platform-specific project template, -which can generally be found in the platform's `template` directory. Until -icon and splashscreen support is added to the CLI, these image resources -aren't used directly. - -See https://issues.apache.org/jira/browse/CB-5145 diff --git a/template_src/res/icon/android/icon-36-ldpi.png b/template_src/res/icon/android/icon-36-ldpi.png deleted file mode 100644 index cd5032a..000 Binary files a/template_src/res/icon/android/icon-36-ldpi.png and /dev/null differ diff --git a/template_src/res/icon/android/icon-48-mdpi.png b/template_src/res/icon/android/icon-48-mdpi.png deleted file mode 100644 index e79c606..000 Binary files a/template_src/res/icon/android/icon-48-mdpi.png and /dev/null differ diff --git a/template_src/res/icon/android/icon-72-hdpi.png b/template_src/res/icon/android/icon-72-hdpi.png deleted file mode 100644 index 4d27634..000 Binary files a/template_src/res/icon/android/icon-72-hdpi.png and /dev/null differ diff --git a/template_src/res/icon/android/icon-96-xhdpi.png b/template_src/res/icon/android/icon-96-xhdpi.png deleted file mode 100644 index ec7ffbf..000 Binary files a/template_src/res/icon/android/icon-96-xhdpi.png and /dev/null differ diff --git a/template_src/res/icon/bada-wac/icon-48-type5.png b/template_src/res/icon/bada-wac/icon-48-type5.png deleted file mode 100644 index 8ad8bac..000 Binary files a/template_src/res/icon/bada-wac/icon-48-type5.png and /dev/null differ diff --git a/template_src/res/icon/bada-wac/icon-50-type3.png b/template_src/res/icon/bada-wac/icon-50-type3.png deleted file mode 100644 index c6ddf84..000 Binary files a/template_src/res/icon/bada-wac/icon-50-type3.png and /dev/null differ diff --git a/template_src/res/icon/bada-wac/icon-80-type4.png b/template_src/res/icon/bada-wac/icon-80-type4.png deleted file mode 100644 index f86a27a..000 Binary files a/template_src/res/icon/bada-wac/icon-80-type4.png and /dev/null differ diff --git a/template_src/res/icon/bada/icon-128.png b/template_src/res/icon/bada/icon-128.png deleted file mode 100644 index 3516df3..000 Binary files a/template_src/res/icon/bada/icon-128.png and /dev/null differ diff --git a/template_src/res/icon/blackberry/icon-80.png b/template_src/res/icon/blackberry/icon-80.png deleted file mode 100644 index f86a27a..000 Binary files a/template_src/res/icon/blackberry/icon-80.png and /dev/null differ diff --git a/template_src/res/icon/blackberry10/icon-80.png b/template_src/res/icon/blackberry10/icon-80.png deleted file mode 100644 index f86a27a..000 Binary files a/template_src/res/icon/blackberry10/icon-80.png and /dev/null differ diff --git a/template_src/res/icon/ios/icon-57-2x.png b/template_src/res/icon/ios/icon-57-2x.png deleted file mode 100644 index efd9c37..000 Binary files a/template_src/res/icon/ios/icon-57-2x.png and /dev/null differ diff --git a/template_src/res/icon/ios/icon-57.png b/template_src/res/icon/ios/icon-57.png deleted file mode 100644 index c795fc4..000 Binary files a/template_src/res/icon/ios/icon-57.png and /dev/null differ diff --git a/template_src/res/icon/ios/icon-72-2x.png b/template_src/res/icon/ios/icon-72-2x.png deleted file mode 100644 index dd819da..000 Binary files a/template_src/res/icon/ios/icon-72-2x.png and /dev/null differ diff --git a/template_src/res/icon/ios/icon-72.png b/template_src/res/icon/ios/icon-72.png deleted file mode 100644 index b1cfde7..000 Binary files a/template_src/res/icon/ios/icon-72.png and /dev/null differ diff --git a/template_src/res/icon/tizen/icon-128.png b/template_src/res/icon/tizen/icon-128.png deleted file mode 100644 index 3516df3..000 Binary files a/template_src/res/icon/tizen/icon-128.png and /dev/null differ diff --git a/template_src/res/icon/webos/icon-64.png b/template_src/res/icon/webos/icon-64.png deleted file mode 100644 index 03b3849..000 Binary files a/template_src/res/icon/webos/icon-64.png and
[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482346#comment-16482346 ] ASF subversion and git services commented on CB-14098: -- Commit af6bcf820c786485671077d5e9e10e8a1732592a in cordova-app-hello-world's branch refs/heads/master from [~shazron] [ https://gitbox.apache.org/repos/asf?p=cordova-app-hello-world.git;h=af6bcf8 ] Merge pull request #21 from raphinesse/slimdown CB-14098: Remove unused res folder > Remove unused res folder from app template > -- > > Key: CB-14098 > URL: https://issues.apache.org/jira/browse/CB-14098 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world >Affects Versions: 3.11.0 >Reporter: Raphael >Priority: Major > > The res folder weighs around 10MiB and contains resources for a whole lot of > platforms, most of which are actually deprecated. Furthermore, as I > understand the included `README.md` (which I'm not sure I do), the contents > of this folder seem to not even being used for anything. > So my proposal is to remove this directory from the template. That would > decrease the installation size of `cordova` by about two thirds and remove > unnecessary clutter from any newly created apps. > If I did get anything wrong and this is actually used, we should probably > clarify the README, remove all content related to deprecated platforms (like > suggested in CB-13726) and run them through some compressors (pngquant and > zopflipng). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482343#comment-16482343 ] ASF GitHub Bot commented on CB-14098: - shazron commented on issue #21: CB-14098: Remove unused res folder URL: https://github.com/apache/cordova-app-hello-world/pull/21#issuecomment-390608786 iOS images are in this bundle, which is in the platform template: https://github.com/apache/cordova-ios/tree/3507af4ac68ed13cfb4d8ecfd0e91e747a9c6875/bin/templates/project/__PROJECT_NAME__/Images.xcassets This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unused res folder from app template > -- > > Key: CB-14098 > URL: https://issues.apache.org/jira/browse/CB-14098 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world >Affects Versions: 3.11.0 >Reporter: Raphael >Priority: Major > > The res folder weighs around 10MiB and contains resources for a whole lot of > platforms, most of which are actually deprecated. Furthermore, as I > understand the included `README.md` (which I'm not sure I do), the contents > of this folder seem to not even being used for anything. > So my proposal is to remove this directory from the template. That would > decrease the installation size of `cordova` by about two thirds and remove > unnecessary clutter from any newly created apps. > If I did get anything wrong and this is actually used, we should probably > clarify the README, remove all content related to deprecated platforms (like > suggested in CB-13726) and run them through some compressors (pngquant and > zopflipng). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482345#comment-16482345 ] ASF subversion and git services commented on CB-14098: -- Commit 6c5e87bdcda82adcfa9133b5e85ff7bd05331a67 in cordova-app-hello-world's branch refs/heads/master from [~raphinesse] [ https://gitbox.apache.org/repos/asf?p=cordova-app-hello-world.git;h=6c5e87b ] CB-14098: Remove unused res folder > Remove unused res folder from app template > -- > > Key: CB-14098 > URL: https://issues.apache.org/jira/browse/CB-14098 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world >Affects Versions: 3.11.0 >Reporter: Raphael >Priority: Major > > The res folder weighs around 10MiB and contains resources for a whole lot of > platforms, most of which are actually deprecated. Furthermore, as I > understand the included `README.md` (which I'm not sure I do), the contents > of this folder seem to not even being used for anything. > So my proposal is to remove this directory from the template. That would > decrease the installation size of `cordova` by about two thirds and remove > unnecessary clutter from any newly created apps. > If I did get anything wrong and this is actually used, we should probably > clarify the README, remove all content related to deprecated platforms (like > suggested in CB-13726) and run them through some compressors (pngquant and > zopflipng). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482091#comment-16482091 ] ASF GitHub Bot commented on CB-14098: - raphinesse commented on issue #21: CB-14098: Remove unused res folder URL: https://github.com/apache/cordova-app-hello-world/pull/21#issuecomment-390522900 @Menardi The former README in this folder says: > Although there are default image resources in a newly-created project, those come from the platform-specific project template, which can generally be found in the platform's `template` directory. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unused res folder from app template > -- > > Key: CB-14098 > URL: https://issues.apache.org/jira/browse/CB-14098 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world >Affects Versions: 3.11.0 >Reporter: Raphael >Priority: Major > > The res folder weighs around 10MiB and contains resources for a whole lot of > platforms, most of which are actually deprecated. Furthermore, as I > understand the included `README.md` (which I'm not sure I do), the contents > of this folder seem to not even being used for anything. > So my proposal is to remove this directory from the template. That would > decrease the installation size of `cordova` by about two thirds and remove > unnecessary clutter from any newly created apps. > If I did get anything wrong and this is actually used, we should probably > clarify the README, remove all content related to deprecated platforms (like > suggested in CB-13726) and run them through some compressors (pngquant and > zopflipng). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482092#comment-16482092 ] ASF GitHub Bot commented on CB-14098: - raphinesse commented on issue #21: CB-14098: Remove unused res folder URL: https://github.com/apache/cordova-app-hello-world/pull/21#issuecomment-390522900 @Menardi Thanks for testing. The former README in this folder says: > Although there are default image resources in a newly-created project, those come from the platform-specific project template, which can generally be found in the platform's `template` directory. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unused res folder from app template > -- > > Key: CB-14098 > URL: https://issues.apache.org/jira/browse/CB-14098 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world >Affects Versions: 3.11.0 >Reporter: Raphael >Priority: Major > > The res folder weighs around 10MiB and contains resources for a whole lot of > platforms, most of which are actually deprecated. Furthermore, as I > understand the included `README.md` (which I'm not sure I do), the contents > of this folder seem to not even being used for anything. > So my proposal is to remove this directory from the template. That would > decrease the installation size of `cordova` by about two thirds and remove > unnecessary clutter from any newly created apps. > If I did get anything wrong and this is actually used, we should probably > clarify the README, remove all content related to deprecated platforms (like > suggested in CB-13726) and run them through some compressors (pngquant and > zopflipng). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482089#comment-16482089 ] ASF GitHub Bot commented on CB-14098: - Menardi commented on issue #21: CB-14098: Remove unused res folder URL: https://github.com/apache/cordova-app-hello-world/pull/21#issuecomment-390522704 I agree, it looks like the `res` folder is redundant. An iOS app built on this template is just fine, and has all the default Cordova icons. I'm not sure where they're being taken from, but it's not this `res` folder. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unused res folder from app template > -- > > Key: CB-14098 > URL: https://issues.apache.org/jira/browse/CB-14098 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world >Affects Versions: 3.11.0 >Reporter: Raphael >Priority: Major > > The res folder weighs around 10MiB and contains resources for a whole lot of > platforms, most of which are actually deprecated. Furthermore, as I > understand the included `README.md` (which I'm not sure I do), the contents > of this folder seem to not even being used for anything. > So my proposal is to remove this directory from the template. That would > decrease the installation size of `cordova` by about two thirds and remove > unnecessary clutter from any newly created apps. > If I did get anything wrong and this is actually used, we should probably > clarify the README, remove all content related to deprecated platforms (like > suggested in CB-13726) and run them through some compressors (pngquant and > zopflipng). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14098) Remove unused res folder from app template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480566#comment-16480566 ] ASF GitHub Bot commented on CB-14098: - raphinesse opened a new pull request #21: CB-14098: Remove unused res folder URL: https://github.com/apache/cordova-app-hello-world/pull/21 ### Platforms affected All ### What does this PR do? Remove unused icons and splash screens from this template to save 10MiB in every cordova project created from it and every installation of `cordova`. ### What testing has been done on this change? Manual. I can create a new project with this, `add platform android` and `run` it. Has no obviously missing assets. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unused res folder from app template > -- > > Key: CB-14098 > URL: https://issues.apache.org/jira/browse/CB-14098 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world >Affects Versions: 3.11.0 >Reporter: Raphael >Priority: Major > > The res folder weighs around 10MiB and contains resources for a whole lot of > platforms, most of which are actually deprecated. Furthermore, as I > understand the included `README.md` (which I'm not sure I do), the contents > of this folder seem to not even being used for anything. > So my proposal is to remove this directory from the template. That would > decrease the installation size of `cordova` by about two thirds and remove > unnecessary clutter from any newly created apps. > If I did get anything wrong and this is actually used, we should probably > clarify the README, remove all content related to deprecated platforms (like > suggested in CB-13726) and run them through some compressors (pngquant and > zopflipng). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
