[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669797#comment-16669797
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-434612801
 
 
   Rebased. Tested on Android (7) and iOS (iPhone 8) emulator.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669682#comment-16669682
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-434580744
 
 
   I will look at it, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669228#comment-16669228
 ] 

ASF GitHub Bot commented on CB-14187:
-

janpio commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-434437617
 
 
   #276 is merged, so this can be taken care of now I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639737#comment-16639737
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-427342839
 
 
   Thanks! I'll be happy to rebase on master once #276 is sorted out.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637586#comment-16637586
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-426829387
 
 
   @wvengen can you help resolve the conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636022#comment-16636022
 ] 

ASF GitHub Bot commented on CB-14187:
-

janpio commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-426404825
 
 
   And passing :) (context: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-426404322)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596177#comment-16596177
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-416904036
 
 
   Hi @brodybits just a reminder, if you see an opportunity to take another 
look, please don't forget :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567930#comment-16567930
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-410177810
 
 
   No problem, looking forward to getting this merged, somewhere in the coming 
weeks if all works out. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567870#comment-16567870
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-410168819
 
 
   Thanks @wvengen for the update, fixing the eslint warnings, and fixing the 
alert calls. I will probably need 1-2 weeks to take another look. Apologies for 
the extra delays.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567810#comment-16567810
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen edited a comment on issue #274: CB-14187: (ios) Change the InAppBrowser 
to allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409462737
 
 
   @brodybits thanks for checking again. The important change is adding 
`_blank` to `window.open`, which was not present on my fork's `master` yet (but 
added to the docs in this PR). I'll create a PR for your test app with all 
changes needed to make it work.
   
   Also, I'll look into the eslint output.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564822#comment-16564822
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on a change in pull request #274: CB-14187: (ios) Change the 
InAppBrowser to allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#discussion_r206768695
 
 

 ##
 File path: tests/tests.js
 ##
 @@ -693,4 +698,29 @@ exports.defineManualTests = function (contentEl, 
createActionButton) {
 });
 });
 }, 'openHardwareBackDefaultAfterNo');
+
+// Customscheme
+createActionButton('customscheme', function () {
+var ref = cordova.InAppBrowser.open('about:blank', '_blank', 
'hidden=yes');
+var openedCustomscheme = false;
+ref.addEventListener('loadstop', function (e) {
+// Avoid showing the alert twice on iOS, since loadstop is also 
being called after the customscheme event.
+if (!openedCustomscheme) {
+openedCustomscheme = true;
+ref.executeScript({ code: 
'window.location.replace("custom://test");' });
+}
+});
+ref.addEventListener('customscheme', function (e) {
+if (e && e.url === "custom://test") {
 
 Review comment:
   Thanks! I went for the bonus in 93077ef (hoping it will help motivate you to 
complete the review ;) ). Tested it still works (Android).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564789#comment-16564789
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409462737
 
 
   @brodybits thanks for checking again. The important change is adding 
`_blank_` to `window.open`, which was not present on my fork's `master` yet 
(but added to the docs in this PR). I'll create a PR for your test app with all 
changes needed to make it work.
   
   Also, I'll look into the eslint output.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564520#comment-16564520
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409405089
 
 
   I pulled the changes from 

 (master branch) into my master branch, doesn't seem to help on either Android 
or iOS. Gotta say I am getting ready to give up on this one. I just pushed one 
more change to 
 to use your 
`q-m:feature/allowedschemes-ios` branch for now, it would be great if you could 
fix the sample for the sake of the user community.
   
   If you want another expert to take a look I suggest you send a request to: 



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564358#comment-16564358
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on a change in pull request #274: CB-14187: (ios) Change 
the InAppBrowser to allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#discussion_r206679000
 
 

 ##
 File path: tests/tests.js
 ##
 @@ -693,4 +698,29 @@ exports.defineManualTests = function (contentEl, 
createActionButton) {
 });
 });
 }, 'openHardwareBackDefaultAfterNo');
+
+// Customscheme
+createActionButton('customscheme', function () {
+var ref = cordova.InAppBrowser.open('about:blank', '_blank', 
'hidden=yes');
+var openedCustomscheme = false;
+ref.addEventListener('loadstop', function (e) {
+// Avoid showing the alert twice on iOS, since loadstop is also 
being called after the customscheme event.
+if (!openedCustomscheme) {
+openedCustomscheme = true;
+ref.executeScript({ code: 
'window.location.replace("custom://test");' });
+}
+});
+ref.addEventListener('customscheme', function (e) {
+if (e && e.url === "custom://test") {
 
 Review comment:
   I just discovered today that `npm run eslint` has a few failures:
   
   ```
   /Users/brodybits/Documents/cordova/cordova-plugin-inappbrowser/tests/tests.js
 714:32  error  Strings must use singlequotequotes
 715:1   error  Expected indentation of 16 spaces but found 14  indent
 715:15  error  'alert' is not defined  no-undef
 717:1   error  Expected indentation of 16 spaces but found 14  indent
 717:15  error  'alert' is not defined  no-undef
 722:13  error  'alert' is not defined  no-undef
   
   ✖ 6 problems (6 errors, 0 warnings)
 3 errors, 0 warnings potentially fixable with the `--fix` option.
   ```
   
   I can think of 2 possible solutions for `'alert' is not defined`:
   - use `// eslint-disable-line no-undef`
   - preferred: use `window.alert` (less ugly, more likely to work on Windows 
platform)
   
   A nice bonus would be to fix `alert` --> `window.alert` throughout 
`tests.js`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563676#comment-16563676
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen edited a comment on issue #274: CB-14187: (ios) Change the InAppBrowser 
to allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409220992
 
 
   It took me some experimentation to find the cause, but the page you load in 
the whitelist (local page), it is loaded in the Cordova WebView instead of 
InAppBrowser. Make it `cordova.InAppBrowser.open('iabpage.html', '_blank')` and 
the example should work.
   
   Some small corrections in: 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/5917542781efd220745dca3172489ff38f0b95a7
 (should work without) and 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/821652d41c22347eb50cb61ff97dba5a2b5abc0e
 (makes link work).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563673#comment-16563673
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409222786
 
 
   Thanks @wvengen I will take another look today.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563668#comment-16563668
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen edited a comment on issue #274: CB-14187: (ios) Change the InAppBrowser 
to allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409220992
 
 
   It took me some experimentation to find the cause, but since the page you 
load in the whitelist (local page), it is loaded in the Cordova WebView instead 
of InAppBrowser. Make it `cordova.InAppBrowser.open('iabpage.html', '_blank')` 
and the example should work.
   
   Some small corrections in: 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/5917542781efd220745dca3172489ff38f0b95a7
 (should work without) and 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/821652d41c22347eb50cb61ff97dba5a2b5abc0e
 (makes link work).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563667#comment-16563667
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409220992
 
 
   It took me some experimentation to find the cause, but since the page you 
load is local, it is loaded in the Cordova WebView instead of InAppBrowser. 
Make it `cordova.InAppBrowser.open('iabpage.html', '_blank')` and the example 
should work.
   
   Some small corrections in: 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/5917542781efd220745dca3172489ff38f0b95a7
 (should work without) and 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/821652d41c22347eb50cb61ff97dba5a2b5abc0e
 (makes link work).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551360#comment-16551360
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-406739430
 
 
   I gotta say that I am still not able to get it to work on either Android or 
iOS in my test project at 
 (with 1 test 
link and 3 button tests). I suspect that I am doing something wrong; it would 
be best if you can issue a PR to correct me.
   
   If I would add the proposed version of this plugin using the following 
command:
   ```
   cordova plugin add 
https://github.com/q-m/cordova-plugin-inappbrowser#feature/allowedschemes-ios
   ```
   
   then add iOS platform and then run from Xcode, I would get the following 
console log message on iOS when I click the test link or any test button:
   ```
   2018-07-20 17:35:38.166670-0400 HelloCordova[12282:282185] Failed to load 
webpage with error: The URL can’t be shown
   ```
   
   I get the following console log output if I click the test 3 button:
   
   ```
   2018-07-20 18:05:31.146655-0400 HelloCordova[12987:301089] NSURLConnection 
finished with error - code -1002
   2018-07-20 18:05:31.155721-0400 HelloCordova[12987:299914] Failed to load 
webpage with error: The URL can’t be shown
   ```
   
   Test does not work for me on Android either.
   
   If another Cordova member with more experience with this plugin can review 
and test I would be grateful.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548894#comment-16548894
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-406176669
 
 
   Thanks for testing. Apparently I didn't test it enough, sorry. Still, for me 
it works on iOS, except that sometimes the alert _Result verified_ is shown 
twice. That is because, apparently, the loadstop event is being fired for 
customscheme as well. I don't see how that can be avoided, as in 
[`webViewDidFinishLoad`](https://github.com/apache/cordova-plugin-inappbrowser/blob/9cc7f69625363de9872f9dbc028b739f195a4f93/src/ios/CDVInAppBrowser.m#L463)
 (nor the [originating 
method](https://github.com/apache/cordova-plugin-inappbrowser/blob/9cc7f69625363de9872f9dbc028b739f195a4f93/src/ios/CDVInAppBrowser.m#L946))
 there is no context about the URL that caused it.
   
   My proposal:
   1. Mention `loadstop` being called for `customscheme` in the documentation 
(an extra `iOS quirks` in 
[addEventListener](https://github.com/apache/cordova-plugin-inappbrowser#inappbrowseraddeventlistener)).
   2. In the test, only navigate to the custom URL at the first time it happens.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548667#comment-16548667
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-406127713
 
 
   Thanks @wvengen. Unfortunately I had some real trouble getting a test demo 
to work on iOS. A quick demo project that shows this functionality working the 
same way on both Android and iOS (as closely as possible) would be really 
helpful.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547933#comment-16547933
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-405962280
 
 
   Thanks for your review, @brodybits! I've added a test and some documentation.
   I opted for a manual test only, since this needs a `config.xml` preference 
(even though I added that to the CONTRIBUTING document). It might be useful to 
add the preference to the regular Cordova documentation at some point in the 
future (not sure if that is desirable or not).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546636#comment-16546636
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-405590334
 
 
   The proposed changes definitely seem to be consistent with the corresponding 
functionality for Android from GH-263 
([CB-14013](https://issues.apache.org/jira/browse/CB-14013)). A couple more 
things that could help:
   - a quick and easy app that I or someone else could use to test on both iOS 
and Android
   - document the custom scheme support for both Android and iOS


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531245#comment-16531245
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen opened a new pull request #274: CB-14187: (ios) Change the InAppBrowser 
to allow custom schemes
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274
 
 
   …Auth
   
   
   
   ### Platforms affected
   
   - iOS
   
   ### What does this PR do?
   
   Implements [CB-14187](https://issues.apache.org/jira/browse/CB-14187), which 
adds support for the `AllowedSchemes` preference and `customscheme` event for 
iOS.
   
   ### What testing has been done on this change?
   
   Tested on an iPhone 5SE running iOS 11.4.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [x] Added automated test coverage as appropriate for this change: as 
[CB-14013](https://issues.apache.org/jira/browse/CB-14013) 
(https://github.com/apache/cordova-plugin-inappbrowser/pull/263) did not 
include additional tests, I expect it to be unnecessary here as well.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org