[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374639#comment-16374639 ] ASF subversion and git services commented on CB-8515: - Commit 399b87193016ebc2a8b4154de9fae0af68cd70ac in cordova-docs's branch refs/heads/master from Jan Piotrowski [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=399b871 ] CB-8515 add Windows as supported platform for `defaultlocale` (#782) In https://github.com/apache/cordova-windows/pull/59 `defaultlocale` was implemented for Windows. > Support DefaultLanguage selection for Windows > - > > Key: CB-8515 > URL: https://issues.apache.org/jira/browse/CB-8515 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-windows >Reporter: Murat Sutunc >Priority: Major > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for Windows 8.0, > 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale" > attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374637#comment-16374637 ] ASF GitHub Bot commented on CB-8515: janpio closed pull request #782: CB-8515 add Windows as supported platform for `defaultlocale` URL: https://github.com/apache/cordova-docs/pull/782 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support DefaultLanguage selection for Windows > - > > Key: CB-8515 > URL: https://issues.apache.org/jira/browse/CB-8515 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-windows >Reporter: Murat Sutunc >Priority: Major > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for Windows 8.0, > 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale" > attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863523#comment-15863523 ] ASF GitHub Bot commented on CB-8515: Github user cofetti commented on the issue: https://github.com/apache/cordova-windows/pull/59 This change is still not reflected in documentation in https://cordova.apache.org/docs/en/latest/config_ref/ (defaultlocale is shown as iOS-only) > Support DefaultLanguage selection for Windows > - > > Key: CB-8515 > URL: https://issues.apache.org/jira/browse/CB-8515 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Murat Sutunc > > The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) > supports "defaultlocale" attribute. > Cordova should set the appropriate project file attributes for Windows 8.0, > 8.1, and Windows Phone 8.1 using the W3C widget spec "defaultlocale" > attribute. > In the case widget is missing "defaultlocale" attribute, it should default to > "en-us". -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14330202#comment-14330202 ] ASF subversion and git services commented on CB-8515: - Commit e25bc2a3c67f975ab4bfe16952d6bcb59f35bf31 in cordova-windows's branch refs/heads/master from [~muratsu] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=e25bc2a ] CB-8515 Support DefaultLanguage selection for Windows github close #59 Support DefaultLanguage selection for Windows - Key: CB-8515 URL: https://issues.apache.org/jira/browse/CB-8515 Project: Apache Cordova Issue Type: Improvement Components: Windows Reporter: Murat Sutunc The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) supports defaultlocale attribute. Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale attribute. In the case widget is missing defaultlocale attribute, it should default to en-us. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14330203#comment-14330203 ] ASF GitHub Bot commented on CB-8515: Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/59 Support DefaultLanguage selection for Windows - Key: CB-8515 URL: https://issues.apache.org/jira/browse/CB-8515 Project: Apache Cordova Issue Type: Improvement Components: Windows Reporter: Murat Sutunc The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) supports defaultlocale attribute. Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale attribute. In the case widget is missing defaultlocale attribute, it should default to en-us. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[
https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328745#comment-14328745
]
ASF GitHub Bot commented on CB-8515:
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/59#discussion_r25058822
--- Diff: template/cordova/lib/prepare.js ---
@@ -40,14 +40,37 @@ module.exports.applyPlatformConfig = function () {
return false;
});
+// Apply appxmanifest changes
['package.windows.appxmanifest', 'package.windows80.appxmanifest',
'package.phone.appxmanifest'].forEach(
function(manifestFile) {
updateManifestFile(config, path.join(ROOT, manifestFile));
});
+// Apply jsproj changes
+['CordovaApp.Phone.jsproj', 'CordovaApp.Windows.jsproj',
'CordovaApp.Windows80.jsproj'].forEach(
+function(jsprojFile) {
+updatejsprojFile(config, path.join(ROOT, jsprojFile));
+});
+
copyImages(config);
};
+function updatejsprojFile(config, jsProjFilePath) {
+var defaultLocale = config.defaultLocale();
+
+if (defaultLocale) {
--- End diff --
I think we should remove or set to default DefaultLanguage in case there is
no config.defaultLocale().
Support DefaultLanguage selection for Windows
-
Key: CB-8515
URL: https://issues.apache.org/jira/browse/CB-8515
Project: Apache Cordova
Issue Type: Improvement
Components: Windows
Reporter: Murat Sutunc
The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute)
supports defaultlocale attribute.
Cordova should set the appropriate project file attributes for Windows 8.0,
8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale
attribute.
In the case widget is missing defaultlocale attribute, it should default to
en-us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328893#comment-14328893 ] ASF GitHub Bot commented on CB-8515: Github user muratsu commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75235633 if no locale is not found it uses the current default language which is en-us. Since that is already hardcoded in proj files I'm not re-setting it. removing might have some side effects. Support DefaultLanguage selection for Windows - Key: CB-8515 URL: https://issues.apache.org/jira/browse/CB-8515 Project: Apache Cordova Issue Type: Improvement Components: Windows Reporter: Murat Sutunc The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) supports defaultlocale attribute. Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale attribute. In the case widget is missing defaultlocale attribute, it should default to en-us. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328917#comment-14328917 ] ASF GitHub Bot commented on CB-8515: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75238727 I meant if you changed locale in config.xml and then removed this settings it will continue pointing to the wrong previously used locale, not the default one. Support DefaultLanguage selection for Windows - Key: CB-8515 URL: https://issues.apache.org/jira/browse/CB-8515 Project: Apache Cordova Issue Type: Improvement Components: Windows Reporter: Murat Sutunc The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) supports defaultlocale attribute. Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale attribute. In the case widget is missing defaultlocale attribute, it should default to en-us. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328918#comment-14328918 ] ASF GitHub Bot commented on CB-8515: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75238948 May be just use something like this var defaultLocale = config.defaultLocale() || 'en-us'; Support DefaultLanguage selection for Windows - Key: CB-8515 URL: https://issues.apache.org/jira/browse/CB-8515 Project: Apache Cordova Issue Type: Improvement Components: Windows Reporter: Murat Sutunc The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) supports defaultlocale attribute. Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale attribute. In the case widget is missing defaultlocale attribute, it should default to en-us. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328920#comment-14328920 ] ASF GitHub Bot commented on CB-8515: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75239086 But this is minor, so I'm +1 merging this. Support DefaultLanguage selection for Windows - Key: CB-8515 URL: https://issues.apache.org/jira/browse/CB-8515 Project: Apache Cordova Issue Type: Improvement Components: Windows Reporter: Murat Sutunc The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) supports defaultlocale attribute. Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale attribute. In the case widget is missing defaultlocale attribute, it should default to en-us. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329371#comment-14329371 ] ASF GitHub Bot commented on CB-8515: Github user muratsu commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75298546 I'll fix the default locale to en-US. When a defaultlocale is not present we should set it to en-US. Good catch! Support DefaultLanguage selection for Windows - Key: CB-8515 URL: https://issues.apache.org/jira/browse/CB-8515 Project: Apache Cordova Issue Type: Improvement Components: Windows Reporter: Murat Sutunc The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) supports defaultlocale attribute. Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale attribute. In the case widget is missing defaultlocale attribute, it should default to en-us. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329428#comment-14329428 ] ASF GitHub Bot commented on CB-8515: Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/59#issuecomment-75305927 This looks good! @sgrebnov Can you please help merge this one? It will be good to have this in the next cordova-windows release. Support DefaultLanguage selection for Windows - Key: CB-8515 URL: https://issues.apache.org/jira/browse/CB-8515 Project: Apache Cordova Issue Type: Improvement Components: Windows Reporter: Murat Sutunc The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) supports defaultlocale attribute. Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale attribute. In the case widget is missing defaultlocale attribute, it should default to en-us. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8515) Support DefaultLanguage selection for Windows
[ https://issues.apache.org/jira/browse/CB-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328495#comment-14328495 ] ASF GitHub Bot commented on CB-8515: GitHub user muratsu opened a pull request: https://github.com/apache/cordova-windows/pull/59 CB-8515 Support DefaultLanguage selection for Windows Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale attribute. Related JIRA: https://issues.apache.org/jira/browse/CB-8515 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-8515 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit e0c5093ef621f83adc87db995ab2ce5615183e65 Author: Murat Sutunc mura...@microsoft.com Date: 2015-02-20T02:53:38Z CB-8515 Support DefaultLanguage selection for Windows Support DefaultLanguage selection for Windows - Key: CB-8515 URL: https://issues.apache.org/jira/browse/CB-8515 Project: Apache Cordova Issue Type: Improvement Components: Windows Reporter: Murat Sutunc The widget spec (http://www.w3.org/TR/widgets/#the-defaultlocale-attribute) supports defaultlocale attribute. Cordova should set the appropriate project file attributes for Windows 8.0, 8.1, and Windows Phone 8.1 using the W3C widget spec defaultlocale attribute. In the case widget is missing defaultlocale attribute, it should default to en-us. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
