[jira] [Commented] (DRILL-2650) Cancelled queries json profile shows query end time occurs before fragments end time

2015-09-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745318#comment-14745318
 ] 

ASF GitHub Bot commented on DRILL-2650:
---

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/80


> Cancelled queries json profile shows query end time occurs before fragments 
> end time 
> -
>
> Key: DRILL-2650
> URL: https://issues.apache.org/jira/browse/DRILL-2650
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - HTTP
>Affects Versions: 0.9.0
>Reporter: Krystal
>Assignee: Deneche A. Hakim
> Fix For: 1.2.0
>
> Attachments: DRILL-2650.1.patch.txt
>
>
> I have a query that was successfully cancelled.  The query start and end time 
> is as follows:
> "type": 1,
> "start": 1427839192049,
> "end": 1427839194966,
> This translates to a query duration of about 3 seconds.  However, the 
> duration of the query's fragments are much longer up to more than 6 seconds.  
> Here is an entry for majorFragmentId=0 with a duration of 6.6 seconds:
>  "startTime": 1427839192796,
>  "endTime": 1427839199408,
> 8 out of 11 major fragments have duration greater than the query itself.  To 
> an end user, this is confusing and does not make sense.  We should wait for 
> all of the major fragments to be completely cancelled before updating the the 
> "end" time of the query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-2650) Cancelled queries json profile shows query end time occurs before fragments end time

2015-09-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735795#comment-14735795
 ] 

ASF GitHub Bot commented on DRILL-2650:
---

Github user adeneche commented on the pull request:

https://github.com/apache/drill/pull/80#issuecomment-138727479
  
+1, LGTM

It's important to note this won't fix the running time for failed queries, 
at least not until DRILL-3167 is fixed


> Cancelled queries json profile shows query end time occurs before fragments 
> end time 
> -
>
> Key: DRILL-2650
> URL: https://issues.apache.org/jira/browse/DRILL-2650
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - HTTP
>Affects Versions: 0.9.0
>Reporter: Krystal
>Assignee: Deneche A. Hakim
> Fix For: 1.2.0
>
> Attachments: DRILL-2650.1.patch.txt
>
>
> I have a query that was successfully cancelled.  The query start and end time 
> is as follows:
> "type": 1,
> "start": 1427839192049,
> "end": 1427839194966,
> This translates to a query duration of about 3 seconds.  However, the 
> duration of the query's fragments are much longer up to more than 6 seconds.  
> Here is an entry for majorFragmentId=0 with a duration of 6.6 seconds:
>  "startTime": 1427839192796,
>  "endTime": 1427839199408,
> 8 out of 11 major fragments have duration greater than the query itself.  To 
> an end user, this is confusing and does not make sense.  We should wait for 
> all of the major fragments to be completely cancelled before updating the the 
> "end" time of the query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-2650) Cancelled queries json profile shows query end time occurs before fragments end time

2015-07-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637999#comment-14637999
 ] 

ASF GitHub Bot commented on DRILL-2650:
---

Github user sudheeshkatkam commented on the pull request:

https://github.com/apache/drill/pull/80#issuecomment-123918414
  
Downgraded to .debug()


 Cancelled queries json profile shows query end time occurs before fragments 
 end time 
 -

 Key: DRILL-2650
 URL: https://issues.apache.org/jira/browse/DRILL-2650
 Project: Apache Drill
  Issue Type: Bug
  Components: Client - HTTP
Affects Versions: 0.9.0
Reporter: Krystal
Assignee: Jacques Nadeau
 Fix For: 1.2.0

 Attachments: DRILL-2650.1.patch.txt


 I have a query that was successfully cancelled.  The query start and end time 
 is as follows:
 type: 1,
 start: 1427839192049,
 end: 1427839194966,
 This translates to a query duration of about 3 seconds.  However, the 
 duration of the query's fragments are much longer up to more than 6 seconds.  
 Here is an entry for majorFragmentId=0 with a duration of 6.6 seconds:
  startTime: 1427839192796,
  endTime: 1427839199408,
 8 out of 11 major fragments have duration greater than the query itself.  To 
 an end user, this is confusing and does not make sense.  We should wait for 
 all of the major fragments to be completely cancelled before updating the the 
 end time of the query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-2650) Cancelled queries json profile shows query end time occurs before fragments end time

2015-07-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623108#comment-14623108
 ] 

ASF GitHub Bot commented on DRILL-2650:
---

Github user cwestin commented on a diff in the pull request:

https://github.com/apache/drill/pull/80#discussion_r34406507
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -695,7 +697,10 @@ public void close() {
   Preconditions.checkState(!isClosed);
   Preconditions.checkState(resultState != null);
 
-  logger.info(foreman cleaning up.);
+  // to track how long the query takes
+  queryManager.markEndTime();
+
+  logger.info(queryIdString + : cleaning up.);
--- End diff --

.info() seems like it will generate a lot of noise here, should it be 
.debug()?


 Cancelled queries json profile shows query end time occurs before fragments 
 end time 
 -

 Key: DRILL-2650
 URL: https://issues.apache.org/jira/browse/DRILL-2650
 Project: Apache Drill
  Issue Type: Bug
  Components: Client - HTTP
Affects Versions: 0.9.0
Reporter: Krystal
Assignee: Jacques Nadeau
 Fix For: 1.2.0

 Attachments: DRILL-2650.1.patch.txt


 I have a query that was successfully cancelled.  The query start and end time 
 is as follows:
 type: 1,
 start: 1427839192049,
 end: 1427839194966,
 This translates to a query duration of about 3 seconds.  However, the 
 duration of the query's fragments are much longer up to more than 6 seconds.  
 Here is an entry for majorFragmentId=0 with a duration of 6.6 seconds:
  startTime: 1427839192796,
  endTime: 1427839199408,
 8 out of 11 major fragments have duration greater than the query itself.  To 
 an end user, this is confusing and does not make sense.  We should wait for 
 all of the major fragments to be completely cancelled before updating the the 
 end time of the query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-2650) Cancelled queries json profile shows query end time occurs before fragments end time

2015-07-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623109#comment-14623109
 ] 

ASF GitHub Bot commented on DRILL-2650:
---

Github user cwestin commented on a diff in the pull request:

https://github.com/apache/drill/pull/80#discussion_r34406523
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -789,7 +794,7 @@ protected void processEvent(final StateEvent event) {
   final Exception exception = event.exception;
 
   // TODO Auto-generated method stub
-  logger.info(State change requested.  {} -- {}, state, newState,
+  logger.info(queryIdString + : State change requested {} -- {}, 
state, newState,
--- End diff --

.info() - .debug()?


 Cancelled queries json profile shows query end time occurs before fragments 
 end time 
 -

 Key: DRILL-2650
 URL: https://issues.apache.org/jira/browse/DRILL-2650
 Project: Apache Drill
  Issue Type: Bug
  Components: Client - HTTP
Affects Versions: 0.9.0
Reporter: Krystal
Assignee: Jacques Nadeau
 Fix For: 1.2.0

 Attachments: DRILL-2650.1.patch.txt


 I have a query that was successfully cancelled.  The query start and end time 
 is as follows:
 type: 1,
 start: 1427839192049,
 end: 1427839194966,
 This translates to a query duration of about 3 seconds.  However, the 
 duration of the query's fragments are much longer up to more than 6 seconds.  
 Here is an entry for majorFragmentId=0 with a duration of 6.6 seconds:
  startTime: 1427839192796,
  endTime: 1427839199408,
 8 out of 11 major fragments have duration greater than the query itself.  To 
 an end user, this is confusing and does not make sense.  We should wait for 
 all of the major fragments to be completely cancelled before updating the the 
 end time of the query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-2650) Cancelled queries json profile shows query end time occurs before fragments end time

2015-07-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623114#comment-14623114
 ] 

ASF GitHub Bot commented on DRILL-2650:
---

Github user cwestin commented on the pull request:

https://github.com/apache/drill/pull/80#issuecomment-120554910
  
Do we want to stick with .info() for these messages instead of .debug()? 
Asking because I'm not sure, but it seems like noise.

Otherwise, non-binding ship it.


 Cancelled queries json profile shows query end time occurs before fragments 
 end time 
 -

 Key: DRILL-2650
 URL: https://issues.apache.org/jira/browse/DRILL-2650
 Project: Apache Drill
  Issue Type: Bug
  Components: Client - HTTP
Affects Versions: 0.9.0
Reporter: Krystal
Assignee: Jacques Nadeau
 Fix For: 1.2.0

 Attachments: DRILL-2650.1.patch.txt


 I have a query that was successfully cancelled.  The query start and end time 
 is as follows:
 type: 1,
 start: 1427839192049,
 end: 1427839194966,
 This translates to a query duration of about 3 seconds.  However, the 
 duration of the query's fragments are much longer up to more than 6 seconds.  
 Here is an entry for majorFragmentId=0 with a duration of 6.6 seconds:
  startTime: 1427839192796,
  endTime: 1427839199408,
 8 out of 11 major fragments have duration greater than the query itself.  To 
 an end user, this is confusing and does not make sense.  We should wait for 
 all of the major fragments to be completely cancelled before updating the the 
 end time of the query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DRILL-2650) Cancelled queries json profile shows query end time occurs before fragments end time

2015-07-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618940#comment-14618940
 ] 

ASF GitHub Bot commented on DRILL-2650:
---

GitHub user sudheeshkatkam opened a pull request:

https://github.com/apache/drill/pull/80

DRILL-2650: Mark query end time when closing the Foreman

@jacques-n @cwestin please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sudheeshkatkam/drill DRILL-2650

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #80


commit 1ad9c5ad8d70947f029132ff1abfd03d02f464c0
Author: Sudheesh Katkam skat...@maprtech.com
Date:   2015-07-07T21:08:09Z

DRILL-2650: Mark query end time when closing the Foreman




 Cancelled queries json profile shows query end time occurs before fragments 
 end time 
 -

 Key: DRILL-2650
 URL: https://issues.apache.org/jira/browse/DRILL-2650
 Project: Apache Drill
  Issue Type: Bug
  Components: Client - HTTP
Affects Versions: 0.9.0
Reporter: Krystal
Assignee: Sudheesh Katkam
 Fix For: 1.2.0

 Attachments: DRILL-2650.1.patch.txt


 I have a query that was successfully cancelled.  The query start and end time 
 is as follows:
 type: 1,
 start: 1427839192049,
 end: 1427839194966,
 This translates to a query duration of about 3 seconds.  However, the 
 duration of the query's fragments are much longer up to more than 6 seconds.  
 Here is an entry for majorFragmentId=0 with a duration of 6.6 seconds:
  startTime: 1427839192796,
  endTime: 1427839199408,
 8 out of 11 major fragments have duration greater than the query itself.  To 
 an end user, this is confusing and does not make sense.  We should wait for 
 all of the major fragments to be completely cancelled before updating the the 
 end time of the query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)