[
https://issues.apache.org/jira/browse/FLINK-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534012#comment-14534012
]
ASF GitHub Bot commented on FLINK-1980:
---
Github user rmetzger commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534044#comment-14534044
]
ASF GitHub Bot commented on FLINK-1807:
---
Github user thvasilo commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534047#comment-14534047
]
ASF GitHub Bot commented on FLINK-1807:
---
Github user thvasilo commented on a diff in
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29922360
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29922432
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534183#comment-14534183
]
Aljoscha Krettek commented on FLINK-1991:
-
But conversion to a tuple is only
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/658#discussion_r29920729
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/InputStreamFSInputWrapper.java
---
@@ -0,0 +1,60 @@
+package
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/658#issuecomment-100129770
Thank you for this pull request. I'll review it now.
The first thing I saw is that the build has failed:
```
[INFO]
[
https://issues.apache.org/jira/browse/FLINK-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534011#comment-14534011
]
ASF GitHub Bot commented on FLINK-1980:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/658#issuecomment-100132056
The change looks good, its not completely consistent with our coding
guidelines. But a few runs of mvn install -DskipTests will resolve this ;)
(also, the
[
https://issues.apache.org/jira/browse/FLINK-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534030#comment-14534030
]
ASF GitHub Bot commented on FLINK-1980:
---
Github user rmetzger commented on the pull
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/656#issuecomment-100159626
Thank you for the contribution Johaness. For the logistic loss could you
change the implementation to match the approximate version that sklearn (and
other libraries)
[
https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534138#comment-14534138
]
ASF GitHub Bot commented on FLINK-1979:
---
Github user thvasilo commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek reassigned FLINK-1990:
---
Assignee: Aljoscha Krettek
Uppercase AS keyword not allowed in select expression
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534040#comment-14534040
]
ASF GitHub Bot commented on FLINK-1807:
---
Github user thvasilo commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534068#comment-14534068
]
ASF GitHub Bot commented on FLINK-1977:
---
Github user aljoscha commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534064#comment-14534064
]
ASF GitHub Bot commented on FLINK-1807:
---
Github user thvasilo commented on a diff in
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29922815
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/658#discussion_r29920868
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -18,24 +18,20 @@
package
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/658#discussion_r29920838
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/InputStreamFSInputWrapper.java
---
@@ -0,0 +1,60 @@
+package
[
https://issues.apache.org/jira/browse/FLINK-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534019#comment-14534019
]
ASF GitHub Bot commented on FLINK-1980:
---
Github user rmetzger commented on a diff in
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29922199
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/659#issuecomment-100144884
I think this would not solve our problems. I will start a discussion thread
on the dev list.
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/FLINK-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-1718.
Add sparse vector and sparse matrix types to machine learning library
[
https://issues.apache.org/jira/browse/FLINK-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534348#comment-14534348
]
ASF GitHub Bot commented on FLINK-1974:
---
Github user fhueske commented on the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29927671
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,200 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/613#discussion_r29927830
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -0,0 +1,200 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/613#issuecomment-100173917
Looks good. Two minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534216#comment-14534216
]
ASF GitHub Bot commented on FLINK-1807:
---
Github user tillrohrmann commented on the
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/613#issuecomment-100175431
Want me to do the rebase and squashing or will you take care of it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534232#comment-14534232
]
ASF GitHub Bot commented on FLINK-1807:
---
Github user tillrohrmann commented on the
Till Rohrmann created FLINK-1993:
Summary: Replace MultipleLinearRegression's custom SGD with
optimization framework's SGD
Key: FLINK-1993
URL: https://issues.apache.org/jira/browse/FLINK-1993
[
https://issues.apache.org/jira/browse/FLINK-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-1696.
Add multiple linear regression to ML library
[
https://issues.apache.org/jira/browse/FLINK-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-1695.
Create machine learning library
---
Key: FLINK-1695
[
https://issues.apache.org/jira/browse/FLINK-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534281#comment-14534281
]
Fabian Hueske commented on FLINK-1991:
--
I know, but `Pojo` or `Row` are not good
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534211#comment-14534211
]
ASF GitHub Bot commented on FLINK-1807:
---
Github user tillrohrmann commented on a
[
https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534219#comment-14534219
]
Till Rohrmann commented on FLINK-1979:
--
Sounds like a good idea to save some
[
https://issues.apache.org/jira/browse/FLINK-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-1698.
Add polynomial base feature mapper to ML library
[
https://issues.apache.org/jira/browse/FLINK-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-1716.
Add CoCoA algorithm to flink-ml
---
Key: FLINK-1716
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534215#comment-14534215
]
ASF GitHub Bot commented on FLINK-1807:
---
Github user tillrohrmann commented on a
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534227#comment-14534227
]
ASF GitHub Bot commented on FLINK-1807:
---
Github user thvasilo commented on the pull
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/613#issuecomment-100175119
Looks good :-) Thanks for you great work @thvasilo. Will merge it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Till Rohrmann created FLINK-1992:
Summary: Add convergence criterion to SGD optimizer
Key: FLINK-1992
URL: https://issues.apache.org/jira/browse/FLINK-1992
Project: Flink
Issue Type:
Fabian Hueske created FLINK-1996:
Summary: Add output methods to Table API
Key: FLINK-1996
URL: https://issues.apache.org/jira/browse/FLINK-1996
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534320#comment-14534320
]
ASF GitHub Bot commented on FLINK-1151:
---
Github user fhueske closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-1151:
-
Assignee: (was: Fabian Hueske)
CollectionDataSource does not provide statistics
[
https://issues.apache.org/jira/browse/FLINK-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534319#comment-14534319
]
ASF GitHub Bot commented on FLINK-1151:
---
Github user fhueske commented on the pull
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/652#issuecomment-100196560
Thanks for the update, looks good!
Will merge that if nobody objects.
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/FLINK-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534600#comment-14534600
]
ASF GitHub Bot commented on FLINK-1980:
---
Github user rmetzger commented on the pull
Github user sekruse commented on the pull request:
https://github.com/apache/flink/pull/658#issuecomment-100240346
Alright, I incorporated all the feedback. The build seems to be passing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/FLINK-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-1997.
---
Resolution: Fixed
Fixed in
[
https://issues.apache.org/jira/browse/FLINK-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-1998.
---
Resolution: Fixed
Fixed in
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/658#issuecomment-100245298
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-1995.
---
Resolution: Fixed
Resolved.
The Flink project is categorized under Incubator in the Apache
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/663
[FLINK-1976][gelly] Added ForwardedFields Annotations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andralungu/flink fwdFields
[
https://issues.apache.org/jira/browse/FLINK-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535531#comment-14535531
]
ASF GitHub Bot commented on FLINK-1976:
---
GitHub user andralungu opened a pull
[
https://issues.apache.org/jira/browse/FLINK-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andra Lungu reassigned FLINK-1976:
--
Assignee: Andra Lungu
Add ForwardedFields* hints for the optimizer
[
https://issues.apache.org/jira/browse/FLINK-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535541#comment-14535541
]
ASF GitHub Bot commented on FLINK-1976:
---
Github user hsaputra commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535573#comment-14535573
]
ASF GitHub Bot commented on FLINK-1976:
---
Github user andralungu commented on the
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/663#issuecomment-100372745
Sure @hsaputra ,
I thought the JIRA issue was descriptive enough. We were missing
ForwardedFields* annotations for the majority of Gelly classes in
[
https://issues.apache.org/jira/browse/FLINK-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek reassigned FLINK-1998:
---
Assignee: Aljoscha Krettek
Equality filter predicate not correctly evaluated by
[
https://issues.apache.org/jira/browse/FLINK-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534451#comment-14534451
]
Fabian Hueske commented on FLINK-1996:
--
Would it be more than having the interfaces
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/473#discussion_r29937747
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/GenericTypeInfo.java
---
@@ -70,9 +69,6 @@ public boolean isKeyType() {
[
https://issues.apache.org/jira/browse/FLINK-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534457#comment-14534457
]
ASF GitHub Bot commented on FLINK-1676:
---
Github user rmetzger commented on a diff in
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/473#issuecomment-100226540
I rebased to the current master and addressed the concerns.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534458#comment-14534458
]
ASF GitHub Bot commented on FLINK-1676:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534461#comment-14534461
]
Aljoscha Krettek commented on FLINK-1998:
-
Found the problem. The generated code
[
https://issues.apache.org/jira/browse/FLINK-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534464#comment-14534464
]
Aljoscha Krettek commented on FLINK-1996:
-
In scala this works already, using
[
https://issues.apache.org/jira/browse/FLINK-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534430#comment-14534430
]
ASF GitHub Bot commented on FLINK-1792:
---
Github user tillrohrmann commented on the
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-100220928
LGTM :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-100221773
Great. Once this is green, I'll push it to master:
https://travis-ci.org/rmetzger/flink/builds/61757934
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/FLINK-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534434#comment-14534434
]
ASF GitHub Bot commented on FLINK-1792:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-1995:
--
Issue Type: Task (was: Bug)
The Flink project is categorized under Incubator in the Apache
[
https://issues.apache.org/jira/browse/FLINK-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534383#comment-14534383
]
Robert Metzger commented on FLINK-1995:
---
Will do
The Flink project is categorized
[
https://issues.apache.org/jira/browse/FLINK-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger reassigned FLINK-1995:
-
Assignee: Robert Metzger
The Flink project is categorized under Incubator in the Apache
[
https://issues.apache.org/jira/browse/FLINK-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534438#comment-14534438
]
Aljoscha Krettek commented on FLINK-1996:
-
This would require duplicating all the
[
https://issues.apache.org/jira/browse/FLINK-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534443#comment-14534443
]
ASF GitHub Bot commented on FLINK-1676:
---
Github user rmetzger commented on a diff in
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/473#discussion_r29936564
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -310,6 +316,18 @@ public int getFieldIndex(String fieldName)
[
https://issues.apache.org/jira/browse/FLINK-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534408#comment-14534408
]
Fabian Hueske commented on FLINK-1997:
--
With some help from [~aljoscha] I found out
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534411#comment-14534411
]
ASF GitHub Bot commented on FLINK-1807:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/613
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
81 matches
Mail list logo
