[
https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518160#comment-15518160
]
ASF GitHub Bot commented on FLINK-2055:
---
Github user delding commented on the issue:
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Thanks for very detailed and helpful comments, let me work on it :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2540
[FLINK-4606] [Client] Integrate the new ResourceManager with the existed
FlinkResourceManager
This pr aims to integrate the new ResourceManager with the existed
FlinkResourceManager, the main
[
https://issues.apache.org/jira/browse/FLINK-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515702#comment-15515702
]
Jark Wu commented on FLINK-4605:
Hi [~twalthr], could you explain this issue a little more detail ? What
[
https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515537#comment-15515537
]
ASF GitHub Bot commented on FLINK-4624:
---
Github user s1ck commented on the issue:
Github user s1ck commented on the issue:
https://github.com/apache/flink/pull/2527
> I'm not following why specifying the TypeInformation is now required with
the change to using Either. Is the type system failing to handle this properly?
You are right, I was experimenting with
GitHub user apivovarov opened a pull request:
https://github.com/apache/flink/pull/2539
[FLINK-4668] Fix positive random int generation
https://issues.apache.org/jira/browse/FLINK-4668
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/FLINK-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515563#comment-15515563
]
ASF GitHub Bot commented on FLINK-4668:
---
GitHub user apivovarov opened a pull request:
Github user s1ck commented on a diff in the pull request:
https://github.com/apache/flink/pull/2527#discussion_r80186110
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/Summarization.java
---
@@ -226,11 +247,15 @@ public void
Github user s1ck commented on the issue:
https://github.com/apache/flink/pull/2527
> I'd also like to add a ToNullValue translator that would accept any type
and convert to NullValue.
I don't know if I get this right. Do you mean an additional test case with
`NullValue` as
[
https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515541#comment-15515541
]
ASF GitHub Bot commented on FLINK-4624:
---
Github user s1ck commented on the issue:
Github user s1ck commented on the issue:
https://github.com/apache/flink/pull/2527
> Would a graph translator simplify the conversion from Long to String? You
can do graph.run(new TranslateEdgeValues<...>(new StringToLong()) and write a
simple public class StringToLong implements
[
https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515524#comment-15515524
]
ASF GitHub Bot commented on FLINK-4624:
---
Github user s1ck commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515544#comment-15515544
]
ASF GitHub Bot commented on FLINK-4624:
---
Github user s1ck commented on the issue:
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2482
Added a shortcut (rocksdb) for configuring RocksDB state backend and added
the dedicated option config `state.backend.rocksdb.checkpointdir`.
---
If your project is set up for it, you can reply to
[
https://issues.apache.org/jira/browse/FLINK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515569#comment-15515569
]
ASF GitHub Bot commented on FLINK-4579:
---
Github user wuchong commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515685#comment-15515685
]
ASF GitHub Bot commented on FLINK-4606:
---
GitHub user beyond1920 opened a pull request:
Vijay Srinivasaraghavan created FLINK-4667:
--
Summary: Yarn Session CLI not listening on correct ZK namespace
when HA is enabled to use ZooKeeper backend
Key: FLINK-4667
URL:
Alexander Pivovarov created FLINK-4668:
--
Summary: Fix positive random int generation
Key: FLINK-4668
URL: https://issues.apache.org/jira/browse/FLINK-4668
Project: Flink
Issue Type: Bug
zhangjing created FLINK-4670:
Summary: Add watch mechanism on current RPC framework
Key: FLINK-4670
URL: https://issues.apache.org/jira/browse/FLINK-4670
Project: Flink
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/FLINK-4664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516062#comment-15516062
]
ASF GitHub Bot commented on FLINK-4664:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2536
Code looks good. Feel free to merge at your discretion ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516197#comment-15516197
]
ASF GitHub Bot commented on FLINK-2055:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516216#comment-15516216
]
ASF GitHub Bot commented on FLINK-4606:
---
Github user tillrohrmann commented on the issue:
shijinkui created FLINK-4669:
Summary: scala api createLocalEnvironment() function add default
Configuration parameter
Key: FLINK-4669
URL: https://issues.apache.org/jira/browse/FLINK-4669
Project: Flink
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2538
+1
Will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2517
alright, I'll sketch some code:
MetricRegistry:
```
List reporters = ...
List groups = ...
List delimiter = ...
char getDelimiter(int reporterIndex) {
return
[
https://issues.apache.org/jira/browse/FLINK-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516074#comment-15516074
]
ASF GitHub Bot commented on FLINK-4666:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2537
Thanks for that cleanup. I like it have the code be conscious about object
creation and boxing.
Merging this...
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/FLINK-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516071#comment-15516071
]
ASF GitHub Bot commented on FLINK-4665:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2539
I think this is not necessary. `Random.nextInt(int)` returns only positive
values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516082#comment-15516082
]
ASF GitHub Bot commented on FLINK-4668:
---
Github user StephanEwen commented on the issue:
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2543
[FLINK-4606] [cluster management] Add watch mechanism on current RPC
framework
This pr aims at adding watch mechanism on current RPC framework, so RPC
gateway could be watched to make sure the
[
https://issues.apache.org/jira/browse/FLINK-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516187#comment-15516187
]
ASF GitHub Bot commented on FLINK-4606:
---
GitHub user beyond1920 opened a pull request:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2332
Don't you loose any guarantees regarding order of mutations the moment you
use asynchronous updates anyway?
The WriteAheadSink should only be used if you want to deal with
non-deterministic
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2543
The linked JIRA issue seems to be wrong.
I'm not completely sure whether we want to add this functionality to the
`RpcService` or not. At the moment it is easy to implement because we
[
https://issues.apache.org/jira/browse/FLINK-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516017#comment-15516017
]
ASF GitHub Bot commented on FLINK-4379:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2512
+1, I like the changes.
Concerning (7) - I think creating the state backend once sounds good. It is
more in line with the keyed state backend.
Concerning Aljoscha's comments:
[
https://issues.apache.org/jira/browse/FLINK-4663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516058#comment-15516058
]
ASF GitHub Bot commented on FLINK-4663:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2534
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516075#comment-15516075
]
ASF GitHub Bot commented on FLINK-4564:
---
Github user zentol commented on the issue:
GitHub user gaborhermann opened a pull request:
https://github.com/apache/flink/pull/2542
[FLINK-4613] Extend ALS to handle implicit feedback datasets
This extension of the ALS algorithm changes some parts of the code if
`implicitPrefs` flag is set to true. Mainly the local parts
[
https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516142#comment-15516142
]
ASF GitHub Bot commented on FLINK-4613:
---
GitHub user gaborhermann opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515828#comment-15515828
]
Fabian Hueske commented on FLINK-2170:
--
FLINK-3848 and FLINK-3849 have not been addressed yet.
I
[
https://issues.apache.org/jira/browse/FLINK-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515830#comment-15515830
]
Jark Wu commented on FLINK-4621:
I think the problem is how to convert BigDecimal into relative java
[
https://issues.apache.org/jira/browse/FLINK-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-4315:
-
Assignee: Evgeny Kincharov
> Remove Hadoop Dependency from flink-java
>
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2523
Looks pretty straight forward to me.
+1
Will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516084#comment-15516084
]
Stephan Ewen commented on FLINK-4218:
-
Okay, I will take a stab at this...
> Sporadic
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2332
Thanks for looking into the Cassandra connector. Maybe @zentol (who
implemented the Cassandra connector) can comment how an HBase sink can be made
fault-tolerant and what code could be reused for
[
https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516117#comment-15516117
]
ASF GitHub Bot commented on FLINK-2055:
---
Github user fhueske commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515997#comment-15515997
]
Stephan Ewen commented on FLINK-4660:
-
It should have been fixed as of 2 days ago:
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2541
[FLINK-4669] scala api createLocalEnvironment() function add default
Configuration parameter
1. add Configuration as createLocalEnvironment second default paramter
2. fix the mistake scaladoc
[
https://issues.apache.org/jira/browse/FLINK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515995#comment-15515995
]
ASF GitHub Bot commented on FLINK-4669:
---
GitHub user shijinkui opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515992#comment-15515992
]
Stephan Ewen commented on FLINK-4596:
-
Adding [~till.rohrmann] to this - he created the restart
[
https://issues.apache.org/jira/browse/FLINK-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516052#comment-15516052
]
ASF GitHub Bot commented on FLINK-4556:
---
Github user StephanEwen commented on the issue:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2484#discussion_r80232630
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
---
[
https://issues.apache.org/jira/browse/FLINK-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-4666.
---
> Make constants to be final in ParameterTool
> ---
>
>
[
https://issues.apache.org/jira/browse/FLINK-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-4666.
-
Resolution: Fixed
Fix Version/s: 1.2.0
Fixed via 568845a3cfea1f6fe71a99f1f546cbd4d947fb33
[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516435#comment-15516435
]
ASF GitHub Bot commented on FLINK-4564:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516424#comment-15516424
]
ASF GitHub Bot commented on FLINK-4564:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516430#comment-15516430
]
ASF GitHub Bot commented on FLINK-4564:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516427#comment-15516427
]
ASF GitHub Bot commented on FLINK-4564:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516432#comment-15516432
]
ASF GitHub Bot commented on FLINK-4564:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80241086
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -168,21 +168,40 @@ public String
[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516433#comment-15516433
]
ASF GitHub Bot commented on FLINK-4564:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516429#comment-15516429
]
ASF GitHub Bot commented on FLINK-4564:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516438#comment-15516438
]
ASF GitHub Bot commented on FLINK-4564:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516428#comment-15516428
]
ASF GitHub Bot commented on FLINK-4564:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80240197
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -99,10 +99,17 @@ public MetricRegistry(Configuration
[
https://issues.apache.org/jira/browse/FLINK-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516448#comment-15516448
]
ASF GitHub Bot commented on FLINK-4549:
---
Github user fhueske commented on a diff in the pull
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2536
I added a second commit to move the translators into their own subpackage,
as well as additional tests.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2500#discussion_r80237743
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -545,7 +545,9 @@ class CodeGenerator(
[
https://issues.apache.org/jira/browse/FLINK-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516449#comment-15516449
]
ASF GitHub Bot commented on FLINK-4549:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516450#comment-15516450
]
ASF GitHub Bot commented on FLINK-4549:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516445#comment-15516445
]
ASF GitHub Bot commented on FLINK-4218:
---
Github user StephanEwen commented on the issue:
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2500#discussion_r80243251
--- Diff: docs/dev/table_api.md ---
@@ -2442,6 +3141,18 @@ object TimestampModifier extends ScalarFunction {
+### Limitations
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2500#discussion_r80238320
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -657,13 +659,17 @@ class CodeGenerator(
[
https://issues.apache.org/jira/browse/FLINK-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516530#comment-15516530
]
刘喆 commented on FLINK-4632:
---
It is (2).
I make a new idle hadoop yarn cluster, and use the source from github
[
https://issues.apache.org/jira/browse/FLINK-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516270#comment-15516270
]
ASF GitHub Bot commented on FLINK-4177:
---
Github user StephanEwen commented on a diff in the pull
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2484#discussion_r79462622
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2484#discussion_r79463411
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2543
Hi, till. Thanks for your review.
First sorry to bind to the wrong jira link, already correct it.
About heartbeatManager, i thought we could separate HeartbeatManager into
two part, each
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2484#discussion_r79462214
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
[
https://issues.apache.org/jira/browse/FLINK-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516273#comment-15516273
]
ASF GitHub Bot commented on FLINK-4670:
---
Github user beyond1920 commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516272#comment-15516272
]
ASF GitHub Bot commented on FLINK-4177:
---
Github user StephanEwen commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516301#comment-15516301
]
ASF GitHub Bot commented on FLINK-4177:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516321#comment-15516321
]
ASF GitHub Bot commented on FLINK-4177:
---
Github user StephanEwen commented on a diff in the pull
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2532
Good work. ð
I merged this, so could you please close the two PRs and the relevant
issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80239606
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -99,10 +99,17 @@ public MetricRegistry(Configuration
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80239024
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/UnregisteredMetricsGroup.java
---
@@ -114,4 +114,9 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80239440
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -72,14 +74,12 @@ public MetricRegistry(Configuration
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80238884
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -168,21 +168,40 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80241027
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -168,21 +168,40 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80239515
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -99,10 +99,17 @@ public MetricRegistry(Configuration
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80240342
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -163,7 +170,16 @@ public void startQueryService(ActorSystem
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80241072
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -168,21 +168,40 @@ public String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80240685
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -219,9 +235,19 @@ public ScopeFormats getScopeFormats() {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80240626
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -219,9 +235,19 @@ public ScopeFormats getScopeFormats() {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80240523
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -219,9 +235,19 @@ public ScopeFormats getScopeFormats() {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80240221
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -163,7 +170,16 @@ public void startQueryService(ActorSystem
1 - 100 of 225 matches
Mail list logo
