[jira] [Assigned] (FLINK-5943) Unprotected access to haServices in YarnFlinkApplicationMasterRunner#shutdown()

2017-04-17 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang reassigned FLINK-5943: --- Assignee: mingleizhang > Unprotected access to haServices in > YarnFlinkApplicationMasterRun

[jira] [Commented] (FLINK-5943) Unprotected access to haServices in YarnFlinkApplicationMasterRunner#shutdown()

2017-04-17 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970759#comment-15970759 ] mingleizhang commented on FLINK-5943: - [~tedyu] Hi, Ted, How do you think of this ? I

[jira] [Created] (FLINK-6313) Some words was spelled wrong and incorrect LOG.error without print

2017-04-17 Thread mingleizhang (JIRA)
mingleizhang created FLINK-6313: --- Summary: Some words was spelled wrong and incorrect LOG.error without print Key: FLINK-6313 URL: https://issues.apache.org/jira/browse/FLINK-6313 Project: Flink

[GitHub] flink pull request #3728: [FLINK-6313] [flink-runtime] Fix Some words was sp...

2017-04-17 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/3728 [FLINK-6313] [flink-runtime] Fix Some words was spelled wrong and inc… …orrect LOG.error without print. Thanks for contributing to Apache Flink. Before you open your pull request,

[jira] [Commented] (FLINK-6313) Some words was spelled wrong and incorrect LOG.error without print

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970818#comment-15970818 ] ASF GitHub Bot commented on FLINK-6313: --- GitHub user zhangminglei opened a pull requ

[GitHub] flink issue #3697: [FLINK-6257][table]Optimize test cases

2017-04-17 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3697 @zentol Thank you for the reminder. And I added some change messages. Thanks, SunJincheng --- If your project is set up for it, you can reply to this email and have your reply appear o

[jira] [Commented] (FLINK-6257) Post-pass OVER windows

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970882#comment-15970882 ] ASF GitHub Bot commented on FLINK-6257: --- Github user sunjincheng121 commented on the

[jira] [Commented] (FLINK-1960) Add comments and docs for withForwardedFields and related operators

2017-04-17 Thread hzhuangzhenxi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970928#comment-15970928 ] hzhuangzhenxi commented on FLINK-1960: -- HI, I would like to work on this issue.

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @tzulitai Hi, Could you please review my code ? I am appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970959#comment-15970959 ] ASF GitHub Bot commented on FLINK-6130: --- Github user zhangminglei commented on the i

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970972#comment-15970972 ] ASF GitHub Bot commented on FLINK-6130: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #3726: [FLINK-6130] [yarn] Fix Consider calling resourceM...

2017-04-17 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3726#discussion_r111730519 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkApplicationMasterRunner.java --- @@ -158,14 +160,16 @@ protected int runApplicationMaster

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-17 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3726 I don't think the timeout was related. We'll see from this Travis run :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970973#comment-15970973 ] ASF GitHub Bot commented on FLINK-6130: --- Github user tzulitai commented on the issue

[GitHub] flink pull request #3726: [FLINK-6130] [yarn] Fix Consider calling resourceM...

2017-04-17 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/3726#discussion_r111731104 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkApplicationMasterRunner.java --- @@ -158,14 +160,16 @@ protected int runApplicationMa

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970975#comment-15970975 ] ASF GitHub Bot commented on FLINK-6130: --- Github user zhangminglei commented on a dif

[GitHub] flink pull request #3726: [FLINK-6130] [yarn] Fix Consider calling resourceM...

2017-04-17 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3726#discussion_r111731219 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkApplicationMasterRunner.java --- @@ -158,14 +160,16 @@ protected int runApplicationMaster

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970977#comment-15970977 ] ASF GitHub Bot commented on FLINK-6130: --- Github user tzulitai commented on a diff in

[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...

2017-04-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 Travis sucks some time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970983#comment-15970983 ] ASF GitHub Bot commented on FLINK-6130: --- Github user zhangminglei commented on the i

[GitHub] flink pull request #3726: [FLINK-6130] [yarn] Fix Consider calling resourceM...

2017-04-17 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/3726#discussion_r111732371 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkApplicationMasterRunner.java --- @@ -158,14 +160,16 @@ protected int runApplicationMa

[jira] [Commented] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970988#comment-15970988 ] ASF GitHub Bot commented on FLINK-6130: --- Github user zhangminglei commented on a dif

[jira] [Commented] (FLINK-5943) Unprotected access to haServices in YarnFlinkApplicationMasterRunner#shutdown()

2017-04-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971074#comment-15971074 ] Ted Yu commented on FLINK-5943: --- lgtm > Unprotected access to haServices in > YarnFlinkApp

[jira] [Created] (FLINK-6314) Allow setting mapper options

2017-04-17 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-6314: --- Summary: Allow setting mapper options Key: FLINK-6314 URL: https://issues.apache.org/jira/browse/FLINK-6314 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-6306) Sink for eventually consistent file systems

2017-04-17 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-6306: Description: Currently Flink provides the BucketingSink as an exactly once method for writing out to

[jira] [Updated] (FLINK-6306) Sink for eventually consistent file systems

2017-04-17 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-6306: Description: Currently Flink provides the BucketingSink as an exactly once method for writing out to

[jira] [Created] (FLINK-6315) Notify on checkpoint timeout

2017-04-17 Thread Seth Wiesman (JIRA)
Seth Wiesman created FLINK-6315: --- Summary: Notify on checkpoint timeout Key: FLINK-6315 URL: https://issues.apache.org/jira/browse/FLINK-6315 Project: Flink Issue Type: New Feature C

[jira] [Commented] (FLINK-5550) NotFoundException: Could not find job with id

2017-04-17 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971389#comment-15971389 ] Neelesh Srinivas Salian commented on FLINK-5550: Hi [~jeffreyji666], is th

[jira] [Commented] (FLINK-5506) Java 8 - CommunityDetection.java:158 - java.lang.NullPointerException

2017-04-17 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971390#comment-15971390 ] Neelesh Srinivas Salian commented on FLINK-5506: Hi, [~mcoimbra] is this s

[jira] [Updated] (FLINK-6306) Sink for eventually consistent file systems

2017-04-17 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-6306: Attachment: eventually-consistent-sink > Sink for eventually consistent file systems > -

[jira] [Commented] (FLINK-6306) Sink for eventually consistent file systems

2017-04-17 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971397#comment-15971397 ] Seth Wiesman commented on FLINK-6306: - The idea is that data is buffered on local disk

[jira] [Commented] (FLINK-4831) Implement a log4j metric reporter

2017-04-17 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971400#comment-15971400 ] Neelesh Srinivas Salian commented on FLINK-4831: Shall I work on this if n

[GitHub] flink pull request #3729: [FLINK-6315] Notify on checkpoint timeout

2017-04-17 Thread sjwiesman
GitHub user sjwiesman opened a pull request: https://github.com/apache/flink/pull/3729 [FLINK-6315] Notify on checkpoint timeout https://issues.apache.org/jira/browse/FLINK-6315 A common use case when writing a custom operator that outputs data to some third party location

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971404#comment-15971404 ] ASF GitHub Bot commented on FLINK-6315: --- GitHub user sjwiesman opened a pull request

[jira] [Commented] (FLINK-4831) Implement a log4j metric reporter

2017-04-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971428#comment-15971428 ] Chesnay Schepler commented on FLINK-4831: - I have some work-in-progress here: http

[GitHub] flink issue #3459: [FLINK-5654] Add processing time OVER RANGE BETWEEN x PRE...

2017-04-17 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3459 Hi @huawei-flink, the feature was contributed in a follow up PR. Could you close this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971520#comment-15971520 ] ASF GitHub Bot commented on FLINK-5654: --- Github user fhueske commented on the issue:

[GitHub] flink pull request #3696: [FLINK-6090] [table] Add RetractionRule at the sta...

2017-04-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3696#discussion_r111804596 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamCorrelate.scala --- @@ -36,14 +36,14 @@ import o

[jira] [Commented] (FLINK-6090) Add RetractionRule at the stage of decoration

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971543#comment-15971543 ] ASF GitHub Bot commented on FLINK-6090: --- Github user fhueske commented on a diff in

[GitHub] flink issue #3696: [FLINK-6090] [table] Add RetractionRule at the stage of d...

2017-04-17 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3696 Hi @hequn8128 and @shaoxuan-wang, I merged this PR to the `table-retraction` branch. Could you close it? Thanks! --- If your project is set up for it, you can reply to this email and have your r

[jira] [Commented] (FLINK-6090) Add RetractionRule at the stage of decoration

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971577#comment-15971577 ] ASF GitHub Bot commented on FLINK-6090: --- Github user fhueske commented on the issue:

[GitHub] flink pull request #3694: [FLINK-6240] [table] codeGen dataStream aggregates...

2017-04-17 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3694#discussion_r111813245 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -792,6 +792,20 @@ object Aggr

[GitHub] flink issue #3694: [FLINK-6240] [table] codeGen dataStream aggregates that u...

2017-04-17 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3694 Thanks @fhueske , I have addressed your comments, please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (FLINK-6240) codeGen dataStream aggregates that use AggregateAggFunction

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971602#comment-15971602 ] ASF GitHub Bot commented on FLINK-6240: --- Github user shaoxuan-wang commented on the

[jira] [Commented] (FLINK-6240) codeGen dataStream aggregates that use AggregateAggFunction

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971601#comment-15971601 ] ASF GitHub Bot commented on FLINK-6240: --- Github user shaoxuan-wang commented on a di

[GitHub] flink pull request #3694: [FLINK-6240] [table] codeGen dataStream aggregates...

2017-04-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3694#discussion_r111816123 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -792,6 +792,20 @@ object AggregateU

[GitHub] flink pull request #3694: [FLINK-6240] [table] codeGen dataStream aggregates...

2017-04-17 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3694#discussion_r111814395 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -396,13 +396,68 @@ class CodeGenerator(

[jira] [Commented] (FLINK-6240) codeGen dataStream aggregates that use AggregateAggFunction

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971623#comment-15971623 ] ASF GitHub Bot commented on FLINK-6240: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6240) codeGen dataStream aggregates that use AggregateAggFunction

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971624#comment-15971624 ] ASF GitHub Bot commented on FLINK-6240: --- Github user fhueske commented on a diff in

[GitHub] flink issue #3348: [FLINK-5090] [network] Add metrics for details about inbo...

2017-04-17 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3348 yes, that's exactly why --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971632#comment-15971632 ] ASF GitHub Bot commented on FLINK-5090: --- Github user NicoK commented on the issue:

[jira] [Commented] (FLINK-6292) Travis: transfer.sh not accepting uploads via http:// anymore

2017-04-17 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971637#comment-15971637 ] Nico Kruber commented on FLINK-6292: does it make sense to cherry-pick this commit int

[jira] [Commented] (FLINK-6240) codeGen dataStream aggregates that use AggregateAggFunction

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971754#comment-15971754 ] ASF GitHub Bot commented on FLINK-6240: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3694: [FLINK-6240] [table] codeGen dataStream aggregates...

2017-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3694 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-6240) codeGen dataStream aggregates that use AggregateAggFunction

2017-04-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6240. Resolution: Implemented Fix Version/s: 1.3.0 Implemented with 9be5cc42c02c258d3843c373b735024

[jira] [Created] (FLINK-6316) Kinesis connector docs should mention that FlinkKinesisConsumer does not provide strong ordering guarantees on resharding

2017-04-17 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-6316: -- Summary: Kinesis connector docs should mention that FlinkKinesisConsumer does not provide strong ordering guarantees on resharding Key: FLINK-6316 URL: https://issues.

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-17 Thread lingjinjiang
Github user lingjinjiang commented on the issue: https://github.com/apache/flink/pull/3711 @greghogan thanks for your review. I have another question, how can I assign the issue to myself ? --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-6286) hbase command not found error

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971920#comment-15971920 ] ASF GitHub Bot commented on FLINK-6286: --- Github user lingjinjiang commented on the i

[GitHub] flink issue #3728: [FLINK-6313] [flink-runtime] Fix Some words was spelled w...

2017-04-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3728 @tzulitai Hi, Could you please review those code ? Thanks and appreciate ~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-6313) Some words was spelled wrong and incorrect LOG.error without print

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971944#comment-15971944 ] ASF GitHub Bot commented on FLINK-6313: --- Github user zhangminglei commented on the i

[GitHub] flink pull request #3696: [FLINK-6090] [table] Add RetractionRule at the sta...

2017-04-17 Thread hequn8128
Github user hequn8128 closed the pull request at: https://github.com/apache/flink/pull/3696 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Commented] (FLINK-6090) Add RetractionRule at the stage of decoration

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971958#comment-15971958 ] ASF GitHub Bot commented on FLINK-6090: --- Github user hequn8128 closed the pull reque

[jira] [Closed] (FLINK-6090) Add RetractionRule at the stage of decoration

2017-04-17 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng closed FLINK-6090. -- Resolution: Fixed > Add RetractionRule at the stage of decoration >

[jira] [Commented] (FLINK-5943) Unprotected access to haServices in YarnFlinkApplicationMasterRunner#shutdown()

2017-04-17 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971966#comment-15971966 ] mingleizhang commented on FLINK-5943: - [~tedyu] Thanks and appreciate it. I will give

[GitHub] flink pull request #3594: [FLINK-6149] [table] Add additional flink logical ...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3594#discussion_r111856357 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -228,15 +229,24 @@ abstract class Batch

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971969#comment-15971969 ] ASF GitHub Bot commented on FLINK-6149: --- Github user KurtYoung commented on a diff i

[jira] [Commented] (FLINK-5550) NotFoundException: Could not find job with id

2017-04-17 Thread jiwengang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971984#comment-15971984 ] jiwengang commented on FLINK-5550: -- yep > NotFoundException: Could not find job with id

[GitHub] flink pull request #3594: [FLINK-6149] [table] Add additional flink logical ...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3594#discussion_r111857715 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalJoin.scala --- @@ -0,0 +1,130 @@ +/* + * Licen

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971988#comment-15971988 ] ASF GitHub Bot commented on FLINK-6149: --- Github user KurtYoung commented on a diff i

[GitHub] flink pull request #3594: [FLINK-6149] [table] Add additional flink logical ...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3594#discussion_r111857813 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalAggregate.scala --- @@ -0,0 +1,92 @@ +/* + * L

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971990#comment-15971990 ] ASF GitHub Bot commented on FLINK-6149: --- Github user KurtYoung commented on a diff i

[jira] [Commented] (FLINK-5943) Unprotected access to haServices in YarnFlinkApplicationMasterRunner#shutdown()

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971996#comment-15971996 ] ASF GitHub Bot commented on FLINK-5943: --- GitHub user zhangminglei opened a pull requ

[GitHub] flink pull request #3730: [FLINK-5943] [YARN] Fix unprotected access to haSe...

2017-04-17 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/3730 [FLINK-5943] [YARN] Fix unprotected access to haServices in YarnFlink… …ApplicationMasterRunner#shutdown(). Thanks for contributing to Apache Flink. Before you open your pull reques

[GitHub] flink pull request #3594: [FLINK-6149] [table] Add additional flink logical ...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3594#discussion_r111858923 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalAggregate.scala --- @@ -0,0 +1,92 @@ +/* + * L

[GitHub] flink pull request #3594: [FLINK-6149] [table] Add additional flink logical ...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3594#discussion_r111859756 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalSort.scala --- @@ -0,0 +1,148 @@ +/* + * Licen

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972015#comment-15972015 ] ASF GitHub Bot commented on FLINK-6149: --- Github user KurtYoung commented on a diff i

[GitHub] flink pull request #3594: [FLINK-6149] [table] Add additional flink logical ...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3594#discussion_r111860136 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/rel/logical/FlinkLogicalTableSourceScan.scala --- @@ -0,0 +1,109 @@ +/*

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972018#comment-15972018 ] ASF GitHub Bot commented on FLINK-6149: --- Github user KurtYoung commented on a diff i

[GitHub] flink pull request #3594: [FLINK-6149] [table] Add additional flink logical ...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3594#discussion_r111860657 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/TableEnvironmentTest.scala --- @@ -335,7 +335,8 @@ class TableEnvironmentTest

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972024#comment-15972024 ] ASF GitHub Bot commented on FLINK-6149: --- Github user KurtYoung commented on a diff i

[GitHub] flink pull request #3594: [FLINK-6149] [table] Add additional flink logical ...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3594#discussion_r111861037 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/cost/FlinkRelMdRowCount.scala --- @@ -23,13 +23,17 @@ import org.apache.c

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972028#comment-15972028 ] ASF GitHub Bot commented on FLINK-6149: --- Github user KurtYoung commented on a diff i

[GitHub] flink pull request #3594: [FLINK-6149] [table] Add additional flink logical ...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3594#discussion_r111861591 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetCorrelateRule.scala --- @@ -18,58 +18,57 @@ pac

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972034#comment-15972034 ] ASF GitHub Bot commented on FLINK-6149: --- Github user KurtYoung commented on a diff i

[GitHub] flink issue #3594: [FLINK-6149] [table] Add additional flink logical relatio...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3594 Hi @fhueske , sorry for taking it so long to update this PR. Looks like it has so many conflicts with master now, once you are ok with all the changes, i will rebase it to master. --- If your

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972040#comment-15972040 ] ASF GitHub Bot commented on FLINK-6149: --- Github user KurtYoung commented on the issu

[jira] [Updated] (FLINK-5867) The implementation of RestartPipelinedRegionStrategy

2017-04-17 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu updated FLINK-5867: Description: The RestartPipelinedRegionStrategy's responsibility is the following: 1. Calculate all Failover

[jira] [Updated] (FLINK-5867) The implementation of RestartPipelinedRegionStrategy

2017-04-17 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu updated FLINK-5867: Summary: The implementation of RestartPipelinedRegionStrategy (was: The implementation of FailoverCoordinat

[GitHub] flink issue #3652: [FLINK-6210] close RocksDB in ListViaMergeSpeedMiniBenchm...

2017-04-17 Thread fanyon
Github user fanyon commented on the issue: https://github.com/apache/flink/pull/3652 Hi @shixiaogang , as we discussed before, I have closed all resources in latest commit, thank you for your comments. --- If your project is set up for it, you can reply to this email and have your re

[jira] [Commented] (FLINK-6210) RocksDB instance should be closed in ListViaMergeSpeedMiniBenchmark

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972200#comment-15972200 ] ASF GitHub Bot commented on FLINK-6210: --- Github user fanyon commented on the issue:

[GitHub] flink issue #3686: [FLINK-6271][jdbc]Fix nullPointer when there's a single s...

2017-04-17 Thread patricklucas
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3686 @fpompermaier FYI your author email address on this commit was "f.pomperma...@gmai.com" (missing 'l'). You might have a typo in your gitconfig? --- If your project is set up for it, you can rep

[jira] [Commented] (FLINK-6271) NumericBetweenParametersProvider NullPointer

2017-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972202#comment-15972202 ] ASF GitHub Bot commented on FLINK-6271: --- Github user patricklucas commented on the i