[GitHub] flink pull request #3933: [FLINK-6606] Create checkpoint hook with user clas...

2017-05-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3933#discussion_r117421730 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/hooks/MasterHooks.java --- @@ -267,6 +269,112 @@ else if (!allowUnmatchedStat

[jira] [Commented] (FLINK-6606) Create checkpoint hook with user classloader

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017026#comment-16017026 ] ASF GitHub Bot commented on FLINK-6606: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #3933: [FLINK-6606] Create checkpoint hook with user clas...

2017-05-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3933#discussion_r117427223 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/hooks/MasterHooks.java --- @@ -267,6 +269,112 @@ else if (!allowUnmatchedStat

[jira] [Commented] (FLINK-6606) Create checkpoint hook with user classloader

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017047#comment-16017047 ] ASF GitHub Bot commented on FLINK-6606: --- Github user tillrohrmann commented on a dif

[jira] [Created] (FLINK-6633) Register with shared state registry before aadding to CompletedCheckpointStore

2017-05-19 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-6633: - Summary: Register with shared state registry before aadding to CompletedCheckpointStore Key: FLINK-6633 URL: https://issues.apache.org/jira/browse/FLINK-6633 Projec

[jira] [Updated] (FLINK-6633) Register with shared state registry before adding to CompletedCheckpointStore

2017-05-19 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-6633: -- Summary: Register with shared state registry before adding to CompletedCheckpointStore (was: Re

[jira] [Created] (FLINK-6634) NFA serializer does not serialize the ValueTimeWrapper counter.

2017-05-19 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-6634: - Summary: NFA serializer does not serialize the ValueTimeWrapper counter. Key: FLINK-6634 URL: https://issues.apache.org/jira/browse/FLINK-6634 Project: Flink

[jira] [Closed] (FLINK-6633) Register with shared state registry before adding to CompletedCheckpointStore

2017-05-19 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6633. - Resolution: Fixed fixed in 0162543ac1 > Register with shared state registry before adding to Comp

[jira] [Commented] (FLINK-6632) Fix parameter case sensitive error for test passing/rejecting filter API

2017-05-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017092#comment-16017092 ] Fabian Hueske commented on FLINK-6632: -- I think a better approach to solve this would

[GitHub] flink issue #3939: [FLINK-6612] Allow ZooKeeperStateHandleStore to lock crea...

2017-05-19 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3939 Thanks for your work @tillrohrmann ! I merged this manually. Please close this PR and the jira. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-6612) ZooKeeperStateHandleStore does not guard against concurrent delete operations

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017093#comment-16017093 ] ASF GitHub Bot commented on FLINK-6612: --- Github user StefanRRichter commented on the

[GitHub] flink issue #3913: [FLINK-6574] Support nested catalogs in ExternalCatalog.

2017-05-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3913 Thanks for the update @haohui and the review @KurtYoung. Will merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Commented] (FLINK-6574) Support nested catalogs in ExternalCatalog

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017130#comment-16017130 ] ASF GitHub Bot commented on FLINK-6574: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3910: [FLINK-6582] [docs] Project from maven archetype is not b...

2017-05-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3910 Thanks a lot for fixing the issue. I've tested it again, and it works. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-6582) Project from maven archetype is not buildable by default due to ${scala.binary.version}

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017132#comment-16017132 ] ASF GitHub Bot commented on FLINK-6582: --- Github user rmetzger commented on the issue

[GitHub] flink pull request #3943: [FLINK-6617][table] Improve JAVA and SCALA logical...

2017-05-19 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3943 [FLINK-6617][table] Improve JAVA and SCALA logical plans consistent test In this PR. I had make some changes as follows: 1. Add all the tableAPI AVA and SCALA logical plans consistent test

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441680 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobSubmissionClientActor.java --- @@ -119,7 +119,7 @@ public void handleCustomMessage(O

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441909 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FixedDelayRestartStrategy.java --- @@ -87,7 +87,7 @@ public static Fixe

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117443837 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java --- @@ -55,4 +55,88 @@ public static final ConfigOption AKKA_WATCH_

[jira] [Commented] (FLINK-6617) Improve JAVA and SCALA logical plans consistent test

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017134#comment-16017134 ] ASF GitHub Bot commented on FLINK-6617: --- GitHub user sunjincheng121 opened a pull re

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441984 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java --- @@ -114,13 +114,11 @@ public QueryableStateClient(

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441051 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java --- @@ -27,7 +27,7 @@ */ @PublicEvolving public class AkkaO

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441386 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobAttachmentClientActor.java --- @@ -114,7 +114,7 @@ else if (JobClientMessages.getRe

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117441942 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyFactory.java --- @@ -100,7 +100,7 @@ public static Resta

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117442464 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingUtils.scala --- @@ -28,7 +28,7 @@ import com.google.common.util.concurren

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117442054 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java --- @@ -146,7 +147,7 @@ public static TaskManagerCo

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017136#comment-16017136 ] ASF GitHub Bot commented on FLINK-6495: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017138#comment-16017138 ] ASF GitHub Bot commented on FLINK-6495: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017137#comment-16017137 ] ASF GitHub Bot commented on FLINK-6495: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017139#comment-16017139 ] ASF GitHub Bot commented on FLINK-6495: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017142#comment-16017142 ] ASF GitHub Bot commented on FLINK-6495: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017135#comment-16017135 ] ASF GitHub Bot commented on FLINK-6495: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017143#comment-16017143 ] ASF GitHub Bot commented on FLINK-6495: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017140#comment-16017140 ] ASF GitHub Bot commented on FLINK-6495: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017141#comment-16017141 ] ASF GitHub Bot commented on FLINK-6495: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #3910: [FLINK-6582] [docs] Project from maven archetype i...

2017-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3910 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (FLINK-6582) Project from maven archetype is not buildable by default due to ${scala.binary.version}

2017-05-19 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-6582. --- Resolution: Fixed Fix for master/1.4: http://git-wip-us.apache.org/repos/asf/flink/commit/6ae7

[jira] [Commented] (FLINK-6582) Project from maven archetype is not buildable by default due to ${scala.binary.version}

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017144#comment-16017144 ] ASF GitHub Bot commented on FLINK-6582: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-5998) Un-fat Hadoop from Flink fat jar

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017147#comment-16017147 ] ASF GitHub Bot commented on FLINK-5998: --- Github user rmetzger commented on the issue

[GitHub] flink issue #3856: [FLINK-5998] Fix shaded Hadoop Jar

2017-05-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3856 Afaik this PR can be closed because it has been superseded by Stephan's PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] flink pull request #3911: [FLINK-6539] Add end-to-end tests

2017-05-19 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/3911#discussion_r117445440 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -227,5 +227,15 @@ upload_artifacts_s3 # we are going back to cd ../../ +# run end-to-end te

[GitHub] flink issue #3907: [FLINK-6586] InputGateMetrics return 0 as minimum for loc...

2017-05-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3907 Updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-6539) Add automated end-to-end tests

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017152#comment-16017152 ] ASF GitHub Bot commented on FLINK-6539: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-6586) InputGateMetrics#refreshAndGetMin returns Integer.MAX_VALUE for local channels

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017155#comment-16017155 ] ASF GitHub Bot commented on FLINK-6586: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-5340) Add a metric exposing jobs uptimes

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017163#comment-16017163 ] ASF GitHub Bot commented on FLINK-5340: --- Github user zentol commented on the issue:

[GitHub] flink issue #3908: [FLINK-5340] Document job uptime/downtime/restartTime/ful...

2017-05-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3908 @alpinegizmo I've updated the wording. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[jira] [Assigned] (FLINK-6451) Web UI: Rename 'Metrics' view to 'Task Metrics'

2017-05-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6451: --- Assignee: Chesnay Schepler > Web UI: Rename 'Metrics' view to 'Task Metrics' > --

[jira] [Assigned] (FLINK-6450) Web UI Subtasks view for TaskManagers has a misleading name

2017-05-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6450: --- Assignee: Chesnay Schepler > Web UI Subtasks view for TaskManagers has a misleading n

[jira] [Created] (FLINK-6635) ClientConnectionTest is broken because the ClusterClient lazily connects to the JobManager

2017-05-19 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-6635: Summary: ClientConnectionTest is broken because the ClusterClient lazily connects to the JobManager Key: FLINK-6635 URL: https://issues.apache.org/jira/browse/FLINK-6635

[jira] [Assigned] (FLINK-6448) Web UI TaskManager view: Rename 'Free Memory' to 'JVM Heap'

2017-05-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6448: --- Assignee: Chesnay Schepler > Web UI TaskManager view: Rename 'Free Memory' to 'JVM He

[jira] [Commented] (FLINK-6495) Migrate Akka configuration options

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017169#comment-16017169 ] ASF GitHub Bot commented on FLINK-6495: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117447913 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingUtils.scala --- @@ -28,7 +28,7 @@ import com.google.common.util.con

[GitHub] flink issue #3939: [FLINK-6612] Allow ZooKeeperStateHandleStore to lock crea...

2017-05-19 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3939 Merged in 3d119e1155aa8930cc7b18a085d6790cb2c63b70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] flink pull request #3939: [FLINK-6612] Allow ZooKeeperStateHandleStore to lo...

2017-05-19 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/3939 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (FLINK-6612) ZooKeeperStateHandleStore does not guard against concurrent delete operations

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017172#comment-16017172 ] ASF GitHub Bot commented on FLINK-6612: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #3940: [backport 1.3] [FLINK-6612] Allow ZooKeeperStateHa...

2017-05-19 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/3940 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] flink issue #3940: [backport 1.3] [FLINK-6612] Allow ZooKeeperStateHandleSto...

2017-05-19 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3940 Merged in f58fec70fef12056bd58b6cc2985532ccb07625e --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[jira] [Commented] (FLINK-6612) ZooKeeperStateHandleStore does not guard against concurrent delete operations

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017173#comment-16017173 ] ASF GitHub Bot commented on FLINK-6612: --- Github user tillrohrmann closed the pull re

[jira] [Commented] (FLINK-6612) ZooKeeperStateHandleStore does not guard against concurrent delete operations

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017174#comment-16017174 ] ASF GitHub Bot commented on FLINK-6612: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-6612) ZooKeeperStateHandleStore does not guard against concurrent delete operations

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017175#comment-16017175 ] ASF GitHub Bot commented on FLINK-6612: --- Github user tillrohrmann closed the pull re

[jira] [Closed] (FLINK-6612) ZooKeeperStateHandleStore does not guard against concurrent delete operations

2017-05-19 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-6612. Resolution: Fixed 1.4.0: 3d119e1155aa8930cc7b18a085d6790cb2c63b70 1.3.0: f58fec70fef12056bd58b6cc298

[jira] [Assigned] (FLINK-6610) WebServer could not be created,when set the "jobmanager.web.submit.enable" to false

2017-05-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6610: --- Assignee: Chesnay Schepler (was: zhihao chen) > WebServer could not be created,when

[jira] [Commented] (FLINK-6539) Add automated end-to-end tests

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017187#comment-16017187 ] ASF GitHub Bot commented on FLINK-6539: --- Github user rmetzger commented on the issue

[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests

2017-05-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3911 I tried it locally, but got some weird results: ``` Found error in log files. Found exception in log files. Found non-empty file build-target/log/flink-robert-jobmanager-0-robert

[jira] [Updated] (FLINK-6632) Fix parameter case sensitive error for test passing/rejecting filter API

2017-05-19 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6632: --- Description: TableAPI {{testAllPassingFilter}}: {code} val t = util.addTable[(Int, Long, String)](

[GitHub] flink pull request #3944: [FLINK-6632][table]Improved the method BoolLiteral...

2017-05-19 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3944 [FLINK-6632][table]Improved the method BoolLiteral of ExpressionParse… This PR. only improved the method `BoolLiteral` of `ExpressionParser` for case insensitive. - [x] General

[jira] [Commented] (FLINK-6632) Fix parameter case sensitive error for test passing/rejecting filter API

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017198#comment-16017198 ] ASF GitHub Bot commented on FLINK-6632: --- GitHub user sunjincheng121 opened a pull re

[GitHub] flink pull request #3934: [FLINK-6065] Add initClient method to Elasticsearc...

2017-05-19 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3934#discussion_r117452130 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchApiCallBridge.java

[GitHub] flink pull request #3934: [FLINK-6065] Add initClient method to Elasticsearc...

2017-05-19 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3934#discussion_r117451847 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchApiCallBridge.java

[GitHub] flink pull request #3934: [FLINK-6065] Add initClient method to Elasticsearc...

2017-05-19 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3934#discussion_r117452728 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchApiCallBridge.java

[jira] [Commented] (FLINK-6065) Make TransportClient for ES5 pluggable

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017226#comment-16017226 ] ASF GitHub Bot commented on FLINK-6065: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-6065) Make TransportClient for ES5 pluggable

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017225#comment-16017225 ] ASF GitHub Bot commented on FLINK-6065: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-6065) Make TransportClient for ES5 pluggable

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017224#comment-16017224 ] ASF GitHub Bot commented on FLINK-6065: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #3934: [FLINK-6065] Add initClient method to Elasticsearc...

2017-05-19 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3934#discussion_r117455309 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchApiCallBridge.java

[jira] [Commented] (FLINK-6065) Make TransportClient for ES5 pluggable

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017230#comment-16017230 ] ASF GitHub Bot commented on FLINK-6065: --- Github user tzulitai commented on a diff in

[GitHub] flink issue #3934: [FLINK-6065] Add initClient method to ElasticsearchApiCal...

2017-05-19 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3934 Answer to some of your other questions: 1. I don't think the Apache ICLA is strictly required, unless you're invited as a Committer of the project. 2. The tests should be added unde

[jira] [Commented] (FLINK-6065) Make TransportClient for ES5 pluggable

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017234#comment-16017234 ] ASF GitHub Bot commented on FLINK-6065: --- Github user tzulitai commented on the issue

[GitHub] flink pull request #3945: [FLINK-6634] [cep] NFASerializer serializes Comput...

2017-05-19 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3945 [FLINK-6634] [cep] NFASerializer serializes ComputationState counter. Before the recently introduces `NFASerializer` was not serializing the `counter` of the `ComputationState`. This could result in ex

[jira] [Commented] (FLINK-6634) NFA serializer does not serialize the ValueTimeWrapper counter.

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017286#comment-16017286 ] ASF GitHub Bot commented on FLINK-6634: --- GitHub user kl0u opened a pull request:

[GitHub] flink pull request #3941: [FLINK-6603] [streaming] Enable checkstyle on test...

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3941#discussion_r117463482 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1696,13 +1699,13 @@ publi

[GitHub] flink pull request #3941: [FLINK-6603] [streaming] Enable checkstyle on test...

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3941#discussion_r117463365 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1237,9 +1240,9 @@ public

[GitHub] flink pull request #3941: [FLINK-6603] [streaming] Enable checkstyle on test...

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3941#discussion_r117463445 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1518,9 +1521,9 @@ public

[GitHub] flink pull request #3941: [FLINK-6603] [streaming] Enable checkstyle on test...

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3941#discussion_r117463416 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1374,9 +1377,9 @@ public

[GitHub] flink pull request #3941: [FLINK-6603] [streaming] Enable checkstyle on test...

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3941#discussion_r117463525 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1979,9 +1982,9 @@ public

[GitHub] flink pull request #3941: [FLINK-6603] [streaming] Enable checkstyle on test...

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3941#discussion_r117463516 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1887,10 +1890,10 @@ publi

[jira] [Commented] (FLINK-6603) Enable checkstyle on test sources

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017289#comment-16017289 ] ASF GitHub Bot commented on FLINK-6603: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6603) Enable checkstyle on test sources

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017290#comment-16017290 ] ASF GitHub Bot commented on FLINK-6603: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #3941: [FLINK-6603] [streaming] Enable checkstyle on test...

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3941#discussion_r117463433 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1438,10 +1441,10 @@ publi

[GitHub] flink pull request #3941: [FLINK-6603] [streaming] Enable checkstyle on test...

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3941#discussion_r117463463 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1610,9 +1613,9 @@ public

[GitHub] flink pull request #3941: [FLINK-6603] [streaming] Enable checkstyle on test...

2017-05-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3941#discussion_r117463501 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1783,13 +1786,13 @@ publi

[jira] [Commented] (FLINK-6603) Enable checkstyle on test sources

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017293#comment-16017293 ] ASF GitHub Bot commented on FLINK-6603: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6603) Enable checkstyle on test sources

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017292#comment-16017292 ] ASF GitHub Bot commented on FLINK-6603: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6603) Enable checkstyle on test sources

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017294#comment-16017294 ] ASF GitHub Bot commented on FLINK-6603: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6603) Enable checkstyle on test sources

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017295#comment-16017295 ] ASF GitHub Bot commented on FLINK-6603: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6603) Enable checkstyle on test sources

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017288#comment-16017288 ] ASF GitHub Bot commented on FLINK-6603: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6603) Enable checkstyle on test sources

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017291#comment-16017291 ] ASF GitHub Bot commented on FLINK-6603: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6603) Enable checkstyle on test sources

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017296#comment-16017296 ] ASF GitHub Bot commented on FLINK-6603: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6454) Add more permission settings to the web UI

2017-05-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017303#comment-16017303 ] Chesnay Schepler commented on FLINK-6454: - We can combine both approaches into a s

[GitHub] flink issue #3833: [FLINK-6221] Add PrometheusReporter

2017-05-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3833 I'll take a look later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[jira] [Commented] (FLINK-6221) Add Prometheus support to metrics

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017308#comment-16017308 ] ASF GitHub Bot commented on FLINK-6221: --- Github user zentol commented on the issue:

  1   2   3   >