[GitHub] flink issue #4061: [FLINK-6841][table]Using TableSourceTable for both Stream...

2017-06-07 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4061 Hi @twalthr I think `DefinedProctimeAttribute` can be implemented by a batch table source. If we do not want a batch table source can implements `DefinedProctimeAttribute `, we should add

[jira] [Commented] (FLINK-6841) using TableSourceTable for both Stream and Batch OR remove useless import

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041179#comment-16041179 ] ASF GitHub Bot commented on FLINK-6841: --- Github user sunjincheng121 commented on the issue:

[jira] [Commented] (FLINK-6865) Expand checkstyle docs to include import in intellij

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041095#comment-16041095 ] ASF GitHub Bot commented on FLINK-6865: --- Github user greghogan commented on the issue:

[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4086 If the long-term plan is to have one checkstyle then we should keep the current plain name. We may be at the point where we can rename the checkstyles and update the in-progress modules to use a

[GitHub] flink pull request #4059: [FLINK-6830] Add StatefulJobSavepointFrom13Migrati...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4059 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4052: [FLINK-6808] Implement compatibility methods for C...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4052 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6772) Incorrect ordering of matched state events in Flink CEP

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041018#comment-16041018 ] ASF GitHub Bot commented on FLINK-6772: --- Github user kl0u commented on the issue:

[jira] [Commented] (FLINK-6853) Migrating from Flink 1.1 fails for FlinkCEP

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041171#comment-16041171 ] ASF GitHub Bot commented on FLINK-6853: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-6844) TraversableSerializer should implement compatibility methods

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041170#comment-16041170 ] ASF GitHub Bot commented on FLINK-6844: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-6830) Add ITTests for savepoint migration from 1.3

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041169#comment-16041169 ] ASF GitHub Bot commented on FLINK-6830: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4079: [FLINK-6853] [DataStream] Let StreamRecordSerializ...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4079 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4081: [FLINK-6844] [scala] Implement compatibility metho...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4081 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #4084: [FLINK-6772] [cep] Fix ordering (by timestamp) of matched...

2017-06-07 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4084 Thanks @dawidwys ! I will let travis have another go on the rebased version and then merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #4072: [FLINK-6848] Update managed state docs

2017-06-07 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4072 Hi @Fokko, thanks a lot for this contribution! The current changes look good. However, while you're on it, what do you think about also adding a Scala counterpart example for the other code

[jira] [Commented] (FLINK-6848) Extend the managed state docs with a Scala example

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041016#comment-16041016 ] ASF GitHub Bot commented on FLINK-6848: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-6808) Stream join fails when checkpointing is enabled

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041168#comment-16041168 ] ASF GitHub Bot commented on FLINK-6808: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-6849) Refactor operator state backend and internal operator state hierarchy

2017-06-07 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040295#comment-16040295 ] mingleizhang commented on FLINK-6849: - I think we can do this refactor by the below three steps. 1.

[jira] [Comment Edited] (FLINK-6849) Refactor operator state backend and internal operator state hierarchy

2017-06-07 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040295#comment-16040295 ] mingleizhang edited comment on FLINK-6849 at 6/7/17 7:03 AM: - I think we can

[jira] [Comment Edited] (FLINK-6849) Refactor operator state backend and internal operator state hierarchy

2017-06-07 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040295#comment-16040295 ] mingleizhang edited comment on FLINK-6849 at 6/7/17 6:41 AM: - I think we can

[GitHub] flink issue #3998: [FLINK-6661][web] Merge "Subtasks" and "SubtasksByTaskMan...

2017-06-07 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3998 we got enough space, so why not be explicit about it :) Will change it while merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Comment Edited] (FLINK-6849) Refactor operator state backend and internal operator state hierarchy

2017-06-07 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040295#comment-16040295 ] mingleizhang edited comment on FLINK-6849 at 6/7/17 6:59 AM: - I think that we

[jira] [Commented] (FLINK-6661) Merge "Subtasks" and "TaskManagers" view

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040334#comment-16040334 ] ASF GitHub Bot commented on FLINK-6661: --- Github user zentol commented on the issue:

[jira] [Resolved] (FLINK-6844) TraversableSerializer should implement compatibility methods

2017-06-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-6844. Resolution: Fixed Fix Version/s: 1.4.0 Fixed for 1.3 via

[jira] [Closed] (FLINK-6844) TraversableSerializer should implement compatibility methods

2017-06-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-6844. -- > TraversableSerializer should implement compatibility methods >

[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-07 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4086 hmmi just retried it and it didn't work this time. Let me investigate a bit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-6865) Expand checkstyle docs to include import in intellij

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041302#comment-16041302 ] ASF GitHub Bot commented on FLINK-6865: --- Github user zentol commented on the issue:

[jira] [Closed] (FLINK-6853) Migrating from Flink 1.1 fails for FlinkCEP

2017-06-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-6853. -- > Migrating from Flink 1.1 fails for FlinkCEP > ---

[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-07 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4086 Something the import did in fact set was spaces around operators. It may be that not all checkstyle rules are properly imported. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-6865) Expand checkstyle docs to include import in intellij

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041329#comment-16041329 ] ASF GitHub Bot commented on FLINK-6865: --- Github user zentol commented on the issue:

[jira] [Resolved] (FLINK-6830) Add ITTests for savepoint migration from 1.3

2017-06-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-6830. Resolution: Fixed Fix Version/s: 1.4.0 Fixed for master via

[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-07 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4086 yes, it's a good idea to "flip" the checkstyle names. I only checked a few things, but importing the checkstyle configuration, with the Checkstyle-IDEA plugin enabled, at the very least

[jira] [Commented] (FLINK-6865) Expand checkstyle docs to include import in intellij

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041263#comment-16041263 ] ASF GitHub Bot commented on FLINK-6865: --- Github user zentol commented on the issue:

[jira] [Resolved] (FLINK-6815) Javadocs don't work anymore in Flink 1.4-SNAPSHOT

2017-06-07 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-6815. --- Resolution: Fixed Fix Version/s: 1.4.0 1.3.1 1.4:

[jira] [Resolved] (FLINK-6853) Migrating from Flink 1.1 fails for FlinkCEP

2017-06-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-6853. Resolution: Fixed Fix Version/s: 1.4.0 1.3.1 Fixed for

[jira] [Resolved] (FLINK-6808) Stream join fails when checkpointing is enabled

2017-06-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-6808. Resolution: Fixed Fixed for 1.3.1 via f74caf7062b1cc23a704f8f8b8171be430b60807.

[jira] [Closed] (FLINK-6830) Add ITTests for savepoint migration from 1.3

2017-06-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-6830. -- > Add ITTests for savepoint migration from 1.3 >

[jira] [Commented] (FLINK-6488) Remove 'start-local.sh' script

2017-06-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040531#comment-16040531 ] Chesnay Schepler commented on FLINK-6488: - Of course it is redundant, that's the whole point. If

[jira] [Commented] (FLINK-6488) Remove 'start-local.sh' script

2017-06-07 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040547#comment-16040547 ] mingleizhang commented on FLINK-6488: - [~Zentol] So, We will still keep {{start-local.sh}} and do not

[jira] [Commented] (FLINK-6488) Remove 'start-local.sh' script

2017-06-07 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040566#comment-16040566 ] mingleizhang commented on FLINK-6488: - That makes sense better. Patch will available soon. > Remove

[jira] [Commented] (FLINK-6281) Create TableSink for JDBC

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040577#comment-16040577 ] ASF GitHub Bot commented on FLINK-6281: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3712: [FLINK-6281] Create TableSink for JDBC.

2017-06-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3712#discussion_r120575757 --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSinkTest.java --- @@ -0,0 +1,79 @@ +/* + * Licensed

[jira] [Commented] (FLINK-6281) Create TableSink for JDBC

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040578#comment-16040578 ] ASF GitHub Bot commented on FLINK-6281: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3712: [FLINK-6281] Create TableSink for JDBC.

2017-06-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3712#discussion_r120576032 --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSinkTest.java --- @@ -0,0 +1,79 @@ +/* + * Licensed

[jira] [Commented] (FLINK-6488) Remove 'start-local.sh' script

2017-06-07 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040370#comment-16040370 ] mingleizhang commented on FLINK-6488: - It would seems redundant if we keep {{start-local.sh}}. But If

[jira] [Closed] (FLINK-6858) Unbounded event time Over Window emits incorrect timestamps

2017-06-07 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6858. Resolution: Invalid Hi [~Yuhong_kyo], you are of course right. The operators work exactly as they

[jira] [Commented] (FLINK-6488) Remove 'start-local.sh' script

2017-06-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040561#comment-16040561 ] Chesnay Schepler commented on FLINK-6488: - We will change {{start-local.sh}} to a) print a

[jira] [Commented] (FLINK-6849) Refactor operator state backend and internal operator state hierarchy

2017-06-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040460#comment-16040460 ] Stefan Richter commented on FLINK-6849: --- I agree in general, because this was clear from the

[jira] [Comment Edited] (FLINK-6849) Refactor operator state backend and internal operator state hierarchy

2017-06-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040460#comment-16040460 ] Stefan Richter edited comment on FLINK-6849 at 6/7/17 8:09 AM: --- I agree in

[jira] [Created] (FLINK-6861) Use OperatorID in metric system

2017-06-07 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-6861: --- Summary: Use OperatorID in metric system Key: FLINK-6861 URL: https://issues.apache.org/jira/browse/FLINK-6861 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-6281) Create TableSink for JDBC

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040576#comment-16040576 ] ASF GitHub Bot commented on FLINK-6281: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3712: [FLINK-6281] Create TableSink for JDBC.

2017-06-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3712#discussion_r120576118 --- Diff: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java --- @@ -202,14 +202,20 @@ public void

[jira] [Commented] (FLINK-6849) Refactor operator state backend and internal operator state hierarchy

2017-06-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040439#comment-16040439 ] Tzu-Li (Gordon) Tai commented on FLINK-6849: Hi [~mingleizhang], your proposals also match

[jira] [Closed] (FLINK-5053) Incremental / lightweight snapshots for checkpoints

2017-06-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-5053. - Resolution: Implemented > Incremental / lightweight snapshots for checkpoints >

[jira] [Closed] (FLINK-6364) Implement incremental checkpointing in RocksDBStateBackend

2017-06-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6364. - Resolution: Fixed > Implement incremental checkpointing in RocksDBStateBackend >

[jira] [Comment Edited] (FLINK-6488) Remove 'start-local.sh' script

2017-06-07 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040566#comment-16040566 ] mingleizhang edited comment on FLINK-6488 at 6/7/17 9:25 AM: - That makes sense

[jira] [Updated] (FLINK-6866) ClosureCleaner.clean fails for scala's JavaConverters wrapper classes

2017-06-07 Thread SmedbergM (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] SmedbergM updated FLINK-6866: - Description: MWE: ``` import scala.collection.JavaConverters._ import

[jira] [Updated] (FLINK-6866) ClosureCleaner.clean fails for scala's JavaConverters wrapper classes

2017-06-07 Thread SmedbergM (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] SmedbergM updated FLINK-6866: - Description: MWE: ``` import scala.collection.JavaConverters._ import

[jira] [Commented] (FLINK-6865) Expand checkstyle docs to include import in intellij

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041558#comment-16041558 ] ASF GitHub Bot commented on FLINK-6865: --- Github user zentol commented on the issue:

[jira] [Created] (FLINK-6866) ClosureCleaner.clean fails for scala's JavaConverters wrapper classes

2017-06-07 Thread SmedbergM (JIRA)
SmedbergM created FLINK-6866: Summary: ClosureCleaner.clean fails for scala's JavaConverters wrapper classes Key: FLINK-6866 URL: https://issues.apache.org/jira/browse/FLINK-6866 Project: Flink

[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-07 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4086 Only a (small) subset of checkstyle modules can be moduled, which sadly doesn't include the `ImportOrder` module. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-6865) Expand checkstyle docs to include import in intellij

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041521#comment-16041521 ] ASF GitHub Bot commented on FLINK-6865: --- Github user zentol commented on the issue:

[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-07 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4086 Here's a list of the currently supported modules btw.: ``` EmptyLineSeparator FileTabCharacter Indentation LeftCurly LineLength NeedBraces NoWhitespacesBefore

[jira] [Commented] (FLINK-6865) Expand checkstyle docs to include import in intellij

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041533#comment-16041533 ] ASF GitHub Bot commented on FLINK-6865: --- Github user greghogan commented on the issue:

[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4086 Okay, second best may be to create an IntelliJ Code Style configuration for developers to import. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-6865) Expand checkstyle docs to include import in intellij

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041551#comment-16041551 ] ASF GitHub Bot commented on FLINK-6865: --- Github user zentol commented on the issue:

[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-07 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4086 I don't know a lot about the intellij code style config; can we only define subset that is imported without affecting the rest? Btw., I'm looking into contributing to the checkstyle plugin to

[jira] [Created] (FLINK-6862) Tumble window rowtime not resolve at logic plan validation

2017-06-07 Thread Mark You (JIRA)
Mark You created FLINK-6862: --- Summary: Tumble window rowtime not resolve at logic plan validation Key: FLINK-6862 URL: https://issues.apache.org/jira/browse/FLINK-6862 Project: Flink Issue Type:

[jira] [Updated] (FLINK-6862) Tumble window rowtime not resolve at logic plan validation

2017-06-07 Thread Mark You (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark You updated FLINK-6862: Description: Following code sample work in version 1.2.1, but failed at 1.3.0 {code:title=

[GitHub] flink pull request #4048: [FLINK-6812] Enforce Java8 when creating a release

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6844) TraversableSerializer should implement compatibility methods

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040677#comment-16040677 ] ASF GitHub Bot commented on FLINK-6844: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-6661) Merge "Subtasks" and "TaskManagers" view

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040592#comment-16040592 ] ASF GitHub Bot commented on FLINK-6661: --- Github user asfgit closed the pull request at:

[GitHub] flink issue #4069: [FLINK-6723] Activate strict checkstyle for flink-librari...

2017-06-07 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4069 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-6723) Activate strict checkstyle for flink-libraries

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040599#comment-16040599 ] ASF GitHub Bot commented on FLINK-6723: --- Github user zentol commented on the issue:

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

2017-06-07 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4039 I will address them today. I am working on last comment with enabling the changes also for Partitioner. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-6783) Wrongly extracted TypeInformations for WindowedStream::aggregate

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040620#comment-16040620 ] ASF GitHub Bot commented on FLINK-6783: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

2017-06-07 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/4039 Cool, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer

2017-06-07 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040629#comment-16040629 ] sunjincheng commented on FLINK-6859: Get set of registered timers by namespace. And traverse the timer

[GitHub] flink issue #4048: [FLINK-6812] Enforce Java8 when creating a release

2017-06-07 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/4048 I've tested the change with the release scripts, and the elasticsearch5 connector was showing up. I'll merge the change now. --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-6812) Elasticsearch 5 release artifacts not published to Maven central

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040662#comment-16040662 ] ASF GitHub Bot commented on FLINK-6812: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3998: [FLINK-6661][web] Merge "Subtasks" and "SubtasksBy...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3998 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Closed] (FLINK-6661) Merge "Subtasks" and "TaskManagers" view

2017-06-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6661. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: c595502148de7dc02a407480570f9e51df81b268

[jira] [Commented] (FLINK-6783) Wrongly extracted TypeInformations for WindowedStream::aggregate

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040609#comment-16040609 ] ASF GitHub Bot commented on FLINK-6783: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

2017-06-07 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/4039 @dawidwys What's your schedule to address the comments? This is one of the real blockers for the 1.3.1 release, and I would like to put the first RC this week. --- If your project is set up

[GitHub] flink pull request #4083: [FLINK-6742] Improve savepoint migration failure e...

2017-06-07 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4083 [FLINK-6742] Improve savepoint migration failure error message This PR improves the error messages if the savepoint migration fails because a stateful task was removed or the parallelism of stateful

[jira] [Updated] (FLINK-6862) Tumble window rowtime not resolve at logic plan validation

2017-06-07 Thread Mark You (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark You updated FLINK-6862: Description: Following code sample work in version 1.2.1, but failed at 1.3.0 {code:title=

[jira] [Commented] (FLINK-6742) Improve error message when savepoint migration fails due to task removal

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040645#comment-16040645 ] ASF GitHub Bot commented on FLINK-6742: --- GitHub user zentol opened a pull request:

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-07 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040642#comment-16040642 ] Fabian Hueske commented on FLINK-6788: -- I think it is fine to remove these classes. Their original

[jira] [Assigned] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6788: --- Assignee: Miao Wang > Remove unused GenericFlatTypePostPass/AbstractSchema class >

[jira] [Commented] (FLINK-6812) Elasticsearch 5 release artifacts not published to Maven central

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040661#comment-16040661 ] ASF GitHub Bot commented on FLINK-6812: --- Github user rmetzger commented on the issue:

[jira] [Resolved] (FLINK-6812) Elasticsearch 5 release artifacts not published to Maven central

2017-06-07 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-6812. --- Resolution: Fixed Fix Version/s: 1.4.0 Resolved for 1.4 in

[GitHub] flink issue #4081: [FLINK-6844] [scala] Implement compatibility methods for ...

2017-06-07 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4081 Tested this with a stateful job that uses Scala collections as state. Merging this .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #4079: [FLINK-6853] [DataStream] Let StreamRecordSerializer be c...

2017-06-07 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4079 The test results in #4073 covers this change and results are green. Since #4073 is not really a real blocker for 1.3.1, while this fix is to allow CEP migration from 1.1, I'll merge this

[jira] [Commented] (FLINK-6853) Migrating from Flink 1.1 fails for FlinkCEP

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040682#comment-16040682 ] ASF GitHub Bot commented on FLINK-6853: --- Github user tzulitai commented on the issue:

[jira] [Updated] (FLINK-6742) Improve error message when savepoint migration fails due to task removal

2017-06-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6742: Summary: Improve error message when savepoint migration fails due to task removal (was:

[jira] [Assigned] (FLINK-6742) Improve error message when savepoint migration fails due to task removal

2017-06-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6742: --- Assignee: Chesnay Schepler > Improve error message when savepoint migration fails

[jira] [Commented] (FLINK-6783) Wrongly extracted TypeInformations for WindowedStream::aggregate

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040611#comment-16040611 ] ASF GitHub Bot commented on FLINK-6783: --- Github user dawidwys commented on the issue:

[jira] [Commented] (FLINK-6788) Remove unused GenericFlatTypePostPass/AbstractSchema class

2017-06-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040655#comment-16040655 ] Chesnay Schepler commented on FLINK-6788: - [~wm624] I've given you contributor permissions, you

[jira] [Commented] (FLINK-6830) Add ITTests for savepoint migration from 1.3

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040676#comment-16040676 ] ASF GitHub Bot commented on FLINK-6830: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4059: [FLINK-6830] Add StatefulJobSavepointFrom13MigrationITCas...

2017-06-07 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4059 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-6834) Over window doesn't support complex calculation

2017-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040683#comment-16040683 ] ASF GitHub Bot commented on FLINK-6834: --- Github user fhueske commented on a diff in the pull

  1   2   3   >