[jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323756#comment-16323756 ] ASF GitHub Bot commented on FLINK-8306: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5284: [FLINK-8306] [kafka, tests] Fix invalid mock verification...

2018-01-12 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5284 Yes, I've fixed that checkstyle on my local pre-merge branch 👌 ---

[GitHub] flink issue #5233: [FLINK-8348] [flip6] Print help for DefaultCLI

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5233 Thanks for the review @GJL. Merging this PR once Travis gives green light. ---

[jira] [Commented] (FLINK-8348) Print help for DefaultCLI

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323807#comment-16323807 ] ASF GitHub Bot commented on FLINK-8348: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323753#comment-16323753 ] ASF GitHub Bot commented on FLINK-8306: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5284: [FLINK-8306] [kafka, tests] Fix invalid mock verif...

2018-01-12 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5284#discussion_r161176765 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java --- @@

[GitHub] flink issue #5232: [FLINK-8347] [flip6] Make cluster id used by ClusterDescr...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5232 Thanks a lot for the review @GJL. Rebased onto the latest master. Merging once Travis gives green light. ---

[jira] [Commented] (FLINK-8347) Make Cluster id typesafe

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323798#comment-16323798 ] ASF GitHub Bot commented on FLINK-8347: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-8119) Cannot submit jobs to YARN Session in FLIP-6 mode

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323812#comment-16323812 ] ASF GitHub Bot commented on FLINK-8119: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5234: [FLINK-8119] [flip6] Wire correct Flip6 components in Fli...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5234 Thanks for the review @GJL. Rebased onto the latest master. Merging once Travis gives green light. ---

[GitHub] flink issue #5124: [FLINK-8199] [elasticsearch connector] Properly annotate ...

2018-01-12 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5124 Since there are no other objections, merging this now. ---

[jira] [Commented] (FLINK-8199) Annotation for Elasticsearch connector

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323751#comment-16323751 ] ASF GitHub Bot commented on FLINK-8199: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323765#comment-16323765 ] ASF GitHub Bot commented on FLINK-7511: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-8201) YarnResourceManagerTest causes license checking failure

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323828#comment-16323828 ] ASF GitHub Bot commented on FLINK-8201: --- Github user tillrohrmann commented on the issue:

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-12 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r161179351 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to the

[jira] [Commented] (FLINK-8369) Port SubtaskExecutionAttemptAccumulatorsHandler to new REST endpoint

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323784#comment-16323784 ] ASF GitHub Bot commented on FLINK-8369: --- GitHub user ifndef-SleePy opened a pull request:

[GitHub] flink pull request #5285: [FLINK-8369] [REST] Migrate SubtaskExecutionAttemp...

2018-01-12 Thread ifndef-SleePy
GitHub user ifndef-SleePy opened a pull request: https://github.com/apache/flink/pull/5285 [FLINK-8369] [REST] Migrate SubtaskExecutionAttemptAccumulatorsHandler to new a REST handler ## What is the purpose of the change * Migrate 

[GitHub] flink issue #5123: [FLINK-8201] YarnResourceManagerTest causes license check...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5123 Thanks for the update @wenlong88. The fix looks good to me. Merging this PR once Travis gives green light. ---

[jira] [Reopened] (FLINK-8022) Kafka at-least-once tests fail occasionally

2018-01-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reopened FLINK-8022: -- Problem seems not to be fully resolved: https://travis-ci.org/apache/flink/jobs/328040753 > Kafka

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324006#comment-16324006 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324007#comment-16324007 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Assigned] (FLINK-8367) Port SubtaskCurrentAttemptDetailsHandler to new REST endpoint

2018-01-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8367: --- Assignee: Gary Yao (was: Biao Liu) > Port SubtaskCurrentAttemptDetailsHandler to new REST endpoint

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323999#comment-16323999 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324005#comment-16324005 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324002#comment-16324002 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324003#comment-16324003 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324004#comment-16324004 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324008#comment-16324008 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161236268 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java --- @@ -0,0 +1,337 @@ +/* + *

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161242236 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java --- @@ -294,44 +306,108 @@ public void

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161242245 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java --- @@ -294,44 +306,108 @@ public void

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324079#comment-16324079 ] ASF GitHub Bot commented on FLINK-8317: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161242312 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/savepoints/SavepointInfoTest.java --- @@ -0,0 +1,52 @@ +/* + *

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324077#comment-16324077 ] ASF GitHub Bot commented on FLINK-8317: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324081#comment-16324081 ] ASF GitHub Bot commented on FLINK-8317: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161242316 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlersTest.java --- @@ -0,0 +1,277 @@ +/* + *

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324078#comment-16324078 ] ASF GitHub Bot commented on FLINK-8317: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161242267 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -185,37 +205,19 @@ private void submitJob(JobGraph

[jira] [Commented] (FLINK-8417) Support STSAssumeRoleSessionCredentialsProvider in FlinkKinesisConsumer

2018-01-12 Thread Sreenath Kodedala (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324096#comment-16324096 ] Sreenath Kodedala commented on FLINK-8417: -- STSAssumeRole requires Role ARN to assume and

[jira] [Assigned] (FLINK-8369) Port SubtaskExecutionAttemptAccumulatorsHandler to new REST endpoint

2018-01-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8369: --- Assignee: Gary Yao (was: Biao Liu) > Port SubtaskExecutionAttemptAccumulatorsHandler to new REST

[jira] [Assigned] (FLINK-7858) Port JobVertexTaskManagersHandler to REST endpoint

2018-01-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-7858: --- Assignee: Fang Yong (was: Gary Yao) > Port JobVertexTaskManagersHandler to REST endpoint >

[jira] [Assigned] (FLINK-7858) Port JobVertexTaskManagersHandler to REST endpoint

2018-01-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-7858: --- Assignee: Gary Yao (was: Fang Yong) > Port JobVertexTaskManagersHandler to REST endpoint >

[jira] [Assigned] (FLINK-8289) The RestServerEndpoint should return the address with real ip when getRestAdddress

2018-01-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-8289: Assignee: shuai.xu > The RestServerEndpoint should return the address with real ip when >

[GitHub] flink pull request #5288: [FLINK-8395][network] add a read-only sliced ByteB...

2018-01-12 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5288 [FLINK-8395][network] add a read-only sliced ByteBuf implementation based on NetworkBuffer ## What is the purpose of the change To insert the same buffer (or sub-regions from it) multiple

[jira] [Commented] (FLINK-8022) Kafka at-least-once tests fail occasionally

2018-01-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324052#comment-16324052 ] Till Rohrmann commented on FLINK-8022: -- Another instance:

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324001#comment-16324001 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Assigned] (FLINK-8367) Port SubtaskCurrentAttemptDetailsHandler to new REST endpoint

2018-01-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8367: --- Assignee: Biao Liu (was: Gary Yao) > Port SubtaskCurrentAttemptDetailsHandler to new REST endpoint

[jira] [Assigned] (FLINK-8369) Port SubtaskExecutionAttemptAccumulatorsHandler to new REST endpoint

2018-01-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8369: --- Assignee: Biao Liu (was: Gary Yao) > Port SubtaskExecutionAttemptAccumulatorsHandler to new REST

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324022#comment-16324022 ] ASF GitHub Bot commented on FLINK-8317: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161234791 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -185,37 +205,19 @@ private void submitJob(JobGraph

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324084#comment-16324084 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Created] (FLINK-8422) Checkstyle for org.apache.flink.api.java.tuple

2018-01-12 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-8422: - Summary: Checkstyle for org.apache.flink.api.java.tuple Key: FLINK-8422 URL: https://issues.apache.org/jira/browse/FLINK-8422 Project: Flink Issue Type:

[jira] [Comment Edited] (FLINK-8417) Support STSAssumeRoleSessionCredentialsProvider in FlinkKinesisConsumer

2018-01-12 Thread Sreenath Kodedala (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324096#comment-16324096 ] Sreenath Kodedala edited comment on FLINK-8417 at 1/12/18 4:33 PM: ---

[jira] [Commented] (FLINK-8414) Gelly performance seriously decreases when using the suggested parallelism configuration

2018-01-12 Thread flora karniav (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324228#comment-16324228 ] flora karniav commented on FLINK-8414: -- Thank you for your reply, I am running the

[jira] [Assigned] (FLINK-7711) Port JarListHandler to new REST endpoint

2018-01-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-7711: --- Assignee: Gary Yao (was: Fang Yong) > Port JarListHandler to new REST endpoint >

[jira] [Assigned] (FLINK-7711) Port JarListHandler to new REST endpoint

2018-01-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-7711: --- Assignee: Fang Yong (was: Gary Yao) > Port JarListHandler to new REST endpoint >

[jira] [Assigned] (FLINK-7857) Port JobVertexDetails to REST endpoint

2018-01-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-7857: --- Assignee: Fang Yong (was: Gary Yao) > Port JobVertexDetails to REST endpoint >

[GitHub] flink issue #5170: [FLINK-8266] [runtime] add network memory to ResourceProf...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5170 Thanks for the contribution @shuai-xu. There are some merge conflicts. Could you please resolve them? ---

[jira] [Commented] (FLINK-8266) Add network memory to ResourceProfile

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324089#comment-16324089 ] ASF GitHub Bot commented on FLINK-8266: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-8414) Gelly performance seriously decreases when using the suggested parallelism configuration

2018-01-12 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324133#comment-16324133 ] Greg Hogan commented on FLINK-8414: --- This is more of a question than a reported bug and may be more

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324000#comment-16324000 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161230366 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/savepoints/SavepointInfoTest.java --- @@ -0,0 +1,52 @@ +/* +

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324032#comment-16324032 ] ASF GitHub Bot commented on FLINK-8317: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161238338 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java --- @@ -0,0 +1,337 @@ +/* + *

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161243072 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java --- @@ -0,0 +1,337 @@ +/* +

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161243207 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java --- @@ -137,4 +138,21 @@ JobID

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324087#comment-16324087 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324118#comment-16324118 ] ASF GitHub Bot commented on FLINK-8399: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324119#comment-16324119 ] ASF GitHub Bot commented on FLINK-8399: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324115#comment-16324115 ] ASF GitHub Bot commented on FLINK-8399: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324117#comment-16324117 ] ASF GitHub Bot commented on FLINK-8399: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324113#comment-16324113 ] ASF GitHub Bot commented on FLINK-8399: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5289: [hotfix] [docs] Fix typos

2018-01-12 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/5289 [hotfix] [docs] Fix typos From the IntelliJ `Typos` inspection. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[jira] [Commented] (FLINK-8417) Support STSAssumeRoleSessionCredentialsProvider in FlinkKinesisConsumer

2018-01-12 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324202#comment-16324202 ] Tzu-Li (Gordon) Tai commented on FLINK-8417: Fro the Javadocs, it mentions that the

[jira] [Commented] (FLINK-8417) Support STSAssumeRoleSessionCredentialsProvider in FlinkKinesisConsumer

2018-01-12 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324204#comment-16324204 ] Tzu-Li (Gordon) Tai commented on FLINK-8417: The Role ARN for the Temporary Credentials should

[jira] [Comment Edited] (FLINK-8417) Support STSAssumeRoleSessionCredentialsProvider in FlinkKinesisConsumer

2018-01-12 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324202#comment-16324202 ] Tzu-Li (Gordon) Tai edited comment on FLINK-8417 at 1/12/18 4:36 PM: -

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161220157 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java --- @@ -294,44 +306,108 @@ public void

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161228758 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java --- @@ -27,11 +27,16 @@ import

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161218205 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -185,37 +205,19 @@ private void

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161220129 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java --- @@ -294,44 +306,108 @@ public void

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161224329 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java --- @@ -0,0 +1,337 @@ +/* +

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161228957 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlersTest.java --- @@ -0,0 +1,277 @@ +/*

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161229580 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlersTest.java --- @@ -0,0 +1,277 @@ +/*

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161230839 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java --- @@ -137,4 +138,21 @@ JobID

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161224559 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java --- @@ -0,0 +1,337 @@ +/* +

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324039#comment-16324039 ] ASF GitHub Bot commented on FLINK-8317: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324083#comment-16324083 ] ASF GitHub Bot commented on FLINK-8317: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161242967 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java --- @@ -0,0 +1,337 @@ +/* +

[jira] [Created] (FLINK-8421) HeapInternalTimerService should reconfigure compatible key / namespace serializers on restore

2018-01-12 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-8421: -- Summary: HeapInternalTimerService should reconfigure compatible key / namespace serializers on restore Key: FLINK-8421 URL:

[jira] [Created] (FLINK-8423) OperatorChain#pushToOperator catch block may fail with NPE

2018-01-12 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-8423: --- Summary: OperatorChain#pushToOperator catch block may fail with NPE Key: FLINK-8423 URL: https://issues.apache.org/jira/browse/FLINK-8423 Project: Flink

[jira] [Closed] (FLINK-7747) remove the ResultPartitionWriter wrapper

2018-01-12 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-7747. -- Resolution: Fixed Fix Version/s: 1.5.0 > remove the ResultPartitionWriter wrapper >

[jira] [Updated] (FLINK-7746) move ResultPartitionWriter#writeBufferToAllChannels up into ResultPartition

2018-01-12 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-7746: --- Fix Version/s: (was: 1.5.0) > move ResultPartitionWriter#writeBufferToAllChannels up into

[jira] [Closed] (FLINK-7746) move ResultPartitionWriter#writeBufferToAllChannels up into ResultPartition

2018-01-12 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber closed FLINK-7746. -- Resolution: Won't Do > move ResultPartitionWriter#writeBufferToAllChannels up into ResultPartition >

[jira] [Commented] (FLINK-8395) Create (derived) sliced Buffer class

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324016#comment-16324016 ] ASF GitHub Bot commented on FLINK-8395: --- GitHub user NicoK opened a pull request:

[jira] [Commented] (FLINK-8289) The RestServerEndpoint should return the address with real ip when getRestAdddress

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324059#comment-16324059 ] ASF GitHub Bot commented on FLINK-8289: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5190: [FLINK-8289] [runtime] set the rest.address to the host o...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5190 I agree with @EronWright. We should introduce an `RestOptions#BIND_ADDRESS` which defaults to `0.0.0.0` and a `RestOptions#ADDRESS` which contains the advertised address under which the

[jira] [Commented] (FLINK-8288) Register the web interface url to yarn for yarn job mode

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324102#comment-16324102 ] ASF GitHub Bot commented on FLINK-8288: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5186: [FLINK-8288] [runtime] register job master rest endpoint ...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5186 Thanks for the contribution @shuai-xu and the review @NicoK. Merging this PR. ---

[jira] [Commented] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324114#comment-16324114 ] ASF GitHub Bot commented on FLINK-8399: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324116#comment-16324116 ] ASF GitHub Bot commented on FLINK-8399: --- Github user tillrohrmann commented on a diff in the pull

  1   2   3   >