[GitHub] flink pull request #5281: [FLINK-7938] [State Backend] support addAll() in L...

2018-01-16 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5281#discussion_r161905498 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java --- @@ -167,24 +167,48 @@

[jira] [Created] (FLINK-8441) serialize values and value separator directly to stream in RocksDBListState

2018-01-16 Thread Bowen Li (JIRA)
Bowen Li created FLINK-8441: --- Summary: serialize values and value separator directly to stream in RocksDBListState Key: FLINK-8441 URL: https://issues.apache.org/jira/browse/FLINK-8441 Project: Flink

[jira] [Updated] (FLINK-8441) serialize values and value separator directly to stream in RocksDBListState

2018-01-16 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8441: Affects Version/s: 1.5.0 > serialize values and value separator directly to stream in RocksDBListState >

[jira] [Commented] (FLINK-7938) support addAll() in ListState

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327907#comment-16327907 ] ASF GitHub Bot commented on FLINK-7938: --- Github user bowenli86 commented on a diff in the pull

[jira] [Updated] (FLINK-8441) serialize values and value separator directly to stream in RocksDBListState

2018-01-16 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8441: Fix Version/s: 1.5.0 > serialize values and value separator directly to stream in RocksDBListState >

[jira] [Resolved] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2018-01-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8175. -- Resolution: Fixed Fixed via 907361d862c77a70ff60d27e7fcc13647eac0e6d > remove

[GitHub] flink pull request #5112: [FLINK-8175] [DataStream API java/scala] remove fl...

2018-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5112 ---

[jira] [Commented] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326861#comment-16326861 ] ASF GitHub Bot commented on FLINK-8175: --- Github user asfgit closed the pull request at:

[jira] [Created] (FLINK-8436) Allow implementing both RetractTableSink and BatchTableSink in one class

2018-01-16 Thread Timo Walther (JIRA)
Timo Walther created FLINK-8436: --- Summary: Allow implementing both RetractTableSink and BatchTableSink in one class Key: FLINK-8436 URL: https://issues.apache.org/jira/browse/FLINK-8436 Project: Flink

[GitHub] flink pull request #5057: [FLINK-8049] [FLINK-8050] REST client/server repor...

2018-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5057 ---

[jira] [Commented] (FLINK-8049) RestClient#shutdown() ignores exceptions thrown when shutting down netty.

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326974#comment-16326974 ] ASF GitHub Bot commented on FLINK-8049: --- Github user asfgit closed the pull request at:

[jira] [Updated] (FLINK-8187) Web client does not print errors

2018-01-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8187: Description: When submitting a jar with no defined Main class, the web client does not

[GitHub] flink pull request #5281: [FLINK-7938] [State Backend] support addAll() in L...

2018-01-16 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5281#discussion_r161694419 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java --- @@ -167,24

[jira] [Commented] (FLINK-7938) support addAll() in ListState

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326911#comment-16326911 ] ASF GitHub Bot commented on FLINK-7938: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-7938) support addAll() in ListState

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326905#comment-16326905 ] ASF GitHub Bot commented on FLINK-7938: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-7938) support addAll() in ListState

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326906#comment-16326906 ] ASF GitHub Bot commented on FLINK-7938: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5281: [FLINK-7938] [State Backend] support addAll() in L...

2018-01-16 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5281#discussion_r161693241 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java --- @@

[GitHub] flink pull request #5281: [FLINK-7938] [State Backend] support addAll() in L...

2018-01-16 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5281#discussion_r161693211 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java ---

[jira] [Commented] (FLINK-8436) Allow implementing both RetractTableSink and BatchTableSink in one class

2018-01-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326963#comment-16326963 ] Fabian Hueske commented on FLINK-8436: -- +1 > Allow implementing both RetractTableSink and

[jira] [Updated] (FLINK-8436) Allow implementing both RetractTableSink and BatchTableSink in one class

2018-01-16 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-8436: Description: When implementing a table sink that should have the functionality of both a

[jira] [Closed] (FLINK-8050) RestServer#shutdown() ignores exceptions thrown when shutting down netty.

2018-01-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-8050. - Resolution: Fixed Fix Version/s: 1.5.0 Merged with 

[jira] [Closed] (FLINK-8049) RestClient#shutdown() ignores exceptions thrown when shutting down netty.

2018-01-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-8049. - Resolution: Fixed Fix Version/s: 1.5.0 Merged with 

[GitHub] flink pull request #:

2018-01-16 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/907361d862c77a70ff60d27e7fcc13647eac0e6d#commitcomment-26885301 In flink-streaming-java/src/main/java/org/apache/flink/streaming/experimental/CollectSink.java: In

[jira] [Closed] (FLINK-8414) Gelly performance seriously decreases when using the suggested parallelism configuration

2018-01-16 Thread flora karniav (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] flora karniav closed FLINK-8414. Resolution: Feedback Received > Gelly performance seriously decreases when using the suggested

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2018-01-16 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/5172#discussion_r161818655 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityUtils.java --- @@ -48,7 +48,7 @@ public static SecurityContext

[jira] [Created] (FLINK-8440) Create Gitter Chanel for Flink users

2018-01-16 Thread Josh Lemer (JIRA)
Josh Lemer created FLINK-8440: - Summary: Create Gitter Chanel for Flink users Key: FLINK-8440 URL: https://issues.apache.org/jira/browse/FLINK-8440 Project: Flink Issue Type: Task

[jira] [Commented] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327369#comment-16327369 ] ASF GitHub Bot commented on FLINK-8275: --- Github user EronWright commented on a diff in the pull

[jira] [Assigned] (FLINK-8354) Flink Kafka connector ignores Kafka message headers

2018-01-16 Thread Aegeaner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aegeaner reassigned FLINK-8354: --- Assignee: Aegeaner > Flink Kafka connector ignores Kafka message headers >

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2018-01-16 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/5172#discussion_r161821092 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java --- @@ -126,12 +124,6 @@ public static void

[jira] [Commented] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327379#comment-16327379 ] ASF GitHub Bot commented on FLINK-8275: --- Github user EronWright commented on a diff in the pull

[jira] [Commented] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327389#comment-16327389 ] ASF GitHub Bot commented on FLINK-8275: --- Github user EronWright commented on a diff in the pull

[jira] [Assigned] (FLINK-8435) Adding BloomFilter/HyperLogLog state as Managed once

2018-01-16 Thread Aegeaner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aegeaner reassigned FLINK-8435: --- Assignee: Aegeaner > Adding BloomFilter/HyperLogLog state as Managed once >

[jira] [Commented] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327388#comment-16327388 ] ASF GitHub Bot commented on FLINK-8275: --- Github user EronWright commented on a diff in the pull

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2018-01-16 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/5172#discussion_r161822214 --- Diff: flink-yarn/src/test/resources/flink-conf.yaml --- @@ -0,0 +1,23 @@

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2018-01-16 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/5172#discussion_r161822100 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java --- @@ -142,19 +134,22 @@ public static void

[GitHub] flink issue #5302: [FLINK-7777][build] Bump japicmp to 0.11.0

2018-01-16 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5302 merging. ---

[jira] [Comment Edited] (FLINK-8290) Modify clientId to groupId in flink-connector-kafka-0.8

2018-01-16 Thread xymaqingxiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327118#comment-16327118 ] xymaqingxiang edited comment on FLINK-8290 at 1/16/18 1:33 PM: --- The

[jira] [Commented] (FLINK-8290) Modify clientId to groupId in flink-connector-kafka-0.8

2018-01-16 Thread xymaqingxiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327118#comment-16327118 ] xymaqingxiang commented on FLINK-8290: -- The description of “client.id” is “An id string to pass to

[jira] [Created] (FLINK-8438) Ensure that implicit Scala TypeInformation works in Eclipse IDE

2018-01-16 Thread Timo Walther (JIRA)
Timo Walther created FLINK-8438: --- Summary: Ensure that implicit Scala TypeInformation works in Eclipse IDE Key: FLINK-8438 URL: https://issues.apache.org/jira/browse/FLINK-8438 Project: Flink

[jira] [Comment Edited] (FLINK-4940) Add support for broadcast state

2018-01-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327201#comment-16327201 ] Kostas Kloudas edited comment on FLINK-4940 at 1/16/18 2:59 PM: "We

[jira] [Closed] (FLINK-7604) Add OpenTSDB metrics reporter

2018-01-16 Thread Hai Zhou UTC+8 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hai Zhou UTC+8 closed FLINK-7604. - Resolution: Won't Do Fix Version/s: (was: 1.5.0) > Add OpenTSDB metrics reporter >

[jira] [Created] (FLINK-8439) Document using a custom AWS Credentials Provider with flink-3s-fs-hadoop

2018-01-16 Thread Dyana Rose (JIRA)
Dyana Rose created FLINK-8439: - Summary: Document using a custom AWS Credentials Provider with flink-3s-fs-hadoop Key: FLINK-8439 URL: https://issues.apache.org/jira/browse/FLINK-8439 Project: Flink

[GitHub] flink pull request #5302: [FLINK-7777][build] Bump japicmp to 0.11.0

2018-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5302 ---

[jira] [Closed] (FLINK-7777) Bump japicmp to 0.11.0

2018-01-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-. --- Resolution: Fixed master: 988bdde17fec8896aae4bc041a10d5e30a4cb702 > Bump japicmp to 0.11.0

[jira] [Commented] (FLINK-7777) Bump japicmp to 0.11.0

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327072#comment-16327072 ] ASF GitHub Bot commented on FLINK-: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8290) Modify clientId to groupId in flink-connector-kafka-0.8

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327130#comment-16327130 ] ASF GitHub Bot commented on FLINK-8290: --- GitHub user maqingxiang opened a pull request:

[jira] [Assigned] (FLINK-4940) Add support for broadcast state

2018-01-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-4940: - Assignee: Kostas Kloudas > Add support for broadcast state >

[jira] [Commented] (FLINK-8438) Ensure that implicit Scala TypeInformation works in Eclipse IDE

2018-01-16 Thread David Anderson (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327197#comment-16327197 ] David Anderson commented on FLINK-8438: --- This code (adapted from the Flink scala quickstart)

[jira] [Commented] (FLINK-4940) Add support for broadcast state

2018-01-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327201#comment-16327201 ] Kostas Kloudas commented on FLINK-4940: --- "We therefore only have to checkpoint the state of one

[jira] [Comment Edited] (FLINK-4940) Add support for broadcast state

2018-01-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327201#comment-16327201 ] Kostas Kloudas edited comment on FLINK-4940 at 1/16/18 2:58 PM: "We

[jira] [Comment Edited] (FLINK-4940) Add support for broadcast state

2018-01-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327201#comment-16327201 ] Kostas Kloudas edited comment on FLINK-4940 at 1/16/18 3:01 PM: "We

[jira] [Reopened] (FLINK-7364) Log exceptions from user code in streaming jobs

2018-01-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reopened FLINK-7364: - Just ran into this on master, will investigate in which circumstances this happens. Neither

[GitHub] flink issue #5292: [FLINK-8422] [core] Checkstyle for org.apache.flink.api.j...

2018-01-16 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/5292 Looks good to me. +1 ---

[jira] [Commented] (FLINK-8422) Checkstyle for org.apache.flink.api.java.tuple

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327217#comment-16327217 ] ASF GitHub Bot commented on FLINK-8422: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #5303: [hotfix][docs] Adjust RocksDb dependency docs

2018-01-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5303 I would suggest to start thinking about the dependencies the following way: - There are pure user-code projects where the Flink runtime is "provided" and they are started using an

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-01-16 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5295#discussion_r161799387 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicProcessingTimeSessionWindows.java --- @@ -0,0

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327324#comment-16327324 ] ASF GitHub Bot commented on FLINK-8384: --- Github user dyanarose commented on a diff in the pull

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327326#comment-16327326 ] ASF GitHub Bot commented on FLINK-8384: --- Github user dyanarose commented on a diff in the pull

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327322#comment-16327322 ] ASF GitHub Bot commented on FLINK-8384: --- Github user dyanarose commented on a diff in the pull

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327323#comment-16327323 ] ASF GitHub Bot commented on FLINK-8384: --- Github user dyanarose commented on a diff in the pull

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327325#comment-16327325 ] ASF GitHub Bot commented on FLINK-8384: --- Github user dyanarose commented on a diff in the pull

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-01-16 Thread dyanarose
Github user dyanarose commented on a diff in the pull request: https://github.com/apache/flink/pull/5295#discussion_r161807828 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicEventTimeSessionWindows.java --- @@ -0,0 +1,101 @@

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-01-16 Thread dyanarose
Github user dyanarose commented on a diff in the pull request: https://github.com/apache/flink/pull/5295#discussion_r161807850 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicProcessingTimeSessionWindows.java --- @@ -0,0

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-01-16 Thread dyanarose
Github user dyanarose commented on a diff in the pull request: https://github.com/apache/flink/pull/5295#discussion_r161807869 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicProcessingTimeSessionWindows.java --- @@ -0,0

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-01-16 Thread dyanarose
Github user dyanarose commented on a diff in the pull request: https://github.com/apache/flink/pull/5295#discussion_r161807837 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicEventTimeSessionWindows.java --- @@ -0,0 +1,101 @@

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327310#comment-16327310 ] ASF GitHub Bot commented on FLINK-8384: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-01-16 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5295#discussion_r161799107 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicEventTimeSessionWindows.java --- @@ -0,0

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-01-16 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5295#discussion_r161800866 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SessionWindowTimeGapExtractor.java --- @@ -0,0 +1,30

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327309#comment-16327309 ] ASF GitHub Bot commented on FLINK-8384: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-01-16 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5295#discussion_r161799438 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicProcessingTimeSessionWindows.java --- @@ -0,0

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327307#comment-16327307 ] ASF GitHub Bot commented on FLINK-8384: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327308#comment-16327308 ] ASF GitHub Bot commented on FLINK-8384: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-01-16 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5295#discussion_r161798960 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicEventTimeSessionWindows.java --- @@ -0,0

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327306#comment-16327306 ] ASF GitHub Bot commented on FLINK-8384: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-01-16 Thread dyanarose
Github user dyanarose commented on a diff in the pull request: https://github.com/apache/flink/pull/5295#discussion_r161807900 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SessionWindowTimeGapExtractor.java --- @@ -0,0 +1,30 @@

[GitHub] flink pull request #4649: [FLINK-6116] Watermarks don't work when unioning w...

2018-01-16 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4649#discussion_r161795511 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -183,6 +183,14 @@ public Long map(Long value)

[GitHub] flink pull request #4649: [FLINK-6116] Watermarks don't work when unioning w...

2018-01-16 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4649#discussion_r161799381 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java --- @@ -624,6 +633,10 @@ public long

[jira] [Commented] (FLINK-6116) Watermarks don't work when unioning with same DataStream

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327279#comment-16327279 ] ASF GitHub Bot commented on FLINK-6116: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4649: [FLINK-6116] Watermarks don't work when unioning w...

2018-01-16 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4649#discussion_r161799248 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -183,6 +183,14 @@ public Long map(Long value)

[jira] [Commented] (FLINK-6116) Watermarks don't work when unioning with same DataStream

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327284#comment-16327284 ] ASF GitHub Bot commented on FLINK-6116: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4649: [FLINK-6116] Watermarks don't work when unioning w...

2018-01-16 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4649#discussion_r161793648 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTaskTestHarness.java --- @@ -143,7 +144,8 @@

[jira] [Commented] (FLINK-6116) Watermarks don't work when unioning with same DataStream

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327281#comment-16327281 ] ASF GitHub Bot commented on FLINK-6116: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-6116) Watermarks don't work when unioning with same DataStream

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327280#comment-16327280 ] ASF GitHub Bot commented on FLINK-6116: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-6116) Watermarks don't work when unioning with same DataStream

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327283#comment-16327283 ] ASF GitHub Bot commented on FLINK-6116: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4649: [FLINK-6116] Watermarks don't work when unioning w...

2018-01-16 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4649#discussion_r161793609 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTaskTestHarness.java --- @@ -127,7 +127,8 @@

[GitHub] flink pull request #4649: [FLINK-6116] Watermarks don't work when unioning w...

2018-01-16 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4649#discussion_r161791264 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java --- @@ -411,6 +413,13 @@ private void

[GitHub] flink pull request #4649: [FLINK-6116] Watermarks don't work when unioning w...

2018-01-16 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4649#discussion_r161797181 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java --- @@ -411,6 +413,13 @@ private void

[jira] [Commented] (FLINK-6116) Watermarks don't work when unioning with same DataStream

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327285#comment-16327285 ] ASF GitHub Bot commented on FLINK-6116: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-6116) Watermarks don't work when unioning with same DataStream

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327282#comment-16327282 ] ASF GitHub Bot commented on FLINK-6116: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4649: [FLINK-6116] Watermarks don't work when unioning w...

2018-01-16 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4649#discussion_r161797751 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java --- @@ -60,17 +60,23 @@ */ private

[jira] [Commented] (FLINK-6116) Watermarks don't work when unioning with same DataStream

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327278#comment-16327278 ] ASF GitHub Bot commented on FLINK-6116: --- Github user pnowojski commented on a diff in the pull

[jira] [Reopened] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-16 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang reopened FLINK-7456: - > Implement Netty sender incoming pipeline for credit-based >

[GitHub] flink issue #4552: [FLINK-7456][network] Implement Netty sender incoming pip...

2018-01-16 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4552 @NicoK , I have submitted the switch for keeping the old mode and the new credit-based mode. ---

[jira] [Closed] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-16 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang closed FLINK-7456. --- Resolution: Fixed > Implement Netty sender incoming pipeline for credit-based >

[jira] [Closed] (FLINK-7468) Implement sender backlog logic for credit-based

2018-01-16 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang closed FLINK-7468. --- Resolution: Fixed > Implement sender backlog logic for credit-based >

[jira] [Commented] (FLINK-8431) Allow to specify # GPUs for TaskManager in Mesos

2018-01-16 Thread Dongwon Kim (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328386#comment-16328386 ] Dongwon Kim commented on FLINK-8431: [~eronwright] I'm testing my implementation by launching a

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328393#comment-16328393 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on the issue:

[jira] [Updated] (FLINK-8437) SideOutput() API is ambiguous

2018-01-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8437: Description: The current API for retrieving Side Outputs is a bit ambiguous. Consider the

[GitHub] flink pull request #5304: [FLINK-8290]Modify clientId to groupId in flink-co...

2018-01-16 Thread maqingxiang
GitHub user maqingxiang opened a pull request: https://github.com/apache/flink/pull/5304 [FLINK-8290]Modify clientId to groupId in flink-connector-kafka-0.8 Now the Clientid that consumes the all topics are constant("flink-kafka-consumer-legacy-" + broker.id()), and it is not easy

[jira] [Commented] (FLINK-7777) Bump japicmp to 0.11.0

2018-01-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327066#comment-16327066 ] ASF GitHub Bot commented on FLINK-: --- Github user zentol commented on the issue:

  1   2   >