[jira] [Commented] (FLINK-9421) RunningJobsRegistry entries are not cleaned up after job termination

2018-05-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488085#comment-16488085 ] Till Rohrmann commented on FLINK-9421: -- Sorry [~yanghua], I actually have a fix ready but did not see

[jira] [Commented] (FLINK-9422) Dedicated operator for UNION on streaming tables with time attributes

2018-05-23 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487968#comment-16487968 ] Rong Rong commented on FLINK-9422: -- +1 on "can apply windowed aggregates on the result". This would make

[GitHub] flink issue #5964: [FLINK-8655] [Cassandra Connector] add keyspace in cassan...

2018-05-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5964 That the example doesn't work isn't related to this PR so I'll merge it as is. But I'll take a look what the problem is, and either fix it or open a JIRA. ---

[jira] [Commented] (FLINK-8655) Add a default keyspace to CassandraSink

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486808#comment-16486808 ] ASF GitHub Bot commented on FLINK-8655: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-9383) Extend DistributedCache E2E test to cover directories

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486838#comment-16486838 ] ASF GitHub Bot commented on FLINK-9383: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #6023: [FLINK-9383][runtime] Test directories in Distribu...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6023#discussion_r190144815 --- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh --- @@ -93,6 +93,14 @@ if [ $EXIT_CODE == 0 ]; then EXIT_CODE=$? fi +if [

[GitHub] flink issue #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer Backpr...

2018-05-23 Thread fmthoma
Github user fmthoma commented on the issue: https://github.com/apache/flink/pull/6021 @tzulitai I believe the right location is `docs/dev/connectors/kinesis.md`? I'll add some docs there. ---

[GitHub] flink issue #5650: [FLINK-8845][state] Introduce RocksDBWriteBatchWrapper to...

2018-05-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5650 @sihuazhou thanks for this nice contribution. LGTM 👍 Will merge. ---

[GitHub] flink issue #6027: [FLINK-7814][TableAPI && SQL] Add BETWEEN and NOT BETWEEN...

2018-05-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6027 Thanks for the update @Xpray. I will merge this... ---

[jira] [Commented] (FLINK-7814) Add BETWEEN and NOT BETWEEN expression to Table API

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486902#comment-16486902 ] ASF GitHub Bot commented on FLINK-7814: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5959: [FLINK-9258][metrics] Thread-safe initialization o...

2018-05-23 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5959#discussion_r190168697 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java --- @@ -57,11 +57,12 @@ public

[jira] [Commented] (FLINK-9258) ConcurrentModificationException in ComponentMetricGroup.getAllVariables

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486917#comment-16486917 ] ASF GitHub Bot commented on FLINK-9258: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-9344) Support INTERSECT and INTERSECT ALL for streaming

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486934#comment-16486934 ] ASF GitHub Bot commented on FLINK-9344: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #6059: [Flink-9418] Migrate SharedBuffer to use MapState

2018-05-23 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/6059 [Flink-9418] Migrate SharedBuffer to use MapState ## What is the purpose of the change Migrate `SharedBuffer` to `MapState` so to improve memory managment and decrease the amount of data

[GitHub] flink issue #6059: [Flink-9418] Migrate SharedBuffer to use MapState

2018-05-23 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6059 R: @kl0u ---

[GitHub] flink pull request #6041: [FLINK-9326] TaskManagerOptions.NUM_TASK_SLOTS doe...

2018-05-23 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6041#discussion_r190187802 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/LocalStreamEnvironment.java --- @@ -103,9 +103,16 @@ public

[jira] [Created] (FLINK-9422) Dedicated operator for UNION on streaming tables with time attributes

2018-05-23 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-9422: Summary: Dedicated operator for UNION on streaming tables with time attributes Key: FLINK-9422 URL: https://issues.apache.org/jira/browse/FLINK-9422 Project: Flink

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r190140724 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java --- @@ -26,20

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r190140597 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java --- @@ -26,20

[jira] [Commented] (FLINK-8944) Use ListShards for shard discovery in the flink kinesis connector

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486812#comment-16486812 ] ASF GitHub Bot commented on FLINK-8944: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8944) Use ListShards for shard discovery in the flink kinesis connector

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486811#comment-16486811 ] ASF GitHub Bot commented on FLINK-8944: --- Github user tzulitai commented on a diff in the pull

[jira] [Resolved] (FLINK-9349) KafkaConnector Exception while fetching from multiple kafka topics

2018-05-23 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-9349. Resolution: Fixed Fix Version/s: 1.5.1 1.4.3

[jira] [Updated] (FLINK-9416) Make job submission retriable operation in case of a ongoing leader election

2018-05-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-9416: - Fix Version/s: 1.5.1 1.6.0 > Make job submission retriable operation in case

[jira] [Created] (FLINK-9416) Make job submission retriable operation in case of a ongoing leader election

2018-05-23 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-9416: Summary: Make job submission retriable operation in case of a ongoing leader election Key: FLINK-9416 URL: https://issues.apache.org/jira/browse/FLINK-9416 Project:

[jira] [Commented] (FLINK-9303) Unassign partitions from Kafka client if partitions become unavailable

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486873#comment-16486873 ] ASF GitHub Bot commented on FLINK-9303: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-9303) Unassign partitions from Kafka client if partitions become unavailable

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486874#comment-16486874 ] ASF GitHub Bot commented on FLINK-9303: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-9303) Unassign partitions from Kafka client if partitions become unavailable

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486872#comment-16486872 ] ASF GitHub Bot commented on FLINK-9303: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5991: [FLINK-9303] [kafka] Adding support for unassign d...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5991#discussion_r190153528 --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --- @@

[GitHub] flink pull request #5991: [FLINK-9303] [kafka] Adding support for unassign d...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5991#discussion_r190150419 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -235,7

[GitHub] flink pull request #5991: [FLINK-9303] [kafka] Adding support for unassign d...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5991#discussion_r190152570 --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --- @@

[jira] [Created] (FLINK-9418) Migrate SharedBuffer to use MapState

2018-05-23 Thread Dawid Wysakowicz (JIRA)
Dawid Wysakowicz created FLINK-9418: --- Summary: Migrate SharedBuffer to use MapState Key: FLINK-9418 URL: https://issues.apache.org/jira/browse/FLINK-9418 Project: Flink Issue Type:

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-05-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r190156721 --- Diff: flink-end-to-end-tests/run-nightly-tests.sh --- @@ -30,168 +30,50 @@ if [ -z "$FLINK_DIR" ] ; then exit 1 fi -source

[jira] [Commented] (FLINK-9257) End-to-end tests prints "All tests PASS" even if individual test-script returns non-zero exit code

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486885#comment-16486885 ] ASF GitHub Bot commented on FLINK-9257: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...

2018-05-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5869 that shouldn't be possible, as all tasks are removed when a TM disassociates from the JM which also implies removing all metrics related to a specific task. ---

[jira] [Commented] (FLINK-8946) TaskManager stop sending metrics after JobManager failover

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486912#comment-16486912 ] ASF GitHub Bot commented on FLINK-8946: --- Github user yanghua commented on the issue:

[jira] [Commented] (FLINK-9258) ConcurrentModificationException in ComponentMetricGroup.getAllVariables

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486911#comment-16486911 ] ASF GitHub Bot commented on FLINK-9258: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...

2018-05-23 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5869 so I just remove the close method from `disassociateFromJobManager `? ---

[GitHub] flink issue #5959: [FLINK-9258][metrics] Thread-safe initialization of varia...

2018-05-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5959 I have two quick questions: - Why does `ComponentMetricGroup` even override the method `getAllVariables` from `AbstractMetricGroup` with essentially the exact same code? -Why is it

[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...

2018-05-23 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5869 @zentol normally, it seems you are right. But I don't know if there is any exception could cause any remained information, at the jm switching moment. ---

[jira] [Commented] (FLINK-8946) TaskManager stop sending metrics after JobManager failover

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486910#comment-16486910 ] ASF GitHub Bot commented on FLINK-8946: --- Github user yanghua commented on the issue:

[jira] [Commented] (FLINK-9349) KafkaConnector Exception while fetching from multiple kafka topics

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486925#comment-16486925 ] ASF GitHub Bot commented on FLINK-9349: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-9384) KafkaAvroTableSource failed to work due to type mismatch

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486930#comment-16486930 ] ASF GitHub Bot commented on FLINK-9384: --- Github user twalthr commented on a diff in the pull

[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...

2018-05-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5869 that should do the trick imo. ---

[jira] [Commented] (FLINK-9258) ConcurrentModificationException in ComponentMetricGroup.getAllVariables

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486950#comment-16486950 ] ASF GitHub Bot commented on FLINK-9258: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #5959: [FLINK-9258][metrics] Thread-safe initialization of varia...

2018-05-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5959 Sounds good. After the mentioned changes this looks ready to merge for me 👍 ---

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-05-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r190176842 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/KeyedProcessFunctionWithCleanupState.scala --- @@ -44,8

[jira] [Commented] (FLINK-6016) Newlines should be valid in quoted strings in CSV

2018-05-23 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486989#comment-16486989 ] Fabian Hueske commented on FLINK-6016: -- This problem cannot be solve with the current implementation

[jira] [Commented] (FLINK-8985) End-to-end test: CLI

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486843#comment-16486843 ] ASF GitHub Bot commented on FLINK-8985: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #6027: [FLINK-7814][TableAPI && SQL] Add BETWEEN and NOT ...

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6027 ---

[GitHub] flink issue #6040: [FLINK-9349][Kafka Connector] KafkaConnector Exception wh...

2018-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6040 Using `CheckedThread` is more preferable, as it simplifies some of the test code. But yes, the utility was introduced at a later point in time in Flink, so some parts of the test code might

[GitHub] flink issue #6007: [FLINK-8518][Table API & SQL] Support DOW for EXTRACT

2018-05-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6007 Thanks for the PR @snuyanzin. I created the issue because it seems that this is more than a one line change. I tested your queries in Postgres SQL and it returns 0 instead of 1. We should have the

[jira] [Created] (FLINK-9419) UNION should not be treated as retraction producing operator

2018-05-23 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-9419: Summary: UNION should not be treated as retraction producing operator Key: FLINK-9419 URL: https://issues.apache.org/jira/browse/FLINK-9419 Project: Flink

[jira] [Updated] (FLINK-9058) Relax ListState.addAll() and ListState.update() to take Iterable

2018-05-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-9058: - Affects Version/s: 1.6.0 1.5.0 > Relax ListState.addAll() and

[jira] [Updated] (FLINK-9058) Relax ListState.addAll() and ListState.update() to take Iterable

2018-05-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-9058: - Fix Version/s: (was: 1.5.0) > Relax ListState.addAll() and ListState.update() to take

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r190140777 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486823#comment-16486823 ] ASF GitHub Bot commented on FLINK-6968: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-9349) KafkaConnector Exception while fetching from multiple kafka topics

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486821#comment-16486821 ] ASF GitHub Bot commented on FLINK-9349: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r190136859 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486829#comment-16486829 ] ASF GitHub Bot commented on FLINK-6968: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #6040: [FLINK-9349][Kafka Connector] KafkaConnector Excep...

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6040 ---

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r190140171 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed

[jira] [Assigned] (FLINK-9417) Send heartbeat requests from RPC endpoint's main thread

2018-05-23 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou reassigned FLINK-9417: - Assignee: Sihua Zhou > Send heartbeat requests from RPC endpoint's main thread >

[jira] [Commented] (FLINK-9258) ConcurrentModificationException in ComponentMetricGroup.getAllVariables

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486907#comment-16486907 ] ASF GitHub Bot commented on FLINK-9258: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5959: [FLINK-9258][metrics] Thread-safe initialization o...

2018-05-23 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5959#discussion_r190165634 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java --- @@ -57,11 +57,12 @@ public

[jira] [Commented] (FLINK-9384) KafkaAvroTableSource failed to work due to type mismatch

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486929#comment-16486929 ] ASF GitHub Bot commented on FLINK-9384: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...

2018-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6026#discussion_r190169591 --- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java --- @@ -76,19 +77,35 @@ */

[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...

2018-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6026#discussion_r190170050 --- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java --- @@ -76,19 +77,35 @@ */

[GitHub] flink pull request #5998: [FLINK-9344] [TableAPI & SQL] Support INTERSECT an...

2018-05-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5998#discussion_r190171657 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/setop/StreamIntersectCoProcessFunction.scala --- @@ -0,0 +1,236 @@

[GitHub] flink pull request #6026: [FLINK-9384]KafkaAvroTableSource failed to work du...

2018-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6026#discussion_r190169511 --- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java --- @@ -76,19 +77,35 @@ */

[jira] [Commented] (FLINK-9384) KafkaAvroTableSource failed to work due to type mismatch

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486928#comment-16486928 ] ASF GitHub Bot commented on FLINK-9384: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-9258) ConcurrentModificationException in ComponentMetricGroup.getAllVariables

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486947#comment-16486947 ] ASF GitHub Bot commented on FLINK-9258: --- Github user zentol commented on the issue:

[jira] [Created] (FLINK-9421) RunningJobsRegistry entries are not cleaned up after job termination

2018-05-23 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-9421: Summary: RunningJobsRegistry entries are not cleaned up after job termination Key: FLINK-9421 URL: https://issues.apache.org/jira/browse/FLINK-9421 Project: Flink

[jira] [Resolved] (FLINK-9070) Improve performance of RocksDBMapState.clear()

2018-05-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-9070. -- Resolution: Fixed Fixed via master: 87e54eb3bc 1.5.0: 5df2bc5c9f > Improve performance of

[jira] [Commented] (FLINK-8985) End-to-end test: CLI

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486848#comment-16486848 ] ASF GitHub Bot commented on FLINK-8985: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5840: [FLINK-7850] [build system] Give each maven profil...

2018-05-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5840#discussion_r190155490 --- Diff: flink-libraries/flink-ml/pom.xml --- @@ -116,6 +119,9 @@ default

[jira] [Commented] (FLINK-9374) Flink Kinesis Producer does not backpressure

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486879#comment-16486879 ] ASF GitHub Bot commented on FLINK-9374: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-7850) Given each maven profile an activation property

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486880#comment-16486880 ] ASF GitHub Bot commented on FLINK-7850: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-9374) Flink Kinesis Producer does not backpressure

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486876#comment-16486876 ] ASF GitHub Bot commented on FLINK-9374: --- Github user fmthoma commented on the issue:

[jira] [Commented] (FLINK-8845) Use WriteBatch to improve performance for recovery in RocksDB backend

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486877#comment-16486877 ] ASF GitHub Bot commented on FLINK-8845: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer Backpr...

2018-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6021 @fmthoma yes, that would be great. ---

[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...

2018-05-23 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5869 @zentol if we just remove it from `disassociateFromJobManager ` and do not clear and reinitialize it, when a new job manager reconnect to the task manager , it would remain some tasks' information

[jira] [Commented] (FLINK-8946) TaskManager stop sending metrics after JobManager failover

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486890#comment-16486890 ] ASF GitHub Bot commented on FLINK-8946: --- Github user yanghua commented on the issue:

[jira] [Commented] (FLINK-8946) TaskManager stop sending metrics after JobManager failover

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486897#comment-16486897 ] ASF GitHub Bot commented on FLINK-8946: --- Github user zentol commented on the issue:

[jira] [Resolved] (FLINK-7814) Add BETWEEN and NOT BETWEEN expression to Table API

2018-05-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-7814. - Resolution: Fixed Fix Version/s: 1.6.0 Fixed in 1.6.0:

[jira] [Commented] (FLINK-9349) KafkaConnector Exception while fetching from multiple kafka topics

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486921#comment-16486921 ] ASF GitHub Bot commented on FLINK-9349: --- Github user snuyanzin commented on the issue:

[GitHub] flink issue #6040: [FLINK-9349][Kafka Connector] KafkaConnector Exception wh...

2018-05-23 Thread snuyanzin
Github user snuyanzin commented on the issue: https://github.com/apache/flink/pull/6040 @tzulitai thank you for your review and comments based on your comments I have a question. Could you please clarify it? You mentioned Flink's `OneShotLatch ` and `CheckedThread ` at the

[GitHub] flink issue #5959: [FLINK-9258][metrics] Thread-safe initialization of varia...

2018-05-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5959 The methods have been identical since FLINK-7692, but I didn't catch it in the review. Thus, `ComponentMetricGroup#getAllVariables()` should be removed, along with

[jira] [Commented] (FLINK-8518) Support DOW, EPOCH, DECADE for EXTRACT

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486966#comment-16486966 ] ASF GitHub Bot commented on FLINK-8518: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-8946) TaskManager stop sending metrics after JobManager failover

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486990#comment-16486990 ] ASF GitHub Bot commented on FLINK-8946: --- GitHub user yanghua opened a pull request:

[jira] [Comment Edited] (FLINK-6016) Newlines should be valid in quoted strings in CSV

2018-05-23 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486989#comment-16486989 ] Fabian Hueske edited comment on FLINK-6016 at 5/23/18 9:42 AM: --- This problem

[GitHub] flink pull request #6060: [FLINK-8946] TaskManager stop sending metrics afte...

2018-05-23 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6060 [FLINK-8946] TaskManager stop sending metrics after JobManager failover ## What is the purpose of the change *This pull request improve error message for when queryable state not ready /

[jira] [Commented] (FLINK-9326) TaskManagerOptions.NUM_TASK_SLOTS does not work for local/embedded mode

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486997#comment-16486997 ] ASF GitHub Bot commented on FLINK-9326: --- Github user yanghua commented on a diff in the pull

[jira] [Created] (FLINK-9420) Add tests for SQL IN sub-query operator in streaming

2018-05-23 Thread Timo Walther (JIRA)
Timo Walther created FLINK-9420: --- Summary: Add tests for SQL IN sub-query operator in streaming Key: FLINK-9420 URL: https://issues.apache.org/jira/browse/FLINK-9420 Project: Flink Issue Type:

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r190141550 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/KeyedOneInputStreamOperatorTestHarness.java --- @@ -78,6 +82,20 @@ public int

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486826#comment-16486826 ] ASF GitHub Bot commented on FLINK-6968: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r190137151 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486824#comment-16486824 ] ASF GitHub Bot commented on FLINK-6968: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486830#comment-16486830 ] ASF GitHub Bot commented on FLINK-6968: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r190135653 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r190137656 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed

  1   2   3   4   >