[jira] [Created] (FLINK-9602) Extend CommonOption section

2018-06-16 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-9602: --- Summary: Extend CommonOption section Key: FLINK-9602 URL: https://issues.apache.org/jira/browse/FLINK-9602 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-9601) Snapshot of CopyOnWriteStateTable will failed, when the amount of record is more than MAXIMUM_CAPACITY

2018-06-16 Thread Sihua Zhou (JIRA)
Sihua Zhou created FLINK-9601: - Summary: Snapshot of CopyOnWriteStateTable will failed, when the amount of record is more than MAXIMUM_CAPACITY Key: FLINK-9601 URL: https://issues.apache.org/jira/browse/FLINK-9601

[GitHub] flink issue #6159: [FLINK-9487] Prepare InternalTimerHeap for asynchronous s...

2018-06-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6159 @StefanRRichter Sorry that I didn't take a look again yesterday, I was a bit too busy at that time. I had a look at the fix for the `CopyOnWriteStateTable`, I afraid it's still a partial fix, I

[jira] [Commented] (FLINK-9487) Prepare InternalTimerHeap for asynchronous snapshots

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514743#comment-16514743 ] ASF GitHub Bot commented on FLINK-9487: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6174: [FLINNK-9601][state]Try to reuse the snapshotData array a...

2018-06-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6174 CC @StefanRRichter ---

[GitHub] flink pull request #6174: [FLINNK-9601][state]Try to reuse the snapshotData ...

2018-06-16 Thread sihuazhou
GitHub user sihuazhou opened a pull request: https://github.com/apache/flink/pull/6174 [FLINNK-9601][state]Try to reuse the snapshotData array as the partitioned destination on… ## What is the purpose of the change In `CopyOnWriteStateTableSnapshot`, we only reuse the

[jira] [Comment Edited] (FLINK-9597) Flink application does not scale as expected

2018-06-16 Thread swy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514727#comment-16514727 ] swy edited comment on FLINK-9597 at 6/16/18 9:27 AM: - Hi [~fhueske] Do you mind to

[jira] [Commented] (FLINK-9571) Switch to internal states in StateBinder

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514787#comment-16514787 ] ASF GitHub Bot commented on FLINK-9571: --- Github user sihuazhou commented on a diff in the pull

[jira] [Commented] (FLINK-9571) Switch to internal states in StateBinder

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514789#comment-16514789 ] ASF GitHub Bot commented on FLINK-9571: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #6173: [FLINK-9571] Refactor StateBinder to internal back...

2018-06-16 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6173#discussion_r195903979 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/StateBinder.java --- @@ -23,7 +23,10 @@ /** * The {@code StateBinder} is

[GitHub] flink pull request #6173: [FLINK-9571] Refactor StateBinder to internal back...

2018-06-16 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6173#discussion_r195903433 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -203,91 +216,16 @@ private boolean

[GitHub] flink pull request #6173: [FLINK-9571] Refactor StateBinder to internal back...

2018-06-16 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6173#discussion_r195903383 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -110,7 +123,7 @@ /** * Map

[GitHub] flink pull request #6173: [FLINK-9571] Refactor StateBinder to internal back...

2018-06-16 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6173#discussion_r195903191 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java --- @@

[GitHub] flink pull request #6173: [FLINK-9571] Refactor StateBinder to internal back...

2018-06-16 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6173#discussion_r195903638 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[GitHub] flink pull request #6173: [FLINK-9571] Refactor StateBinder to internal back...

2018-06-16 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6173#discussion_r195903619 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[jira] [Commented] (FLINK-9571) Switch to internal states in StateBinder

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514790#comment-16514790 ] ASF GitHub Bot commented on FLINK-9571: --- Github user sihuazhou commented on a diff in the pull

[jira] [Commented] (FLINK-9571) Switch to internal states in StateBinder

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514788#comment-16514788 ] ASF GitHub Bot commented on FLINK-9571: --- Github user sihuazhou commented on a diff in the pull

[jira] [Commented] (FLINK-9571) Switch to internal states in StateBinder

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514791#comment-16514791 ] ASF GitHub Bot commented on FLINK-9571: --- Github user sihuazhou commented on a diff in the pull

[jira] [Commented] (FLINK-9571) Switch to internal states in StateBinder

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514786#comment-16514786 ] ASF GitHub Bot commented on FLINK-9571: --- Github user sihuazhou commented on a diff in the pull

[jira] [Closed] (FLINK-9597) Flink application does not scale as expected

2018-06-16 Thread swy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] swy closed FLINK-9597. -- Resolution: Later > Flink application does not scale as expected > > >

[jira] [Commented] (FLINK-9552) NPE in SpanningRecordSerializer during checkpoint with iterations

2018-06-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514698#comment-16514698 ] Till Rohrmann commented on FLINK-9552: -- You could add the checkpoint lock around the {{collect}}

[jira] [Commented] (FLINK-9597) Flink application does not scale as expected

2018-06-16 Thread swy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514727#comment-16514727 ] swy commented on FLINK-9597: Hi [~fhueske] Do you mind to share your experience any other reason the

[jira] [Commented] (FLINK-9597) Flink application does not scale as expected

2018-06-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514734#comment-16514734 ] Fabian Hueske commented on FLINK-9597: -- Thanks für starting the thread on the mailing list! Would

[jira] [Created] (FLINK-9603) Incorrect indexing of part files, when part suffix is specified (FileAlreadyExistsException)

2018-06-16 Thread Rinat Sharipov (JIRA)
Rinat Sharipov created FLINK-9603: - Summary: Incorrect indexing of part files, when part suffix is specified (FileAlreadyExistsException) Key: FLINK-9603 URL: https://issues.apache.org/jira/browse/FLINK-9603

[jira] [Updated] (FLINK-9603) Incorrect indexing of part files, when part suffix is specified (FileAlreadyExistsException)

2018-06-16 Thread Rinat Sharipov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rinat Sharipov updated FLINK-9603: -- Description: Hi mates, since 1.5 release, BucketingSink has ability to configure suffix of

[jira] [Assigned] (FLINK-9603) Incorrect indexing of part files, when part suffix is specified (FileAlreadyExistsException)

2018-06-16 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9603: --- Assignee: vinoyang > Incorrect indexing of part files, when part suffix is specified >

[jira] [Commented] (FLINK-9563) Migrate integration tests for CEP

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514885#comment-16514885 ] ASF GitHub Bot commented on FLINK-9563: --- Github user deepaks4077 commented on the issue:

[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...

2018-06-16 Thread deepaks4077
Github user deepaks4077 commented on the issue: https://github.com/apache/flink/pull/6170 @zentol, I've updated the tests and all tests pass now. Please take a look when you get the chance. ---

[jira] [Assigned] (FLINK-9598) [Checkpoints] The config Minimum Pause Between Checkpoints doesn't work when there's a checkpoint failure

2018-06-16 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9598: --- Assignee: vinoyang > [Checkpoints] The config Minimum Pause Between Checkpoints doesn't work when

[jira] [Commented] (FLINK-9601) Snapshot of CopyOnWriteStateTable will failed when the amount of record is more than MAXIMUM_CAPACITY

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514841#comment-16514841 ] ASF GitHub Bot commented on FLINK-9601: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #6174: [FLINK-9601][state]Try to reuse the snapshotData array as...

2018-06-16 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6174 Thanks for the contribution. I think the general idea is good, but I think the implementation can be improved. How about changing `CopyOnWriteStateTable::snapshotTableArrays()` in such ways

[jira] [Commented] (FLINK-9380) Failing end-to-end tests should not clean up logs

2018-06-16 Thread Deepak Sharma (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514884#comment-16514884 ] Deepak Sharma commented on FLINK-9380: -- Hi [~till.rohrmann], are we saying that we want the failed

[jira] [Assigned] (FLINK-9602) Extend CommonOption section

2018-06-16 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9602: --- Assignee: vinoyang > Extend CommonOption section > --- > >

[GitHub] flink issue #6174: [FLINK-9601][state]Try to reuse the snapshotData array as...

2018-06-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6174 @StefanRRichter Thanks for the review, I think that makes a lot of sense, will change it according to your suggestion. ---

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2018-06-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514975#comment-16514975 ] Ted Yu commented on FLINK-4534: --- lgtm > Lack of synchronization in BucketingSink#restoreState() >

[jira] [Updated] (FLINK-6359) Utilize Hierarchical Timing Wheels for performant timer

2018-06-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6359: -- Labels: perfomance (was: ) > Utilize Hierarchical Timing Wheels for performant timer >

[jira] [Commented] (FLINK-9601) Snapshot of CopyOnWriteStateTable will failed when the amount of record is more than MAXIMUM_CAPACITY

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514945#comment-16514945 ] ASF GitHub Bot commented on FLINK-9601: --- Github user sihuazhou commented on the issue:

[jira] [Updated] (FLINK-9601) Snapshot of CopyOnWriteStateTable will failed when the amount of record is more than MAXIMUM_CAPACITY

2018-06-16 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou updated FLINK-9601: -- Summary: Snapshot of CopyOnWriteStateTable will failed when the amount of record is more than

[jira] [Commented] (FLINK-9585) Logger in ZooKeeperStateHandleStore is public and non-final

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514806#comment-16514806 ] ASF GitHub Bot commented on FLINK-9585: --- GitHub user yanghua opened a pull request:

[jira] [Commented] (FLINK-9585) Logger in ZooKeeperStateHandleStore is public and non-final

2018-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514807#comment-16514807 ] ASF GitHub Bot commented on FLINK-9585: --- Github user yanghua commented on the issue:

[GitHub] flink pull request #6175: [FLINK-9585] Logger in ZooKeeperStateHandleStore i...

2018-06-16 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6175 [FLINK-9585] Logger in ZooKeeperStateHandleStore is public and non-final ## What is the purpose of the change *This pull request mark Logger in ZooKeeperStateHandleStore as private and

[GitHub] flink issue #6175: [FLINK-9585] Logger in ZooKeeperStateHandleStore is publi...

2018-06-16 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6175 cc @zentol ---

[jira] [Updated] (FLINK-9603) Incorrect indexing of part files, when part suffix is specified (FileAlreadyExistsException)

2018-06-16 Thread Rinat Sharipov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rinat Sharipov updated FLINK-9603: -- Description: Hi mates, since 1.5 release, BucketingSink has ability to configure suffix of