[GitHub] zentol commented on a change in pull request #7049: [FLINK-10816][cep] Fix LockableTypeSerializer.duplicate() to consider…

2018-11-07 Thread GitBox
zentol commented on a change in pull request #7049: [FLINK-10816][cep] Fix LockableTypeSerializer.duplicate() to consider… URL: https://github.com/apache/flink/pull/7049#discussion_r231608543 ## File path:

[jira] [Commented] (FLINK-10816) Fix LockableTypeSerializer.duplicate()

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678567#comment-16678567 ] ASF GitHub Bot commented on FLINK-10816: zentol commented on a change in pull request #7049:

[GitHub] zentol commented on a change in pull request #7049: [FLINK-10816][cep] Fix LockableTypeSerializer.duplicate() to consider…

2018-11-07 Thread GitBox
zentol commented on a change in pull request #7049: [FLINK-10816][cep] Fix LockableTypeSerializer.duplicate() to consider… URL: https://github.com/apache/flink/pull/7049#discussion_r231609118 ## File path:

[jira] [Updated] (FLINK-10816) Fix LockableTypeSerializer.duplicate()

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10816: --- Labels: pull-request-available (was: ) > Fix LockableTypeSerializer.duplicate() >

[GitHub] StefanRRichter opened a new pull request #7049: [FLINK-10816][cep] Fix LockableTypeSerializer.duplicate() to consider…

2018-11-07 Thread GitBox
StefanRRichter opened a new pull request #7049: [FLINK-10816][cep] Fix LockableTypeSerializer.duplicate() to consider… URL: https://github.com/apache/flink/pull/7049 … deep duplication of element serializer ## What is the purpose of the change

[GitHub] zentol commented on issue #7041: [FLINK-9002] [e2e] Add operators with input type that goes through Avro serialization

2018-11-07 Thread GitBox
zentol commented on issue #7041: [FLINK-9002] [e2e] Add operators with input type that goes through Avro serialization URL: https://github.com/apache/flink/pull/7041#issuecomment-436715885 There's a typo in the commit message: `tyoe`-> `type`

[jira] [Commented] (FLINK-9002) Add operators with input type that goes through Avro serialization (with schema/generic)

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678574#comment-16678574 ] ASF GitHub Bot commented on FLINK-9002: --- zentol commented on issue #7041: [FLINK-9002] [e2e] Add

[GitHub] zentol commented on a change in pull request #7049: [FLINK-10816][cep] Fix LockableTypeSerializer.duplicate() to consider…

2018-11-07 Thread GitBox
zentol commented on a change in pull request #7049: [FLINK-10816][cep] Fix LockableTypeSerializer.duplicate() to consider… URL: https://github.com/apache/flink/pull/7049#discussion_r231607022 ## File path:

[GitHub] TisonKun closed pull request #6947: [hotfix] [tests] refactor YARNSessionCapacitySchedulerITCase

2018-11-07 Thread GitBox
TisonKun closed pull request #6947: [hotfix] [tests] refactor YARNSessionCapacitySchedulerITCase URL: https://github.com/apache/flink/pull/6947 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[jira] [Commented] (FLINK-10816) Fix LockableTypeSerializer.duplicate()

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678517#comment-16678517 ] ASF GitHub Bot commented on FLINK-10816: StefanRRichter opened a new pull request #7049:

[jira] [Created] (FLINK-10817) Upgrade presto dependency to support path-style access

2018-11-07 Thread Adam Lamar (JIRA)
Adam Lamar created FLINK-10817: -- Summary: Upgrade presto dependency to support path-style access Key: FLINK-10817 URL: https://issues.apache.org/jira/browse/FLINK-10817 Project: Flink Issue

[jira] [Closed] (FLINK-10682) EOFException occurs during deserialization of Avro class

2018-11-07 Thread Ben La Monica (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben La Monica closed FLINK-10682. - Resolution: Resolved Fix Version/s: 1.5.5 [~till.rohrmann] that did the trick! It no

[jira] [Commented] (FLINK-10803) Add documentation about S3 support by the StreamingFileSink

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678571#comment-16678571 ] ASF GitHub Bot commented on FLINK-10803: zentol commented on a change in pull request #7046:

[GitHub] zentol commented on a change in pull request #7046: [FLINK-10803] Update the documentation to include changes to the S3 connector.

2018-11-07 Thread GitBox
zentol commented on a change in pull request #7046: [FLINK-10803] Update the documentation to include changes to the S3 connector. URL: https://github.com/apache/flink/pull/7046#discussion_r231609764 ## File path: docs/dev/connectors/streamfile_sink.md ## @@ -24,16 +24,24

[jira] [Commented] (FLINK-10816) Fix LockableTypeSerializer.duplicate()

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678557#comment-16678557 ] ASF GitHub Bot commented on FLINK-10816: zentol commented on a change in pull request #7049:

[jira] [Commented] (FLINK-10816) Fix LockableTypeSerializer.duplicate()

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678568#comment-16678568 ] ASF GitHub Bot commented on FLINK-10816: zentol commented on a change in pull request #7049:

[jira] [Updated] (FLINK-10817) Upgrade presto dependency to support path-style access

2018-11-07 Thread Adam Lamar (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Lamar updated FLINK-10817: --- Description: In order to use any given non-AWS s3 implementation backed by the presto s3

[GitHub] sunjincheng121 commented on issue #6949: [FLINK-10676][table] Add 'as' method for OverWindowWithOrderBy

2018-11-07 Thread GitBox
sunjincheng121 commented on issue #6949: [FLINK-10676][table] Add 'as' method for OverWindowWithOrderBy URL: https://github.com/apache/flink/pull/6949#issuecomment-436838520 CI find `JobManagerHAProcessFailureRecoveryITCase.testDispatcherProcessFailure:331 » IllegalArgument` test fail

[GitHub] TisonKun opened a new pull request #7050: [hotfix] Follow up FLINK-6046 to clean unused variable

2018-11-07 Thread GitBox
TisonKun opened a new pull request #7050: [hotfix] Follow up FLINK-6046 to clean unused variable URL: https://github.com/apache/flink/pull/7050 ## What is the purpose of the change After FLINK-6046 5ff07e63d1e9a98959e5edf6687b847d23d5 resolved, we replaced

[GitHub] sunjincheng121 commented on issue #6949: [FLINK-10676][table] Add 'as' method for OverWindowWithOrderBy

2018-11-07 Thread GitBox
sunjincheng121 commented on issue #6949: [FLINK-10676][table] Add 'as' method for OverWindowWithOrderBy URL: https://github.com/apache/flink/pull/6949#issuecomment-436862717 After the rerun, the error disappeared. no specific reasons are found, so created a JIRA.

[GitHub] zhijiangW opened a new pull request #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation

2018-11-07 Thread GitBox
zhijiangW opened a new pull request #7051: [FLINK-10820][network] Simplify the RebalancePartitioner implementation URL: https://github.com/apache/flink/pull/7051 ## What is the purpose of the change *The current `RebalancePartitioner` implementations seems a little hacky for

[GitHub] TisonKun commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys

2018-11-07 Thread GitBox
TisonKun commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-436856289 ping @tillrohrmann as we have cut the release branch. This is an

[GitHub] TisonKun commented on issue #6946: [FLINK-10700] [cluster managerment] Remove LegacyStandaloneClusterDes…

2018-11-07 Thread GitBox
TisonKun commented on issue #6946: [FLINK-10700] [cluster managerment] Remove LegacyStandaloneClusterDes… URL: https://github.com/apache/flink/pull/6946#issuecomment-436856580 cc @StefanRRichter @GJL This is an automated

[GitHub] tzulitai commented on issue #7041: [FLINK-9002] [e2e] Add operators with input type that goes through Avro serialization

2018-11-07 Thread GitBox
tzulitai commented on issue #7041: [FLINK-9002] [e2e] Add operators with input type that goes through Avro serialization URL: https://github.com/apache/flink/pull/7041#issuecomment-436888088 @zentol Thanks, will remember to fix the typo when merging. @dawidwys I addressed your

[GitHub] TisonKun closed pull request #6353: [FLINK-9875][runtime] Add concurrent creation of execution job vertex

2018-11-07 Thread GitBox
TisonKun closed pull request #6353: [FLINK-9875][runtime] Add concurrent creation of execution job vertex URL: https://github.com/apache/flink/pull/6353 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] TisonKun commented on issue #6353: [FLINK-9875][runtime] Add concurrent creation of execution job vertex

2018-11-07 Thread GitBox
TisonKun commented on issue #6353: [FLINK-9875][runtime] Add concurrent creation of execution job vertex URL: https://github.com/apache/flink/pull/6353#issuecomment-436855410 close as no consensus, further discussion happened as described above.

[GitHub] asfgit closed pull request #6949: [FLINK-10676][table] Add 'as' method for OverWindowWithOrderBy

2018-11-07 Thread GitBox
asfgit closed pull request #6949: [FLINK-10676][table] Add 'as' method for OverWindowWithOrderBy URL: https://github.com/apache/flink/pull/6949 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[jira] [Commented] (FLINK-9875) Add concurrent creation of execution job vertex

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679221#comment-16679221 ] ASF GitHub Bot commented on FLINK-9875: --- TisonKun closed pull request #6353: [FLINK-9875][runtime]

[jira] [Commented] (FLINK-10555) Port AkkaSslITCase to new code base

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679224#comment-16679224 ] ASF GitHub Bot commented on FLINK-10555: TisonKun commented on issue #6849: [FLINK-10555] [test]

[jira] [Commented] (FLINK-9875) Add concurrent creation of execution job vertex

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679220#comment-16679220 ] ASF GitHub Bot commented on FLINK-9875: --- TisonKun commented on issue #6353: [FLINK-9875][runtime]

[GitHub] TisonKun closed pull request #6345: [FLINK-9869][runtime] Send PartitionInfo in batch to Improve perfornance

2018-11-07 Thread GitBox
TisonKun closed pull request #6345: [FLINK-9869][runtime] Send PartitionInfo in batch to Improve perfornance URL: https://github.com/apache/flink/pull/6345 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] TisonKun commented on issue #6345: [FLINK-9869][runtime] Send PartitionInfo in batch to Improve perfornance

2018-11-07 Thread GitBox
TisonKun commented on issue #6345: [FLINK-9869][runtime] Send PartitionInfo in batch to Improve perfornance URL: https://github.com/apache/flink/pull/6345#issuecomment-436854489 close for no longer interest This is an

[GitHub] tzulitai commented on a change in pull request #7041: [FLINK-9002] [e2e] Add operators with input type that goes through Avro serialization

2018-11-07 Thread GitBox
tzulitai commented on a change in pull request #7041: [FLINK-9002] [e2e] Add operators with input type that goes through Avro serialization URL: https://github.com/apache/flink/pull/7041#discussion_r231775701 ## File path:

[GitHub] tzulitai commented on a change in pull request #7041: [FLINK-9002] [e2e] Add operators with input type that goes through Avro serialization

2018-11-07 Thread GitBox
tzulitai commented on a change in pull request #7041: [FLINK-9002] [e2e] Add operators with input type that goes through Avro serialization URL: https://github.com/apache/flink/pull/7041#discussion_r231775682 ## File path:

[jira] [Closed] (FLINK-10815) Rethink the rescale operation, can we do it async

2018-11-07 Thread Shimin Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shimin Yang closed FLINK-10815. --- Resolution: Workaround > Rethink the rescale operation, can we do it async >

[jira] [Commented] (FLINK-10815) Rethink the rescale operation, can we do it async

2018-11-07 Thread Shimin Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679185#comment-16679185 ] Shimin Yang commented on FLINK-10815: - Thanks [~dawidwys]. I will close this issue. > Rethink the

[GitHub] TisonKun commented on issue #6849: [FLINK-10555] [test] Port AkkaSslITCase to new code base

2018-11-07 Thread GitBox
TisonKun commented on issue #6849: [FLINK-10555] [test] Port AkkaSslITCase to new code base URL: https://github.com/apache/flink/pull/6849#issuecomment-436855977 re-push for resolving conflict. This is an automated message

[jira] [Commented] (FLINK-9002) Add operators with input type that goes through Avro serialization (with schema/generic)

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679342#comment-16679342 ] ASF GitHub Bot commented on FLINK-9002: --- tzulitai commented on a change in pull request #7041:

[jira] [Commented] (FLINK-9002) Add operators with input type that goes through Avro serialization (with schema/generic)

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679345#comment-16679345 ] ASF GitHub Bot commented on FLINK-9002: --- tzulitai commented on issue #7041: [FLINK-9002] [e2e] Add

[jira] [Commented] (FLINK-10706) Update the Flink Dashboard and its components

2018-11-07 Thread Yadong Xie (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679189#comment-16679189 ] Yadong Xie commented on FLINK-10706: [~Zentol] [~wolli] thank you! I will start my work soon. >

[jira] [Commented] (FLINK-10791) Provide end-to-end test for Kafka 0.11 connector

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677908#comment-16677908 ] ASF GitHub Bot commented on FLINK-10791: yanghua commented on issue #7038: [FLINK-10791] Provide

[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector

2018-11-07 Thread GitBox
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-436561044 @pnowojski @aljoscha can you review this PR? thanks. This

[jira] [Commented] (FLINK-10704) Fix sql client end to end test failure

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677912#comment-16677912 ] ASF GitHub Bot commented on FLINK-10704: yanghua commented on issue #6963: [FLINK-10704] Fix sql

[GitHub] yanghua commented on issue #6963: [FLINK-10704] Fix sql client end to end test failure

2018-11-07 Thread GitBox
yanghua commented on issue #6963: [FLINK-10704] Fix sql client end to end test failure URL: https://github.com/apache/flink/pull/6963#issuecomment-436561330 @pnowojski Can we merge this PR? This is an automated message from

[jira] [Commented] (FLINK-10770) Some generated functions are not opened properly.

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677918#comment-16677918 ] ASF GitHub Bot commented on FLINK-10770: Xpray commented on issue #7014: [FLINK-10770] [Table &

[jira] [Commented] (FLINK-10805) test_confluent_schema_registry.sh and test_sql_client.sh end-to-end test broken

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677928#comment-16677928 ] ASF GitHub Bot commented on FLINK-10805: twalthr commented on a change in pull request #7034:

[jira] [Closed] (FLINK-10800) Abstract the StreamPartitionerTest for common codes

2018-11-07 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-10800. -- Resolution: Fixed Fix Version/s: 1.8.0 merged commit 53ee80e into apache:master >

[GitHub] pnowojski commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink

2018-11-07 Thread GitBox
pnowojski commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink URL: https://github.com/apache/flink/pull/6927#issuecomment-436568924 @yanghua please do not trigger rebuild of errors like this: ``` Waiting for Elasticsearch node to work...

[GitHub] shaoxuan-wang commented on issue #6924: [FLINK-10600] Provide End-to-end test cases for modern Kafka connectors

2018-11-07 Thread GitBox
shaoxuan-wang commented on issue #6924: [FLINK-10600] Provide End-to-end test cases for modern Kafka connectors URL: https://github.com/apache/flink/pull/6924#issuecomment-436572212 > @yanghua if the tests are not stable for 2.0 connector, they should be fixed. > > @shaoxuan-wang

[GitHub] tillrohrmann commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests

2018-11-07 Thread GitBox
tillrohrmann commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests URL: https://github.com/apache/flink/pull/7034#discussion_r231456626 ## File path: flink-end-to-end-tests/test-scripts/test_sql_client.sh ## @@ -360,13 +362,14 @@

[jira] [Commented] (FLINK-10805) test_confluent_schema_registry.sh and test_sql_client.sh end-to-end test broken

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678016#comment-16678016 ] ASF GitHub Bot commented on FLINK-10805: tillrohrmann commented on a change in pull request

[GitHub] tillrohrmann commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests

2018-11-07 Thread GitBox
tillrohrmann commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests URL: https://github.com/apache/flink/pull/7034#discussion_r231458488 ## File path: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh ## @@ -45,7 +45,7 @@

[jira] [Updated] (FLINK-10353) Restoring a KafkaProducer with Semantic.EXACTLY_ONCE from a savepoint written with Semantic.AT_LEAST_ONCE fails with NPE

2018-11-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-10353: --- Fix Version/s: 1.7.0 1.6.3 > Restoring a KafkaProducer with

[jira] [Reopened] (FLINK-10353) Restoring a KafkaProducer with Semantic.EXACTLY_ONCE from a savepoint written with Semantic.AT_LEAST_ONCE fails with NPE

2018-11-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter reopened FLINK-10353: > Restoring a KafkaProducer with Semantic.EXACTLY_ONCE from a savepoint written > with

[jira] [Commented] (FLINK-10706) Update the Flink Dashboard and its components

2018-11-07 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678026#comment-16678026 ] Fabian Wollert commented on FLINK-10706: [~Zentol] thx. [~vthinkxie] I assigned the ticket now

[jira] [Issue Comment Deleted] (FLINK-10353) Restoring a KafkaProducer with Semantic.EXACTLY_ONCE from a savepoint written with Semantic.AT_LEAST_ONCE fails with NPE

2018-11-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-10353: --- Comment: was deleted (was: Merged in: master: 85f895b083 release-1.7: 090119ac96) >

[jira] [Commented] (FLINK-10801) Fix sql client integrate elasticsearch connector test failure

2018-11-07 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678077#comment-16678077 ] vinoyang commented on FLINK-10801: -- [~pnowojski]  Ok, go ahead. I know that sleep 20s is not the best

[jira] [Comment Edited] (FLINK-10463) Null literal cannot be properly parsed in Java Table API function call

2018-11-07 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676901#comment-16676901 ] Xingcan Cui edited comment on FLINK-10463 at 11/7/18 11:32 AM: --- Fixed in

[jira] [Assigned] (FLINK-10634) End-to-end test: Metrics accessible via REST API

2018-11-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-10634: Assignee: Chesnay Schepler (was: Biao Liu) > End-to-end test: Metrics

[jira] [Commented] (FLINK-10706) Update the Flink Dashboard and its components

2018-11-07 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677903#comment-16677903 ] Fabian Wollert commented on FLINK-10706: Hi [~vthinkxie] i would love to, but i'm not able to (I

[jira] [Created] (FLINK-10809) Using DataStreamUtils.reinterpretAsKeyedStream produces corrupted keyed state after restore

2018-11-07 Thread Dawid Wysakowicz (JIRA)
Dawid Wysakowicz created FLINK-10809: Summary: Using DataStreamUtils.reinterpretAsKeyedStream produces corrupted keyed state after restore Key: FLINK-10809 URL:

[jira] [Commented] (FLINK-10706) Update the Flink Dashboard and its components

2018-11-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677915#comment-16677915 ] Chesnay Schepler commented on FLINK-10706: -- [~wolli] [~vthinkxie] I've given both of you

[GitHub] 1u0 commented on issue #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB

2018-11-07 Thread GitBox
1u0 commented on issue #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB URL: https://github.com/apache/flink/pull/6976#issuecomment-436570526 @zentol, an exception would be thrown on `report()`. What do you think about making `db` configuration parameter as

[jira] [Commented] (FLINK-7155) Add Influxdb metrics reporter

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677965#comment-16677965 ] ASF GitHub Bot commented on FLINK-7155: --- zentol commented on issue #6976: [FLINK-7155][metrics] Add

[GitHub] zentol edited a comment on issue #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB

2018-11-07 Thread GitBox
zentol edited a comment on issue #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB URL: https://github.com/apache/flink/pull/6976#issuecomment-436573129 > What do you think about making db configuration parameter as required? Makes sense to me.

[jira] [Commented] (FLINK-7155) Add Influxdb metrics reporter

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677966#comment-16677966 ] ASF GitHub Bot commented on FLINK-7155: --- zentol edited a comment on issue #6976:

[jira] [Commented] (FLINK-10770) Some generated functions are not opened properly.

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677976#comment-16677976 ] ASF GitHub Bot commented on FLINK-10770: Xpray commented on issue #7014: [FLINK-10770] [Table &

[jira] [Commented] (FLINK-10805) test_confluent_schema_registry.sh and test_sql_client.sh end-to-end test broken

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677978#comment-16677978 ] ASF GitHub Bot commented on FLINK-10805: twalthr commented on a change in pull request #7034:

[GitHub] twalthr commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests

2018-11-07 Thread GitBox
twalthr commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests URL: https://github.com/apache/flink/pull/7034#discussion_r231449486 ## File path: flink-end-to-end-tests/test-scripts/test_sql_client.sh ## @@ -360,13 +362,14 @@

[jira] [Commented] (FLINK-10736) Shaded Hadoop S3A end-to-end test failed on Travis

2018-11-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678012#comment-16678012 ] Till Rohrmann commented on FLINK-10736: --- Yes or to use a publicly available file stored in S3. >

[jira] [Commented] (FLINK-10721) kafkaFetcher runFetchLoop throw exception will cause follow-up code not execute in FlinkKafkaConsumerBase run method

2018-11-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678011#comment-16678011 ] Chesnay Schepler commented on FLINK-10721: -- I would instead suggest to modify the

[jira] [Commented] (FLINK-10805) test_confluent_schema_registry.sh and test_sql_client.sh end-to-end test broken

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678014#comment-16678014 ] ASF GitHub Bot commented on FLINK-10805: tillrohrmann commented on a change in pull request

[GitHub] tillrohrmann commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests

2018-11-07 Thread GitBox
tillrohrmann commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests URL: https://github.com/apache/flink/pull/7034#discussion_r231456340 ## File path: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh ## @@ -45,7 +45,7 @@

[jira] [Closed] (FLINK-10353) Restoring a KafkaProducer with Semantic.EXACTLY_ONCE from a savepoint written with Semantic.AT_LEAST_ONCE fails with NPE

2018-11-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-10353. -- Resolution: Fixed Merged in: master: 85f895b083 release-1.7: 090119ac96 > Restoring a

[GitHub] zentol commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests

2018-11-07 Thread GitBox
zentol commented on a change in pull request #7034: [FLINK-10805] Fix failing end-to-end tests URL: https://github.com/apache/flink/pull/7034#discussion_r231457628 ## File path: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh ## @@ -45,7 +45,7 @@ function

[jira] [Closed] (FLINK-10353) Restoring a KafkaProducer with Semantic.EXACTLY_ONCE from a savepoint written with Semantic.AT_LEAST_ONCE fails with NPE

2018-11-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-10353. -- Resolution: Fixed Merged in: master: 85f895b083 release-1.7: 090119ac96 release-1.6:

[jira] [Commented] (FLINK-10704) Fix sql client end to end test failure

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678039#comment-16678039 ] ASF GitHub Bot commented on FLINK-10704: pnowojski commented on issue #6963: [FLINK-10704] Fix

[jira] [Closed] (FLINK-10704) Fix sql client end to end test failure

2018-11-07 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-10704. -- Resolution: Fixed Fix Version/s: 1.7.0 Merged - as `af90555fb4` into master - as

[jira] [Commented] (FLINK-10704) Fix sql client end to end test failure

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678040#comment-16678040 ] ASF GitHub Bot commented on FLINK-10704: pnowojski closed pull request #6963: [FLINK-10704] Fix

[jira] [Commented] (FLINK-10791) Provide end-to-end test for Kafka 0.11 connector

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678071#comment-16678071 ] ASF GitHub Bot commented on FLINK-10791: yanghua commented on issue #7038: [FLINK-10791] Provide

[GitHub] zentol opened a new pull request #7043: [FLINK-10811][hcatalog] Add scala suffix

2018-11-07 Thread GitBox
zentol opened a new pull request #7043: [FLINK-10811][hcatalog] Add scala suffix URL: https://github.com/apache/flink/pull/7043 This PR adds a scala suffix to the `flink-hcatalog` module, as required due to the compile dependency on `flink-hadoop-compatibility_${scala.binary.version}`.

[jira] [Updated] (FLINK-10811) Hcatalog modules needs scala suffix

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10811: --- Labels: pull-request-available (was: ) > Hcatalog modules needs scala suffix >

[jira] [Commented] (FLINK-10811) Hcatalog modules needs scala suffix

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678128#comment-16678128 ] ASF GitHub Bot commented on FLINK-10811: zentol opened a new pull request #7043:

[jira] [Commented] (FLINK-10711) flink-end-to-end-tests can fail silently

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678140#comment-16678140 ] ASF GitHub Bot commented on FLINK-10711: zentol commented on a change in pull request #7023:

[GitHub] Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly.

2018-11-07 Thread GitBox
Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly. URL: https://github.com/apache/flink/pull/7014#issuecomment-436563611 Hi @jrthe42 , Thanks for the contribution. It seems you did not add test case to every generate function you

[GitHub] pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases for modern Kafka connectors

2018-11-07 Thread GitBox
pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases for modern Kafka connectors URL: https://github.com/apache/flink/pull/6924#issuecomment-436566067 @yanghua if the tests are not stable for 2.0 connector, they should be fixed. @shaoxuan-wang what test

[jira] [Commented] (FLINK-10600) Provide End-to-end test cases for modern Kafka connectors

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677929#comment-16677929 ] ASF GitHub Bot commented on FLINK-10600: pnowojski commented on issue #6924: [FLINK-10600]

[GitHub] zentol commented on issue #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB

2018-11-07 Thread GitBox
zentol commented on issue #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB URL: https://github.com/apache/flink/pull/6976#issuecomment-436569484 I agree that the reporter should not create a database, at the very least not in the first version. If the db doesn't exist,

[GitHub] pnowojski edited a comment on issue #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink

2018-11-07 Thread GitBox
pnowojski edited a comment on issue #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink URL: https://github.com/apache/flink/pull/6927#issuecomment-436568924 @yanghua please do not trigger rebuild of errors like this: ``` Waiting for Elasticsearch node to

[jira] [Commented] (FLINK-10624) Extend SQL client end-to-end to test new KafkaTableSink

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677940#comment-16677940 ] ASF GitHub Bot commented on FLINK-10624: pnowojski commented on issue #6927: [FLINK-10624]

[jira] [Commented] (FLINK-10624) Extend SQL client end-to-end to test new KafkaTableSink

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677942#comment-16677942 ] ASF GitHub Bot commented on FLINK-10624: pnowojski edited a comment on issue #6927:

[jira] [Commented] (FLINK-7155) Add Influxdb metrics reporter

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677945#comment-16677945 ] ASF GitHub Bot commented on FLINK-7155: --- zentol commented on issue #6976: [FLINK-7155][metrics] Add

[jira] [Commented] (FLINK-10600) Provide End-to-end test cases for modern Kafka connectors

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677958#comment-16677958 ] ASF GitHub Bot commented on FLINK-10600: shaoxuan-wang commented on issue #6924: [FLINK-10600]

[GitHub] zentol commented on a change in pull request #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB

2018-11-07 Thread GitBox
zentol commented on a change in pull request #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB URL: https://github.com/apache/flink/pull/6976#discussion_r231446336 ## File path: docs/monitoring/metrics.md ## @@ -672,6 +672,30 @@

[GitHub] zentol commented on issue #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB

2018-11-07 Thread GitBox
zentol commented on issue #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB URL: https://github.com/apache/flink/pull/6976#issuecomment-436573129 > What do you think about making db configuration parameter as required? Makes sense to me.

[jira] [Commented] (FLINK-7155) Add Influxdb metrics reporter

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677962#comment-16677962 ] ASF GitHub Bot commented on FLINK-7155: --- zentol commented on a change in pull request #6976:

[GitHub] Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly.

2018-11-07 Thread GitBox
Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly. URL: https://github.com/apache/flink/pull/7014#issuecomment-436575363 Covering full lifecycle of generated functions looks good to me, but I think we should avoid adding new

[jira] [Commented] (FLINK-10736) Shaded Hadoop S3A end-to-end test failed on Travis

2018-11-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677998#comment-16677998 ] Chesnay Schepler commented on FLINK-10736: -- [~StephanEwen] Are you suggesting to permanently

[GitHub] asfgit closed pull request #7010: [FLINK-10353][kafka] Support change of transactional semantics in Kaf…

2018-11-07 Thread GitBox
asfgit closed pull request #7010: [FLINK-10353][kafka] Support change of transactional semantics in Kaf… URL: https://github.com/apache/flink/pull/7010 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Commented] (FLINK-10353) Restoring a KafkaProducer with Semantic.EXACTLY_ONCE from a savepoint written with Semantic.AT_LEAST_ONCE fails with NPE

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678017#comment-16678017 ] ASF GitHub Bot commented on FLINK-10353: asfgit closed pull request #7010: [FLINK-10353][kafka]

  1   2   3   >