[jira] [Assigned] (FLINK-21019) Bump Netty 4 to 4.1.58

2021-01-19 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-21019: --- Assignee: Huang Xingbo > Bump Netty 4 to 4.1.58 > -- > > Key:

[GitHub] [flink] tillrohrmann commented on pull request #14692: [FLINK-20944][k8s] Do not resolve the rest endpoint address when the service exposed type is ClusterIP

2021-01-19 Thread GitBox
tillrohrmann commented on pull request #14692: URL: https://github.com/apache/flink/pull/14692#issuecomment-762802511 The idea of the address resolution was to check that the client can actually talk to the cluster and to fail early if this is not the case. Hence, I am not sure whether we

[GitHub] [flink] flinkbot edited a comment on pull request #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #10847: URL: https://github.com/apache/flink/pull/10847#issuecomment-573933799 ## CI report: * 88b27b180a90899b60afbfd12c2930939f76a3a4 UNKNOWN * 6f27572110fbc02a1f0ad65260212b621b928dfe Azure:

[GitHub] [flink] leonardBang commented on a change in pull request #14675: [FLINK-18383][docs]translate "JDBC SQL Connector" documentation into …

2021-01-19 Thread GitBox
leonardBang commented on a change in pull request #14675: URL: https://github.com/apache/flink/pull/14675#discussion_r560133922 ## File path: docs/dev/table/connectors/jdbc.zh.md ## @@ -31,35 +31,35 @@ under the License. * This will be replaced by the TOC {:toc} -The JDBC

[GitHub] [flink] twalthr commented on a change in pull request #14660: [FLINK-20971][table-api-java] Support calling SQL expressions in Table API

2021-01-19 Thread GitBox
twalthr commented on a change in pull request #14660: URL: https://github.com/apache/flink/pull/14660#discussion_r560146069 ## File path: docs/dev/table/functions/systemFunctions.md ## @@ -34,6 +34,8 @@ Scalar Functions The scalar functions take zero, one or more values as

[jira] [Closed] (FLINK-15578) Implement exactly-once JDBC sink

2021-01-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-15578. -- Resolution: Fixed merged commit ced428c into apache:master > Implement exactly-once JDBC

[GitHub] [flink] pnowojski merged pull request #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink

2021-01-19 Thread GitBox
pnowojski merged pull request #10847: URL: https://github.com/apache/flink/pull/10847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] rkhachatryan commented on a change in pull request #14683: [FLINK-20992][checkpointing] Tolerate checkpoint cleanup failures

2021-01-19 Thread GitBox
rkhachatryan commented on a change in pull request #14683: URL: https://github.com/apache/flink/pull/14683#discussion_r560190909 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCleanerTest.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot edited a comment on pull request #14683: [FLINK-20992][checkpointing] Tolerate checkpoint cleanup failures

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14683: URL: https://github.com/apache/flink/pull/14683#issuecomment-762201068 ## CI report: * 4b622404a44f014885964d28f894bdd60cb20c7e UNKNOWN * e99d76cdfa380f5885d89e5e81da90b25840aa52 Azure:

[jira] [Commented] (FLINK-15156) Warn user if System.exit() is called in user code

2021-01-19 Thread Hwanju Kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267987#comment-17267987 ] Hwanju Kim commented on FLINK-15156: [~rmetzger] - No problem at all and thanks a lot for such

[GitHub] [flink] tillrohrmann commented on a change in pull request #14692: [FLINK-20944][k8s] Do not resolve the rest endpoint address when the service exposed type is ClusterIP

2021-01-19 Thread GitBox
tillrohrmann commented on a change in pull request #14692: URL: https://github.com/apache/flink/pull/14692#discussion_r560130091 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java ## @@ -125,6 +121,16 @@ public String

[GitHub] [flink] leonardBang edited a comment on pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-19 Thread GitBox
leonardBang edited a comment on pull request #14684: URL: https://github.com/apache/flink/pull/14684#issuecomment-762817601 I'll take a look this PR, @wuchong . @anlen321 Looks like you fixed the conflicts with `git merge` command, it's recommended to use `git rebase master` command

[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph

2021-01-19 Thread GitBox
SteNicholas commented on pull request #14659: URL: https://github.com/apache/flink/pull/14659#issuecomment-762825923 @zhuzhurk , thanks for your detailed review. I have followed your comments and modified the comments and remove the `resetForNewExecution` in `ExecutionJobVertex`. Please

[jira] [Commented] (FLINK-21029) Failure of shutdown lead to restart of (connected) pipeline

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267929#comment-17267929 ] Till Rohrmann commented on FLINK-21029: --- Thanks for reporting this issue [~TheoD]. What would be

[GitHub] [flink] flinkbot edited a comment on pull request #14683: [FLINK-20992][checkpointing] Tolerate checkpoint cleanup failures

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14683: URL: https://github.com/apache/flink/pull/14683#issuecomment-762201068 ## CI report: * 4b622404a44f014885964d28f894bdd60cb20c7e UNKNOWN * e99d76cdfa380f5885d89e5e81da90b25840aa52 Azure:

[GitHub] [flink] dawidwys merged pull request #14681: [FLINK-21009] Can not disable certain options in Elasticsearch 7 connector

2021-01-19 Thread GitBox
dawidwys merged pull request #14681: URL: https://github.com/apache/flink/pull/14681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (FLINK-21028) Streaming application didn't stop properly

2021-01-19 Thread Theo Diefenthal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268016#comment-17268016 ] Theo Diefenthal commented on FLINK-21028: - Sadly, I don't have any DEBUG logs here as I can't

[jira] [Comment Edited] (FLINK-21028) Streaming application didn't stop properly

2021-01-19 Thread Theo Diefenthal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268016#comment-17268016 ] Theo Diefenthal edited comment on FLINK-21028 at 1/19/21, 4:34 PM: ---

[jira] [Comment Edited] (FLINK-20992) Checkpoint cleanup can kill JobMaster

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267853#comment-17267853 ] Till Rohrmann edited comment on FLINK-20992 at 1/19/21, 12:14 PM: -- If

[jira] [Updated] (FLINK-21029) Failure of shutdown lead to restart of (connected) pipeline

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21029: -- Component/s: Runtime / Coordination > Failure of shutdown lead to restart of (connected)

[jira] [Updated] (FLINK-21029) Failure of shutdown lead to restart of (connected) pipeline

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21029: -- Fix Version/s: 1.12.2 1.11.4 1.13.0 > Failure of

[jira] [Updated] (FLINK-21030) Broken job restart for job with disjoint graph

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21030: -- Priority: Critical (was: Major) > Broken job restart for job with disjoint graph >

[jira] [Updated] (FLINK-21030) Broken job restart for job with disjoint graph

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21030: -- Fix Version/s: 1.12.2 1.11.4 1.13.0 > Broken job

[jira] [Updated] (FLINK-21030) Broken job restart for job with disjoint graph

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21030: -- Component/s: Runtime / Coordination > Broken job restart for job with disjoint graph >

[GitHub] [flink] fsw0422 commented on pull request #14692: [FLINK-20944][k8s] Do not resolve the rest endpoint address when the service exposed type is ClusterIP

2021-01-19 Thread GitBox
fsw0422 commented on pull request #14692: URL: https://github.com/apache/flink/pull/14692#issuecomment-762827527 @tillrohrmann in alot of cases, organizations are reluctant to open up NodePorts for security issues, instead exposing a secured ingress where all the external systems talk to.

[jira] [Closed] (FLINK-20971) Allow SQL expressions in Table API

2021-01-19 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-20971. Fix Version/s: 1.13.0 Resolution: Fixed Fixed in 1.13.0:

[GitHub] [flink] zentol edited a comment on pull request #14630: [FLINK-20915][docker] Move docker entrypoint to distribution

2021-01-19 Thread GitBox
zentol edited a comment on pull request #14630: URL: https://github.com/apache/flink/pull/14630#issuecomment-762796099 > How much of that is actually specific to using Flink in Docker[...]? As it stands, I'd say everything. Let's go through it shall we: 1. Setting of certain

[jira] [Created] (FLINK-21031) JobMasterStopWithSavepointIT test is not run due to wrong name

2021-01-19 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21031: Summary: JobMasterStopWithSavepointIT test is not run due to wrong name Key: FLINK-21031 URL: https://issues.apache.org/jira/browse/FLINK-21031 Project:

[jira] [Updated] (FLINK-21031) JobMasterStopWithSavepointIT test is not run due to wrong name

2021-01-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-21031: - Affects Version/s: 1.9.0 > JobMasterStopWithSavepointIT test is not run due to wrong

[jira] [Updated] (FLINK-21031) JobMasterStopWithSavepointIT test is not run due to wrong name

2021-01-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-21031: - Description: The {{JobMasterStopWithSavepointIT}} test is not run when testing via

[GitHub] [flink] wangyang0918 commented on pull request #14692: [FLINK-20944][k8s] Do not resolve the rest endpoint address when the service exposed type is ClusterIP

2021-01-19 Thread GitBox
wangyang0918 commented on pull request #14692: URL: https://github.com/apache/flink/pull/14692#issuecomment-762900776 Both the detached/attached mode for application, the submission process does not need to create a `RestClusterClient`. Currently, we only use the `RestClusterClient` to

[GitHub] [flink] wangyang0918 edited a comment on pull request #14692: [FLINK-20944][k8s] Do not resolve the rest endpoint address when the service exposed type is ClusterIP

2021-01-19 Thread GitBox
wangyang0918 edited a comment on pull request #14692: URL: https://github.com/apache/flink/pull/14692#issuecomment-762900776 Both the detached/attached mode for application, the submission process does not need to create a `RestClusterClient`. Currently, we only use the

[jira] [Closed] (FLINK-21009) Can not disable certain options in Elasticsearch 7 connector

2021-01-19 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-21009. Resolution: Fixed Fixed in: * master ** 9f24c486c87238aeee0083f57ca4e1b132c22bfb * 1.12.2

[GitHub] [flink] zentol commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config

2021-01-19 Thread GitBox
zentol commented on a change in pull request #14694: URL: https://github.com/apache/flink/pull/14694#discussion_r560313932 ## File path: tools/azure-pipelines/jobs-template.yml ## @@ -199,7 +199,7 @@ jobs: condition: not(eq(variables['SKIP'], '1')) - task: Cache@2

[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14637: URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085 ## CI report: * e02d849c359db923aa91235d9756f055cb44c362 Azure:

[jira] [Closed] (FLINK-20949) Separate the implementation of sink nodes

2021-01-19 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-20949. -- Resolution: Fixed Fixed in 1.13.0: 95257a25..53ab2596 > Separate the implementation of sink nodes >

[GitHub] [flink] rmetzger commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config

2021-01-19 Thread GitBox
rmetzger commented on a change in pull request #14694: URL: https://github.com/apache/flink/pull/14694#discussion_r560209321 ## File path: tools/azure-pipelines/jobs-template.yml ## @@ -199,7 +199,7 @@ jobs: condition: not(eq(variables['SKIP'], '1')) - task:

[jira] [Commented] (FLINK-21030) Broken job restart for job with disjoint graph

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267923#comment-17267923 ] Till Rohrmann commented on FLINK-21030: --- Thanks for reporting this issue [~TheoD]. I agree that

[jira] [Created] (FLINK-21033) Remove PendingCheckpoint.statsCallback

2021-01-19 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-21033: - Summary: Remove PendingCheckpoint.statsCallback Key: FLINK-21033 URL: https://issues.apache.org/jira/browse/FLINK-21033 Project: Flink Issue Type:

[jira] [Commented] (FLINK-20995) Calling execute() on org.apache.flink.table.api.Table Throws Exception

2021-01-19 Thread shizhengchao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267996#comment-17267996 ] shizhengchao commented on FLINK-20995: -- Did you submit the task through the web interface ? >

[jira] [Commented] (FLINK-21028) Streaming application didn't stop properly

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268008#comment-17268008 ] Till Rohrmann commented on FLINK-21028: --- Alright, thanks for the clarification [~TheoD]. I think

[jira] [Comment Edited] (FLINK-20992) Checkpoint cleanup can kill JobMaster

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267853#comment-17267853 ] Till Rohrmann edited comment on FLINK-20992 at 1/19/21, 12:13 PM: -- If

[jira] [Commented] (FLINK-20992) Checkpoint cleanup can kill JobMaster

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267853#comment-17267853 ] Till Rohrmann commented on FLINK-20992: --- If you call {{handleAsync}}, then this is the case.

[jira] [Comment Edited] (FLINK-20992) Checkpoint cleanup can kill JobMaster

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267853#comment-17267853 ] Till Rohrmann edited comment on FLINK-20992 at 1/19/21, 12:13 PM: -- If

[jira] [Updated] (FLINK-21031) JobMasterStopWithSavepointIT test is not run due to wrong name

2021-01-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-21031: - Description: The {{JobMasterStopWithSavepointIT}} test is not run when testing via

[jira] [Commented] (FLINK-20992) Checkpoint cleanup can kill JobMaster

2021-01-19 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267951#comment-17267951 ] Roman Khachatryan commented on FLINK-20992: --- I see what you're saying. But the current code

[GitHub] [flink] zentol edited a comment on pull request #14630: [FLINK-20915][docker] Move docker entrypoint to distribution

2021-01-19 Thread GitBox
zentol edited a comment on pull request #14630: URL: https://github.com/apache/flink/pull/14630#issuecomment-762796099 > How much of that is actually specific to using Flink in Docker[...]? As it stands, I'd say everything. Let's go through it shall we: 1. Setting of certain

[jira] [Assigned] (FLINK-21020) Bump Jackson to 2.12.1

2021-01-19 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-21020: --- Assignee: Huang Xingbo > Bump Jackson to 2.12.1 > -- > > Key:

[jira] [Assigned] (FLINK-21021) Bump Beam to 2.27.0

2021-01-19 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-21021: --- Assignee: Huang Xingbo > Bump Beam to 2.27.0 > --- > > Key:

[GitHub] [flink] leonardBang commented on pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-19 Thread GitBox
leonardBang commented on pull request #14684: URL: https://github.com/apache/flink/pull/14684#issuecomment-762817601 I'll take a look this PR, @wuchong . @anlen321 Looks like you fixed the conflicts with `git merge` command, it's recommended to use `git rebase master` command to fix

[GitHub] [flink] zhisheng17 commented on a change in pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-19 Thread GitBox
zhisheng17 commented on a change in pull request #14684: URL: https://github.com/apache/flink/pull/14684#discussion_r560152830 ## File path: flink-connectors/flink-connector-hbase-2.2/src/main/java/org/apache/flink/connector/hbase2/source/HBaseRowDataAsyncLookupFunction.java

[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14659: URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709 ## CI report: * 1b050c2b3acb1c1309e9053364a6f22731dba21a Azure:

[jira] [Commented] (FLINK-21028) Streaming application didn't stop properly

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267933#comment-17267933 ] Till Rohrmann commented on FLINK-21028: --- Thanks for creating this issue [~TheoD]. How does this

[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14694: URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714 ## CI report: * 1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14697: [FLINK-21024][dist] Keep dynamic properties before job arguments.

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14697: URL: https://github.com/apache/flink/pull/14697#issuecomment-762786872 ## CI report: * 2bcacd1650a73b29652336934d514b423f3f636a Azure:

[jira] [Commented] (FLINK-21008) ClusterEntrypoint#shutDownAsync may not be fully executed

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267854#comment-17267854 ] Till Rohrmann commented on FLINK-21008: --- Is it possible to ignore the SIGTERM signal in the JVM?

[GitHub] [flink] flinkbot edited a comment on pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14633: URL: https://github.com/apache/flink/pull/14633#issuecomment-759451108 ## CI report: * 4740cf1d2d0a16700698f5f2108ee4a310d942dd UNKNOWN * 00801e0afc7a16f4dbe36493b6df148b70af1de2 Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #14683: [FLINK-20992][checkpointing] Tolerate checkpoint cleanup failures

2021-01-19 Thread GitBox
tillrohrmann commented on a change in pull request #14683: URL: https://github.com/apache/flink/pull/14683#discussion_r560143586 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java ## @@ -62,8 +62,15 @@ public void

[GitHub] [flink] zhisheng17 commented on a change in pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-19 Thread GitBox
zhisheng17 commented on a change in pull request #14684: URL: https://github.com/apache/flink/pull/14684#discussion_r560152221 ## File path: flink-connectors/flink-connector-hbase-2.2/src/main/java/org/apache/flink/connector/hbase2/source/HBaseRowDataAsyncLookupFunction.java

[GitHub] [flink] dianfu merged pull request #14690: [FLINK-20924][python][table-planner-blink] Port StreamExecPythonOverAggregate and BatchExecPythonOverAggregate to Java

2021-01-19 Thread GitBox
dianfu merged pull request #14690: URL: https://github.com/apache/flink/pull/14690 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] rkhachatryan commented on a change in pull request #14683: [FLINK-20992][checkpointing] Tolerate checkpoint cleanup failures

2021-01-19 Thread GitBox
rkhachatryan commented on a change in pull request #14683: URL: https://github.com/apache/flink/pull/14683#discussion_r560170984 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java ## @@ -62,8 +62,15 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14659: URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709 ## CI report: * 1b050c2b3acb1c1309e9053364a6f22731dba21a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14647: [FLINK-20835] Implement FineGrainedSlotManager

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14647: URL: https://github.com/apache/flink/pull/14647#issuecomment-760154591 ## CI report: * 559cd8d09cca8082e9ca4904d11b11443f4c959f Azure:

[GitHub] [flink] godfreyhe closed pull request #14685: [FLINK-21010] Separate the implementation of StreamExecJoin

2021-01-19 Thread GitBox
godfreyhe closed pull request #14685: URL: https://github.com/apache/flink/pull/14685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Assigned] (FLINK-21010) Separete the implementation of StreamExecJoin

2021-01-19 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he reassigned FLINK-21010: -- Assignee: Wenlong Lyu > Separete the implementation of StreamExecJoin >

[jira] [Closed] (FLINK-21010) Separete the implementation of StreamExecJoin

2021-01-19 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-21010. -- Resolution: Fixed Fixed in 1.13.0: df851ded8607ab9cb17b577220b86f1045cb32e5 > Separete the

[jira] [Commented] (FLINK-20913) Improve new HiveConf(jobConf, HiveConf.class)

2021-01-19 Thread Xingxing Di (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267966#comment-17267966 ] Xingxing Di commented on FLINK-20913: - [~lirui] , I would like to, and i'm working on it. > Improve

[GitHub] [flink] flinkbot edited a comment on pull request #14692: [FLINK-20944][k8s] Do not resolve the rest endpoint address when the service exposed type is ClusterIP

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14692: URL: https://github.com/apache/flink/pull/14692#issuecomment-762669595 ## CI report: * 5f74749ef6ff2e0092a6b563a0261fe234a54fbc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14694: URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714 ## CI report: * e119c9031124430fb5bb93314c0d09826730b24a Azure:

[jira] [Updated] (FLINK-21032) JsonFileCompactionITCase fails on azure

2021-01-19 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-21032: - Affects Version/s: (was: 1.13.0) > JsonFileCompactionITCase fails on azure >

[jira] [Updated] (FLINK-21028) Streaming application didn't stop properly

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21028: -- Component/s: Runtime / Task > Streaming application didn't stop properly >

[jira] [Comment Edited] (FLINK-20992) Checkpoint cleanup can kill JobMaster

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267853#comment-17267853 ] Till Rohrmann edited comment on FLINK-20992 at 1/19/21, 12:15 PM: -- If

[jira] [Closed] (FLINK-20924) Port StreamExecPythonOverAggregate and BatchExecPythonOverAggregate to Java

2021-01-19 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-20924. --- Assignee: Huang Xingbo Resolution: Fixed Merged to master via 

[jira] [Updated] (FLINK-21032) JsonFileCompactionITCase fails on azure

2021-01-19 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-21032: --- Labels: test-stability (was: ) > JsonFileCompactionITCase fails on azure >

[GitHub] [flink] flinkbot edited a comment on pull request #14689: [FLINK-20500][upsert-kafka] Fix temporal join test

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14689: URL: https://github.com/apache/flink/pull/14689#issuecomment-762595621 ## CI report: * 3e8786051223f482699028c5d1683aa66e44e1aa Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14694: URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714 ## CI report: * 1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d Azure:

[GitHub] [flink] sjwiesman closed pull request #14594: [FLINK-20551][docs] Make SQL documentation Blink only

2021-01-19 Thread GitBox
sjwiesman closed pull request #14594: URL: https://github.com/apache/flink/pull/14594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot edited a comment on pull request #14647: [FLINK-20835] Implement FineGrainedSlotManager

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14647: URL: https://github.com/apache/flink/pull/14647#issuecomment-760154591 ## CI report: * 05733d3630a9a72d04545e2e8aeefdf76b2e5cf1 Azure:

[jira] [Commented] (FLINK-21008) ClusterEntrypoint#shutDownAsync may not be fully executed

2021-01-19 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267983#comment-17267983 ] Yang Wang commented on FLINK-21008: --- We could implement an empty {{SignalHandler}}. And then register

[GitHub] [flink] flinkbot edited a comment on pull request #14698: [hotfix][javadoc] Correct the wrong spelling 'perserves' to 'preserves'.

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14698: URL: https://github.com/apache/flink/pull/14698#issuecomment-762796344 ## CI report: * 92e0d648d5e7b56bcb164e9889652c186922de17 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14698: [hotfix][javadoc] Correct the wrong spelling 'perserves' to 'preserves'.

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14698: URL: https://github.com/apache/flink/pull/14698#issuecomment-762796344 ## CI report: * 92e0d648d5e7b56bcb164e9889652c186922de17 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14692: [FLINK-20944][k8s] Do not resolve the rest endpoint address when the service exposed type is ClusterIP

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14692: URL: https://github.com/apache/flink/pull/14692#issuecomment-762669595 ## CI report: * 48ef644b381d5f9f0dd030857fcaab5e80ab4a97 Azure:

[GitHub] [flink] twalthr closed pull request #14660: [FLINK-20971][table-api-java] Support calling SQL expressions in Table API

2021-01-19 Thread GitBox
twalthr closed pull request #14660: URL: https://github.com/apache/flink/pull/14660 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14694: URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714 ## CI report: * 1c8e22e046a15d442e4d0bcdec73c6ea5b4a3f2d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14637: URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085 ## CI report: * e02d849c359db923aa91235d9756f055cb44c362 Azure:

[jira] [Updated] (FLINK-21030) Broken job restart for job with disjoint graph

2021-01-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-21030: - Priority: Blocker (was: Critical) > Broken job restart for job with disjoint graph >

[GitHub] [flink] zentol edited a comment on pull request #14630: [FLINK-20915][docker] Move docker entrypoint to distribution

2021-01-19 Thread GitBox
zentol edited a comment on pull request #14630: URL: https://github.com/apache/flink/pull/14630#issuecomment-762796099 > How much of that is actually specific to using Flink in Docker[...]? As it stands, I'd say everything. Let's go through it shall we: 1. Setting of certain

[GitHub] [flink] wangyang0918 commented on pull request #14692: [FLINK-20944][k8s] Do not resolve the rest endpoint address when the service exposed type is ClusterIP

2021-01-19 Thread GitBox
wangyang0918 commented on pull request #14692: URL: https://github.com/apache/flink/pull/14692#issuecomment-762848713 @tillrohrmann I have the same concern before implement this PR. But now I think this change makes sense since Flink client will not retrieve the result in the application

[GitHub] [flink] rkhachatryan commented on a change in pull request #14683: [FLINK-20992][checkpointing] Tolerate checkpoint cleanup failures

2021-01-19 Thread GitBox
rkhachatryan commented on a change in pull request #14683: URL: https://github.com/apache/flink/pull/14683#discussion_r560170984 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java ## @@ -62,8 +62,15 @@ public void

[GitHub] [flink] zentol edited a comment on pull request #14630: [FLINK-20915][docker] Move docker entrypoint to distribution

2021-01-19 Thread GitBox
zentol edited a comment on pull request #14630: URL: https://github.com/apache/flink/pull/14630#issuecomment-762796099 > How much of that is actually specific to using Flink in Docker[...]? As it stands, I'd say everything. Let's go through it shall we: 1. Setting of certain

[GitHub] [flink] godfreyhe closed pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes

2021-01-19 Thread GitBox
godfreyhe closed pull request #14637: URL: https://github.com/apache/flink/pull/14637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] rmetzger commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config

2021-01-19 Thread GitBox
rmetzger commented on a change in pull request #14694: URL: https://github.com/apache/flink/pull/14694#discussion_r560208530 ## File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java ## @@

[jira] [Created] (FLINK-21032) JsonFileCompactionITCase fails on azure

2021-01-19 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-21032: Summary: JsonFileCompactionITCase fails on azure Key: FLINK-21032 URL: https://issues.apache.org/jira/browse/FLINK-21032 Project: Flink Issue Type:

[GitHub] [flink] tillrohrmann commented on pull request #14692: [FLINK-20944][k8s] Do not resolve the rest endpoint address when the service exposed type is ClusterIP

2021-01-19 Thread GitBox
tillrohrmann commented on pull request #14692: URL: https://github.com/apache/flink/pull/14692#issuecomment-762891085 You are right with the per-job-mode and K8s @wangyang0918. Hence, this was a bad example ;-) But the example of canceling the job/application is actually a good one. If we

[jira] [Commented] (FLINK-21028) Streaming application didn't stop properly

2021-01-19 Thread Theo Diefenthal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267989#comment-17267989 ] Theo Diefenthal commented on FLINK-21028: - Hi Till, thanks for your feedback. Originally on the

[jira] [Commented] (FLINK-21029) Failure of shutdown lead to restart of (connected) pipeline

2021-01-19 Thread Theo Diefenthal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267995#comment-17267995 ] Theo Diefenthal commented on FLINK-21029: - Hi [~trohrmann] , good question indeed. When I

[jira] [Commented] (FLINK-4714) Set task state to RUNNING after state has been restored

2021-01-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268018#comment-17268018 ] Piotr Nowojski commented on FLINK-4714: --- Technically speaking FLINK-17012 is duplicating this

[jira] [Commented] (FLINK-21008) ClusterEntrypoint#shutDownAsync may not be fully executed

2021-01-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268028#comment-17268028 ] Till Rohrmann commented on FLINK-21008: --- I think I would be in favour of triggering a

[jira] [Commented] (FLINK-21029) Failure of shutdown lead to restart of (connected) pipeline

2021-01-19 Thread Theo Diefenthal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268045#comment-17268045 ] Theo Diefenthal commented on FLINK-21029: - Ah you are right again. I ghought for a moment that

[GitHub] [flink] flinkbot edited a comment on pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config

2021-01-19 Thread GitBox
flinkbot edited a comment on pull request #14694: URL: https://github.com/apache/flink/pull/14694#issuecomment-762699714 ## CI report: * e119c9031124430fb5bb93314c0d09826730b24a Azure:

  1   2   3   4   >