[jira] [Updated] (FLINK-25284) Support nulls in DataGen

2023-06-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-25284: Fix Version/s: 1.18.0 > Support nulls in DataGen > > >

[jira] [Resolved] (FLINK-25284) Support nulls in DataGen

2023-06-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-25284. - Resolution: Fixed Merged as

[GitHub] [flink] flinkbot commented on pull request #22704: Flink 30660 hive 3

2023-06-04 Thread via GitHub
flinkbot commented on PR #22704: URL: https://github.com/apache/flink/pull/22704#issuecomment-1575951509 ## CI report: * 5b6232b98d851c5f37536d67876f7bb3f37a58ee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] LadyForest opened a new pull request, #22703: [FLINK-32219][sql-client] Fix SqlClient hangs when executing EXECUTE PLAN statement

2023-06-04 Thread via GitHub
LadyForest opened a new pull request, #22703: URL: https://github.com/apache/flink/pull/22703 ## What is the purpose of the change This PR fixes the issue that the `COMPILE AND EXECUTE PLAN` or `EXECUTE PLAN` statement causes the SQL client to hang forever. The reason is that

[jira] [Updated] (FLINK-32219) SQL client hangs when executing EXECUTE PLAN

2023-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32219: --- Labels: pull-request-available (was: ) > SQL client hangs when executing EXECUTE PLAN >

[jira] [Commented] (FLINK-26803) Merge small ChannelState file for Unaligned Checkpoint

2023-06-04 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729069#comment-17729069 ] Dong Lin commented on FLINK-26803: -- FLIP-306 seems to be relate to this JIRA. But the newly added

[jira] [Updated] (FLINK-32240) Update Flink client to 1.17.1

2023-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32240: --- Labels: pull-request-available (was: ) > Update Flink client to 1.17.1 >

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #611: [FLINK-32240] Upgrade Flink to 1.17.1

2023-06-04 Thread via GitHub
gyfora opened a new pull request, #611: URL: https://github.com/apache/flink-kubernetes-operator/pull/611 ## What is the purpose of the change Upgrade Flink client and example base version to 1.17.1 to levarage fixes and client improvements in newer version. ## Brief change

[jira] [Created] (FLINK-32249) A Java string should be used instead of a Calcite NlsString to construct the table and column comment attributes of CatalogTable

2023-06-04 Thread lincoln lee (Jira)
lincoln lee created FLINK-32249: --- Summary: A Java string should be used instead of a Calcite NlsString to construct the table and column comment attributes of CatalogTable Key: FLINK-32249 URL:

[jira] [Assigned] (FLINK-32219) SQL client hangs when executing EXECUTE PLAN

2023-06-04 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-32219: - Assignee: Jane Chan > SQL client hangs when executing EXECUTE PLAN >

[jira] [Commented] (FLINK-32219) SQL client hangs when executing EXECUTE PLAN

2023-06-04 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729133#comment-17729133 ] Jane Chan commented on FLINK-32219: --- Hi, [~xu_shuai_] Thanks for reporting this issue.

[GitHub] [flink] luoyuxia commented on a diff in pull request #22593: [FLINK-32053][table-planner] Introduce StateMetadata to ExecNode to support configure operator-level state TTL via CompiledPlan

2023-06-04 Thread via GitHub
luoyuxia commented on code in PR #22593: URL: https://github.com/apache/flink/pull/22593#discussion_r1217342980 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java: ## @@ -332,7 +319,7 @@ protected

[jira] [Commented] (FLINK-26803) Merge small ChannelState file for Unaligned Checkpoint

2023-06-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729143#comment-17729143 ] Rui Fan commented on FLINK-26803: - {quote}The PR of this JIRA introduced a new public evolving API

[GitHub] [flink] dchristle commented on pull request #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

2023-06-04 Thread via GitHub
dchristle commented on PR #21729: URL: https://github.com/apache/flink/pull/21729#issuecomment-1575702300 @Myasuka Got it - I just rebased on the latest master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] reswqa commented on pull request #22675: [FLINK-32213][core] Add get off heap buffer in segment

2023-06-04 Thread via GitHub
reswqa commented on PR #22675: URL: https://github.com/apache/flink/pull/22675#issuecomment-1575948406 Merging % CI green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #22703: [FLINK-32219][sql-client] Fix SqlClient hangs when executing EXECUTE PLAN statement

2023-06-04 Thread via GitHub
flinkbot commented on PR #22703: URL: https://github.com/apache/flink/pull/22703#issuecomment-1575948503 ## CI report: * 4c05fdfece001f7a1d5e9788144779221bbc5ea4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia opened a new pull request, #22704: Flink 30660 hive 3

2023-06-04 Thread via GitHub
luoyuxia opened a new pull request, #22704: URL: https://github.com/apache/flink/pull/22704 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Comment Edited] (FLINK-26803) Merge small ChannelState file for Unaligned Checkpoint

2023-06-04 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729067#comment-17729067 ] Dong Lin edited comment on FLINK-26803 at 6/4/23 2:02 PM: -- The PR of this JIRA

[jira] [Commented] (FLINK-26803) Merge small ChannelState file for Unaligned Checkpoint

2023-06-04 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729067#comment-17729067 ] Dong Lin commented on FLINK-26803: -- The PR of this JIRA introduced a new public evolving API

[jira] [Resolved] (FLINK-30751) Remove references to disableDataSync in RocksDB documentation

2023-06-04 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-30751. -- Fix Version/s: 1.18.0 1.16.3 1.17.2 Resolution: Fixed

[GitHub] [flink] luoyuxia commented on a diff in pull request #21927: [FLINK-30966][table-planner] Optimize type inference for Character type and fix result type casting in IfCallGen

2023-06-04 Thread via GitHub
luoyuxia commented on code in PR #21927: URL: https://github.com/apache/flink/pull/21927#discussion_r1217441125 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala: ## @@ -366,6 +366,24 @@ class CalcITCase extends

[GitHub] [flink] flinkbot commented on pull request #22706: [BP-1.17][FLINK-32199][rest] Remove redundant metrics in TaskMetricStore after rescale down.

2023-06-04 Thread via GitHub
flinkbot commented on PR #22706: URL: https://github.com/apache/flink/pull/22706#issuecomment-1576033592 ## CI report: * 4f2a948d3460ed53b2eca731691a057a44acc6de UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] reswqa commented on pull request #22675: [FLINK-32213][core] Add get off heap buffer in segment

2023-06-04 Thread via GitHub
reswqa commented on PR #22675: URL: https://github.com/apache/flink/pull/22675#issuecomment-1576033759 It seems that e2e test is failed, maybe we should rebase the latest `master` branch to see if it is fixed. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (FLINK-32250) Revert the Field name of BUFFER_TIMEOUT to improve compatibility

2023-06-04 Thread Rui Fan (Jira)
Rui Fan created FLINK-32250: --- Summary: Revert the Field name of BUFFER_TIMEOUT to improve compatibility Key: FLINK-32250 URL: https://issues.apache.org/jira/browse/FLINK-32250 Project: Flink

[GitHub] [flink] reswqa commented on pull request #22707: [FLINK-32250][configuration] Revert the field name of BUFFER_TIMEOUT

2023-06-04 Thread via GitHub
reswqa commented on PR #22707: URL: https://github.com/apache/flink/pull/22707#issuecomment-1576088667 I'm not very sure if we need to ensure the compatibility of field names, but FLINK-29372 seems to have made changes as well. -- This is an automated message from the Apache Git Service.

[jira] [Updated] (FLINK-32249) A Java string should be used instead of a Calcite NlsString to construct the table and column comment attributes of CatalogTable

2023-06-04 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-32249: Description: when Flink interacts with CatalogTable, it directly passes the Calcite's NlsString

[GitHub] [flink] shuiqiangchen commented on a diff in pull request #21927: [FLINK-30966][table-planner] Optimize type inference for Character type and fix result type casting in IfCallGen

2023-06-04 Thread via GitHub
shuiqiangchen commented on code in PR #21927: URL: https://github.com/apache/flink/pull/21927#discussion_r1217473915 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala: ## @@ -366,6 +366,24 @@ class CalcITCase

[GitHub] [flink] TanYuxin-tyx commented on pull request #22652: [FLINK-31640][network] Write the accumulated buffers to the right storage tier

2023-06-04 Thread via GitHub
TanYuxin-tyx commented on PR #22652: URL: https://github.com/apache/flink/pull/22652#issuecomment-1575978610 I rebased on the master branch to trigger tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] Myasuka closed pull request #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

2023-06-04 Thread via GitHub
Myasuka closed pull request #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation URL: https://github.com/apache/flink/pull/21729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] 1996fanrui commented on pull request #22673: [BP-1.16][FLINK-32023][API / DataStream] Add config execution.buffer-…

2023-06-04 Thread via GitHub
1996fanrui commented on PR #22673: URL: https://github.com/apache/flink/pull/22673#issuecomment-1575991090 Hi @Myracle , the commit message shouldn't add the `[BP-1.16]`as the prefix, the commit message should be the same with master branch, could you help update the commit message? --

[GitHub] [flink] 1996fanrui commented on pull request #22672: [BP-1.17][FLINK-32023][API / DataStream] Add config execution.buffer-…

2023-06-04 Thread via GitHub
1996fanrui commented on PR #22672: URL: https://github.com/apache/flink/pull/22672#issuecomment-1575991177 Hi @Myracle , the commit message shouldn't add the `[BP-1.17]`as the prefix, the commit message should be the same with master branch, could you help update the commit message? --

[GitHub] [flink] JunRuiLee opened a new pull request, #22705: [BP-1.16][FLINK-32199][rest] Remove redundant metrics in TaskMetricStore after rescale down.

2023-06-04 Thread via GitHub
JunRuiLee opened a new pull request, #22705: URL: https://github.com/apache/flink/pull/22705 Backports [FLINK-32199](https://issues.apache.org/jira/browse/FLINK-32199) to release-1.17. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] flinkbot commented on pull request #22705: [BP-1.16][FLINK-32199][rest] Remove redundant metrics in TaskMetricStore after rescale down.

2023-06-04 Thread via GitHub
flinkbot commented on PR #22705: URL: https://github.com/apache/flink/pull/22705#issuecomment-1575995705 ## CI report: * 0f2164b1ef7a2b70c6980d8d26702c171bbcc97d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] JunRuiLee commented on pull request #22681: [FLINK-32199][runtime] Remove redundant metrics in TaskMetricStore after rescale down

2023-06-04 Thread via GitHub
JunRuiLee commented on PR #22681: URL: https://github.com/apache/flink/pull/22681#issuecomment-1576031799 @wanglijie95 Thanks for reminding. 1.16:https://github.com/apache/flink/pull/22705 1.17:https://github.com/apache/flink/pull/22706 -- This is an automated message from

[GitHub] [flink] JunRuiLee opened a new pull request, #22706: [BP-1.17][FLINK-32199][rest] Remove redundant metrics in TaskMetricStore after rescale down.

2023-06-04 Thread via GitHub
JunRuiLee opened a new pull request, #22706: URL: https://github.com/apache/flink/pull/22706 Backports [FLINK-32199](https://issues.apache.org/jira/browse/FLINK-32199) to release-1.17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (FLINK-26803) Merge small ChannelState file for Unaligned Checkpoint

2023-06-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729170#comment-17729170 ] Rui Fan commented on FLINK-26803: - {quote}It is probably good to always have a FLIP approved for any

[jira] [Commented] (FLINK-32249) A Java string should be used instead of a Calcite NlsString to construct the table and column comment attributes of CatalogTable

2023-06-04 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729175#comment-17729175 ] Aitozi commented on FLINK-32249: It does not reproduce in my local sql client {code:java} Flink SQL>

[jira] [Commented] (FLINK-26803) Merge small ChannelState file for Unaligned Checkpoint

2023-06-04 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729166#comment-17729166 ] Dong Lin commented on FLINK-26803: -- [~fanrui] I see. Thanks for the information. The API change

[GitHub] [flink] flinkbot commented on pull request #22707: [FLINK-32250][configuration] Revert the field name of BUFFER_TIMEOUT

2023-06-04 Thread via GitHub
flinkbot commented on PR #22707: URL: https://github.com/apache/flink/pull/22707#issuecomment-1576059973 ## CI report: * 6b63df5604ea2541d9526442403b53e3c55bd143 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] 1996fanrui opened a new pull request, #22707: [FLINK-32250][configuration] Revert the field name of BUFFER_TIMEOUT

2023-06-04 Thread via GitHub
1996fanrui opened a new pull request, #22707: URL: https://github.com/apache/flink/pull/22707 ## What is the purpose of the change [FLINK-32023](https://issues.apache.org/jira/browse/FLINK-32023) changed the `ExecutionOptions.BUFFER_TIMEOUT` to

[jira] [Updated] (FLINK-32250) Revert the Field name of BUFFER_TIMEOUT to improve compatibility

2023-06-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32250: --- Labels: pull-request-available (was: ) > Revert the Field name of BUFFER_TIMEOUT to

[GitHub] [flink] fredia commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-04 Thread via GitHub
fredia commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1216309817 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java: ## @@ -395,18

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-04 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1216375020 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java: ## @@ -395,18