Re: [PR] [FLINK-33612][table-planner] Hybrid shuffle mode avoids unnecessary blocking edges in the plan [flink]

2023-12-11 Thread via GitHub
lsyldliu commented on code in PR #23771: URL: https://github.com/apache/flink/pull/23771#discussion_r1422369948 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/utils/InputPriorityConflictResolverTest.java: ## @@ -30,19

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
pvary commented on code in PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#discussion_r1422406134 ## .github/workflows/python_ci.yml: ## @@ -23,6 +23,11 @@ on: description: "Flink version to test against." required: true

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
pvary commented on code in PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#discussion_r1422406134 ## .github/workflows/python_ci.yml: ## @@ -23,6 +23,11 @@ on: description: "Flink version to test against." required: true

[jira] [Updated] (FLINK-33797) Flink application FAILED log in info instead of warn

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33797: --- Labels: pull-request-available (was: ) > Flink application FAILED log in info instead of

[jira] [Assigned] (FLINK-33798) Automatically clean up rocksdb logs when the task failover.

2023-12-11 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33798: --- Assignee: Ming Li > Automatically clean up rocksdb logs when the task failover. >

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2023-12-11 Thread via GitHub
flinkbot commented on PR #23908: URL: https://github.com/apache/flink/pull/23908#issuecomment-1850185232 ## CI report: * a2f09acdf5ef582f951296d7b5ed5f65a87d049f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
snuyanzin commented on code in PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#discussion_r1422535978 ## .github/workflows/python_ci.yml: ## @@ -23,6 +23,11 @@ on: description: "Flink version to test against." required: true

[jira] [Comment Edited] (FLINK-24865) Support MATCH_RECOGNIZE in Batch mode

2023-12-11 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795323#comment-17795323 ] Grzegorz Kołakowski edited comment on FLINK-24865 at 12/11/23 12:47 PM:

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-11 Thread via GitHub
pnowojski merged PR #23845: URL: https://github.com/apache/flink/pull/23845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
1996fanrui commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1422419813 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -297,6 +301,28 @@ private void

[jira] [Commented] (FLINK-33696) FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795363#comment-17795363 ] Piotr Nowojski commented on FLINK-33696: merged 7db2ecad165 to master > FLIP-385: Add

[jira] [Commented] (FLINK-33798) Automatically clean up rocksdb logs when the task failover.

2023-12-11 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795377#comment-17795377 ] Rui Fan commented on FLINK-33798: - Thanks [~liming] for reporting this bug. When the log isn't

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
1996fanrui commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1422568938 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/RestApiMetricsCollector.java: ## @@ -78,19 +91,87 @@ protected Map

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
mxm commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1422597784 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/RestApiMetricsCollector.java: ## @@ -78,19 +91,87 @@ protected Map

[jira] [Created] (FLINK-33793) java.lang.NoSuchMethodError when checkpointing in Google Cloud Storage

2023-12-11 Thread 陳昌倬
ChangZhuo Chen (陳昌倬) created FLINK-33793: Summary: java.lang.NoSuchMethodError when checkpointing in Google Cloud Storage Key: FLINK-33793 URL: https://issues.apache.org/jira/browse/FLINK-33793

[jira] [Commented] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-11 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795248#comment-17795248 ] Jing Ge commented on FLINK-33588: - [~zhutong66] do you want to fix the checkstyle issue in the PR and cp

[jira] [Comment Edited] (FLINK-20695) Zookeeper node under leader and leaderlatch is not deleted after job finished

2023-12-11 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795250#comment-17795250 ] Xin Chen edited comment on FLINK-20695 at 12/11/23 9:09 AM: Can the PR fix

[jira] [Created] (FLINK-33794) After Flink Avro deserialization fails, subsequent correct data cannot be deserialized correctly

2023-12-11 Thread WeichengJi (Jira)
WeichengJi created FLINK-33794: -- Summary: After Flink Avro deserialization fails, subsequent correct data cannot be deserialized correctly Key: FLINK-33794 URL: https://issues.apache.org/jira/browse/FLINK-33794

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-11 Thread via GitHub
xiangforever2014 commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1849650290 > > > Hi @xiangforever2014 @masteryhx sorry for jumping in... And I'm wondering if we could use the capital '-D' for short option? Or I suggest we do not leave any short option

Re: [PR] [FLINK-33714][doc] Update the documentation about the usage of RuntimeContext#getExecutionConfig. [flink]

2023-12-11 Thread via GitHub
flinkbot commented on PR #23906: URL: https://github.com/apache/flink/pull/23906#issuecomment-1849710085 ## CI report: * d0e0c3f21c75b2cecff6ee010c4ddd6e10906ed4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [build][hotfix] Release branch should use SNAPSHOT version [flink-connector-pulsar]

2023-12-11 Thread via GitHub
leonardBang opened a new pull request, #66: URL: https://github.com/apache/flink-connector-pulsar/pull/66 ## Purpose of the change hotfix: fix version in release branch ## Verifying this change Please make sure both new and modified tests in this PR follows

[jira] [Commented] (FLINK-33751) use modules correctly when deserializing json plan

2023-12-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795289#comment-17795289 ] Benchao Li commented on FLINK-33751: CC [~dwysakowicz] since I saw you have some activities on json

Re: [PR] [build] Bump version to 4.2-SNAPSHOT [flink-connector-pulsar]

2023-12-11 Thread via GitHub
tisonkun commented on code in PR #67: URL: https://github.com/apache/flink-connector-pulsar/pull/67#discussion_r1422300397 ## docs/data/pulsar.yml: ## @@ -16,7 +16,7 @@ # limitations under the License.

Re: [PR] [FLINK-33719][table] Cleanup the usage of deprecated StreamTableEnvir… [flink]

2023-12-11 Thread via GitHub
liuyongvs commented on PR #23898: URL: https://github.com/apache/flink/pull/23898#issuecomment-1849837960 > Thanks for the contribution > > 1. can you please fix PR description accordingly? > 2. it seems the PR does not clean up all usages (at least in planner), however it should

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
snuyanzin commented on PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#issuecomment-1849915282 @gaborgsomogyi , @dianfu since you had a look at smilar PR can I ask you to hava a look here please? -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-33612][table-planner] Hybrid shuffle mode avoids unnecessary blocking edges in the plan [flink]

2023-12-11 Thread via GitHub
TanYuxin-tyx commented on code in PR #23771: URL: https://github.com/apache/flink/pull/23771#discussion_r1422403200 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/utils/InputPriorityConflictResolverTest.java: ## @@

Re: [PR] [FLINK-33612][table-planner] Hybrid shuffle mode avoids unnecessary blocking edges in the plan [flink]

2023-12-11 Thread via GitHub
TanYuxin-tyx commented on PR #23771: URL: https://github.com/apache/flink/pull/23771#issuecomment-1849994039 @lsyldliu Thanks for reviewing. I have addressed the comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-25565][Formats][Parquet] timestamp int64 option tidy up [flink]

2023-12-11 Thread via GitHub
tweise merged PR #23900: URL: https://github.com/apache/flink/pull/23900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-33797) Flink application FAILED log in info instead of warn

2023-12-11 Thread Nicolas Fraison (Jira)
Nicolas Fraison created FLINK-33797: --- Summary: Flink application FAILED log in info instead of warn Key: FLINK-33797 URL: https://issues.apache.org/jira/browse/FLINK-33797 Project: Flink

[jira] [Closed] (FLINK-33709) Report CheckpointStats as Spans

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-33709. -- Fix Version/s: 1.19.0 Resolution: Fixed Merged f5039a8824e to master > Report

[jira] [Closed] (FLINK-33708) Add Span and TraceReporter concepts

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-33708. -- Fix Version/s: 1.19.0 Assignee: Piotr Nowojski Resolution: Fixed Merged

[jira] [Comment Edited] (FLINK-33708) Add Span and TraceReporter concepts

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795364#comment-17795364 ] Piotr Nowojski edited comment on FLINK-33708 at 12/11/23 1:21 PM: --

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-11 Thread via GitHub
schulzp commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1850111290 @reswqa, fixed the cause of the `NotSerializableException` (implicit reference of anonymous class to `ElasticsearchSinkBuilderBase`). CI should pass now. -- This is

[jira] [Comment Edited] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795401#comment-17795401 ] Matthias Pohl edited comment on FLINK-33641 at 12/11/23 2:51 PM: -

[jira] [Commented] (FLINK-32184) Use revision version property

2023-12-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795319#comment-17795319 ] Sergey Nuyanzin commented on FLINK-32184: - [~chesnay] are going to continue here ? I'm asking

Re: [PR] [FLINK-33361][Connectors/Kafka] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]

2023-12-11 Thread via GitHub
MartijnVisser commented on code in PR #68: URL: https://github.com/apache/flink-connector-kafka/pull/68#discussion_r1422422887 ## pom.xml: ## @@ -78,6 +78,13 @@ under the License. 2.17.1 flink-connector-kafka-parent + + + +

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
1996fanrui commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1422456112 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -222,6 +222,18 @@ private static

Re: [PR] [FLINK-33797] Change log level for Application CANCELED/FAILED logs to WARN [flink]

2023-12-11 Thread via GitHub
flinkbot commented on PR #23907: URL: https://github.com/apache/flink/pull/23907#issuecomment-1850082134 ## CI report: * 2afa8152962696d6f18bee5061b634fcbd6999ea UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-33798) Automatically clean up rocksdb logs when the task failover.

2023-12-11 Thread Ming Li (Jira)
Ming Li created FLINK-33798: --- Summary: Automatically clean up rocksdb logs when the task failover. Key: FLINK-33798 URL: https://issues.apache.org/jira/browse/FLINK-33798 Project: Flink Issue

[jira] [Commented] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795401#comment-17795401 ] Matthias Pohl commented on FLINK-33641: --- {{{}WindowDistinctAggregateITCase{}}}:

Re: [PR] [FLINK-33612][table-planner] Hybrid shuffle mode avoids unnecessary blocking edges in the plan [flink]

2023-12-11 Thread via GitHub
TanYuxin-tyx commented on PR #23771: URL: https://github.com/apache/flink/pull/23771#issuecomment-1850001991 In addition, I've rebased the PR onto the latest master to verify it still works properly. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-24865) Support MATCH_RECOGNIZE in Batch mode

2023-12-11 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795323#comment-17795323 ] Grzegorz Kołakowski commented on FLINK-24865: - Hi [~nicholasjiang] and [~godfreyhe]. Since

[PR] [FLINK-33797] Change log level for Application CANCELED/FAILED logs to WARN [flink]

2023-12-11 Thread via GitHub
ashangit opened a new pull request, #23907: URL: https://github.com/apache/flink/pull/23907 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Assigned] (FLINK-33709) Report CheckpointStats as Spans

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-33709: -- Assignee: Piotr Nowojski > Report CheckpointStats as Spans >

[jira] [Commented] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-11 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795391#comment-17795391 ] Feng Jin commented on FLINK-33780: -- [~liyubin117]  `default_catalog` is usually registered by the

[PR] [FLINK-33775] Report JobInitialization traces [flink]

2023-12-11 Thread via GitHub
pnowojski opened a new pull request, #23908: URL: https://github.com/apache/flink/pull/23908

[jira] [Updated] (FLINK-33775) Report JobInitialization traces

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33775: --- Labels: pull-request-available (was: ) > Report JobInitialization traces >

Re: [PR] [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig [flink]

2023-12-11 Thread via GitHub
zhuzhurk closed pull request #23848: [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig URL: https://github.com/apache/flink/pull/23848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (FLINK-33559) Externalize Kafka Python connector code

2023-12-11 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-33559. --- Resolution: Fixed > Externalize Kafka Python connector code >

Re: [PR] [FLINK-33719][table] Cleanup the usage of deprecated StreamTableEnvir… [flink]

2023-12-11 Thread via GitHub
liuyongvs commented on PR #23898: URL: https://github.com/apache/flink/pull/23898#issuecomment-1849866511 @snuyanzin and do you also help reveiw this cleanup? https://github.com/apache/flink/pull/23897 https://github.com/apache/flink/pull/23895

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
gyfora commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1422337175 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/RestApiMetricsCollector.java: ## @@ -78,19 +91,87 @@ protected Map

[PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
snuyanzin opened a new pull request, #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30 Besides adding ability to customize java version it also adds some tests for it The PR is done in a similar way it is done for non-python ci -- This is an automated message

[jira] [Closed] (FLINK-33713) Deprecate RuntimeContext#getExecutionConfig

2023-12-11 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-33713. --- Fix Version/s: 1.19.0 Resolution: Done Done via 3aa70df4e7da93ed32c26cfabdaeb606233419b1 >

[jira] [Assigned] (FLINK-33712) FLIP-391: Deprecate RuntimeContext#getExecutionConfig

2023-12-11 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-33712: --- Assignee: Junrui Li > FLIP-391: Deprecate RuntimeContext#getExecutionConfig >

[jira] [Assigned] (FLINK-33792) Generate the same code for the same logic

2023-12-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-33792: -- Assignee: Dan Zou > Generate the same code for the same logic >

[jira] [Commented] (FLINK-33559) Externalize Kafka Python connector code

2023-12-11 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795239#comment-17795239 ] Gabor Somogyi commented on FLINK-33559: --- c38a040 on main > Externalize Kafka Python connector

[jira] [Closed] (FLINK-33559) Externalize Kafka Python connector code

2023-12-11 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-33559. - > Externalize Kafka Python connector code > --- > >

Re: [PR] Dev flip 382 [flink]

2023-12-11 Thread via GitHub
flinkbot commented on PR #23905: URL: https://github.com/apache/flink/pull/23905#issuecomment-1849561441 ## CI report: * d39195d8de1bf10369709047fd338ee3606cc04b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Bump org.apache.zookeeper:zookeeper from 3.5.9 to 3.7.2 [flink-connector-kafka]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #72: URL: https://github.com/apache/flink-connector-kafka/pull/72 Bumps org.apache.zookeeper:zookeeper from 3.5.9 to 3.7.2. [![Dependabot compatibility

Re: [PR] [FLINK-33559] Externalize Kafka Python connector code [flink-connector-kafka]

2023-12-11 Thread via GitHub
gaborgsomogyi merged PR #69: URL: https://github.com/apache/flink-connector-kafka/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33559] Externalize Kafka Python connector code [flink-connector-kafka]

2023-12-11 Thread via GitHub
boring-cyborg[bot] commented on PR #69: URL: https://github.com/apache/flink-connector-kafka/pull/69#issuecomment-1849561621 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Bump org.apache.commons:commons-compress from 1.22 to 1.24.0 [flink-connector-kafka]

2023-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #73: URL: https://github.com/apache/flink-connector-kafka/pull/73 Bumps org.apache.commons:commons-compress from 1.22 to 1.24.0. [![Dependabot compatibility

[jira] [Commented] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-11 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795260#comment-17795260 ] Tongtong Zhu commented on FLINK-33588: -- I want to fix the checkstyle issue in the PR and cp to

[jira] [Comment Edited] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-11 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795260#comment-17795260 ] Tongtong Zhu edited comment on FLINK-33588 at 12/11/23 9:35 AM:

Re: [PR] [build] Bump version to 4.2-SNAPSHOT [flink-connector-pulsar]

2023-12-11 Thread via GitHub
snuyanzin commented on code in PR #67: URL: https://github.com/apache/flink-connector-pulsar/pull/67#discussion_r1422304243 ## flink-connector-pulsar-e2e-tests/pom.xml: ## @@ -23,7 +23,7 @@ under the License. org.apache.flink

[jira] [Created] (FLINK-33796) Add ability to customize java version for python ci in connectors

2023-12-11 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33796: --- Summary: Add ability to customize java version for python ci in connectors Key: FLINK-33796 URL: https://issues.apache.org/jira/browse/FLINK-33796 Project:

[jira] [Commented] (FLINK-33792) Generate the same code for the same logic

2023-12-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795235#comment-17795235 ] Benchao Li commented on FLINK-33792: [~FrankZou] Assigned to you. > Generate the same code for the

[PR] Dev flip 382 [flink]

2023-12-11 Thread via GitHub
WencongLiu opened a new pull request, #23905: URL: https://github.com/apache/flink/pull/23905 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

Re: [PR] [FLINK-32681][rocksdb][tests] Add TaskFailureCleaner to RocksDBStateD… [flink]

2023-12-11 Thread via GitHub
Myasuka closed pull request #23111: [FLINK-32681][rocksdb][tests] Add TaskFailureCleaner to RocksDBStateD… URL: https://github.com/apache/flink/pull/23111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-32681][rocksdb][tests] Add TaskFailureCleaner to RocksDBStateD… [flink]

2023-12-11 Thread via GitHub
Myasuka commented on PR #23111: URL: https://github.com/apache/flink/pull/23111#issuecomment-1849632550 Subsumed by https://github.com/apache/flink/pull/23115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Comment Edited] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-11 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795260#comment-17795260 ] Tongtong Zhu edited comment on FLINK-33588 at 12/11/23 9:28 AM:

[jira] [Updated] (FLINK-33714) Update documentation about the usage of RuntimeContext#getExecutionConfig

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33714: --- Labels: pull-request-available (was: ) > Update documentation about the usage of

[PR] [FLINK-33714][doc] Update the documentation about the usage of RuntimeContext#getExecutionConfig. [flink]

2023-12-11 Thread via GitHub
JunRuiLee opened a new pull request, #23906: URL: https://github.com/apache/flink/pull/23906 ## What is the purpose of the change Update the documentation about the usage of RuntimeContext#getExecutionConfig. ## Brief change log Update the

[jira] [Created] (FLINK-33795) Add new config to forbid autoscaling in certain periods of a day

2023-12-11 Thread yonghua jian (Jira)
yonghua jian created FLINK-33795: Summary: Add new config to forbid autoscaling in certain periods of a day Key: FLINK-33795 URL: https://issues.apache.org/jira/browse/FLINK-33795 Project: Flink

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
gyfora commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1422338471 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -222,6 +222,18 @@ private static

[jira] [Closed] (FLINK-33763) Support manual savepoint redeploy for jobs and deployments

2023-12-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33763. -- Fix Version/s: kubernetes-operator-1.8.0 Resolution: Fixed merged to main

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
gyfora merged PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-28691) Improve cache hit rate of generated class

2023-12-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-28691: -- Assignee: Dan Zou > Improve cache hit rate of generated class >

[jira] [Commented] (FLINK-28691) Improve cache hit rate of generated class

2023-12-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795237#comment-17795237 ] Benchao Li commented on FLINK-28691: [~FrankZou] Assigned to you. > Improve cache hit rate of

[jira] [Comment Edited] (FLINK-33791) Fix NPE when array is null in PostgresArrayConverter in flink-connector-jdbc

2023-12-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795236#comment-17795236 ] Sergey Nuyanzin edited comment on FLINK-33791 at 12/11/23 8:26 AM: ---

[jira] [Commented] (FLINK-20695) Zookeeper node under leader and leaderlatch is not deleted after job finished

2023-12-11 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795250#comment-17795250 ] Xin Chen commented on FLINK-20695: -- Can the PR fix the znode deletion if the jobs finish failed or

[jira] [Assigned] (FLINK-33784) CatalogStoreFactory can not be configured via StreamExecutionEnvironment

2023-12-11 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-33784: Assignee: Feng Jin > CatalogStoreFactory can not be configured via

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-11 Thread via GitHub
mxm commented on code in PR #23887: URL: https://github.com/apache/flink/pull/23887#discussion_r1422202775 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/TimestampColumnReader.java: ## @@ -109,6 +157,37 @@ public static TimestampData

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
mxm commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1422277362 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -222,6 +222,18 @@ private static

[PR] [build] Bump version to 4.2-SNAPSHOT [flink-connector-pulsar]

2023-12-11 Thread via GitHub
leonardBang opened a new pull request, #67: URL: https://github.com/apache/flink-connector-pulsar/pull/67 ## Purpose of the change [build] Bump version to 4.2-SNAPSHOT ## Verifying this change Please make sure both new and modified tests in this PR

[jira] [Updated] (FLINK-33796) Add ability to customize java version for python ci in connectors

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33796: --- Labels: pull-request-available (was: ) > Add ability to customize java version for python

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-11 Thread via GitHub
1996fanrui commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1422192659 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java: ## @@ -1244,8 +1244,8 @@ void

[jira] [Commented] (FLINK-33784) CatalogStoreFactory can not be configured via StreamExecutionEnvironment

2023-12-11 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795266#comment-17795266 ] Timo Walther commented on FLINK-33784: -- Hi [~hackergin], DelegatingReadableConfig could be one

Re: [PR] [FLINK-33588][Flink-Runtime] Fix NullArgumentException in DescriptiveStatisticsHistogramStatistics [flink]

2023-12-11 Thread via GitHub
zhutong6688 commented on PR #23749: URL: https://github.com/apache/flink/pull/23749#issuecomment-1849660281 yes, I like to fix it Replied Message | From | Jing ***@***.***> | | Date | 12/08/2023 06:18 | | To | ***@***.***> | | Cc |

[jira] [Resolved] (FLINK-33246) Add RescalingIT case that uses checkpoints and resource requests

2023-12-11 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-33246. -- Fix Version/s: 1.19.0 Resolution: Fixed merged in master

[jira] [Updated] (FLINK-33794) After Flink Avro deserialization fails, subsequent correct data cannot be deserialized correctly

2023-12-11 Thread WeichengJi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WeichengJi updated FLINK-33794: --- Description: Excuse me, this is my first time submitting Flink Jira. I found that when using the

[jira] [Updated] (FLINK-33341) Use available local keyed state for rescaling

2023-12-11 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-33341: - Fix Version/s: 1.19.0 > Use available local keyed state for rescaling >

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-11 Thread via GitHub
pvary commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1849778449 @becketqin: Any more comments? Or do you think it is ready to go? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-32949) Allow specifying the ServerSocket port for the collect function when accessing the TaskManager from the client.

2023-12-11 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795287#comment-17795287 ] Jing Ge commented on FLINK-32949: - [~hzjhjjyy] would you like to review the PR? Thanks! > Allow

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-11 Thread via GitHub
RocMarshal commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1422316793 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -222,6 +223,19 @@ public class RestartStrategyOptions {

Re: [PR] [FLINK-33719][table] Cleanup the usage of deprecated StreamTableEnvir… [flink]

2023-12-11 Thread via GitHub
liuyongvs commented on PR #23898: URL: https://github.com/apache/flink/pull/23898#issuecomment-1849863462 @snuyanzin thanks very much, I didn't notice that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-33795) Add new config to forbid autoscaling in certain periods of a day

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33795: --- Labels: pull-request-available (was: ) > Add new config to forbid autoscaling in certain

[PR] [FLINK-33795] Add new config to forbid autoscaling in certain periods of a day [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
flashJd opened a new pull request, #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728 ## What is the purpose of the change Add new config to forbid autoscaling in certain periods of a day so that we keep flink job unaffected by autoscaling's job restart

Re: [PR] [FLINK-28215][Buildsystem] Update Maven Surefire plugin to 3.2.2 [flink]

2023-12-11 Thread via GitHub
MartijnVisser merged PR #22502: URL: https://github.com/apache/flink/pull/22502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-26586) FileSystem uses unbuffered read I/O

2023-12-11 Thread Matthias Schwalbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795416#comment-17795416 ] Matthias Schwalbe commented on FLINK-26586: --- Hi [~masteryhx] I've reached agreement from my

  1   2   3   >