Re: [PR] [FLINK-34336][test] Fix the bug that AutoRescalingITCase may hang sometimes [flink]

2024-02-19 Thread via GitHub
1996fanrui commented on PR #24248: URL: https://github.com/apache/flink/pull/24248#issuecomment-1953382889 > LGTM  Thanks @XComp for the review! Merging > Can you create a 1.19 backport PR? Sure, I will do it asap. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-34336][test] Fix the bug that AutoRescalingITCase may hang sometimes [flink]

2024-02-19 Thread via GitHub
1996fanrui merged PR #24248: URL: https://github.com/apache/flink/pull/24248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-34147) TimestampData to/from LocalDateTime is ambiguous

2024-02-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34147: --- Labels: pull-request-available (was: ) > TimestampData to/from LocalDateTime is ambiguous

[PR] [FLINK-34147][table-planner] Enhance the java doc of TimestampData to distinguish the different usage of Instant and LocalDateTime [flink]

2024-02-19 Thread via GitHub
swuferhong opened a new pull request, #24339: URL: https://github.com/apache/flink/pull/24339 ## What is the purpose of the change Currently, the java docs of `TimestampData` is ambiguous. `TimestampData` represents both `Instant` and `LocalDateTime`. this class use

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818606#comment-17818606 ] Jane Chan commented on FLINK-29114: --- Hi [~mapohl], sorry for the late reply, I just noticed your

[jira] [Commented] (FLINK-34156) Move Flink Calcite rules from Scala to Java

2024-02-19 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818607#comment-17818607 ] Yunhong Zheng commented on FLINK-34156: --- Hi, [~Sergey Nuyanzin] . Since I have been continuously

[jira] [Commented] (FLINK-34355) Release Testing: Verify FLINK-34054 Support named parameters for functions and procedures

2024-02-19 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818611#comment-17818611 ] Shuai Xu commented on FLINK-34355: -- Hi, I have finished this verification. > Release Testing: Verify

Re: [PR] [FLINK-34434][slotmanager] Complete the returnedFuture when slot remo… [flink]

2024-02-19 Thread via GitHub
KarmaGYZ commented on code in PR #24325: URL: https://github.com/apache/flink/pull/24325#discussion_r1494398967 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncerTest.java: ## @@ -216,6 +202,58 @@ void

[jira] [Commented] (FLINK-34346) Release Testing: Verify FLINK-24024 Support session Window TVF

2024-02-19 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818612#comment-17818612 ] Shuai Xu commented on FLINK-34346: -- Hi, I have finished this testing. The exception I think could be

[jira] [Closed] (FLINK-27891) Add ARRAY_APPEND and ARRAY_PREPEND supported in SQL & Table API

2024-02-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-27891. --- > Add ARRAY_APPEND and ARRAY_PREPEND supported in SQL & Table API >

[jira] [Resolved] (FLINK-27891) Add ARRAY_APPEND and ARRAY_PREPEND supported in SQL & Table API

2024-02-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-27891. - Fix Version/s: 1.20.0 Resolution: Fixed > Add ARRAY_APPEND and ARRAY_PREPEND

[jira] [Commented] (FLINK-27891) Add ARRAY_APPEND and ARRAY_PREPEND supported in SQL & Table API

2024-02-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818580#comment-17818580 ] Sergey Nuyanzin commented on FLINK-27891: - Merged as

[jira] [Closed] (FLINK-34160) Migrate FlinkCalcMergeRule

2024-02-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-34160. --- > Migrate FlinkCalcMergeRule > -- > > Key: FLINK-34160

[jira] [Resolved] (FLINK-34160) Migrate FlinkCalcMergeRule

2024-02-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-34160. - Resolution: Fixed > Migrate FlinkCalcMergeRule > -- > >

[jira] [Commented] (FLINK-34160) Migrate FlinkCalcMergeRule

2024-02-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818586#comment-17818586 ] Sergey Nuyanzin commented on FLINK-34160: - Merged as

Re: [PR] [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions [flink]

2024-02-19 Thread via GitHub
snuyanzin merged PR #19873: URL: https://github.com/apache/flink/pull/19873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34160][table] Migration of FlinkCalcMergeRule to java [flink]

2024-02-19 Thread via GitHub
snuyanzin merged PR #24142: URL: https://github.com/apache/flink/pull/24142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-32596) The partition key will be wrong when use Flink dialect to create Hive table

2024-02-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818603#comment-17818603 ] luoyuxia commented on FLINK-32596: -- [~walls.flink.m] Thanks for your investagtion. So, do you mean Hive

Re: [PR] [FLINK-34147][table-planner] Enhance the java doc of TimestampData to distinguish the different usage of Instant and LocalDateTime [flink]

2024-02-19 Thread via GitHub
flinkbot commented on PR #24339: URL: https://github.com/apache/flink/pull/24339#issuecomment-1953353325 ## CI report: * 1e0acf858f5dfa9a029dfc0507d345cdd36a17b3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.17][hotfix][docs] Update the versions of mongodb supported by mongodb-connector [flink]

2024-02-19 Thread via GitHub
flinkbot commented on PR #24345: URL: https://github.com/apache/flink/pull/24345#issuecomment-1953438118 ## CI report: * 181a6cc57d9fc59cf18c69686fc7ddc4735c4f40 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34463] Open catalog in CatalogManager should use proper context classloader [flink]

2024-02-19 Thread via GitHub
hackergin commented on code in PR #24328: URL: https://github.com/apache/flink/pull/24328#discussion_r1495218821 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -310,7 +311,10 @@ public void createCatalog(String

[jira] [Commented] (FLINK-34397) Resource wait timeout can't be disabled

2024-02-19 Thread Pulkit Jain (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818627#comment-17818627 ] Pulkit Jain commented on FLINK-34397: - [~chesnay]  Is there any update on this issue? We are also

Re: [PR] [FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
1996fanrui commented on PR #765: URL: https://github.com/apache/flink-kubernetes-operator/pull/765#issuecomment-1953567662 Hi @mxm @gyfora , gentle ping, do you have any other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Closed] (FLINK-34348) Release Testing: Verify FLINK-20281 Window aggregation supports changelog stream input

2024-02-19 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-34348. --- Resolution: Fixed [~hackergin] Thanks for your testing work! > Release Testing: Verify FLINK-20281

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818685#comment-17818685 ] Matthias Pohl commented on FLINK-31472: ---

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818691#comment-17818691 ] Matthias Pohl commented on FLINK-29114: --- Much appreciated!

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
1996fanrui commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1495183092 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetric.java: ## @@ -39,12 +39,6 @@ public enum ScalingMetric {

Re: [PR] [FLINK-34434][slotmanager] Complete the returnedFuture when slot remo… [flink]

2024-02-19 Thread via GitHub
KarmaGYZ merged PR #24325: URL: https://github.com/apache/flink/pull/24325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33241][doc] Align config option generation documentation for Flink's config documentation. [flink]

2024-02-19 Thread via GitHub
flinkbot commented on PR #24344: URL: https://github.com/apache/flink/pull/24344#issuecomment-1953437389 ## CI report: * 8d4e9490af1859f884721320949815886bdf0f6f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.18][hotfix][docs] Update the versions of mongodb supported by mongodb-connector [flink]

2024-02-19 Thread via GitHub
flinkbot commented on PR #24343: URL: https://github.com/apache/flink/pull/24343#issuecomment-1953436713 ## CI report: * 12c488ade5bc133738eadb5dcc181c61947c935b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [Draft][bugfix] Move the deserialization of shuffleDescriptor to a separate … [flink]

2024-02-19 Thread via GitHub
caodizhou commented on PR #24115: URL: https://github.com/apache/flink/pull/24115#issuecomment-1953442349 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
lajith2006 commented on PR #749: URL: https://github.com/apache/flink-kubernetes-operator/pull/749#issuecomment-1953491190 > > > > > @gyfora yes, I am having JIRA account using which I can login to https://issues.apache.org/jira/projects/FLINK/. > > > > > > > > > > > > okay then

[jira] [Commented] (FLINK-26515) RetryingExecutorTest. testDiscardOnTimeout failed on azure

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818686#comment-17818686 ] Matthias Pohl commented on FLINK-26515: ---

Re: [PR] [CP-1.19][FLINK-34434][slotmanager] Complete the returnedFuture when slot remo… [flink]

2024-02-19 Thread via GitHub
KarmaGYZ commented on PR #24326: URL: https://github.com/apache/flink/pull/24326#issuecomment-1953396289 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34336][test] Fix the bug that AutoRescalingITCase may hang sometimes [flink]

2024-02-19 Thread via GitHub
1996fanrui commented on code in PR #24340: URL: https://github.com/apache/flink/pull/24340#discussion_r1495176445 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java: ## @@ -163,6 +163,8 @@ public void setup() throws Exception {

[PR] [FLINK-34336][test] Fix the bug that AutoRescalingITCase may hang sometimes [flink]

2024-02-19 Thread via GitHub
1996fanrui opened a new pull request, #24340: URL: https://github.com/apache/flink/pull/24340 Backporting FLINK-34336 to 1.19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-34424) BoundedBlockingSubpartitionWriteReadTest#testRead10ConsumersConcurrent times out

2024-02-19 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818615#comment-17818615 ] Yuxin Tan commented on FLINK-34424: --- [~mapohl] [~pnowojski] Sorry for the late reply. I tried to

Re: [PR] [FLINK-34336][test] Fix the bug that AutoRescalingITCase may hang sometimes [flink]

2024-02-19 Thread via GitHub
flinkbot commented on PR #24340: URL: https://github.com/apache/flink/pull/24340#issuecomment-1953400607 ## CI report: * 3c5a7ccf0f1c9c2a4cc27b34ffebb51cb5296c62 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][docs] Update the versions of mongodb supported by mongodb-connector [flink]

2024-02-19 Thread via GitHub
leonardBang merged PR #24337: URL: https://github.com/apache/flink/pull/24337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34383][Documentation] Modify the comment with incorrect syntax [flink]

2024-02-19 Thread via GitHub
zhuzhurk commented on PR #24273: URL: https://github.com/apache/flink/pull/24273#issuecomment-1953432542 Thanks for participating in the community work! @lxliyou001 Usually we will avoid creating individual JIRAs and PRs for this kind of typos to avoid polluting the commit history, as

Re: [PR] [FLINK-34463] Open catalog in CatalogManager should use proper context classloader [flink]

2024-02-19 Thread via GitHub
hackergin commented on code in PR #24328: URL: https://github.com/apache/flink/pull/24328#discussion_r1495218821 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -310,7 +311,10 @@ public void createCatalog(String

[jira] [Closed] (FLINK-34346) Release Testing: Verify FLINK-24024 Support session Window TVF

2024-02-19 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-34346. --- Resolution: Fixed [~xu_shuai_] Thanks for testing this! > Release Testing: Verify FLINK-24024

[jira] [Closed] (FLINK-34355) Release Testing: Verify FLINK-34054 Support named parameters for functions and procedures

2024-02-19 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-34355. --- Resolution: Fixed [~xu_shuai_] Thanks for your testing work! > Release Testing: Verify FLINK-34054

[jira] [Updated] (FLINK-29436) Upgrade Spotless Maven Plugin to 2.27.1

2024-02-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-29436: --- Component/s: Build System Connectors / Parent > Upgrade Spotless Maven Plugin to

[jira] [Commented] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-19 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818688#comment-17818688 ] Rui Fan commented on FLINK-34336: - Hi [~mapohl] , thanks for your reminder. I have submitted a PR to

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-19 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818693#comment-17818693 ] Jing Ge commented on FLINK-34202: - Thanks for the info, [~jeyhunkarimov] could you help check the

[PR] [hotfix][docs] Integrate mongodb v1.1 docs [flink]

2024-02-19 Thread via GitHub
leonardBang opened a new pull request, #24341: URL: https://github.com/apache/flink/pull/24341 [hotfix][docs] Integrate mongodb v1.1 docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [BP-1.17][hotfix][docs] Update the versions of mongodb supported by mongodb-connector [flink]

2024-02-19 Thread via GitHub
Jiabao-Sun opened a new pull request, #24345: URL: https://github.com/apache/flink/pull/24345 ## What is the purpose of the change Update the versions of mongodb supported by mongodb-connector ## Brief change log Currently, we are using mongodb-driver version

[PR] [FLINK-33241][doc] Align config option generation documentation for Flink's config documentation. [flink]

2024-02-19 Thread via GitHub
JunRuiLee opened a new pull request, #24344: URL: https://github.com/apache/flink/pull/24344 ## What is the purpose of the change The configuration parameter docs generation is documented in two places in different ways:

[PR] [BP-1.19][hotfix][docs] Update the versions of mongodb supported by mongodb-connector [flink]

2024-02-19 Thread via GitHub
Jiabao-Sun opened a new pull request, #24342: URL: https://github.com/apache/flink/pull/24342 ## What is the purpose of the change Update the versions of mongodb supported by mongodb-connector ## Brief change log Currently, we are using mongodb-driver version

[PR] [BP-1.18][hotfix][docs] Update the versions of mongodb supported by mongodb-connector [flink]

2024-02-19 Thread via GitHub
Jiabao-Sun opened a new pull request, #24343: URL: https://github.com/apache/flink/pull/24343 ## What is the purpose of the change Update the versions of mongodb supported by mongodb-connector ## Brief change log Currently, we are using mongodb-driver version

[jira] [Updated] (FLINK-33241) Align config option generation documentation for Flink's config documentation

2024-02-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33241: --- Labels: pull-request-available starter (was: starter) > Align config option generation

Re: [PR] [BP-1.19][hotfix][docs] Update the versions of mongodb supported by mongodb-connector [flink]

2024-02-19 Thread via GitHub
flinkbot commented on PR #24342: URL: https://github.com/apache/flink/pull/24342#issuecomment-1953436142 ## CI report: * 144537475e2e0e05d0535d2934d0c7a935126507 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][docs] Integrate mongodb v1.1 docs [flink]

2024-02-19 Thread via GitHub
flinkbot commented on PR #24341: URL: https://github.com/apache/flink/pull/24341#issuecomment-1953435662 ## CI report: * 5a4261423d548338d3ca8f1109bec13184ac346a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Resolved] (FLINK-34434) DefaultSlotStatusSyncer doesn't complete the returned future

2024-02-19 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo resolved FLINK-34434. Resolution: Fixed > DefaultSlotStatusSyncer doesn't complete the returned future >

[jira] [Commented] (FLINK-34434) DefaultSlotStatusSyncer doesn't complete the returned future

2024-02-19 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818657#comment-17818657 ] Yangze Guo commented on FLINK-34434: 1.19: 8cf29969d9aec4943713f0a6096b703718ce0dd0

[jira] [Updated] (FLINK-34434) DefaultSlotStatusSyncer doesn't complete the returned future

2024-02-19 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-34434: --- Fix Version/s: 1.19.0 1.18.2 1.20.0 > DefaultSlotStatusSyncer

Re: [PR] [CP-1.19][FLINK-34434][slotmanager] Complete the returnedFuture when slot remo… [flink]

2024-02-19 Thread via GitHub
KarmaGYZ merged PR #24326: URL: https://github.com/apache/flink/pull/24326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-34348) Release Testing: Verify FLINK-20281 Window aggregation supports changelog stream input

2024-02-19 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818666#comment-17818666 ] Feng Jin commented on FLINK-34348: -- cc [~lincoln.86xy]  The test has been completed as above. >

Re: [PR] [FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-02-19 Thread via GitHub
1996fanrui commented on code in PR #24211: URL: https://github.com/apache/flink/pull/24211#discussion_r1495341757 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java: ## @@ -100,11 +100,14 @@

[jira] [Commented] (FLINK-34274) AdaptiveSchedulerTest.testRequirementLowerBoundDecreaseAfterResourceScarcityBelowAvailableSlots times out

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818690#comment-17818690 ] Matthias Pohl commented on FLINK-34274: --- master (1.20):

[jira] [Commented] (FLINK-30784) HiveTableSourceITCase.testPartitionFilter failed with assertion error

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818689#comment-17818689 ] Matthias Pohl commented on FLINK-30784: ---

Re: [PR] [CP-1.18][FLINK-34434][slotmanager] Complete the returnedFuture when slot remo… [flink]

2024-02-19 Thread via GitHub
KarmaGYZ merged PR #24327: URL: https://github.com/apache/flink/pull/24327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-34452) Release Testing: Verify FLINK-15959 Add min number of slots configuration to limit total number of slots

2024-02-19 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34452: Fix Version/s: 1.19.0 > Release Testing: Verify FLINK-15959 Add min number of slots configuration

[jira] [Commented] (FLINK-34305) Release Testing Instructions: Verify FLINK-33261 Support Setting Parallelism for Table/SQL Sources

2024-02-19 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818677#comment-17818677 ] lincoln lee commented on FLINK-34305: - [~sudewei.sdw][~Zhanghao Chen] Can you help estimate when the

[jira] [Commented] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818684#comment-17818684 ] Matthias Pohl commented on FLINK-34336: --- Thanks [~fanrui]. Can you also create a 1.19 backport?

[jira] [Comment Edited] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818691#comment-17818691 ] Matthias Pohl edited comment on FLINK-29114 at 2/20/24 7:56 AM: Much

[jira] [Updated] (FLINK-34364) Fix release utils mount point to match the release doc and scripts

2024-02-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-34364: --- Fix Version/s: connector-parent-1.1.0 > Fix release utils mount point to match the release doc and

[jira] [Commented] (FLINK-34434) DefaultSlotStatusSyncer doesn't complete the returned future

2024-02-19 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818613#comment-17818613 ] Yangze Guo commented on FLINK-34434: master: 15af3e49ca42fea1e3f6c53d6d1498315b1322ac

[jira] [Commented] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-19 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818614#comment-17818614 ] Rui Fan commented on FLINK-34336: - Merged to master(1.20) via: e2e3de2d48e3f02b746bdbdcb4da7b0477986a11

[jira] [Updated] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-19 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34336: Fix Version/s: 1.20.0 > AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState > may

Re: [PR] [FLINK-34386][state] Add RocksDB bloom filter metrics [flink]

2024-02-19 Thread via GitHub
hejufang commented on PR #24274: URL: https://github.com/apache/flink/pull/24274#issuecomment-1953405068 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

2024-02-19 Thread via GitHub
lincoln-lil commented on PR #24121: URL: https://github.com/apache/flink/pull/24121#issuecomment-1953417819 @twalthr Thank you for reviewing this! Yes, some work was needed to make it more readable, the original scala version use the same case branch style as

[jira] [Commented] (FLINK-34406) Expose RuntimeContext in FunctionContext

2024-02-19 Thread yisha zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818616#comment-17818616 ] yisha zhou commented on FLINK-34406: Hi [~twalthr] ,  what do you think about this proposal?  I

Re: [PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-02-19 Thread via GitHub
zhougit86 commented on code in PR #24163: URL: https://github.com/apache/flink/pull/24163#discussion_r1495227606 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java: ## @@ -114,7 +116,8 @@ public KubernetesResourceManagerDriver(

[jira] [Updated] (FLINK-34399) Release Testing: Verify FLINK-33644 Make QueryOperations SQL serializable

2024-02-19 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34399: Component/s: Table SQL / API > Release Testing: Verify FLINK-33644 Make QueryOperations SQL

Re: [PR] [FLINK-34336][test] Fix the bug that AutoRescalingITCase may hang sometimes [flink]

2024-02-19 Thread via GitHub
XComp commented on code in PR #24340: URL: https://github.com/apache/flink/pull/24340#discussion_r1495372884 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java: ## @@ -163,6 +163,8 @@ public void setup() throws Exception {

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818374#comment-17818374 ] Matthias Pohl commented on FLINK-34202: --- Thanks for looking into it, everyone. We use random

Re: [PR] [FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-02-19 Thread via GitHub
pnowojski commented on code in PR #24211: URL: https://github.com/apache/flink/pull/24211#discussion_r1494192141 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java: ## @@ -100,11 +100,14 @@ public

[jira] [Commented] (FLINK-34459) Results column names should match SELECT clause expression names

2024-02-19 Thread Lorenzo Affetti (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818385#comment-17818385 ] Lorenzo Affetti commented on FLINK-34459: - [~martijnvisser] well, if the name is a long one it

Re: [PR] [FLINK-22765][test] Fixes test instability in ExceptionUtilsITCase#testIsMetaspaceOutOfMemoryError [flink]

2024-02-19 Thread via GitHub
XComp commented on code in PR #24315: URL: https://github.com/apache/flink/pull/24315#discussion_r1494214115 ## flink-core/src/test/java/org/apache/flink/testutils/ClassLoaderUtils.java: ## @@ -55,7 +58,7 @@ private static URLClassLoader createClassLoader(File root,

Re: [PR] [FLINK-22765][test] Fixes test instability in ExceptionUtilsITCase#testIsMetaspaceOutOfMemoryError [flink]

2024-02-19 Thread via GitHub
XComp commented on code in PR #24315: URL: https://github.com/apache/flink/pull/24315#discussion_r1494214673 ## flink-core/src/test/java/org/apache/flink/testutils/ClassLoaderUtils.java: ## @@ -158,7 +170,7 @@ public ClassLoaderBuilder withParentClassLoader(ClassLoader

Re: [PR] [FLINK-22765][test] Fixes test instability in ExceptionUtilsITCase#testIsMetaspaceOutOfMemoryError [flink]

2024-02-19 Thread via GitHub
XComp commented on PR #24315: URL: https://github.com/apache/flink/pull/24315#issuecomment-1951990498 > I guess if we migrate from junit4 to junit5 then we don't need to depend on TestLogger which contains JUnit4 rules instead need to use @ExtendWith(TestLoggerExtension.class) > Also

[jira] [Commented] (FLINK-34459) Results column names should match SELECT clause expression names

2024-02-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818393#comment-17818393 ] Martijn Visser commented on FLINK-34459: I still am not convinced this is an actual user

[jira] [Created] (FLINK-34463) Open catalog in CatalogManager should use proper context classloader

2024-02-19 Thread jrthe42 (Jira)
jrthe42 created FLINK-34463: --- Summary: Open catalog in CatalogManager should use proper context classloader Key: FLINK-34463 URL: https://issues.apache.org/jira/browse/FLINK-34463 Project: Flink

Re: [PR] [FLINK-34463] Open catalog in CatalogManager should use proper context classloader [flink]

2024-02-19 Thread via GitHub
flinkbot commented on PR #24328: URL: https://github.com/apache/flink/pull/24328#issuecomment-1952032998 ## CI report: * 0867037b4fde47c69379dfd8b650e91393b9f249 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34264[plugins] add pushgateway http basic auth [flink]

2024-02-19 Thread via GitHub
flinkbot commented on PR #24329: URL: https://github.com/apache/flink/pull/24329#issuecomment-1952034920 ## CI report: * b95032b5dbcacfb7be570adec95bc9fc43f022fb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34418) Disk space issues for Docker-ized GitHub Action jobs

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818411#comment-17818411 ] Matthias Pohl commented on FLINK-34418: ---

[jira] [Commented] (FLINK-26644) python StreamExecutionEnvironmentTests.test_generate_stream_graph_with_dependencies failed on azure

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818410#comment-17818410 ] Matthias Pohl commented on FLINK-26644: ---

[jira] [Commented] (FLINK-34418) Disk space issues for Docker-ized GitHub Action jobs

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818409#comment-17818409 ] Matthias Pohl commented on FLINK-34418: ---

[jira] [Commented] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818429#comment-17818429 ] Matthias Pohl commented on FLINK-34336: --- Yes, I postponed looking into the PR. I will do it today.

[jira] [Comment Edited] (FLINK-21672) End to end tests (streaming) aren't Java vendor neutral (sun.management bean used)

2024-02-19 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818182#comment-17818182 ] david radley edited comment on FLINK-21672 at 2/19/24 9:51 AM: --- Hi

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-19 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818439#comment-17818439 ] lincoln lee commented on FLINK-34202: - 1.20(master):

[jira] [Commented] (FLINK-34459) Results column names should match SELECT clause expression names

2024-02-19 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818440#comment-17818440 ] Jeyhun Karimov commented on FLINK-34459: Hi [~martijnvisser] yes, there are some tradeoffs.

[PR] [hotfix] Integrate mongodb v1.1 docs [flink]

2024-02-19 Thread via GitHub
leonardBang opened a new pull request, #24332: URL: https://github.com/apache/flink/pull/24332 [hotfix] Integrate mongodb v1.1 docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-19 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818368#comment-17818368 ] lincoln lee commented on FLINK-22765: - JDK21:

[jira] [Commented] (FLINK-34418) Disk space issues for Docker-ized GitHub Action jobs

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818401#comment-17818401 ] Matthias Pohl commented on FLINK-34418: ---

[jira] [Comment Edited] (FLINK-34443) YARNFileReplicationITCase.testPerJobModeWithCustomizedFileReplication failed when deploying job cluster

2024-02-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818396#comment-17818396 ] Matthias Pohl edited comment on FLINK-34443 at 2/19/24 9:23 AM: *

[jira] [Comment Edited] (FLINK-21672) End to end tests (streaming) aren't Java vendor neutral (sun.management bean used)

2024-02-19 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818182#comment-17818182 ] david radley edited comment on FLINK-21672 at 2/19/24 9:48 AM: --- Hi

[PR] [FLINK-34152] Tune all directly observable memory types [flink-kubernetes-operator]

2024-02-19 Thread via GitHub
mxm opened a new pull request, #778: URL: https://github.com/apache/flink-kubernetes-operator/pull/778 This is the generalized version of #762 in which we tune all directly observable Flink memory pools: heap, managed memory, network, and metaspace. Notable changes: - New

  1   2   3   >