XComp commented on PR #24315:
URL: https://github.com/apache/flink/pull/24315#issuecomment-1951990498

   > I guess if we migrate from junit4 to junit5 then we don't need to depend 
on TestLogger which contains JUnit4 rules
   instead need to use @ExtendWith(TestLoggerExtension.class)
   > Also it would make sense to harden modifiers for tests since JUnit5 
doesn't require public
   
   Yikes, that I missed in the end. Thanks for noticing and sorry for being 
careless here. :innocent: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to