Re: [PR] [FLINK-34961] Use dedicated CI name for Kubernetes Operator to differentiate it in infra-reports [flink-kubernetes-operator]

2024-04-13 Thread via GitHub
caicancai commented on PR #813: URL: https://github.com/apache/flink-kubernetes-operator/pull/813#issuecomment-2053630401 it look good for me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-35094) SinkTestSuiteBase.testScaleDown is hanging for 1.20-SNAPSHOT

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35094: --- Labels: pull-request-available test-stability (was: test-stability) >

[PR] [FLINK-35094] SinkTestSuiteBase.testScaleDown is hanging for 1.20-SNAPSHOT [flink-connector-elasticsearch]

2024-04-13 Thread via GitHub
snuyanzin opened a new pull request, #98: URL: https://github.com/apache/flink-connector-elasticsearch/pull/98 The PR adds `org.apache.flink.core.execution.CheckpointingMode` to make E2E test compatible with 1.18, 1.19, 1.20 Flink versions -- This is an automated message from the Apache

Re: [PR] [FLINK-30081][runtime] Reset jvm-overhead.min/max for local executor [flink]

2024-04-13 Thread via GitHub
liuml07 commented on code in PR #22547: URL: https://github.com/apache/flink/pull/22547#discussion_r1563862180 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java: ## @@ -285,4 +286,15 @@ private static void

Re: [PR] chore: fix typo [flink-kubernetes-operator]

2024-04-13 Thread via GitHub
caicancai commented on PR #812: URL: https://github.com/apache/flink-kubernetes-operator/pull/812#issuecomment-2053629838 @drgnchan I think the commit message is best changed to the form of "[hotfix] XXX" -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-13 Thread via GitHub
caicancai commented on PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#issuecomment-2053635501 > Thanks @caicancai for the great work! > > Overall is good for me, i left some comments, please take a look in your free time, thanks a lot. > > I wanna

Re: [PR] [FLINK-34961] Use dedicated CI name for Rabbit MQ connector to differentiate it in infra-reports [flink-connector-rabbitmq]

2024-04-13 Thread via GitHub
boring-cyborg[bot] commented on PR #26: URL: https://github.com/apache/flink-connector-rabbitmq/pull/26#issuecomment-2053716419 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-34961] Use dedicated CI name for Rabbit MQ connector to differentiate it in infra-reports [flink-connector-rabbitmq]

2024-04-13 Thread via GitHub
snuyanzin merged PR #26: URL: https://github.com/apache/flink-connector-rabbitmq/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 [flink-connector-aws]

2024-04-13 Thread via GitHub
dannycranmer commented on PR #131: URL: https://github.com/apache/flink-connector-aws/pull/131#issuecomment-2053726181 We need to update NOTICE file with this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 [flink-connector-aws]

2024-04-13 Thread via GitHub
snuyanzin commented on PR #131: URL: https://github.com/apache/flink-connector-aws/pull/131#issuecomment-2053726937 I would suggest to bump rather to 1.26.1 to avoid issues mentioned at FLINK-35008 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-30081][runtime] Reset unused options like jvm-overhead.min/max for local executor [flink]

2024-04-13 Thread via GitHub
liuml07 commented on code in PR #22547: URL: https://github.com/apache/flink/pull/22547#discussion_r1564418871 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java: ## @@ -285,4 +286,15 @@ private static void

[jira] [Updated] (FLINK-35098) Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35098: --- Labels: pull-request-available (was: ) > Incorrect results for queries like "10 >= y" on

[PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-13 Thread via GitHub
jeyhunkarimov opened a new pull request, #24658: URL: https://github.com/apache/flink/pull/24658 ## What is the purpose of the change Fix incorrect results in thanEquals filters ## Brief change log - Fix the reverse function for Orc GREATER_THAN_OR_EQUAL - Fix the

[jira] [Commented] (FLINK-35040) The performance of serializerHeavyString regresses since April 3

2024-04-13 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836843#comment-17836843 ] Robert Metzger commented on FLINK-35040: Do we know what causes the performance degradation with

[PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]

2024-04-13 Thread via GitHub
empathy87 opened a new pull request, #24659: URL: https://github.com/apache/flink/pull/24659 ## What is the purpose of the change Fixes an issue with SQL queries containing expressions like **10 >= y** when using Filesystem connector and ORC format. ## Brief change log

[jira] [Commented] (FLINK-35098) Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format

2024-04-13 Thread Andrey Gaskov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836879#comment-17836879 ] Andrey Gaskov commented on FLINK-35098: --- [~jeyhunkarimov], thank you! I submitted my PR. >

Re: [PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]

2024-04-13 Thread via GitHub
flinkbot commented on PR #24659: URL: https://github.com/apache/flink/pull/24659#issuecomment-2053886702 ## CI report: * 8db107dba2702b73249b586ff4d3266e1a8f2bc8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-35098) Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format

2024-04-13 Thread Andrey Gaskov (Jira)
Andrey Gaskov created FLINK-35098: - Summary: Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format Key: FLINK-35098 URL:

Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-13 Thread via GitHub
flinkbot commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2053746320 ## CI report: * bad8304a2d5ad3d9fda25596469405bc4ec9a1d4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-35098) Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format

2024-04-13 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836868#comment-17836868 ] Jeyhun Karimov commented on FLINK-35098: Hi [~empathy87] sorry, I have been working on the issue

[jira] [Commented] (FLINK-35098) Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format

2024-04-13 Thread Andrey Gaskov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836830#comment-17836830 ] Andrey Gaskov commented on FLINK-35098: --- Please, assign this issue to me. I know where it could be

Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-13 Thread via GitHub
jeyhunkarimov commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2053765908 > Thanks for contribution > however it seems the test doesn't reproduce the actual issue: I tried to execute it without fix and it is green > Hi @snuyanzin thanks

Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-13 Thread via GitHub
jeyhunkarimov closed pull request #24658: [FLINK-35098][orc] Fix incorrect results in thanEquals filters URL: https://github.com/apache/flink/pull/24658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-34961] Use dedicated CI name for Kubernetes Operator to differentiate it in infra-reports [flink-kubernetes-operator]

2024-04-13 Thread via GitHub
snuyanzin commented on PR #813: URL: https://github.com/apache/flink-kubernetes-operator/pull/813#issuecomment-2053722641 Thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-34961] Use dedicated CI name for Kubernetes Operator to differentiate it in infra-reports [flink-kubernetes-operator]

2024-04-13 Thread via GitHub
snuyanzin merged PR #813: URL: https://github.com/apache/flink-kubernetes-operator/pull/813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-13 Thread via GitHub
snuyanzin commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2053762163 Thanks for contribution however it seems the test Doesn't reproduce the actual issue: I tried to execute it without fix and it is green -- This is an automated message from