Re: [PR] [FLINK-34902][table] Fix IndexOutOfBoundsException for VALUES [flink]

2024-04-26 Thread via GitHub
reswqa commented on PR #24724: URL: https://github.com/apache/flink/pull/24724#issuecomment-2078864754 @twalthr, would you mind taking a look at this? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-35012) ChangelogNormalizeRestoreTest.testRestore failure

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841108#comment-17841108 ] Weijie Guo commented on FLINK-35012:

[jira] [Updated] (FLINK-35245) Add metrics for flink-connector-tidb-cdc

2024-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35245: --- Labels: pull-request-available (was: ) > Add metrics for flink-connector-tidb-cdc >

[jira] [Updated] (FLINK-35173) Debezium for Mysql connector Custom Time Serializer

2024-04-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren updated FLINK-35173: -- Affects Version/s: cdc-3.1.0 (was: 3.1.0) > Debezium for Mysql

[jira] [Updated] (FLINK-35192) operator oom

2024-04-26 Thread Biao Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Geng updated FLINK-35192: -- Attachment: screenshot-3.png > operator oom > > > Key: FLINK-35192 >

[jira] [Commented] (FLINK-35189) Introduce test-filesystem Catalog based on FileSystem Connector to support materialized table

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841128#comment-17841128 ] dalongliu commented on FLINK-35189: --- Merged in master: 714d1cb2e0bd0df03393492dc87cbd800af63e1b >

[jira] [Assigned] (FLINK-35195) Support the execution of create materialized table in continuous refresh mode

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-35195: - Assignee: dalongliu > Support the execution of create materialized table in continuous refresh

[jira] [Commented] (FLINK-35192) operator oom

2024-04-26 Thread Biao Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841129#comment-17841129 ] Biao Geng commented on FLINK-35192: --- !screenshot-3.png! According to the flink k8s op's codes, the

[jira] [Comment Edited] (FLINK-34694) Delete num of associations for streaming outer join

2024-04-26 Thread Roman Boyko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837205#comment-17837205 ] Roman Boyko edited comment on FLINK-34694 at 4/26/24 10:05 AM: --- Hi

[jira] [Comment Edited] (FLINK-34694) Delete num of associations for streaming outer join

2024-04-26 Thread Roman Boyko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837205#comment-17837205 ] Roman Boyko edited comment on FLINK-34694 at 4/26/24 10:04 AM: --- Hi

Re: [PR] [cdc-base] Support `Scan Newly Added Tables` feature [flink-cdc]

2024-04-26 Thread via GitHub
Jiabao-Sun closed pull request #1838: [cdc-base] Support `Scan Newly Added Tables` feature URL: https://github.com/apache/flink-cdc/pull/1838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35246: --- Fix Version/s: 1.20.0 > SqlClientSSLTest.testGatewayMode failed in AZP >

[jira] [Updated] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35246: --- Description: {code:java} Apr 26 01:51:10 java.lang.IllegalArgumentException: The given host:port

Re: [PR] [tidb] Add metrics for tidb connector [flink-cdc]

2024-04-26 Thread via GitHub
xieyi888 commented on PR #1974: URL: https://github.com/apache/flink-cdc/pull/1974#issuecomment-2078942188 > add metrcis: currentFetchEventTimeLag, currentEmitEventTimeLag, sourceIdleTime for TiKVRichParallelSourceFunction > Thanks @xieyi888 for the great work! Before this PR

[jira] [Assigned] (FLINK-35244) Move package for flink-connector-tidb-cdc test

2024-04-26 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun reassigned FLINK-35244: -- Assignee: Xie Yi > Move package for flink-connector-tidb-cdc test >

Re: [PR] [FLINK-35246][test] Fix incorrect address construction in SqlClientSSLTest [flink]

2024-04-26 Thread via GitHub
flinkbot commented on PR #24727: URL: https://github.com/apache/flink/pull/24727#issuecomment-2078971258 ## CI report: * a327b1e5ee7948bfd7f5c699222be5575e72f6f6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32877][Filesystem]add HTTP options to gcs-cloud-storage client [flink]

2024-04-26 Thread via GitHub
dannycranmer closed pull request #23226: [FLINK-32877][Filesystem]add HTTP options to gcs-cloud-storage client URL: https://github.com/apache/flink/pull/23226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-32877][Filesystem]add HTTP options to gcs-cloud-storage client [flink]

2024-04-26 Thread via GitHub
dannycranmer commented on PR #23226: URL: https://github.com/apache/flink/pull/23226#issuecomment-2078971443 Merged in https://github.com/apache/flink/pull/24673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (FLINK-32877) Support for HTTP connect and timeout options while writes in GCS connector

2024-04-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-32877. --- Resolution: Done > Support for HTTP connect and timeout options while writes in GCS

[jira] [Comment Edited] (FLINK-34694) Delete num of associations for streaming outer join

2024-04-26 Thread Roman Boyko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837205#comment-17837205 ] Roman Boyko edited comment on FLINK-34694 at 4/26/24 10:01 AM: --- Hi

[jira] [Created] (FLINK-35244) Move package for flink-connector-tidb-cdc test

2024-04-26 Thread Xie Yi (Jira)
Xie Yi created FLINK-35244: -- Summary: Move package for flink-connector-tidb-cdc test Key: FLINK-35244 URL: https://issues.apache.org/jira/browse/FLINK-35244 Project: Flink Issue Type: Improvement

Re: [PR] [BP3.1][FLINK-35173][cdc][mysql] Debezium custom time serializer for MySQL connector (#3240) [flink-cdc]

2024-04-26 Thread via GitHub
PatrickRen merged PR #3264: URL: https://github.com/apache/flink-cdc/pull/3264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1784#comment-1784 ] Weijie Guo edited comment on FLINK-35246 at 4/26/24 8:59 AM: - {code:java}

Re: [PR] [BP-3.1][FLINK-35235][pipeline-connector][kafka] Fix missing dependencies in the uber jar of Kafka pipeline sink. [flink-cdc]

2024-04-26 Thread via GitHub
Jiabao-Sun merged PR #3263: URL: https://github.com/apache/flink-cdc/pull/3263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-32877) Support for HTTP connect and timeout options while writes in GCS connector

2024-04-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-32877: -- Affects Version/s: 1.18.1 1.19.0 > Support for HTTP connect and

[jira] [Updated] (FLINK-32877) Support for HTTP connect and timeout options while writes in GCS connector

2024-04-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-32877: -- Fix Version/s: 1.20.0 > Support for HTTP connect and timeout options while writes in GCS

[jira] [Assigned] (FLINK-35194) Support describe job syntax and execution

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-35194: - Assignee: xuyang > Support describe job syntax and execution >

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1580840112 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1580840112 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent

Re: [PR] Kafka part required for Flink Apicurio Avro support. Prototype for review [flink-connector-kafka]

2024-04-26 Thread via GitHub
boring-cyborg[bot] commented on PR #99: URL: https://github.com/apache/flink-connector-kafka/pull/99#issuecomment-2079138385 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

Re: [PR] [FLINK-35026][runtime][config] Introduce async execution configurations [flink]

2024-04-26 Thread via GitHub
fredia merged PR #24667: URL: https://github.com/apache/flink/pull/24667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35176][Connector/JDBC] Support property authentication connection for JDBC catalog & dynamic table [flink-connector-jdbc]

2024-04-26 Thread via GitHub
RocMarshal commented on code in PR #116: URL: https://github.com/apache/flink-connector-jdbc/pull/116#discussion_r1580440708 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java: ## @@ -29,18 +29,22 @@ import

[jira] [Commented] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1784#comment-1784 ] Weijie Guo commented on FLINK-35246: {code:java} InetSocketAddress.createUnresolved(

[jira] [Created] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35246: -- Summary: SqlClientSSLTest.testGatewayMode failed in AZP Key: FLINK-35246 URL: https://issues.apache.org/jira/browse/FLINK-35246 Project: Flink Issue Type: Bug

[jira] [Assigned] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-35246: -- Assignee: Weijie Guo > SqlClientSSLTest.testGatewayMode failed in AZP >

[jira] [Updated] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35246: --- Labels: pull-request-available (was: ) > SqlClientSSLTest.testGatewayMode failed in AZP >

[jira] [Resolved] (FLINK-35235) Fix missing dependencies in the uber jar

2024-04-26 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun resolved FLINK-35235. Assignee: LvYanquan Resolution: Fixed Resolved via * cdc master:

Re: [PR] [FLINK-31223] sql-client.sh fails to start with ssl enabled [flink]

2024-04-26 Thread via GitHub
reswqa commented on PR #22026: URL: https://github.com/apache/flink/pull/22026#issuecomment-2078960338 @davidradl Make sense to back port this as we should treat this as a bugfix because sql client previously supported SSL, which is a kind of regresssion. -- This is an automated message

[jira] [Assigned] (FLINK-35197) Support the execution of suspend, resume materialized table in continuous refresh mode

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-35197: - Assignee: Feng Jin > Support the execution of suspend, resume materialized table in continuous

[jira] [Commented] (FLINK-35194) Support describe job syntax and execution

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841122#comment-17841122 ] dalongliu commented on FLINK-35194: --- Yeah, assigned to you. > Support describe job syntax and

Re: [PR] [FLINK-35189][test-utils]Introduce test-filesystem Catalog based on FileSystem Connector to support materialized table [flink]

2024-04-26 Thread via GitHub
lsyldliu merged PR #24712: URL: https://github.com/apache/flink/pull/24712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-35026) Introduce async execution configurations

2024-04-26 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841182#comment-17841182 ] Yanfei Lei commented on FLINK-35026: Merged into master via 713c30f..3ff2ba4  > Introduce async

[jira] [Resolved] (FLINK-35026) Introduce async execution configurations

2024-04-26 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei resolved FLINK-35026. Resolution: Resolved > Introduce async execution configurations >

Re: [PR] [fix] repair a snapshot-split bug: [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on PR #2968: URL: https://github.com/apache/flink-cdc/pull/2968#issuecomment-2078771360 Hi @AidenPerce, could you please rebase this PR with latest `master` branch before it could be merged? Renaming like `com.ververica.cdc` to `org.apache.flink.cdc` might be necessary.

Re: [PR] [BP-3.1][minor][cdc][docs] Add user guide about providing extra jar package in quickstart docs [flink-cdc]

2024-04-26 Thread via GitHub
Jiabao-Sun merged PR #3251: URL: https://github.com/apache/flink-cdc/pull/3251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-35173) Debezium for Mysql connector Custom Time Serializer

2024-04-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841109#comment-17841109 ] Qingsheng Ren commented on FLINK-35173: --- flink-cdc release-3.1:

[jira] [Assigned] (FLINK-35173) Debezium for Mysql connector Custom Time Serializer

2024-04-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-35173: - Assignee: ZhengYu Chen > Debezium for Mysql connector Custom Time Serializer >

[jira] [Resolved] (FLINK-35173) Debezium for Mysql connector Custom Time Serializer

2024-04-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-35173. --- Resolution: Fixed > Debezium for Mysql connector Custom Time Serializer >

[jira] [Updated] (FLINK-35173) Debezium for Mysql connector Custom Time Serializer

2024-04-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren updated FLINK-35173: -- Fix Version/s: cdc-3.1.0 (was: 3.1.0) > Debezium for Mysql connector

[jira] [Commented] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841105#comment-17841105 ] Weijie Guo commented on FLINK-18476:

Re: [PR] [FLINK-32084][checkpoint] Migrate current file merging of channel state snapshot into the unify file merging framework [flink]

2024-04-26 Thread via GitHub
fredia commented on PR #24653: URL: https://github.com/apache/flink/pull/24653#issuecomment-2078953534 @Zakelly @1996fanrui would you please to take a look? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (FLINK-35194) Support describe job syntax and execution

2024-04-26 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841113#comment-17841113 ] xuyang commented on FLINK-35194: Hi, can I take this jira? > Support describe job syntax and execution

Re: [PR] [FLINK-32877][Filesystem][Rebased] Add HTTP options to java-storage client [flink]

2024-04-26 Thread via GitHub
dannycranmer commented on PR #24673: URL: https://github.com/apache/flink/pull/24673#issuecomment-2078965258 LGTM, I will fix the commit message on merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (FLINK-35189) Introduce test-filesystem Catalog based on FileSystem Connector to support materialized table

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-35189. --- Resolution: Fixed > Introduce test-filesystem Catalog based on FileSystem Connector to support >

Re: [PR] [minor][docs] Add user guide about providing extra jar package in quickstart docs [flink-cdc]

2024-04-26 Thread via GitHub
Jiabao-Sun merged PR #3250: URL: https://github.com/apache/flink-cdc/pull/3250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35217] Add missing fsync to #closeForCommit in some subclasses of RecoverableFsDataOutputStream. [flink]

2024-04-26 Thread via GitHub
rkhachatryan commented on PR #24722: URL: https://github.com/apache/flink/pull/24722#issuecomment-2078909771 Thanks for the fix, I think it should solve the problem. However, 1. Is there a way to test it? 2. Should `GSRecoverableFsDataOutputStream` and `FSDataOutputStreamWrapper`

[jira] [Updated] (FLINK-35244) Move package for flink-connector-tidb-cdc test

2024-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35244: --- Labels: pull-request-available (was: ) > Move package for flink-connector-tidb-cdc test >

Re: [PR] [FLINK-32843][JUnit5 Migration] Migrate the jobmaster package of flink-runtime module to JUnit5 [flink]

2024-04-26 Thread via GitHub
Jiabao-Sun commented on code in PR #24723: URL: https://github.com/apache/flink/pull/24723#discussion_r1580689343 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterQueryableStateTest.java: ## @@ -96,17 +89,17 @@ public class JobMasterQueryableStateTest

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
Jiabao-Sun commented on PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#issuecomment-2078993303 Thanks @zhongqishang for this fix. Hi @yuxiqian, do you have time to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-04-26 Thread via GitHub
kottmann commented on PR #22789: URL: https://github.com/apache/flink/pull/22789#issuecomment-2079230716 Sorry for the delay on my end, I added a new commit to address all your comments above. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-31223] sql-client.sh fails to start with ssl enabled [flink]

2024-04-26 Thread via GitHub
davidradl commented on PR #22026: URL: https://github.com/apache/flink/pull/22026#issuecomment-2078935154 > Thanks for the review! merging... @reswqa thanks for doing this :-) We are looking for this to me back ported to 1.18 and 1.19. Are you ok to do this and I can review - or

[jira] [Commented] (FLINK-35041) IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841107#comment-17841107 ] Weijie Guo commented on FLINK-35041:

Re: [PR] [FLINK-35217] Add missing fsync to #closeForCommit in some subclasses of RecoverableFsDataOutputStream. [flink]

2024-04-26 Thread via GitHub
StefanRRichter commented on PR #24722: URL: https://github.com/apache/flink/pull/24722#issuecomment-2078937897 Thanks for the review, for 1. I don't know how we can test this without OS level tools, but I'm open to ideas. 2. I don't think `GSRecoverableFsDataOutputStream` requires any

[jira] [Created] (FLINK-35245) Add metrics for flink-connector-tidb-cdc

2024-04-26 Thread Xie Yi (Jira)
Xie Yi created FLINK-35245: -- Summary: Add metrics for flink-connector-tidb-cdc Key: FLINK-35245 URL: https://issues.apache.org/jira/browse/FLINK-35245 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-35235][pipeline-connector][kafka] Fix missing dependencies in the uber jar of Kafka pipeline sink. [flink-cdc]

2024-04-26 Thread via GitHub
Jiabao-Sun merged PR #3262: URL: https://github.com/apache/flink-cdc/pull/3262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-32877][Filesystem][Rebased] Add HTTP options to java-storage client [flink]

2024-04-26 Thread via GitHub
dannycranmer commented on PR #24673: URL: https://github.com/apache/flink/pull/24673#issuecomment-2078968511 Apologies I did not fix the commit message 臘 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-32877][Filesystem][Rebased] Add HTTP options to java-storage client [flink]

2024-04-26 Thread via GitHub
dannycranmer merged PR #24673: URL: https://github.com/apache/flink/pull/24673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841117#comment-17841117 ] Alexander Fedulov commented on FLINK-35240: --- I don't think touching any of the flush-specific

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#issuecomment-2079004056 @Jiabao-Sun Sure, I'll take it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841063#comment-17841063 ] Zhongqiang Gong commented on FLINK-35240: - Welcome [~robyoung] to join this disscussion. And you

Re: [PR] [FLINK-32622][table-planner] Optimize mini-batch assignment [flink]

2024-04-26 Thread via GitHub
jeyhunkarimov commented on PR #23470: URL: https://github.com/apache/flink/pull/23470#issuecomment-2078737997 Hi @xuyangzhong thanks for the comment. I addressed your comments. Please, let me know if you agree. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhongqiang Gong updated FLINK-35240: Attachment: screenshot-1.png > Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

[jira] [Updated] (FLINK-35072) Doris pipeline sink does not support applying AlterColumnTypeEvent

2024-04-26 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yux updated FLINK-35072: Fix Version/s: cdc-3.2.0 > Doris pipeline sink does not support applying AlterColumnTypeEvent >

[jira] [Updated] (FLINK-35120) Add Doris Pipeline connector integration test cases

2024-04-26 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yux updated FLINK-35120: Fix Version/s: cdc-3.2.0 > Add Doris Pipeline connector integration test cases >

[jira] [Updated] (FLINK-35092) Add integrated test for Doris / Starrocks sink pipeline connector

2024-04-26 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yux updated FLINK-35092: Fix Version/s: cdc-3.2.0 > Add integrated test for Doris / Starrocks sink pipeline connector >

[jira] [Updated] (FLINK-35090) Doris sink fails to create table when database does not exist

2024-04-26 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yux updated FLINK-35090: Fix Version/s: cdc-3.2.0 > Doris sink fails to create table when database does not exist >

[jira] [Resolved] (FLINK-35239) 1.19 docs show outdated warning

2024-04-26 Thread Ufuk Celebi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi resolved FLINK-35239. - Resolution: Fixed > 1.19 docs show outdated warning > --- > >

Re: [PR] [FLINK-35173] Debezium for Mysql connector Custom Time Serializer [flink-cdc]

2024-04-26 Thread via GitHub
PatrickRen merged PR #3240: URL: https://github.com/apache/flink-cdc/pull/3240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-35243) Carry pre-schema payload with SchemaChangeEvents

2024-04-26 Thread yux (Jira)
yux created FLINK-35243: --- Summary: Carry pre-schema payload with SchemaChangeEvents Key: FLINK-35243 URL: https://issues.apache.org/jira/browse/FLINK-35243 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]

2024-04-26 Thread via GitHub
yeezychao commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2078737494 @Myasuka PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (FLINK-35242) Add fine-grained schema evolution strategy

2024-04-26 Thread yux (Jira)
yux created FLINK-35242: --- Summary: Add fine-grained schema evolution strategy Key: FLINK-35242 URL: https://issues.apache.org/jira/browse/FLINK-35242 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-35240][Connectors][format]Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record for csv format [flink]

2024-04-26 Thread via GitHub
flinkbot commented on PR #24730: URL: https://github.com/apache/flink/pull/24730#issuecomment-2079743542 ## CI report: * 418a88849ef1c9f850cc80b5f691cfe033ac7c09 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33210] Cleanup the lineage interface comments [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu opened a new pull request, #24731: URL: https://github.com/apache/flink/pull/24731 ## What is the purpose of the change Format the class comments of lineage interface classes ## Brief change log - Remove the unneeded empty line of class comments ##

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841301#comment-17841301 ] Zhongqiang Gong commented on FLINK-35240: - [~afedulov] I opened a pr to patch this issue. Would

[jira] [Updated] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35240: --- Labels: pull-request-available (was: ) > Disable FLUSH_AFTER_WRITE_VALUE to avoid flush

Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]

2024-04-26 Thread via GitHub
GOODBOY008 commented on code in PR #90: URL: https://github.com/apache/flink-connector-pulsar/pull/90#discussion_r1581286005 ## flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/SampleData.java: ## @@ -49,7 +49,7 @@ public Foo() {}

Re: [PR] [FLINK-33210] Cleanup the lineage interface comments [flink]

2024-04-26 Thread via GitHub
flinkbot commented on PR #24731: URL: https://github.com/apache/flink/pull/24731#issuecomment-2079751600 ## CI report: * 93207bb3788bdcd5f6cf3657c2feb5d92ddb5871 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-26 Thread via GitHub
mas-chen commented on code in PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#discussion_r1581372979 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java: ## @@ -464,6

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1581321727 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/PhysicalTransformation.java: ## @@ -34,6 +35,7 @@ public abstract class

[jira] [Updated] (FLINK-35247) Upgrade spotless apply to `2.41.1` in flink-connector-parent to work with Java 21

2024-04-26 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-35247: --- Description: Spotless apply version from flink-connector-parent does not work with Java 21 Issue

Re: [PR] [FLINK-31223] sql-client.sh fails to start with ssl enabled [flink]

2024-04-26 Thread via GitHub
davidradl commented on PR #22026: URL: https://github.com/apache/flink/pull/22026#issuecomment-2079304678 > @davidradl Make sense to back port this as we should treat this as a bugfix because sql client previously supported SSL, which is a kind of regresssion. > > If you want, just

Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]

2024-04-26 Thread via GitHub
syhily commented on code in PR #90: URL: https://github.com/apache/flink-connector-pulsar/pull/90#discussion_r1581009843 ## flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/SampleData.java: ## @@ -49,7 +49,7 @@ public Foo() {}

[jira] [Commented] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841227#comment-17841227 ] Weijie Guo commented on FLINK-35246: master via 4e6dbe2d1a225a0d0e48fd0997c1f11317402e42. >

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841238#comment-17841238 ] Zhongqiang Gong commented on FLINK-35240: - Base on the logic of _writer. close,We can disable

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-26 Thread via GitHub
IgnasD commented on PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#issuecomment-2079488271 Changed the title as requested. Also, I've added filtering to `unassignedInitialPartitions` as suggested and covered it with a test case. -- This is an automated message from

Re: [PR] [FLINK-35022][Connector/DynamoDB] Add TypeInformed DDB Element Converter [flink-connector-aws]

2024-04-26 Thread via GitHub
vahmed-hamdy commented on code in PR #136: URL: https://github.com/apache/flink-connector-aws/pull/136#discussion_r1581114799 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbTypeInformedElementConverter.java: ## @@

[jira] [Commented] (FLINK-35232) Support for retry settings on GCS connector

2024-04-26 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841267#comment-17841267 ] Oleksandr Nitavskyi commented on FLINK-35232: - [~galenwarren] thanks. We have reduced the

[jira] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2024-04-26 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31223 ] david radley deleted comment on FLINK-31223: -- was (Author: JIRAUSER300523): [~Weijie Guo] I have created pr [https://github.com/apache/flink/pull/24729] for the 1.18 backport >

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to g… [flink]

2024-04-26 Thread via GitHub
davidradl closed pull request #24729: [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to g… URL: https://github.com/apache/flink/pull/24729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-31223] sql-client.sh fails to start with ssl enabled [flink]

2024-04-26 Thread via GitHub
davidradl commented on PR #22026: URL: https://github.com/apache/flink/pull/22026#issuecomment-2079731646 > > @davidradl Make sense to back port this as we should treat this as a bugfix because sql client previously supported SSL, which is a kind of regresssion. > > If you want, just go

  1   2   >