Github user addisonj commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r108790880
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -162,11 +182,65 @@ public
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
@EronWright good suggestion in regards to containerInfo without an image
name, I confirmed in the mesos docs that it should work that way.
Lemme know if there is anything else
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
@tillrohrmann this was the PR I mentioned to you during flink foward, if
you get a chance to look :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/1668
Very interested in this work. It sounds like there are few loose ends and
then some cleanup before it might be ready for merge, @senorcarbone or
@StephanEwen anything that can be supported
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3344
Even with this in place, I am still regularly seeing timeouts on quite a
few PRs. In addition to the travis queue being backed up, its taking 12+ hours
to get feedback which is mostly just build
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
@EronWright @zentol minor bump on this... any other steps to get this on
the path to being merged?
Don't want to let this hang out for too long so I forgot about it :)
---
If your
GitHub user addisonj opened a pull request:
https://github.com/apache/flink/pull/3481
[FLINK-5975] Add volume support to flink-mesos
When using containerization, specifically, docker, it is useful to be
able to attach additional volumes, such as an NFS share.
This adds
Github user addisonj commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104838693
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +264,61 @@ public String
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
@zentol thanks for the quality reviews. The code reads a lot cleaner with
the mode parsing being handled by the enum. My java is pretty rusty after all
being in scala of late :)
I think
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
Okay, just moved things around, agree that its a better place, but was
hesitant at first as we were building any other mesos objects earlier.
Hopefully this still works. I think going forwad
Github user addisonj commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104790136
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user addisonj commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104790634
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -262,9 +265,67 @@ public String
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
@zentol thanks for the review! I think I addressed all those, updated via
an amend. Wasn't sure if you want changes as new commits or not.
Also, the build passed locally for me, but I
Github user addisonj commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104752423
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -131,9 +134,7 @@ public int getPorts
GitHub user addisonj opened a pull request:
https://github.com/apache/flink/pull/6183
[FLINK-9616][metrics] Fix datadog to include shaded deps
## What is the purpose of the change
This fixes a broken build that wasn't properly including a shaded in the
jar it builds
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/6183
This is fixed by #6191
---
Github user addisonj closed the pull request at:
https://github.com/apache/flink/pull/6183
---
17 matches
Mail list logo
