Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2272#discussion_r75332918
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/ReduceOperatorBase.java
---
@@ -202,7 +203,9 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2272#discussion_r75333518
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/ReduceOperatorBase.java
---
@@ -202,7 +203,9 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2272#discussion_r75338445
--- Diff:
flink-optimizer/src/test/java/org/apache/flink/optimizer/DistinctCompilationTest.java
---
@@ -71,8 +71,8 @@ public void testDistinctPlain
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2272
Thanks for the PR @greghogan. I added a few comments.
Looks good to merge otherwise.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2289
Thanks for the fix @mushketyk!
Looks good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2304#discussion_r75459189
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/BigDecParser.java ---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2304#discussion_r75459165
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/BigDecParser.java ---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2304
Thanks @twalthr, PR looks good.
Only added a hint how String creations can be avoided.
Good to merge otherwise.
---
If your project is set up for it, you can reply to this email and
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75479103
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/CompositeAccessTest.scala
---
@@ -0,0 +1,167
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75479361
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/SelectITCase.scala
---
@@ -146,4 +146,22 @@ class SelectITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75479712
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2319
Hi @twalthr, thanks for the PR.
I added a few comments / suggestions. Also, the documentation should be
extended.
Thanks, Fabian
---
If your project is set up for it, you can reply to
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2289
Sorry for the delay @mushketyk!
Will merge it tomorrow. Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75835251
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSink.scala
---
@@ -41,46 +38,13 @@ trait TableSink[T
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75835356
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -26,6 +26,8 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75835433
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75835537
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75835608
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka09JsonTableSink.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75835662
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka09JsonTableSink.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75835821
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSinkTest.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75835841
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka09JsonTableSinkTest.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75836176
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSink.java
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75836302
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75836644
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75836733
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/JsonRowSerializationSchemaTest.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75836831
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkTestBase.java
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2244
Hi @mushketyk, thanks for the PR. Looks quite good. I added a few comments.
Cheers, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2368#discussion_r75894020
--- Diff: docs/apis/streaming/windows.md ---
@@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit
of incremental window compu
the
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2368#discussion_r75893984
--- Diff: docs/apis/streaming/windows.md ---
@@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit
of incremental window compu
the
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2368#discussion_r75894336
--- Diff: docs/apis/streaming/windows.md ---
@@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit
of incremental window compu
the
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2368#discussion_r75895039
--- Diff: docs/apis/streaming/windows.md ---
@@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit
of incremental window compu
the
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2368
Hi @danielblazevski, thanks for the PR. I added a some comments and
suggestions.
Thank you, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75900345
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75900712
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/CompositeAccessTest.scala
---
@@ -0,0 +1,167
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2272
Thanks for the update @greghogan.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2368
Thanks for the fast update @danielblazevski.
I think you accidentally added `tools/FlinkCodyStyle.xml` to your commit.
---
If your project is set up for it, you can reply to this email and have
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2244
Hi @mushketyk, thanks for the fast reply.
I saw your comments but no new commit. Did you forget to push to your PR
branch?
Thanks, Fabian
---
If your project is set up for it, you can
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2244
Ah, I see. Very good :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2368#discussion_r75959873
--- Diff: docs/apis/streaming/windows.md ---
@@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit
of incremental window compu
the
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2368
No worries :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2411
Thanks for the quick fix, @wuchong!
The change looks good, but I just realized that the Java code might be on
purpose in the Scala tab. It shows the interface of the `WindowFunction` which
is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2368#discussion_r76008397
--- Diff: docs/apis/streaming/windows.md ---
@@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit
of incremental window compu
the
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r76010171
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/JsonRowSerializationSchemaTest.java
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r76010265
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSink.java
---
@@ -75,6
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2244
Thanks for the update @mushketyk. Regarding the `ObjectNode` that's fine.
It was just a possible optimization but if it is not worked let's keep it as it
is. I added two minor comments.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2411
Ah, OK. Didn't know that. Thanks! :-)
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r76024507
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2368#discussion_r76115561
--- Diff: docs/apis/streaming/windows.md ---
@@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit
of incremental window compu
the
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2368
Thanks for the update! The example looks good. I'll do some minor
reformatting and merge the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2391#discussion_r76237569
--- Diff: docs/apis/table.md ---
@@ -1445,6 +1445,28 @@ TEMPORAL.extract(TIMEINTERVALUNIT
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2391#discussion_r76237586
--- Diff: docs/apis/table.md ---
@@ -1445,6 +1445,28 @@ TEMPORAL.extract(TIMEINTERVALUNIT
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2391
Looks good! Thanks, @twalthr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2244
Looks good to merge @mushketyk :-)
The only thing that I'd change would be to rename
`Kafka08JsonTableSinkTest` to `Kafka08JsonTableSinkITCase` (same for Kafka09*),
since these are long ru
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2420
Thanks for the fix @haoch! However, @smarthi opened #2416 to fix the issue
as well.
Would you mind closing your PR?
There are certainly more things the documentation that can be
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2294
Sorry for the late reply @greghogan.
+1 from me as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2454#discussion_r77494182
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala
---
@@ -112,7 +112,7 @@ object FlinkRuleSets
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2454
Hi @wuchong, thanks for the PR. Just had two minor comments. Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2454#discussion_r77494279
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/DataStreamTable.scala
---
@@ -18,22 +18,11 @@
package
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/2508
[FLINK-2662] [dataSet] Translate union with multiple output into separate
unions with single output.
Fixes FLINK-2662 by translating Union operators with two (or more)
successors into two or more
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2430#discussion_r79390399
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkTestBase.java
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2430
Hi @mushketyk, thanks for reworking the tests and sorry that the review
took a while.
I added a comment. Please let me know if you have questions.
Thanks, Fabian
---
If your project is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2490#discussion_r79404090
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java ---
@@ -971,10 +971,7 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r79419954
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActions.java
---
@@ -0,0 +1,362
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r79420572
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java
---
@@ -0,0 +1,46
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r79422057
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/test/java/org/apache/flink/streaming/connectors/hbase/example/HBaseSinkExample.java
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2490
Thanks for the contribution @apivovarov. The PR looks good except for the
modified test which fails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2508
Adding a NoOp would prevent the unions from being merged, but the output of
the NoOp would still need to be replicated because it needs to be served to two
different operators.
if you have
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2490
Thanks for the fast update @apivovarov.
PR is good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79470876
--- Diff:
flink-batch-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/TestTableInputFormat.java
---
@@ -0,0 +1,112
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79469241
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -93,32 +102,45 @@ private HTable
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79469197
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -93,32 +102,45 @@ private HTable
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79469573
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -131,37 +153,27 @@ public T nextRecord
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79468879
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -67,15 +67,24 @@
protected
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79472506
--- Diff:
flink-batch-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/TestTableInputFormat.java
---
@@ -0,0 +1,112
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79469513
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -131,37 +153,27 @@ public T nextRecord
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79477173
--- Diff:
flink-batch-connectors/flink-hbase/src/test/resources/log4j-test.properties ---
@@ -15,9 +15,16 @@
# specific language governing permissions
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2460
I agree. +1 for moving the examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79477333
--- Diff:
flink-batch-connectors/flink-hbase/src/test/resources/hbase-site.xml ---
@@ -1,43 +0,0 @@
-
-
-
-
--- End diff --
I&#
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2298
Do we agree to stick with the current implementation? If yes, let's close
this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2298
Agreed @twalthr.
IMO, +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2304#discussion_r79573034
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/BigDecParser.java ---
@@ -120,7 +132,14 @@ public static final BigDecimal parseField(byte
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2304#discussion_r79572080
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/BigDecParser.java ---
@@ -55,9 +56,20 @@ public int parseField(byte[] bytes, int startPos
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2304#discussion_r79572690
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/BigDecParser.java ---
@@ -55,9 +56,20 @@ public int parseField(byte[] bytes, int startPos
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79579583
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/SqlTimeParserTest.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2508
Thanks, merging then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79650020
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/SqlDateParserTest.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2477
I agree with @zentol. `this.allowNullValues = false;` is the behavior since
the initial code import. I would not change this and rather fix the JavaDocs.
---
If your project is set up for it, you
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791682
--- Diff:
flink-batch-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/TestTableInputFormatITCase.java
---
@@ -0,0 +1,112
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791290
--- Diff:
flink-batch-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/TestTableInputFormatITCase.java
---
@@ -0,0 +1,112
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791990
--- Diff:
flink-batch-connectors/flink-hbase/src/test/resources/hbase-site.xml ---
@@ -1,43 +0,0 @@
-
-
-
-
--- End diff --
I
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791171
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -67,18 +66,23 @@
protected
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791053
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -67,18 +66,23 @@
protected
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79799184
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79798776
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79798925
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79798804
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79798968
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79798819
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79799395
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79799234
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
1 - 100 of 6299 matches
Mail list logo
