[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/311#issuecomment-71470851 Addressed most comments and renamed constantFields/Sets to forwardedFields as discussed on dev-ml. Would like to merge this soon. --- If your project is set up

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons (...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/335#issuecomment-71492121 Sure, XyzTest are unit tests which are executed in Maven's test phase. These should execute rather fast. Everything that brings up a full Flink system is an integration

[GitHub] flink pull request: [FLINK-1168] Adds multi-char field delimiter s...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/264#issuecomment-71455623 Updated the PR and will merge once Travis completed the build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-02-04 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-72886847 Other comments on the API breaking. If not, I'd merge it... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-02-03 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-72640916 Just implemented the basic triangle enumeration job and figured out that this example is already included in this PR ;-) However, when trying to run both programs, I

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-02-03 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-72641447 btw. implementing the program felt quite good. Very nice API, IMO! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/363#discussion_r24117856 --- Diff: docs/hadoop_compatibility.md --- @@ -52,56 +63,70 @@ Add the following dependency to your `pom.xml` to use the Hadoop Compatibility L

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/363#discussion_r24117714 --- Diff: docs/hadoop_compatibility.md --- @@ -52,56 +63,70 @@ Add the following dependency to your `pom.xml` to use the Hadoop Compatibility L

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-02-04 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-72941023 Got my triangle example also to working on a local setup. :-) Will play around more in the next days. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/363#discussion_r24117603 --- Diff: docs/hadoop_compatibility.md --- @@ -38,9 +39,19 @@ This document shows how to use existing Hadoop MapReduce code with Flink. Please

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/363#discussion_r24118164 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java --- @@ -458,6 +461,67 @@ public CsvReader readCsvFile(String filePath

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-04 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/363#issuecomment-72939364 Looks good. Besides the typos and inline comments, you could also move the `HadoopInputFormatTest` and the `HadoopIOFormatsITCase` to flink-java and flink-tests

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-02-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-72547127 Asking others to implement the standard example programs has worked quite well to identify issues with new APIs. How about, we look for people who try out the API

[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...

2015-02-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/338#issuecomment-72561341 +1 @rmetzger Can you create a JIRA for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1105] Add support for locally sorted ou...

2015-02-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/347#discussion_r23914766 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/DataSink.java --- @@ -83,6 +93,107 @@ public DataSink(DataSetT data, OutputFormatT

[GitHub] flink pull request: [FLINK-1369] [types] Add support for Subclasse...

2015-02-02 Thread fhueske
Github user fhueske closed the pull request at: https://github.com/apache/flink/pull/316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1369] [types] Add support for Subclasse...

2015-02-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/316#issuecomment-72479106 @aljoscha took this PR and extended it. He'll open corresponding PRs. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-02-03 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-72613154 The API was just extended, but the parsing logic for strings changed (see PR description). So programs that relied on the previous way of parsing will fail now

[GitHub] flink pull request: [FLINK1443] Add support for replicating input ...

2015-02-04 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/360 [FLINK1443] Add support for replicating input formats. InputFormats can be wrapped by a ReplicatingInputFormat which takes care that the full input of the wrapped input format is read in each

[GitHub] flink pull request: [FLINK-1422] Add withParameters() to documenta...

2015-02-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/350#discussion_r24167714 --- Diff: docs/programming_guide.md --- @@ -2398,6 +2399,61 @@ of a function, or use the `withParameters(...)` method to pass in a configuratio [Back

[GitHub] flink pull request: [FLINK-1422] Add withParameters() to documenta...

2015-02-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/350#discussion_r24168441 --- Diff: docs/programming_guide.md --- @@ -2398,6 +2399,61 @@ of a function, or use the `withParameters(...)` method to pass in a configuratio [Back

[GitHub] flink pull request: [FLINK1443] Add support for replicating input ...

2015-02-05 Thread fhueske
Github user fhueske closed the pull request at: https://github.com/apache/flink/pull/360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK1443] Add support for replicating input ...

2015-02-05 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/360#issuecomment-73025884 Merged as a19b4a02bfa5237e0dcd2b264da36229546f23c0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1485] Typo in Documentation - Join with...

2015-02-06 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/369#issuecomment-73251849 Definitely! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1485] Typo in Documentation - Join with...

2015-02-06 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/369#issuecomment-73251309 Thanks for the fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1486] add print method for prefixing a ...

2015-02-07 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/372#issuecomment-73387496 I think it would be nice to have some kind of hierarchical structure of the output such as: `$sinkName:$taskId $outputValue` That would give the name of the sink

[GitHub] flink pull request: [FLINK-1486] add print method for prefixing a ...

2015-02-08 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/372#issuecomment-73417227 Sounds good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-785] Chained AllReduce

2015-02-07 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/370#issuecomment-73388209 Looks good in general. You need to make sure though, that you obey the execution object re-usage settings. That basically means you need to pay attention

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-02-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-72501228 I added documentation. Any objections against merging this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1105] Add support for locally sorted ou...

2015-02-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/347#issuecomment-72501446 @rmetzger thanks for the feedback. I addressed your comment. Plan to merge this tomorrow, unless somebody objects. --- If your project is set up for it, you can reply

[GitHub] flink pull request: FLINK-1452: Rename 'flink-addons' to 'flink-st...

2015-02-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/355#issuecomment-72503732 +1 for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1271] Remove writable limitation

2015-01-15 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/287#issuecomment-70112509 LGTM Will do some tests, clean-up and merge if everything is fine --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/311#discussion_r23163896 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/DualInputSemanticProperties.java --- @@ -56,218 +56,135

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-19 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/311#issuecomment-70517390 IMO, users should only be allowed to set semantic properties though field expression strings. There should be no need to implement an own SemanticProperty class

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/311#discussion_r23163889 --- Diff: flink-compiler/src/main/java/org/apache/flink/compiler/dag/AbstractPartialSolutionNode.java --- @@ -86,8 +87,8 @@ public void

[GitHub] flink pull request: [FLINK-1406] update Flink compatibility notice

2015-01-19 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/314#issuecomment-70519951 Good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/311#discussion_r23070484 --- Diff: flink-compiler/src/main/java/org/apache/flink/compiler/dag/BinaryUnionNode.java --- @@ -266,4 +268,44 @@ public void computeOutputEstimates

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/311#discussion_r23073054 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java --- @@ -45,6 +46,16 @@ */ public class PojoTypeInfoT

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/311#issuecomment-70236149 Thanks for the review! Proposed names for constant field semantic properties: * constant fields (current) * unmodified fields * forwarded fields

[GitHub] flink pull request: [FLINK-1369] [types] Add support for Subclasse...

2015-01-16 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/316 [FLINK-1369] [types] Add support for Subclasses, Interfaces, Abstract Classes This PR rebased PR #236 to the current master. Some tests were failing and I had a closer look. The original PR

[GitHub] flink pull request: [FLINK-1406] update Flink compatibility notice

2015-01-17 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/314#issuecomment-70369166 I would add that Windows is only supported for local setups and link to the [Flink on Windows section of the Local Setup page](http://flink.apache.org/docs/0.7-incubating

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-17 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/311#issuecomment-70371949 Right! Some built-in operators had semantic annotations like filter, projection, and aggregation. Due to nesting support, semantic annotation can be added to more

[GitHub] flink pull request: [FLINK-785] Chained AllReduce

2015-02-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/370#issuecomment-73914381 Oh, just saw that you updated your PR. Won't open a PR. You can have a look at my branch here: https://github.com/fhueske/flink/tree/chained_all_reduce --- If your

[GitHub] flink pull request: [FLINK-785] Chained AllReduce

2015-02-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/370#issuecomment-73913500 Hi @zentol, I had a look at your PR and the failing test case. The test was in place to ensure that objects are reused. For that the functions were implemented

[GitHub] flink pull request: [FLINK-1461][api-extending] Add SortPartition ...

2015-02-18 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/381#issuecomment-74908224 any further comment on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-1444][api-extending] Add support for sp...

2015-02-18 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/379#issuecomment-74908763 @rmetzger thanks for the review. Will merge tomorrow if nobody raises a flag. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-1521] Chained operators respect reuse

2015-02-13 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/392#issuecomment-74237302 I agree with Stephan to not copy records for chained mappers. However, we should clearly document the behavior of the different modes or at least the behavior

[GitHub] flink pull request: [FLINK-1466] Add HCatInputFormats to read from...

2015-02-16 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/411 [FLINK-1466] Add HCatInputFormats to read from HCatalog tables. Right now the Flink-tuple mode is restricted to primitive types (no ARRAY, STRUCT, and MAP types) and the max Java/Scala tuple width

[GitHub] flink pull request: [FLINK-1466] Add HCatInputFormats to read from...

2015-02-18 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/411#issuecomment-74894556 @rmetzger Thanks for the feedback. Added support for complex types to the Flink tuple mode and tested it on a local cluster setup. --- If your project is set up

[GitHub] flink pull request: Add auto-parallelism to Jobs (0.8 branch)

2015-02-17 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/410#issuecomment-74643360 Using max parallelism basically prohibits to run more than one program at a time. I don't think that would be a good default mode. --- If your project is set up

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-01-27 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-71760224 Yes, that's still left to do... ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [Typo] Delete DiscardingOuputFormat

2015-01-27 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/343#issuecomment-71760881 +1 good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1105] Add support for locally sorted ou...

2015-01-29 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/347 [FLINK-1105] Add support for locally sorted output You can merge this pull request into a Git repository by running: $ git pull https://github.com/fhueske/flink locallySortedOutput

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-25 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71366397 To be honest, I find this additional option more confusing than helpful. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1433] Add HADOOP_CLASSPATH to start scr...

2015-01-25 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/337#issuecomment-71378388 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/236#issuecomment-71436626 @aljoscha Have a look at #316 where I took this PR, rebased it, and fixed some problems with Pojo types. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71440329 No worries ;-) I understand that discussing such a trivial feature feels like a waste of time. Unfortunately these are the features that are easy to comment

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71435854 Well, you would have saved everybody's time of you had made this requirements clear from the beginning. Besides your first two versions didn't comply with these new

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71433679 Hmmm, using the String pattern seems to be much more comfortable for users, no? If a user wants to have the data written out with some kind of filename pattern

[GitHub] flink pull request: [FLINK-1168] Adds multi-char field delimiter s...

2015-01-23 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/264#issuecomment-71285644 That's a good point. I copied the code from the DelimitedInputFormat which allows to specify the charset for the record delimiter. So if we go with 1. we should

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons (...

2015-02-01 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/335#issuecomment-72359922 One more thing ;-) Did we collect ICLAs from all people contributing significant parts to Gelly? --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons (...

2015-02-01 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/335#issuecomment-72366621 This is not about the license of the software / code itself. The [ASF homepage](http://www.apache.org/licenses/#clas) says The ASF desires that all contributors

[GitHub] flink pull request: [FLINK-1419] [runtime] DC properly synchronize...

2015-02-01 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/339#issuecomment-72390974 +1, will merge. Thanks @zentol @tillrohrmann! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1461][api-extending] Add SortPartition ...

2015-02-11 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/381 [FLINK-1461][api-extending] Add SortPartition operator to Java and Scala APIs. Adds the sortPartition operator to locally sort partitions of a DataSet. You can merge this pull request into a Git

[GitHub] flink pull request: [FLINK-1444][api-extending] Add support for sp...

2015-02-09 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/379 [FLINK-1444][api-extending] Add support for split data properties on data sources This pull request adds support for declaring global and local properties for input splits. You can merge this pull

[GitHub] flink pull request: [FLINK-1478] Add support for strictly local in...

2015-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/375#discussion_r24327047 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java --- @@ -260,15 +260,49 @@ public void

[GitHub] flink pull request: [FLINK-1478] Add support for strictly local in...

2015-02-09 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/375#issuecomment-73505358 Only minor remarks. Looks good otherwise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-05 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/363#issuecomment-73022621 Hmm, yes. That's also a valid point. But on the other hand, new users might not even be aware of the different types of InputFormats. It all would look natural

[GitHub] flink pull request: [FLINK-1501] Add metrics library for monitorin...

2015-02-20 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/421#issuecomment-75313413 This is much needed monitoring and really great! What are the current options for showing the detailed metrics? I see a show 3 TMs and show all TMs button

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-21 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-84382628 Exactly, thanks @hsaputra It would also be good to add some actual arguments to the discussion that go beyond I like xxx more than yyy ;-) --- If your project

[GitHub] flink pull request: [FLINK-1683] [jobmanager]� Fix scheduling pref...

2015-03-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/476#issuecomment-78306554 I updated the PR and made the preference choice a bit more lightweight. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1654] Wrong scala example of POJO type ...

2015-03-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/478#issuecomment-78308404 Thanks for the fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r26215940 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java --- @@ -684,4 +693,178 @@ private void testRemovingTrailingCR(String

[GitHub] flink pull request: Add auto-parallelism to Jobs (0.8 branch)

2015-03-06 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/410#issuecomment-77569539 I think it would be definitely good to have something like a job submission queue, that accepts jobs and executes them as soon as enough as enough resource become

[GitHub] flink pull request: [FLINK-1628] Fix partitioning properties for J...

2015-03-05 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/458 [FLINK-1628] Fix partitioning properties for Joins and CoGroups. Fix partitioning properties for Joins and CoGroups and some smaller bugs on the way. You can merge this pull request into a Git

[GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a partia...

2015-03-10 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/466#issuecomment-78084575 Yes, I've got a couple of comments as well. First of all, as @mxm said, I would propose to call this operator ``combine`` because it is a generalized combiner

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r26203612 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -64,26 +70,45 @@ private transient int commentCount

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r26205234 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -152,6 +177,38 @@ public void setFields(boolean[] sourceFieldMask

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r26206307 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -234,9 +291,29 @@ public OUT readRecord(OUT reuse, byte[] bytes

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r26206381 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -234,9 +291,29 @@ public OUT readRecord(OUT reuse, byte[] bytes

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r26205969 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -152,6 +177,38 @@ public void setFields(boolean[] sourceFieldMask

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r26206133 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -152,6 +177,38 @@ public void setFields(boolean[] sourceFieldMask

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r26206329 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -234,9 +291,29 @@ public OUT readRecord(OUT reuse, byte[] bytes

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-13 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/482#issuecomment-78868258 Its true, the parameters are not necessarily needed, but they don't harm either. In fact, I like it to explicitly specify parameters. I do not see a need to break the API

[GitHub] flink pull request: [FLINK-1683] [jobmanager]� Fix scheduling pref...

2015-03-10 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/476 [FLINK-1683] [jobmanager] Fix scheduling preference choice for non-unary execution tasks Fix validated on a cluster setup. You can merge this pull request into a Git repository by running

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r26216185 --- Diff: flink-scala/src/main/java/org/apache/flink/api/scala/operators/ScalaCsvInputFormat.java --- @@ -66,18 +66,30 @@ public ScalaCsvInputFormat

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/426#issuecomment-78276533 Hi, thanks for the update! This is really good progress! I had a look at your code and noticed a few things apart from the inline comments

[GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a partia...

2015-03-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/466#discussion_r26135427 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReducePartialOperator.java --- @@ -0,0 +1,229 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a partia...

2015-03-12 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/466#issuecomment-78091524 I have to correct myself. A combiner should of course be called on groups of records. Therefore, calling it on a Grouping makes absolute sense. However, the semantics

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r27018833 --- Diff: flink-scala/src/main/java/org/apache/flink/api/scala/operators/ScalaCsvInputFormat.java --- @@ -19,66 +19,91 @@ package

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r27018849 --- Diff: flink-scala/src/main/java/org/apache/flink/api/scala/operators/ScalaCsvInputFormat.java --- @@ -98,98 +123,66 @@ public void setFields(int

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r27018880 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/ExecutionEnvironment.scala --- @@ -223,8 +224,11 @@ class ExecutionEnvironment(javaEnv

[GitHub] flink pull request: [FLINK-1656] Filter ForwardedField properties ...

2015-03-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/525#issuecomment-85499509 Yes, I agree. The fix is more conservative than necessary. I think we can safely relax it if we make the rule for forwarded fields on group-wise operators as follows

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r27018277 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -52,103 +50,86 @@ public static final String

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r27018316 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -52,103 +50,86 @@ public static final String

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/426#issuecomment-85455383 Very good! Let me know, when you want me to have a look again :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r27018151 --- Diff: flink-scala/src/main/java/org/apache/flink/api/scala/operators/ScalaCsvInputFormat.java --- @@ -98,98 +123,66 @@ public void setFields(int

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/426#issuecomment-85447697 I see the issue with the non-deterministic field order and FLINK-1665 as follows. Both, FLINK-1665 and Option 3, solve the problem of non-deterministic field order

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r27018812 --- Diff: flink-scala/src/main/java/org/apache/flink/api/scala/operators/ScalaCsvInputFormat.java --- @@ -19,66 +19,91 @@ package

[GitHub] flink pull request: [FLINK-1512] Add CsvReader for reading into PO...

2015-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r27018473 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -52,103 +50,86 @@ public static final String

  1   2   3   4   5   6   7   8   9   10   >