Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2362
@wuchong Thanks for the fix! Will merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2297
@StephanEwen I renamed `EMPTY_STRING` to `EMPTY_COLUMN`. All parsers that
have a "format" (like Double, Boolean, Integer etc.) return `-1` and set
`EMPTY_COLUMN`. The `StringParser` r
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2265
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2094
I will shepherd this PR. I think I can review it this week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2372#discussion_r74771464
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/exceptions.scala
---
@@ -37,3 +37,16 @@ case class ValidationException(msg
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2372#discussion_r74772260
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/exceptions.scala
---
@@ -37,3 +37,16 @@ case class ValidationException(msg
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2380
[FLINK-4189] [table] Introduce symbols for internal use
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2372
Thanks @wuchong. Will merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2391
[FLINK-3580] [table] Implement FLOOR/CEIL for time points
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75826683
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BasicArrayTypeInfo.java
---
@@ -121,6 +122,18 @@ public boolean isKeyType
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75826929
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BasicTypeInfo.java
---
@@ -171,6 +172,23 @@ public boolean isKeyType
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75827289
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75827397
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75827568
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75828177
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75828736
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75828673
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75829026
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75830865
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -317,7 +308,39 @@ public int getFieldIndex(String fieldName
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75831968
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -317,7 +308,39 @@ public int getFieldIndex(String fieldName
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75832360
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75833200
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75833983
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75834786
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75834833
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75835061
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75835835
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75836333
--- Diff:
flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/ProductFieldAccessor.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75837546
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75839040
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/CaseClassTypeInfo.scala
---
@@ -236,6 +237,31 @@ abstract class CaseClassTypeInfo
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75868407
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -301,12 +301,12 @@ public KeyedStream
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75876606
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/DataStreamPojoITCase.java
---
@@ -139,17 +139,6 @@ public void flatMap(Data
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2094
Thanks for the contribution and your patience @ggevay. I added some line
comments. But in general it looks good.
@StephanEwen is it ok to add an `TypeInformation.getFieldAccessor()` method
to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75898467
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/CompositeAccessTest.scala
---
@@ -0,0 +1,167
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75899092
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r76068132
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2391
If there are no objections, I would merge this later today.
@fhueske ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2391
Thanks @fhueske. I will address your comments and merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76567175
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76567285
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2094
Thanks for updating the PR @ggevay. Beside some small comments the PR looks
good to merge. I can fix them when merging.
@rmetzger you opened the Jira issue. Do you also want to take a final look
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2337
@StephanEwen I have added `TypeInfoFactory` support to the Scala API and
added tests for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2384
Thanks @wuchong. The PR looks good. I will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2102
@wuchong I have added symbols recently. So functions like `TRIM` are now
called correctly. If you like you could update this PR.
---
If your project is set up for it, you can reply to this email
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2441
[FLINK-3580] [table] Add current time point functions
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2441
I thought about it again. Maybe I will rework it a little bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2441
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2454
Thank @wuchong. Looks good to merge. @fhueske do you also want to have a
look at it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2468
[FLINK-3580] [table] Add OVERLAPS function
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2337#discussion_r7227
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -122,14 +123,25 @@
public abstract Class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2337#discussion_r77981435
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInfoFactory.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2337#discussion_r77984002
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
@@ -792,12 +832,40 @@ else if (t instanceof Class
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2483
Thanks for the fix. Will merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2485
Could you rebase your PR on the current master and then do a force push?
There are a lot of commits that should not appear here.
---
If your project is set up for it, you can reply to this email
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2500
[FLINK-4549] [table] Test and document implicitly supported SQL functions
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2502
[FLINK-4550] [table] Clearly define SQL operator table
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2485
Thanks @chobeat. I fixed minor formatting issues and extended the
documentation a little bit. Will merge...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2454
It seems that Calcite is planning to add additional clauses to the SQL
statement. Like `SELECT STREAM x FROM y EMIT xyz`. If we really remove the
keyword we have to make sure that Calcite's p
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2504
[FLINK-4590] [table] Some Table API tests are failing when debug lvl is set
to DEBUG
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2506
[FLINK-4581] [table] Table API throws "No suitable driver found for
jdbc:calcite"
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2507
[FLINK-4252] [table] Validate input and output classes of Table API
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2297
If there are no objections, I would like to merge this PR next week. Other
my other PRs depend on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2511
[FLINK-4288] [table] Make it possible to unregister tables
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2304
@fhueske I improved the big decimal parsing. Now less objects are created.
I hope I didn't introduce new bugs.
---
If your project is set up for it, you can reply to this email and have your
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2298
I think adding some comments the methods doesn't hurt. I would merge this
PR as it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2337
I have added some documentation for type factories. If there are no
objections, I will merge this later today.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2521
[FLINK-4639] [table] Make Calcite features more pluggable
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2304
Thanks again for the review @fhueske. I will fix your comments and merge
this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79632225
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/SqlDateParserTest.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79651336
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/SqlTimeParserTest.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79652411
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/SqlTimestampParserTest.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79652535
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/SqlDateParser.java ---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79776134
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/SqlDateParserTest.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2303
@fhueske thanks for reviewing my code. I addressed your feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79804375
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79804683
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2303#discussion_r79804868
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
@@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2529
[FLINK-4241] [table] Cryptic expression parser exceptions
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2303
@fhueske I think we should keep the methods as they currently are. I
renamed them to "nextNumericString"/"nextNumericStringEndPos" and added a
explanation what a numeric stri
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2504#discussion_r80258489
--- Diff:
flink-libraries/flink-table/src/test/resources/log4j-test.properties ---
@@ -0,0 +1,27
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2502
Thanks @fhueske. Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3389
Thanks for the update @clarkyzl. The code looks good. I will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3107
@wuchong any plans to update this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3407
@clarkyzl I merged the varargs scalar functions. Can you rebase this and
the Hive UDFs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3407
Thanks @clarkyzl. Looks good. Will merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3456#discussion_r105648552
--- Diff:
flink-connectors/flink-hcatalog/src/main/scala/org/apache/flink/table/hive/functions/HiveSimpleUDF.scala
---
@@ -0,0 +1,87
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3456#discussion_r105649084
--- Diff:
flink-connectors/flink-hcatalog/src/test/scala/org/apache/flink/table/hive/functions/utils/ExpressionTestBase.scala
---
@@ -0,0 +1,270
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3456#discussion_r105638967
--- Diff: flink-connectors/flink-hcatalog/pom.xml ---
@@ -44,14 +44,20 @@ under the License.
org.apache.flink
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3456#discussion_r105646877
--- Diff:
flink-connectors/flink-hcatalog/src/main/scala/org/apache/flink/table/hive/functions/HiveSimpleUDF.scala
---
@@ -0,0 +1,87
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3456#discussion_r105638573
--- Diff: flink-connectors/flink-hcatalog/pom.xml ---
@@ -44,14 +44,20 @@ under the License.
org.apache.flink
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3456
Another issue that came to my mind. What about the methods
`UDF#getRequiredJars` and `UDF#getRequiredFiles`? Either we throw an
unsupported exception if the UDF implements these methods or we
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3456#discussion_r105646577
--- Diff:
flink-connectors/flink-hcatalog/src/main/scala/org/apache/flink/table/hive/functions/HiveSimpleUDF.scala
---
@@ -0,0 +1,87
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3456#discussion_r105650856
--- Diff:
flink-connectors/flink-hcatalog/src/main/scala/org/apache/flink/table/hive/functions/HiveSimpleUDF.scala
---
@@ -0,0 +1,87
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3107
Thanks for the quick update @wuchong. The code looks good to merge. Can you
add some documentation to the SQL section?
---
If your project is set up for it, you can reply to this email and have
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3107
Thanks @wuchong. Will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106346971
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CrudExternalCatalog.scala
---
@@ -0,0 +1,110
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106349244
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSourceConverter.scala
---
@@ -0,0 +1,73
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106348421
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableSourceUtil.scala
---
@@ -0,0 +1,153
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106347964
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,76
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106348184
--- Diff:
flink-libraries/flink-table/src/main/resources/tableSourceConverter.properties
---
@@ -0,0 +1,19
1 - 100 of 1788 matches
Mail list logo
