[GitHub] dianfu commented on a change in pull request #7189: [FLINK-10597][table] Enabled UDFs support in MATCH_RECOGNIZE
dianfu commented on a change in pull request #7189: [FLINK-10597][table] Enabled UDFs support in MATCH_RECOGNIZE URL: https://github.com/apache/flink/pull/7189#discussion_r237722370 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/match/PatternSelectFunctionRunner.scala ## @@ -35,20 +36,26 @@ import org.apache.flink.util.Collector class PatternSelectFunctionRunner( name: String, code: String) - extends PatternFlatSelectFunction[Row, CRow] - with Compiler[PatternSelectFunction[Row, Row]] + extends RichPatternFlatSelectFunction[Row, CRow] Review comment: @dawidwys I have rethought about this issue and what about always generating a `PatternFlatSelectFunction` no matter `ONE ROW PER MATCH` or `ALL ROWS PER MATCH` is specified? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dianfu commented on a change in pull request #7189: [FLINK-10597][table] Enabled UDFs support in MATCH_RECOGNIZE
dianfu commented on a change in pull request #7189: [FLINK-10597][table] Enabled UDFs support in MATCH_RECOGNIZE URL: https://github.com/apache/flink/pull/7189#discussion_r237464564 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/match/PatternSelectFunctionRunner.scala ## @@ -35,20 +36,26 @@ import org.apache.flink.util.Collector class PatternSelectFunctionRunner( name: String, code: String) - extends PatternFlatSelectFunction[Row, CRow] - with Compiler[PatternSelectFunction[Row, Row]] + extends RichPatternFlatSelectFunction[Row, CRow] Review comment: OK. Make sense. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dianfu commented on a change in pull request #7189: [FLINK-10597][table] Enabled UDFs support in MATCH_RECOGNIZE
dianfu commented on a change in pull request #7189: [FLINK-10597][table]
Enabled UDFs support in MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7189#discussion_r237464451
##
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
##
@@ -131,47 +132,39 @@ class MatchCodeGenerator(
: GeneratedFunction[F, T] = {
Review comment:
We can add something like `reusablePrepareInputStatements` in CodeGenerator
and place it before `reuseInputUnboxingCode` when generating the function.
Then we can make use of `reusablePrepareInputStatements` to construct the
`reusePatternLists`. But I'm fine with the current implementation as
`reusablePrepareInputStatements` is currently only useful for CEP.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dianfu commented on a change in pull request #7189: [FLINK-10597][table] Enabled UDFs support in MATCH_RECOGNIZE
dianfu commented on a change in pull request #7189: [FLINK-10597][table]
Enabled UDFs support in MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7189#discussion_r237407834
##
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
##
@@ -131,47 +132,39 @@ class MatchCodeGenerator(
: GeneratedFunction[F, T] = {
Review comment:
We can already reuse `FunctionCodeGenerator.generateFunction()` as
IterativeCondition and Pattern(Flat)SelectFunction already support rich
interfaces.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dianfu commented on a change in pull request #7189: [FLINK-10597][table] Enabled UDFs support in MATCH_RECOGNIZE
dianfu commented on a change in pull request #7189: [FLINK-10597][table] Enabled UDFs support in MATCH_RECOGNIZE URL: https://github.com/apache/flink/pull/7189#discussion_r237411315 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/match/PatternSelectFunctionRunner.scala ## @@ -35,20 +36,26 @@ import org.apache.flink.util.Collector class PatternSelectFunctionRunner( name: String, code: String) - extends PatternFlatSelectFunction[Row, CRow] - with Compiler[PatternSelectFunction[Row, Row]] + extends RichPatternFlatSelectFunction[Row, CRow] Review comment: Is there any reason we use a `RichPatternFlatSelectFunction` which actually wraps a `RichPatternSelectFunction`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
