[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3726 Yes we should create another JIRA issue. You can create it. You can also close FLINK-6130 then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @tillrohrmann That is right. We can close this PR surely. BTW, Should we make another jira refactoring this class and ```AbstractYarnFlinkApplicationMasterRunner ``` ? Because I watch the ```AbstractYarnFlinkApplicationMasterRunner ``` and find only one subclass. If we do create another jira, You are the reporter and assign it to me. How do you think of this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3726 @zhangminglei please refrain from pulling more and more people into the loop by directly referencing them given that this is a trivial change and that 5 people are already involved. Looking at the `YarnFlinkApplicationMasterRunner` I think it could benefit from some more refactoring. For example, I don't think that we need to have an `AbstractYarnFlinkApplicationMasterRunner` base class. Both can be combined in one class. Then we can instantiate the services and runtime components in the constructor of `YarnFlinkApplicationMasterRunner`. That way we can get rid of the lock in the `run` method. Given that, I'm not sure whether this PR makes then sense anymore. I think we can close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @zentol Please helps review. I am very appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @StephanEwen Hi, How do you think of this refine ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3726 What is the problem we're trying here to solve? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 Travis sucks some time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3726 I don't think the timeout was related. We'll see from this Travis run :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @tzulitai Hi, Could you please review my code ? I am appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3726: [FLINK-6130] [yarn] Fix Consider calling resourceManager#...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3726 @tedyu @zentol It seems there is a problem with travis-ci test if no output within 5 mins then it will print the stacktrace and then kill the watchdog , please help to review and checkout how to solve, I am appreciate it. ``` Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.213 sec - in org.apache.flink.runtime.minicluster.MiniClusterITCase == Maven produced no output for 300 seconds. == == The following Java processes are running (JPS) == 1552 Launcher 12642 Jps 8045 surefirebooter5889190340308801783.jar ... Trying to KILL watchdog (1547). MVN exited with EXIT CODE: 143. java.io.FileNotFoundException: build-target/lib/flink-dist*.jar (No such file or directory) at java.util.zip.ZipFile.open(Native Method) at java.util.zip.ZipFile.(ZipFile.java:220) at java.util.zip.ZipFile.(ZipFile.java:150) at java.util.zip.ZipFile.(ZipFile.java:121) at sun.tools.jar.Main.list(Main.java:1060) at sun.tools.jar.Main.run(Main.java:291) at sun.tools.jar.Main.main(Main.java:1233) find: `./flink-yarn-tests/target/flink-yarn-tests*': No such file or directory PRODUCED build artifacts. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
