[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6089 @zentol Thanks for the review. I made the clean up and did some changes to get the ES dependency from flink-quickstart-test/pom.xml ---
[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6089 @zentol PR has been updated and usage also changed to `test_quickstarts.sh ` ---
[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6089 @zentol PR is updated with requested changes! Please review ---
[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6089 @zentol PR is updated! ---
[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6089 @zentol Thanks! found them :) ---
[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6089 The ES modules are used in `run-nightly-tests.sh`. ---
[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6089 @zentol I reverted back flink-elasticsearch* modules. Do you think we still need them as they've never been used? ---
[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6089 @zentol updated the PR as suggested! Please review ---
[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6089 @zentol sure! I will update the PR with your requested changes. ---
[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6089 Let's not mix concerns here. Re-using examples can lead to situations where the quickstart tests fail because an example was modified, which by all means shouldn't happen. The examples should certainly be tested as well though, but that's a separate issue. ---
[GitHub] flink issue #6089: [FLINK-9451]End-to-end test: Scala Quickstarts
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6089 @zentol Thanks for review! Yes, I totally agree as the most of test script is duplicated, we need to refactor them the way you mentioned, I will update the PR with new changes. QQ: One reason I borrowed an example from 'Flink-example' module was to e2e test the actual example code also. One benefit would be testing the actual example and safeguard the 'Flink-example' module from any code changes without passing the tests. (or another cleaner option is to increase unittest coverage to flink-example package). Do you think we should have a dedicated module under test folder or extend the 'Flink-example' module with ES example and test e2e for that. ---
