Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/413
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/413#issuecomment-78017191
Looks good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/413#issuecomment-75545980
Exactly, the change is only for 0.8.
For 0.9 its already merged to master using the ExecutionConfig.
---
If your project is set up for it, you can reply to this
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/413#issuecomment-75513308
I assume that this is targeted at the 0.8 branch?
For the 0.9 branch, it would be nice to use the execution config instead to
define which serializer to
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/413#discussion_r25130737
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java
---
@@ -154,6 +176,7 @@ private void
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/413#discussion_r25130794
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java
---
@@ -91,7 +98,22 @@ public T createInstance() {
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/413#discussion_r25130805
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/GenericTypeInfo.java
---
@@ -66,6 +71,9 @@ public boolean isKeyType() {
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/413#issuecomment-75429131
I've updated the PR addressing Till's comments and adding a
`GenericAvroTypeInfo` giving users an additional way to enforce the Avro
serializer.
---
If your project is
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/413#discussion_r25086186
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/GenericTypeInfo.java
---
@@ -66,6 +71,9 @@ public boolean isKeyType() {
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/413#issuecomment-75283551
LGTM besides of my small comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
10 matches
Mail list logo
