[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1017#discussion_r37174502 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java --- @@

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1017#issuecomment-131772364 Allright, if there are no further comments, I'll merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1017 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1017#discussion_r37168797 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java --- @@ -39,61

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1017#discussion_r37174684 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/operators/Output.java --- @@ -33,9 +33,8 @@

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1017#issuecomment-131735854 This looks like a very nice continuation of the cleanup work. I'd suggest to merge it rather sooner than later. --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1017#discussion_r37166759 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java --- @@ -27,114

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1017#discussion_r37167205 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/operators/Output.java --- @@ -33,9 +33,8 @@

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1017#discussion_r37143081 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java --- @@ -27,114

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user ffbin commented on a diff in the pull request: https://github.com/apache/flink/pull/1017#discussion_r37142604 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java --- @@ -27,114

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user gyfora commented on a diff in the pull request: https://github.com/apache/flink/pull/1017#discussion_r37144298 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamIterationTail.java --- @@ -25,65

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1017#discussion_r37146789 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamIterationTail.java --- @@

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1017#discussion_r37146808 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java --- @@

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1017#issuecomment-131431977 Fixed the issues with the tests. Builds locally, waiting for Travis to confirm. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2462] [streaming] Major cleanup of stre...

GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/1017 [FLINK-2462] [streaming] Major cleanup of streaming task structure This pull request addresses exception handling, code duplication, and missed resource cleanups in the streaming operators.