[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-28 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61402967 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,224 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-28 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61402951 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,225 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-28 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61402512 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java --- @@ -0,0 +1,271 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61273003 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitReadOperator.java --- @@ -0,0 +1,176 @@ +/* + *

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61233316 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java --- @@ -0,0 +1,279 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61233284 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java --- @@ -0,0 +1,279 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61232860 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionTest.java --- @@ -0,0 +1,370 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61232298 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitReadOperator.java --- @@ -0,0 +1,176 @@ +/* +

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61231656 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitReadOperator.java --- @@ -0,0 +1,176 @@ +/* +

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61231507 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitReadOperator.java --- @@ -0,0 +1,176 @@ +/* +

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61231326 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitReadOperator.java --- @@ -0,0 +1,176 @@ +/* +

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61230608 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitReadOperator.java --- @@ -0,0 +1,176 @@ +/* +

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61230524 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitReadOperator.java --- @@ -0,0 +1,176 @@ +/* +

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61230544 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitReadOperator.java --- @@ -0,0 +1,176 @@ +/* +

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61230370 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,234 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61229319 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,234 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61228702 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,234 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61228675 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,234 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61228546 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,234 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61065673 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java --- @@ -0,0 +1,279 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-26 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61063235 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java --- @@ -0,0 +1,279 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61062846 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java --- @@ -0,0 +1,279 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-214664097 One additional remark. I'd like to get rid of these fields in `FileSplitMonitoringFunctionTest`: ``` private Set hdPaths = new HashSet<>(); private Set

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r61043013 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,225 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60943147 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,225 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60942903 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java --- @@ -0,0 +1,279 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60942837 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,225 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60942382 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,225 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-214420551 We may want to think about adding a createInputSplits(int minNumSplits, List files) to the FileInputFormat class; as it stands it scans through the entire directory

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60939797 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,225 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60939583 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,225 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60939625 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,225 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60938941 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,225 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60938712 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,225 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60937977 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FilePathFilter.java --- @@ -0,0 +1,64 @@ +/* + *

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60937348 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -35,12 +35,9 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60936805 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java --- @@ -0,0 +1,279 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60935904 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,259 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60933644 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionTest.java --- @@ -0,0 +1,371 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60934370 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionTest.java --- @@ -0,0 +1,371 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60932653 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/DefaultPathFilter.java --- @@ -0,0 +1,7 @@ +package

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60932233 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,259 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60932263 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,259 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60931033 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,259 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-214387476 Can you provide a rough description as to how the FileSourceMonitoringFunction works and how it interacts with the actual formats? --- If your project is set up for it,

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60930454 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/DefaultPathFilter.java --- @@ -0,0 +1,7 @@ +package

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60929807 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionTest.java --- @@ -0,0 +1,371 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60929665 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionTest.java --- @@ -0,0 +1,371 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60928894 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunctionITCase.java --- @@ -0,0 +1,279 @@

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60928614 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,259 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60928509 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,259 @@ +/*

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60928251 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FilePathFilter.java --- @@ -0,0 +1,67 @@ +/* + *

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60928155 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FilePathFilter.java --- @@ -0,0 +1,67 @@ +/* + *

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60928227 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FilePathFilter.java --- @@ -0,0 +1,67 @@ +/* + *

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60928005 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/DefaultPathFilter.java --- @@ -0,0 +1,7 @@ +package

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60927886 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala --- @@ -458,7 +458,7 @@ class

[GitHub] flink pull request: Refactoring the File Monitoring Source.

2016-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1929#discussion_r60927783 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSplitMonitoringFunction.java --- @@ -0,0 +1,259 @@ +/*