Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5220
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r160722901
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
---
@@ -99,6 +69,44 @@ public void testStop() throws
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r160721955
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java ---
@@ -1,170 +0,0 @@
-/*
- * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r160721122
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
---
@@ -99,6 +69,44 @@ public void testStop() throws
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r160720306
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -882,42 +784,28 @@ protected ClusterClient
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r160719791
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -598,189 +535,154 @@ protected int cancel(String[] args) {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r160715198
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -587,9 +526,7 @@ protected int cancel(String[] args) {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r160711940
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -515,33 +464,28 @@ protected int stop(String[] args) {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r160710138
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -292,20 +267,14 @@ protected int run(String[] args) {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r160709495
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -274,19 +251,13 @@ protected int run(String[] args) {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159446300
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
---
@@ -99,6 +69,44 @@ public void testStop() throws Exception {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159447901
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java ---
@@ -1,170 +0,0 @@
-/*
- * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159449988
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendCancelTest.java
---
@@ -42,70 +39,54 @@
/**
* Tests for the CANCEL
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159432084
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -598,189 +535,154 @@ protected int cancel(String[] args) {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159439656
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
---
@@ -99,6 +69,44 @@ public void testStop() throws Exception {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159435504
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -292,20 +267,14 @@ protected int run(String[] args) {
*
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159422039
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -882,42 +784,28 @@ protected ClusterClient
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159425958
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -274,19 +251,13 @@ protected int run(String[] args) {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159431758
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -598,189 +535,154 @@ protected int cancel(String[] args) {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159430427
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -587,9 +526,7 @@ protected int cancel(String[] args) {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159429333
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -515,33 +464,28 @@ protected int stop(String[] args) {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159422003
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -882,42 +784,28 @@ protected ClusterClient
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5220
[FLINK-8333] [flip6] Separate deployment options from command options
## What is the purpose of the change
This commit separates the parsing of command options and deployment options
23 matches
Mail list logo
