[jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway
[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522905#comment-15522905
]
ASF GitHub Bot commented on FLINK-4580:
---
Github user tillrohrmann closed the pull request at:
https://github.com/apache/flink/pull/2526
> Check that the RpcEndpoint supports the specified RpcGateway
>
>
> Key: FLINK-4580
> URL: https://issues.apache.org/jira/browse/FLINK-4580
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the
> {{RpcGateway}}. At the moment, it is not checked whether the {{RpcEndpoint}}
> actually supports the specified {{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding
> {{RpcEndpoint}} supports the specified {{RpcGateway}}. If not, then we can
> let the connect method fail fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway
[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522651#comment-15522651
]
ASF GitHub Bot commented on FLINK-4580:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2526
Thanks for the review @StephanEwen. Will merge this PR then.
> Check that the RpcEndpoint supports the specified RpcGateway
>
>
> Key: FLINK-4580
> URL: https://issues.apache.org/jira/browse/FLINK-4580
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the
> {{RpcGateway}}. At the moment, it is not checked whether the {{RpcEndpoint}}
> actually supports the specified {{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding
> {{RpcEndpoint}} supports the specified {{RpcGateway}}. If not, then we can
> let the connect method fail fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway
[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512922#comment-15512922
]
ASF GitHub Bot commented on FLINK-4580:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2526
Nice!
+1 to merge this
> Check that the RpcEndpoint supports the specified RpcGateway
>
>
> Key: FLINK-4580
> URL: https://issues.apache.org/jira/browse/FLINK-4580
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the
> {{RpcGateway}}. At the moment, it is not checked whether the {{RpcEndpoint}}
> actually supports the specified {{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding
> {{RpcEndpoint}} supports the specified {{RpcGateway}}. If not, then we can
> let the connect method fail fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway
[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509900#comment-15509900
]
ASF GitHub Bot commented on FLINK-4580:
---
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2526
[FLINK-4580] [rpc] Report rpc invocation exceptions to the caller
Reports rpc invocations back to the caller.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink rpcErrorReporting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2526.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2526
commit b52fb356d48850453956d2f6c4e52ba8fe2da8ab
Author: Till Rohrmann
Date: 2016-09-21T13:18:27Z
[FLINK-4580] [rpc] Report rpc invocation exceptions to the caller
> Check that the RpcEndpoint supports the specified RpcGateway
>
>
> Key: FLINK-4580
> URL: https://issues.apache.org/jira/browse/FLINK-4580
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the
> {{RpcGateway}}. At the moment, it is not checked whether the {{RpcEndpoint}}
> actually supports the specified {{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding
> {{RpcEndpoint}} supports the specified {{RpcGateway}}. If not, then we can
> let the connect method fail fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway
[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509897#comment-15509897
]
Till Rohrmann commented on FLINK-4580:
--
Adding this check lazily when executing the rpc call.
> Check that the RpcEndpoint supports the specified RpcGateway
>
>
> Key: FLINK-4580
> URL: https://issues.apache.org/jira/browse/FLINK-4580
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the
> {{RpcGateway}}. At the moment, it is not checked whether the {{RpcEndpoint}}
> actually supports the specified {{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding
> {{RpcEndpoint}} supports the specified {{RpcGateway}}. If not, then we can
> let the connect method fail fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway
[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509763#comment-15509763
]
ASF GitHub Bot commented on FLINK-4580:
---
Github user tillrohrmann closed the pull request at:
https://github.com/apache/flink/pull/2473
> Check that the RpcEndpoint supports the specified RpcGateway
>
>
> Key: FLINK-4580
> URL: https://issues.apache.org/jira/browse/FLINK-4580
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the
> {{RpcGateway}}. At the moment, it is not checked whether the {{RpcEndpoint}}
> actually supports the specified {{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding
> {{RpcEndpoint}} supports the specified {{RpcGateway}}. If not, then we can
> let the connect method fail fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway
[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509762#comment-15509762
]
ASF GitHub Bot commented on FLINK-4580:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2473
Yes agreed. One will always eventually find out about a wrongly connected
rpc endpoint if we introduce a proper error reporting in case of a method
lookup/invocation failure.
> Check that the RpcEndpoint supports the specified RpcGateway
>
>
> Key: FLINK-4580
> URL: https://issues.apache.org/jira/browse/FLINK-4580
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the
> {{RpcGateway}}. At the moment, it is not checked whether the {{RpcEndpoint}}
> actually supports the specified {{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding
> {{RpcEndpoint}} supports the specified {{RpcGateway}}. If not, then we can
> let the connect method fail fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway
[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509607#comment-15509607
]
ASF GitHub Bot commented on FLINK-4580:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2473
The idea is nice, but it comes at the cost of yet another message roundtrip
at startup.
Since we should anyways forward the target endpoint invocation failures to
the source gateway, I think that should improve the failure handling in a
similar way.
> Check that the RpcEndpoint supports the specified RpcGateway
>
>
> Key: FLINK-4580
> URL: https://issues.apache.org/jira/browse/FLINK-4580
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the
> {{RpcGateway}}. At the moment, it is not checked whether the {{RpcEndpoint}}
> actually supports the specified {{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding
> {{RpcEndpoint}} supports the specified {{RpcGateway}}. If not, then we can
> let the connect method fail fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway
[
https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464682#comment-15464682
]
ASF GitHub Bot commented on FLINK-4580:
---
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2473
[FLINK-4580] [rpc] Verify that the rpc endpoint supports the rpc gateway at
connect time
When calling RpcService.connect it is checked that the rpc endpoint
supports the specified
rpc gateway. If not, then a RpcConnectionException is thrown. The
verification is implemented
as an additional message following after the Identify message. The reason
for this is that
the ActorSystem won't wait for the Identify message to time out after it
has determined that
the specified actor does not exist. For user-level messages this seems to
be not the case and,
thus, we would have to wait for the timeout.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink addGatewayEndpointCheck
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2473
commit 189fb14ddf30726f537f681e800c111ba9bc7c81
Author: Till Rohrmann
Date: 2016-09-05T10:13:29Z
[FLINK-4580] [rpc] Verify that the rpc endpoint supports the rpc gateway at
connect time
When calling RpcService.connect it is checked that the rpc endpoint
supports the specified
rpc gateway. If not, then a RpcConnectionException is thrown. The
verification is implemented
as an additional message following after the Identify message. The reason
for this is that
the ActorSystem won't wait for the Identify message to time out after it
has determined that
the specified actor does not exist. For user-level messages this seems to
be not the case and,
thus, we would have to wait for the timeout.
> Check that the RpcEndpoint supports the specified RpcGateway
>
>
> Key: FLINK-4580
> URL: https://issues.apache.org/jira/browse/FLINK-4580
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the
> {{RpcGateway}}. At the moment, it is not checked whether the {{RpcEndpoint}}
> actually supports the specified {{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding
> {{RpcEndpoint}} supports the specified {{RpcGateway}}. If not, then we can
> let the connect method fail fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
