[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395412#comment-16395412 ] ASF GitHub Bot commented on FLINK-8687: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395406#comment-16395406 ] ASF GitHub Bot commented on FLINK-8687: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388919#comment-16388919 ] ASF GitHub Bot commented on FLINK-8687: --- GitHub user zhangminglei opened a pull requ

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-06 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388891#comment-16388891 ] mingleizhang commented on FLINK-8687: - [~yuzhih...@gmail.com] I think I was wrong. >

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-06 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388890#comment-16388890 ] mingleizhang commented on FLINK-8687: - Thanks [~yuzhih...@gmail.com] , actually, I do

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387710#comment-16387710 ] Ted Yu commented on FLINK-8687: --- CliTableResultView is not in gateway package. Can you desc

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-05 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387372#comment-16387372 ] mingleizhang commented on FLINK-8687: - [~yuzhih...@gmail.com] Shouldn't we lock {{writ

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-04 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385511#comment-16385511 ] mingleizhang commented on FLINK-8687: - Thank you very much [~yuzhih...@gmail.com]. :)

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385502#comment-16385502 ] Ted Yu commented on FLINK-8687: --- I agree with what you said. > MaterializedCollectStreamRes

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-04 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385497#comment-16385497 ] mingleizhang commented on FLINK-8687: - Thanks [~yuzhih...@gmail.com] I checked what yo

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-03-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384832#comment-16384832 ] Ted Yu commented on FLINK-8687: --- Looking at LocalExecutor, I think answer is yes. > Materia

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

2018-02-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376346#comment-16376346 ] mingleizhang commented on FLINK-8687: - Does \{{retrievePage}} method will access by mu