Re: [PR] [FLINK-30081][runtime] Reset unused options like jvm-overhead.min/max for local executor [flink]

[via GitHub]

xintongsong closed pull request #22547: [FLINK-30081][runtime] Reset unused 
options like jvm-overhead.min/max for local executor
URL: https://github.com/apache/flink/pull/22547


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-30081][runtime] Reset unused options like jvm-overhead.min/max for local executor [flink]

[via GitHub]

xintongsong commented on code in PR #22547:
URL: https://github.com/apache/flink/pull/22547#discussion_r1566773890


##
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java:
##
@@ -285,4 +286,15 @@ private static  void setConfigOptionToDefaultIfNotSet(
 config.set(option, defaultValue);
 }
 }
+
+private static  void resetConfigOption(
+Configuration config, ConfigOption option, T value) {
+if (config.contains(option)) {
+LOG.info(
+"The configuration option {} has no effect for local 
execution, resetting to {}",
+option.key(),
+value);
+}
+config.set(option, value);
+}

Review Comment:
   I see you've already trigger the CI with a git push. Next time you can 
simply comment `@flinkbot run azure` on the PR.



##
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java:
##
@@ -285,4 +286,15 @@ private static  void setConfigOptionToDefaultIfNotSet(
 config.set(option, defaultValue);
 }
 }
+
+private static  void resetConfigOption(
+Configuration config, ConfigOption option, T value) {
+if (config.contains(option)) {
+LOG.info(
+"The configuration option {} has no effect for local 
execution, resetting to {}",
+option.key(),
+value);
+}
+config.set(option, value);
+}

Review Comment:
   I see you've already trigger the CI with a git push. Next time you can 
simply comment `@flinkbot run azure` on the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-30081][runtime] Reset unused options like jvm-overhead.min/max for local executor [flink]

[via GitHub]

liuml07 commented on code in PR #22547:
URL: https://github.com/apache/flink/pull/22547#discussion_r1564418871


##
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java:
##
@@ -285,4 +286,15 @@ private static  void setConfigOptionToDefaultIfNotSet(
 config.set(option, defaultValue);
 }
 }
+
+private static  void resetConfigOption(
+Configuration config, ConfigOption option, T value) {
+if (config.contains(option)) {
+LOG.info(
+"The configuration option {} has no effect for local 
execution, resetting to {}",
+option.key(),
+value);
+}
+config.set(option, value);
+}

Review Comment:
   @xintongsong how do I trigger a Jenkins build? I tested manually and the 
code snippet in the JIRA passes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org