1996fanrui merged PR #116:
URL: https://github.com/apache/flink-connector-jdbc/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
RocMarshal commented on PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#issuecomment-2092246949
Thanks @eskabetxe for the comments. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
eskabetxe commented on code in PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#discussion_r1584601921
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/AbstractJdbcCatalog.java:
##
@@ -88,32 +92,49 @@ public abstract class
RocMarshal commented on PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#issuecomment-2081320858
Hi, @eskabetxe Would you mind having take a look if you had the free time ?
Many thx!
--
This is an automated message from the Apache Git Service.
To respond to the
RocMarshal commented on PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#issuecomment-2080456998
Thanks @caicancai for the review.
Could @1996fanrui you help take a look if you had the free time ?
Thank you~
--
This is an automated message from the Apache Git
caicancai commented on code in PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#discussion_r1581771380
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java:
##
@@ -77,17 +81,42 @@ public JdbcCatalog(
RocMarshal commented on code in PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#discussion_r1580440708
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java:
##
@@ -29,18 +29,22 @@
import
caicancai commented on code in PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#discussion_r1580352031
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java:
##
@@ -77,17 +81,42 @@ public JdbcCatalog(
RocMarshal closed pull request #116: [FLINK-35176][Connector/JDBC] Support
property authentication connection for JDBC catalog & dynamic table
URL: https://github.com/apache/flink-connector-jdbc/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message,
RocMarshal commented on PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#issuecomment-2077035421
HI, @caicancai @GOODBOY008 Could you help have a review if you had the free
time ? thx a lot.
--
This is an automated message from the Apache Git Service.
To respond to
RocMarshal commented on PR #116:
URL:
https://github.com/apache/flink-connector-jdbc/pull/116#issuecomment-2074135052
blocked by https://github.com/apache/flink-connector-jdbc/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
11 matches
Mail list logo