[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148310#comment-16148310
 ] 

ASF subversion and git services commented on GEODE-3472:


Commit fb9a405f78a1efd3fb3033ff36e9065e8b545ec3 in geode's branch 
refs/heads/feature/GEODE-3543 from [~prhomberg]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fb9a405 ]

GEODE-3472: Remove a great deal of commented-out code.

* this closes #748


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147569#comment-16147569
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/748


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147568#comment-16147568
 ] 

ASF subversion and git services commented on GEODE-3472:


Commit fb9a405f78a1efd3fb3033ff36e9065e8b545ec3 in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fb9a405 ]

GEODE-3472: Remove a great deal of commented-out code.

* this closes #748


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147556#comment-16147556
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/748
  
Precheckin green.


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145935#comment-16145935
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/730


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145934#comment-16145934
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/730
  
Due to significant changes, this pull request is replaced by #748.


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145932#comment-16145932
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/748

GEODE-3472: Remove a great deal of commented-out code.

This pull request replaces #730.

Nontrivial conflicts were introduced after rebasing against GEODE-3436 
(`be8a13`).

This pull request includes all suggestions made in #730, as well as a 
number of other minor refactorings.

Precheckin running.

-

* Additionally refactored touched files, driven by suggested changes in a 
previous pull request and IDE inspections.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a: refactoring] Have you written or updated unit tests to verify your 
changes?

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3472-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/748.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #748


commit 4fecf79d76f2caec59f0c8e5afb0744954e5e203
Author: Patrick Rhomberg 
Date:   2017-08-18T20:59:44Z

GEODE-3472: Remove a great deal of commented-out code.

* Additionally refactored touched files, driven by suggested changes in a 
previous pull request and IDE inspections.




> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144512#comment-16144512
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/730
  
Precheckin returned green.

Open/Close PR to trigger Travis again.  Hopefully they've pulled `develop` 
recently...


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144514#comment-16144514
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/730


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144515#comment-16144515
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

GitHub user PurelyApplied reopened a pull request:

https://github.com/apache/geode/pull/730

GEODE-3472: Remove a great deal of commented-out code.

* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the 
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals, 
etc.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes? 
[n/a: Non-functional changes.]

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3472

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #730


commit 80f44577b8f1431c14934a935f6d426f28ed0dea
Author: Patrick Rhomberg 
Date:   2017-08-18T20:59:44Z

GEODE-3472: Remove a great deal of commented-out code.

* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the 
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals, 
etc.

commit 7a0db737bc7327adea58a5c972ad04856850c8b7
Author: Patrick Rhomberg 
Date:   2017-08-28T20:41:19Z

GEODE-3472: Suggested changes in pull request.

* Corrected incorrect correction of a typo in Gfsh.java
* Removed dead, trivial method
* Moved constant field from MBeanJMXAdapter to its use in VMStatsMonitor

commit 1324ed15533dbf5fe95a81e214d81d2355f239fd
Author: Patrick Rhomberg 
Date:   2017-08-28T22:10:51Z

empty commit to trigger Travis.




> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144511#comment-16144511
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/730


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144436#comment-16144436
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/730
  
@PurelyApplied I think you can also close and reopen a PR to restart Travis.


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144432#comment-16144432
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/730
  
Travis failures appear related to 
`f41ca9d7d2fa7c045ec439df9478335233f1d95e`.  Is there a way to force Travis to 
rerun without applying a new commit?


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144298#comment-16144298
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r135625955
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
 ---
@@ -158,7 +156,7 @@
   private Thread runner;
   private boolean debugON;
   private Terminal terminal;
-  private boolean supressScriptCmdOutput;
+  private boolean suppressScriptCadOutput;
--- End diff --

IntelliJ Autocorrect strikes again!  Good catch.


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144220#comment-16144220
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r135608244
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/MBeanJMXAdapter.java
 ---
@@ -72,16 +72,13 @@
   private DistributedMember distMember;
 
   /**
-   * log writer, or null if there is no distributed system available
-   */
-  // private LogWriterI18n logger = 
InternalDistributedSystem.getLoggerI18n();
-
-  /**
* public constructor
*/
 
+  public static final int VALUE_NOT_AVAILABLE = -1;
--- End diff --

The management pkg depends on the statistics pkg, but statistics should not 
have circular dependency on management. Moving the constant into VMStatsMonitor 
should resolve this.


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139131#comment-16139131
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134869699
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 
---
@@ -212,8 +211,7 @@ public static void bytesToFiles(byte[][] fileData, 
String parentDirPath, boolean
   }
 
   public static boolean isValidFileName(String filePath, String extension) 
{
-boolean isValid = true;
-return isValid;
+return true;
--- End diff --

Can we just delete this method entirely?


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139134#comment-16139134
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134872863
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/MBeanJMXAdapter.java
 ---
@@ -72,16 +72,13 @@
   private DistributedMember distMember;
 
   /**
-   * log writer, or null if there is no distributed system available
-   */
-  // private LogWriterI18n logger = 
InternalDistributedSystem.getLoggerI18n();
-
-  /**
* public constructor
*/
 
+  public static final int VALUE_NOT_AVAILABLE = -1;
--- End diff --

Should this live in VMStatsMonitor since that's the only place it appears 
to be used?


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139133#comment-16139133
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134867453
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
 ---
@@ -415,9 +413,8 @@ public Result toCommandResult() {
   toCommandResult_isPut(section, table);
 } else if (isRemove()) {
   toCommandResult_isRemove(section, table);
-} else if (isSelect()) {
-  // its moved to its separate method
 }
+// isSelect() moved to a separate method
--- End diff --

Did you intended to leave this comment?  


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139132#comment-16139132
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134869226
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
 ---
@@ -158,7 +156,7 @@
   private Thread runner;
   private boolean debugON;
   private Terminal terminal;
-  private boolean supressScriptCmdOutput;
+  private boolean suppressScriptCadOutput;
--- End diff --

This looks like a newly introduced typo :P


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138610#comment-16138610
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134804772
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
 ---
@@ -147,11 +147,10 @@ public ResultData addAsFile(String fileName, String 
fileContents, String message
 
   public ResultData addAsFile(String fileName, byte[] data, int fileType, 
String message,
   boolean addTimeStampToName) {
-byte[] bytes = data;
--- End diff --

I stand corrected. I confused myself with past experiences with other 
languages.



> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137698#comment-16137698
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/730
  
I haven't reviewed this, but :+1: deleting commented code is a GOOD THING.


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137525#comment-16137525
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134618712
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
 ---
@@ -147,11 +147,10 @@ public ResultData addAsFile(String fileName, String 
fileContents, String message
 
   public ResultData addAsFile(String fileName, byte[] data, int fileType, 
String message,
   boolean addTimeStampToName) {
-byte[] bytes = data;
--- End diff --

I might by projecting my Python and C expectations into my relatively new 
Java experience, but I thought this assignment wouldn't change the mutability 
of `data`.  Wouldn't this need `byte[] bytes = data.clone();` to actually 
provided immutability to `data`?  Or is Java more defensive than I realized?


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137493#comment-16137493
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134616035
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
 ---
@@ -147,11 +147,10 @@ public ResultData addAsFile(String fileName, String 
fileContents, String message
 
   public ResultData addAsFile(String fileName, byte[] data, int fileType, 
String message,
   boolean addTimeStampToName) {
-byte[] bytes = data;
--- End diff --

I think the contents of `data` should be treated as if it were immutable in 
this usage, so don't make this and the following change.


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137383#comment-16137383
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/730
  
Precheckin green after merge with 
`be4551191a17b9f50169f375798785ab5373e975`.  Subsequently rebased again with 
minor merge conflict resolved.


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136009#comment-16136009
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/730

GEODE-3472: Remove a great deal of commented-out code.

* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the 
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals, 
etc.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes? 
[n/a: Non-functional changes.]

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3472

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #730


commit 9fb4414b363e9bbc584b67456158ad3f880e269b
Author: Patrick Rhomberg 
Date:   2017-08-18T20:59:44Z

GEODE-3472: Remove a great deal of commented-out code.

* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the 
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals, 
etc.




> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)