[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77071575 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java --- @@ -256,4 +257,68 @@ private static boolean

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77076673 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java --- @@ -256,4 +257,68 @@ private static boolean

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77076942 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java --- @@ -256,4 +257,68 @@ private static boolean

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77077634 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java --- @@ -110,4 +122,68 @@ public static

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77079334 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java --- @@ -29,8 +35,8 @@ */ public

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77084340 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java --- @@ -256,4 +257,68 @@ private static boolean

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77085040 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/EnumHawqType.java --- @@ -43,37 +45,40 @@ public void serialize(EnumHawqType

[GitHub] incubator-hawq pull request #873: HAWQ-992. PXF Hive data type check in Frag...

2016-08-31 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/873#discussion_r77103957 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/EnumHawqType.java --- @@ -43,37 +45,40 @@ public void serialize(EnumHawqType

[GitHub] incubator-hawq issue #837: HAWQ-779 support pxf filter pushdwon at the 'CREA...

2016-09-14 Thread GodenYao
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/837 merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-hawq pull request #:

2016-09-26 Thread GodenYao
Github user GodenYao commented on the pull request: https://github.com/apache/incubator-hawq/commit/9b7f90b744850ff83769c3a46e6d4daeb109cc68#commitcomment-19184677 why change the folder path? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-hawq issue #965: HAWQ-1057. Skip SARG_PUSHDOWN parameter if any of...

2016-10-17 Thread GodenYao
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/965 +1 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-hawq issue #738: Hawq 743

2016-06-24 Thread GodenYao
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/738 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq pull request #779: HAWQ-779. PXF Fix filter test failures

2016-07-07 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/779#discussion_r69990137 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -42,6 +42,7 @@ test__supported_filter_type(void **state) CHAROID

[GitHub] incubator-hawq issue #779: HAWQ-779. PXF Fix filter test failures

2016-07-07 Thread GodenYao
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/779 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-hawq pull request #779: HAWQ-779. PXF Fix filter test failures

2016-07-07 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/779#discussion_r69995640 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -61,7 +62,7 @@ test__supported_filter_type(void **state) /* go over

[GitHub] incubator-hawq pull request #790: HAWQ-919. add missing ASF license header

2016-07-12 Thread GodenYao
GitHub user GodenYao opened a pull request: https://github.com/apache/incubator-hawq/pull/790 HAWQ-919. add missing ASF license header You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-hawq HAWQ-919 Alternatively

[GitHub] incubator-hawq pull request #790: HAWQ-919. add missing ASF license header

2016-07-12 Thread GodenYao
Github user GodenYao closed the pull request at: https://github.com/apache/incubator-hawq/pull/790 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq issue #803: HAWQ-932. Added pxf service address to curl resol...

2016-07-19 Thread GodenYao
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/803 churl_init_upload and churl_init_download only has 1 tag difference ( context->upload = true vs. false) probably worth refactoring to a single function and invoked by these 2, which w

[GitHub] incubator-hawq issue #811: GPSQL-3288: Set dummy workfile pointer to NULL af...

2016-07-25 Thread GodenYao
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/811 even this is an internal customer JIRA, we should still file Apache JIRA so the repro steps and RCA are available to public. --- If your project is set up for it, you can reply to this

[GitHub] incubator-hawq pull request #821: HAWQ-931. ORC optimized profile for PPD/CP

2016-07-28 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/821#discussion_r72674878 --- Diff: pxf/gradle.properties --- @@ -23,4 +23,5 @@ hiveVersion=1.2.1 hbaseVersionJar=1.1.2 hbaseVersionRPM=1.1.2 tomcatVersion

[GitHub] incubator-hawq issue #848: HAWQ-1006. Fix RPM compliance in Redhat Satellite...

2016-08-16 Thread GodenYao
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/848 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq issue #853: HAWQ-967. Extend Projection info to include filte...

2016-08-22 Thread GodenYao
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/853 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq issue #854: HAWQ-997. HAWQ doesn't send PXF data type with pr...

2016-08-24 Thread GodenYao
Github user GodenYao commented on the issue: https://github.com/apache/incubator-hawq/pull/854 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

2016-08-26 Thread GodenYao
Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r76469613 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -165,6 +165,14 @@ private Filter