Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r209506292
--- Diff: contrib/exthdfs/exthdfs.c ---
@@ -0,0 +1,469 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208448574
--- Diff: src/backend/commands/analyze.c ---
@@ -3266,3 +3298,380 @@ static void
gp_statistics_estimate_reltuples_relpages_parquet(Relation rel,
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208439468
--- Diff: src/backend/commands/analyze.c ---
@@ -3266,3 +3298,380 @@ static void
gp_statistics_estimate_reltuples_relpages_parquet(Relation rel,
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437399
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -193,6 +212,9 @@ typedef struct Relation_Data {
List *files;
Oid
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208449241
--- Diff: src/backend/commands/tablecmds.c ---
@@ -1042,7 +1277,7 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208449610
--- Diff: src/backend/commands/tablecmds.c ---
@@ -17561,29 +17887,67 @@ static Datum transformLocationUris(List *locs,
List* fmtopts, bool isweb,
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436217
--- Diff: src/backend/access/external/fileam.c ---
@@ -1381,9 +1603,11 @@ lookupCustomFormatter(char *formatter_name, bool
iswritable)
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435844
--- Diff: src/backend/access/external/fileam.c ---
@@ -1290,6 +1397,97 @@ externalgettup_custom(FileScanDesc scan,
ExternalSelectDesc desc,
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208451302
--- Diff: src/backend/optimizer/plan/createplan.c ---
@@ -1127,6 +1127,20 @@ bool is_pxf_protocol(Uri *uri)
return false;
}
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208451726
--- Diff: src/include/utils/uri.h ---
@@ -32,7 +32,11 @@ typedef enum UriProtocol
URI_HTTP,
URI_GPFDIST,
URI_CUSTOM,
-
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208449174
--- Diff: src/backend/commands/tablecmds.c ---
@@ -939,38 +983,217 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
char*
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208451740
--- Diff: src/include/utils/uri.h ---
@@ -41,6 +45,10 @@ typedef enum UriProtocol
#define PROTOCOL_GPFDIST "gpfdist://"
#define
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208451756
--- Diff: src/include/utils/uri.h ---
@@ -52,6 +60,10 @@ typedef enum UriProtocol
#define IS_GPFDISTS_URI(uri_str) (pg_strncasecmp(uri_str,
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437762
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -1579,7 +1700,242 @@ static void ParquetGetSegFileDataLocation(Relation
relation,
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208449650
--- Diff: src/backend/commands/tablecmds.c ---
@@ -17652,7 +18018,47 @@ static Datum transformLocationUris(List *locs,
List* fmtopts, bool isweb,
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437472
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -844,36 +918,17 @@ int64
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208451046
--- Diff: src/backend/nodes/outfuncs.c ---
@@ -2170,16 +2170,27 @@ _outCreateExternalStmt(StringInfo str,
CreateExternalStmt *node)
{
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436246
--- Diff: src/backend/access/external/fileam.c ---
@@ -1664,7 +1888,9 @@ FunctionCallPrepareFormatter(FunctionCallInfoData*
fcinfo,
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438223
--- Diff: src/backend/commands/analyze.c ---
@@ -989,17 +1013,20 @@ static List* analyzableRelations(bool rootonly, List
**fullRelOids)
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438791
--- Diff: src/include/catalog/pg_exttable.h ---
@@ -164,9 +164,12 @@ GetExtTableEntry(Oid relid);
extern void
RemoveExtTableEntry(Oid relid);
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438657
--- Diff: src/include/utils/uri.h ---
@@ -52,6 +60,10 @@ typedef enum UriProtocol
#define IS_GPFDISTS_URI(uri_str) (pg_strncasecmp(uri_str,
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438576
--- Diff: src/include/utils/uri.h ---
@@ -41,6 +45,10 @@ typedef enum UriProtocol
#define PROTOCOL_GPFDIST "gpfdist://"
#define
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438342
--- Diff: src/include/utils/uri.h ---
@@ -32,7 +32,11 @@ typedef enum UriProtocol
URI_HTTP,
URI_GPFDIST,
URI_CUSTOM,
-
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438291
--- Diff: src/include/nodes/parsenodes.h ---
@@ -1459,8 +1463,10 @@ typedef struct SharedStorageOpStmt
*/
typedef enum ExtTableType
{
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438235
--- Diff: src/include/access/xact.h ---
@@ -173,6 +173,33 @@ typedef struct XidBuffer
extern XidBuffer subxbuf;
extern File subxip_file;
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438165
--- Diff: src/include/access/formatter.h ---
@@ -36,10 +36,19 @@
typedef enum FmtNotification
{
FMT_NONE,
+ FMT_DONE,
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437581
--- Diff: src/backend/optimizer/plan/createplan.c ---
@@ -1127,6 +1127,20 @@ bool is_pxf_protocol(Uri *uri)
return false;
}
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437403
--- Diff: src/backend/commands/tablecmds.c ---
@@ -18041,11 +18646,11 @@ static Datum transformFormatOpts(char formattype,
List *formatOpts, int
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437352
--- Diff: src/backend/commands/tablecmds.c ---
@@ -17845,14 +18448,16 @@ static Datum transformFormatOpts(char formattype,
List *formatOpts, int
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436378
--- Diff: src/backend/commands/tablecmds.c ---
@@ -17615,14 +17979,16 @@ static Datum transformLocationUris(List *locs,
List* fmtopts, bool isweb,
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436303
--- Diff: src/backend/commands/tablecmds.c ---
@@ -17528,6 +17845,15 @@ static Datum transformLocationUris(List *locs,
List* fmtopts, bool isweb, bool
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436195
--- Diff: src/backend/commands/tablecmds.c ---
@@ -1222,20 +1529,24 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436174
--- Diff: src/backend/commands/tablecmds.c ---
@@ -1210,6 +1507,16 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
else
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436164
--- Diff: src/backend/commands/tablecmds.c ---
@@ -1199,6 +1489,13 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
{
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435854
--- Diff: src/backend/commands/tablecmds.c ---
@@ -1174,6 +1426,44 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435805
--- Diff: src/backend/access/external/fileam.c ---
@@ -1290,6 +1397,97 @@ externalgettup_custom(FileScanDesc scan,
ExternalSelectDesc desc,
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435735
--- Diff: src/backend/access/external/fileam.c ---
@@ -782,6 +864,28 @@ external_insert(ExternalInsertDesc extInsertDesc,
TupleTableSlot
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435758
--- Diff: src/backend/commands/tablecmds.c ---
@@ -1105,53 +1340,70 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435710
--- Diff: src/backend/commands/tablecmds.c ---
@@ -939,38 +983,217 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
char*
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435664
--- Diff: src/backend/commands/tablecmds.c ---
@@ -939,38 +983,217 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
char*
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435628
--- Diff: src/backend/commands/tablecmds.c ---
@@ -939,38 +983,217 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
char*
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435571
--- Diff: src/backend/commands/tablecmds.c ---
@@ -632,9 +665,20 @@ DefineRelation_int(CreateStmt *stmt,
*/
descriptor =
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435430
--- Diff: src/backend/access/external/fileam.c ---
@@ -305,11 +308,53 @@ external_beginscan(ExternalScan *extScan,
scan->errcontext.previous
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435255
--- Diff: src/backend/commands/analyze.c ---
@@ -442,6 +455,17 @@ void analyzeStmt(VacuumStmt *stmt, List *relids, int
preferred_seg_num)
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435117
--- Diff: src/backend/commands/analyze.c ---
@@ -442,6 +455,17 @@ void analyzeStmt(VacuumStmt *stmt, List *relids, int
preferred_seg_num)
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435034
--- Diff: src/backend/commands/analyze.c ---
@@ -153,9 +160,15 @@ static List*buildExplicitAttributeNames(Oid
relationOid, VacuumStmt *stmt);
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434847
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -1579,7 +1700,242 @@ static void ParquetGetSegFileDataLocation(Relation
relation,
return;
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434889
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -4039,6 +4398,9 @@ calculate_planner_segment_num(Query *query,
QueryResourceLife resourceLife,
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434912
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -4104,6 +4468,12 @@ calculate_planner_segment_num(Query *query,
QueryResourceLife resourceLife,
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434835
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -1579,7 +1700,242 @@ static void ParquetGetSegFileDataLocation(Relation
relation,
return;
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434815
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -1579,7 +1700,242 @@ static void ParquetGetSegFileDataLocation(Relation
relation,
return;
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434723
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -1579,7 +1700,242 @@ static void ParquetGetSegFileDataLocation(Relation
relation,
return;
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434493
--- Diff: src/backend/access/external/fileam.c ---
@@ -86,14 +86,17 @@ static void InitParseState(CopyState pstate, Relation
relation,
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434427
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -844,36 +918,17 @@ int64
get_block_locations_and_claculte_table_size(split_to_segment_mapping_conte
Github user Librago commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434274
--- Diff: contrib/exthdfs/exthdfs.c ---
@@ -0,0 +1,472 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434291
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -193,6 +212,9 @@ typedef struct Relation_Data {
List *files;
Oid
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434247
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -123,10 +132,20 @@ typedef struct File_Split {
int64 logiceof;
int host;
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434124
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -123,10 +132,20 @@ typedef struct File_Split {
int64 logiceof;
int host;
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433943
--- Diff: src/backend/catalog/heap.c ---
@@ -2543,8 +2551,55 @@ heap_drop_with_catalog(Oid relid)
/*
* External table? If so, delete
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433876
--- Diff: src/backend/catalog/cdb_external_extensions.sql ---
@@ -47,3 +47,38 @@ LANGUAGE C STABLE;
CREATE OR REPLACE FUNCTION
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433762
--- Diff: contrib/exthdfs/exthdfs.c ---
@@ -0,0 +1,472 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433663
--- Diff: contrib/exthdfs/exthdfs.c ---
@@ -0,0 +1,472 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433613
--- Diff: contrib/exthdfs/common.h ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433457
--- Diff: contrib/extfmtcsv/Makefile ---
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433287
--- Diff: contrib/Makefile ---
@@ -9,7 +9,9 @@ WANTED_DIRS = \
extprotocol \
gp_cancel_query \
65 matches
Mail list logo
