[jira] [Commented] (HBASE-23822) Fix typo in procedures.jsp

2020-02-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033937#comment-17033937 ] Hudson commented on HBASE-23822: Results for branch branch-2 [build #2464 on

[jira] [Commented] (HBASE-23814) Add null checks and logging to misc set of tests

2020-02-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033938#comment-17033938 ] Hudson commented on HBASE-23814: Results for branch branch-2 [build #2464 on

[jira] [Commented] (HBASE-23815) [Flakey Test] AbstractTestAsyncTableRegionReplicasRead family of tests fails with no breadcrumbs on why

2020-02-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033939#comment-17033939 ] Hudson commented on HBASE-23815: Results for branch branch-2 [build #2464 on

[jira] [Commented] (HBASE-23816) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:91) Wrong FS!

2020-02-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033940#comment-17033940 ] Hudson commented on HBASE-23816: Results for branch branch-2 [build #2464 on

[jira] [Commented] (HBASE-23824) TestSnapshotScannerHDFSAclController is flakey

2020-02-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033941#comment-17033941 ] Hudson commented on HBASE-23824: Results for branch branch-2 [build #2464 on

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377314093 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java ## @@

[GitHub] [hbase] ndimiduk commented on issue #1143: Backport HBASE-15519, HBASE-23364, HBASE-23802 to branch-2.2

2020-02-10 Thread GitBox
ndimiduk commented on issue #1143: Backport HBASE-15519, HBASE-23364, HBASE-23802 to branch-2.2 URL: https://github.com/apache/hbase/pull/1143#issuecomment-584365689 I think these additional back ports don't make sense for branch-2.2. Closing this one out in favor a of a simplified patch

[GitHub] [hbase] ndimiduk closed pull request #1143: Backport HBASE-15519, HBASE-23364, HBASE-23802 to branch-2.2

2020-02-10 Thread GitBox
ndimiduk closed pull request #1143: Backport HBASE-15519, HBASE-23364, HBASE-23802 to branch-2.2 URL: https://github.com/apache/hbase/pull/1143 This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (HBASE-23825) Increment proto conversion is broken

2020-02-10 Thread Abhishek Singh Chouhan (Jira)
Abhishek Singh Chouhan created HBASE-23825: -- Summary: Increment proto conversion is broken Key: HBASE-23825 URL: https://issues.apache.org/jira/browse/HBASE-23825 Project: HBase

[jira] [Commented] (HBASE-23744) FastPathBalancedQueueRpcExecutor should enforce queue length of 0

2020-02-10 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033872#comment-17033872 ] Geoffrey Jacoby commented on HBASE-23744: - [~anoop.hbase][~xucang][~ndimiduk] - as far as I

[jira] [Commented] (HBASE-23779) Up the default fork count to make builds complete faster; make count relative to CPU count

2020-02-10 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033905#comment-17033905 ] Michael Stack commented on HBASE-23779: --- bq. I don't think it is always around 5k. You are

[GitHub] [hbase] busbey commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads…

2020-02-10 Thread GitBox
busbey commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads… URL: https://github.com/apache/hbase/pull/1158#discussion_r377288653 ## File path: dev-support/hbase-personality.sh ## @@ -140,7 +140,11 @@ function

[GitHub] [hbase] busbey commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads…

2020-02-10 Thread GitBox
busbey commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads… URL: https://github.com/apache/hbase/pull/1158#discussion_r377290392 ## File path: dev-support/jenkins-scripts/generate-hbase-website.sh ## @@ -120,6

[GitHub] [hbase] busbey commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads…

2020-02-10 Thread GitBox
busbey commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads… URL: https://github.com/apache/hbase/pull/1158#discussion_r377289534 ## File path: pom.xml ## @@ -1428,7 +1428,7 @@

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377310286 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java ## @@

[GitHub] [hbase] ndimiduk opened a new pull request #1159: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…

2020-02-10 Thread GitBox
ndimiduk opened a new pull request #1159: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc… URL: https://github.com/apache/hbase/pull/1159 …counting (#1127) Signed-off-by: stack This is an

[GitHub] [hbase] ndimiduk commented on issue #1159: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…

2020-02-10 Thread GitBox
ndimiduk commented on issue #1159: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc… URL: https://github.com/apache/hbase/pull/1159#issuecomment-584368355 This PR replaces #1143. This is an automated

[jira] [Reopened] (HBASE-23816) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:91) Wrong FS!

2020-02-10 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HBASE-23816: --- Reopening. I just got this in a local test run. Same old failure type: {code} [ERROR]

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377345640 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,331

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377358650 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,331

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377363508 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionOptRegionBatchMode.java

[jira] [Commented] (HBASE-23822) Fix typo in procedures.jsp

2020-02-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034035#comment-17034035 ] Hudson commented on HBASE-23822: Results for branch branch-2.2 [build #781 on

[GitHub] [hbase] saintstack opened a new pull request #1162: HBASE-23816 [Flakey Test] TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:91) Wron

2020-02-10 Thread GitBox
saintstack opened a new pull request #1162: HBASE-23816 [Flakey Test] TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:91) Wrong FS! URL: https://github.com/apache/hbase/pull/1162 ADDENDUM: Break test in two to see if it makes it

[GitHub] [hbase] Apache-HBase commented on issue #1161: HBASE-23825 Increment proto conversion is broken

2020-02-10 Thread GitBox
Apache-HBase commented on issue #1161: HBASE-23825 Increment proto conversion is broken URL: https://github.com/apache/hbase/pull/1161#issuecomment-584422591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377392972 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java ## @@

[jira] [Commented] (HBASE-23744) FastPathBalancedQueueRpcExecutor should enforce queue length of 0

2020-02-10 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033967#comment-17033967 ] Nick Dimiduk commented on HBASE-23744: -- bq. And regardless of which path we take in this JIRA, a

[GitHub] [hbase] bharathv closed pull request #1101: HBASE-23305: Master based registry implementation (#954)

2020-02-10 Thread GitBox
bharathv closed pull request #1101: HBASE-23305: Master based registry implementation (#954) URL: https://github.com/apache/hbase/pull/1101 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] apurtell commented on issue #1101: HBASE-23305: Master based registry implementation (#954)

2020-02-10 Thread GitBox
apurtell commented on issue #1101: HBASE-23305: Master based registry implementation (#954) URL: https://github.com/apache/hbase/pull/1101#issuecomment-584389104 Thank you. This is an automated message from the Apache Git

[jira] [Commented] (HBASE-23823) Run maven with more than default single thread (--threads=1C)

2020-02-10 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033917#comment-17033917 ] Sean Busbey commented on HBASE-23823: - to check how heavy we're hitting the thread limits, I'd

[GitHub] [hbase] saintstack commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads…

2020-02-10 Thread GitBox
saintstack commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads… URL: https://github.com/apache/hbase/pull/1158#discussion_r377292283 ## File path: dev-support/hbase-personality.sh ## @@ -140,7 +140,11 @@

[GitHub] [hbase] saintstack commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads…

2020-02-10 Thread GitBox
saintstack commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads… URL: https://github.com/apache/hbase/pull/1158#discussion_r377292863 ## File path: dev-support/jenkins-scripts/generate-hbase-website.sh ## @@

[GitHub] [hbase] apurtell commented on issue #1101: HBASE-23305: Master based registry implementation (#954)

2020-02-10 Thread GitBox
apurtell commented on issue #1101: HBASE-23305: Master based registry implementation (#954) URL: https://github.com/apache/hbase/pull/1101#issuecomment-584387917 Is this the consolidated branch-2 backport? /cc @ndimiduk @saintstack It looks to be with 114 changed files, just want to

[jira] [Commented] (HBASE-18095) Provide an option for clients to find the server hosting META that does not involve the ZooKeeper client

2020-02-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033994#comment-17033994 ] Hudson commented on HBASE-18095: Results for branch HBASE-18095/client-locate-meta-no-zookeeper

[jira] [Updated] (HBASE-23804) Fix default master addr hostname in master registry

2020-02-10 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-23804: - Fix Version/s: (was: 2.3.0) (was: 3.0.0)

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377364958 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377313216 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java ## @@

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377317451 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java ## @@

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377317317 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java ## @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377238105 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ## @@ -496,11 +518,51 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377221782 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/SlowLogPayload.java ## @@ -0,0 +1,318

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377247463 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/RingBufferTruck.java ##

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377225705 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/SlowLogPayload.java ## @@ -0,0 +1,318

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377220054 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -3889,4

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377236616 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ## @@ -496,11 +518,51 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377226196 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/SlowLogPayload.java ## @@ -0,0 +1,318

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377235972 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ## @@ -496,11 +518,51 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377245309 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/OnlineSlowLogProvider.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377252533 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377213128 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -3889,4

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377233563 ## File path: hbase-protocol-shaded/src/main/protobuf/TooSlowLog.proto ## @@ -0,0 +1,45 @@ +/** + * Licensed to

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377231221 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1519,6 +1519,15 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377240740 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ## @@ -215,6 +224,17 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377272041 ## File path: hbase-shell/src/main/ruby/shell/commands/get_slowlog_responses.rb ## @@ -0,0 +1,65 @@ +# +# +#

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377271382 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -1527,6 +1618,16 @@ def stop_master def

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377254854 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377268619 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestOnlineSlowLogProvider.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377269839 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -1453,6 +1453,97 @@ def

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377262043 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java ## @@ -426,4 +437,55

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377273341 ## File path: src/main/asciidoc/_chapters/hbase-default.adoc ## @@ -2207,3 +2207,39 @@ The percent of region

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377253906 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377262647 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestOnlineSlowLogProvider.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377270965 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -1453,6 +1453,97 @@ def

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377272626 ## File path: hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/client/ThriftAdmin.java ## @@ -1157,6

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377269081 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -1453,6 +1453,97 @@ def

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377247844 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/RingBufferTruck.java ##

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377254804 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377251146 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377267771 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestOnlineSlowLogProvider.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377267219 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestOnlineSlowLogProvider.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377258606 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377264208 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestOnlineSlowLogProvider.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377259497 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377252887 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377261014 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/OnlineSlowLogProvider.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377266290 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestOnlineSlowLogProvider.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377235034 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ## @@ -496,11 +518,51 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377230115 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377236813 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ## @@ -496,11 +518,51 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377242097 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -590,6

[GitHub] [hbase] ndimiduk opened a new pull request #1160: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…

2020-02-10 Thread GitBox
ndimiduk opened a new pull request #1160: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc… URL: https://github.com/apache/hbase/pull/1160 …counting (#1127) Signed-off-by: stack This is an

[GitHub] [hbase] ndimiduk commented on a change in pull request #1137: HBASE-23804: Fix default master addr hostname in master registry

2020-02-10 Thread GitBox
ndimiduk commented on a change in pull request #1137: HBASE-23804: Fix default master addr hostname in master registry URL: https://github.com/apache/hbase/pull/1137#discussion_r377340652 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ##

[jira] [Comment Edited] (HBASE-23825) Increment proto conversion is broken

2020-02-10 Thread Abhishek Singh Chouhan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033988#comment-17033988 ] Abhishek Singh Chouhan edited comment on HBASE-23825 at 2/10/20 10:16 PM:

[jira] [Commented] (HBASE-23825) Increment proto conversion is broken

2020-02-10 Thread Abhishek Singh Chouhan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033988#comment-17033988 ] Abhishek Singh Chouhan commented on HBASE-23825: This is not a problem in master and 2.x

[GitHub] [hbase] Apache-HBase commented on issue #1158: HBASE-23823 Run maven with more than default single thread (--threads…

2020-02-10 Thread GitBox
Apache-HBase commented on issue #1158: HBASE-23823 Run maven with more than default single thread (--threads… URL: https://github.com/apache/hbase/pull/1158#issuecomment-584398591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377366112 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377366253 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@

[GitHub] [hbase] abhishek-chouhan opened a new pull request #1161: HBASE-23825 Increment proto conversion is broken

2020-02-10 Thread GitBox
abhishek-chouhan opened a new pull request #1161: HBASE-23825 Increment proto conversion is broken URL: https://github.com/apache/hbase/pull/1161 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-23802) Remove unnecessary Configuration instantiation in LossyAccounting

2020-02-10 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034038#comment-17034038 ] Michael Stack commented on HBASE-23802: --- You want +1s on your backports? You went ahead w/

[jira] [Commented] (HBASE-23779) Up the default fork count to make builds complete faster; make count relative to CPU count

2020-02-10 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033916#comment-17033916 ] Sean Busbey commented on HBASE-23779: - bq. Sean Busbey any objection if I modify the Jenkins script

[GitHub] [hbase] saintstack commented on issue #1158: HBASE-23823 Run maven with more than default single thread (--threads…

2020-02-10 Thread GitBox
saintstack commented on issue #1158: HBASE-23823 Run maven with more than default single thread (--threads… URL: https://github.com/apache/hbase/pull/1158#issuecomment-584331886 Patch adds to hbase-personality extras --threads=0.5C. Adds MAVEN_ARGS for when building site with --threads ==

[jira] [Commented] (HBASE-23792) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState

2020-02-10 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033977#comment-17033977 ] Nick Dimiduk commented on HBASE-23792: -- Argh. > [Flakey Test] >

[GitHub] [hbase] jatsakthi commented on issue #1138: HBASE-22827 Expose multi-region merge in shell and Admin API

2020-02-10 Thread GitBox
jatsakthi commented on issue #1138: HBASE-22827 Expose multi-region merge in shell and Admin API URL: https://github.com/apache/hbase/pull/1138#issuecomment-584385796 @esteban , the current design supports backward compatibility of the just the 2 regions case just like how it used to be

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377358124 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java ## @@

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377357996 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0

[GitHub] [hbase] saintstack opened a new pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads…

2020-02-10 Thread GitBox
saintstack opened a new pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads… URL: https://github.com/apache/hbase/pull/1158 …=1C) This is an automated message from the Apache Git

[GitHub] [hbase] saintstack commented on issue #1158: HBASE-23823 Run maven with more than default single thread (--threads…

2020-02-10 Thread GitBox
saintstack commented on issue #1158: HBASE-23823 Run maven with more than default single thread (--threads… URL: https://github.com/apache/hbase/pull/1158#issuecomment-584333726 Removed changes to the website generating script.

[jira] [Updated] (HBASE-23823) Run maven with more than default single thread (--threads=0.5C)

2020-02-10 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23823: -- Summary: Run maven with more than default single thread (--threads=0.5C) (was: Run maven

[GitHub] [hbase] bharathv commented on a change in pull request #1137: HBASE-23804: Fix default master addr hostname in master registry

2020-02-10 Thread GitBox
bharathv commented on a change in pull request #1137: HBASE-23804: Fix default master addr hostname in master registry URL: https://github.com/apache/hbase/pull/1137#discussion_r377356634 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ##

[GitHub] [hbase] bharathv merged pull request #1137: HBASE-23804: Fix default master addr hostname in master registry

2020-02-10 Thread GitBox
bharathv merged pull request #1137: HBASE-23804: Fix default master addr hostname in master registry URL: https://github.com/apache/hbase/pull/1137 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-02-10 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r377394373 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0

  1   2   >