[jira] [Comment Edited] (HBASE-23938) Replicate slow/large RPC calls to HDFS

2020-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102427#comment-17102427 ] Viraj Jasani edited comment on HBASE-23938 at 5/8/20, 10:12 AM:

[jira] [Updated] (HBASE-24307) [Flakey Tests] krb server for secure thrift tests throws BindException

2020-05-08 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-24307: -- Fix Version/s: 2.3.0 3.0.0-alpha-1 > [Flakey Tests] krb server for secure

[jira] [Updated] (HBASE-23268) Remove disable/enable operations from doc when altering schema

2020-05-08 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-23268: -- Fix Version/s: 3.0.0-alpha-1 > Remove disable/enable operations from doc when altering schema

[GitHub] [hbase] Apache-HBase commented on pull request #1683: HBASE-24345 [ACL] renameRSGroup should require Admin level permission

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1683: URL: https://github.com/apache/hbase/pull/1683#issuecomment-625791036 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.

2020-05-08 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102559#comment-17102559 ] Mark Robert Miller commented on HBASE-24327: Yeah, fire away. >

[GitHub] [hbase] Apache-HBase commented on pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1640: URL: https://github.com/apache/hbase/pull/1640#issuecomment-625807113 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.

2020-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24327: Assignee: Viraj Jasani >

[GitHub] [hbase] HuiHang-Yu commented on pull request #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile

2020-05-08 Thread GitBox
HuiHang-Yu commented on pull request #1380: URL: https://github.com/apache/hbase/pull/1380#issuecomment-625803217 How can i reslove the UT failure "Failed to read test report file ..." ? This is an automated message from

[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625804727 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1683: HBASE-24345 [ACL] renameRSGroup should require Admin level permission

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1683: URL: https://github.com/apache/hbase/pull/1683#issuecomment-625812167 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani opened a new pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

2020-05-08 Thread GitBox
virajjasani opened a new pull request #1684: URL: https://github.com/apache/hbase/pull/1684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Work started] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.

2020-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24327 started by Viraj Jasani. > TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail

[jira] [Updated] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.

2020-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24327: - Fix Version/s: 2.3.0 3.0.0-alpha-1 Status: Patch Available (was:

[jira] [Commented] (HBASE-24342) [Flakey Tests] Disable TestClusterPortAssignment.testClusterPortAssignment as it can't pass 100% of the time

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102601#comment-17102601 ] Hudson commented on HBASE-24342: Results for branch master [build #1720 on

[jira] [Commented] (HBASE-24305) Handle deprecations in ServerName

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102604#comment-17102604 ] Hudson commented on HBASE-24305: Results for branch master [build #1720 on

[jira] [Commented] (HBASE-24338) [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102602#comment-17102602 ] Hudson commented on HBASE-24338: Results for branch master [build #1720 on

[jira] [Commented] (HBASE-24310) Use Slf4jRequestLog for hbase-http

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102603#comment-17102603 ] Hudson commented on HBASE-24310: Results for branch master [build #1720 on

[jira] [Commented] (HBASE-24295) [Chaos Monkey] abstract logging through the class hierarchy

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102600#comment-17102600 ] Hudson commented on HBASE-24295: Results for branch master [build #1720 on

[jira] [Commented] (HBASE-24335) Support deleteall with ts but without column in shell mode

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102599#comment-17102599 ] Hudson commented on HBASE-24335: Results for branch master [build #1720 on

[GitHub] [hbase] HorizonNet opened a new pull request #1685: Backport "HBASE-24305 Prepare deprecations in ServerName (#1666)" to branch-2

2020-05-08 Thread GitBox
HorizonNet opened a new pull request #1685: URL: https://github.com/apache/hbase/pull/1685 Signed-off-by: Duo Zhang Signed-off-by: stack This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1684: URL: https://github.com/apache/hbase/pull/1684#issuecomment-625837709 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625821616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] HorizonNet commented on pull request #1685: Backport "HBASE-24305 Prepare deprecations in ServerName (#1666)" to branch-2

2020-05-08 Thread GitBox
HorizonNet commented on pull request #1685: URL: https://github.com/apache/hbase/pull/1685#issuecomment-625828747 Variation of #1666 to backport the improvements made there to branch-2 without doing the actual deprecations. That includes moving all the usages of deprecated methods to

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-08 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102303#comment-17102303 ] Danil Lipovoy edited comment on HBASE-23887 at 5/8/20, 6:39 AM:

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-08 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102303#comment-17102303 ] Danil Lipovoy edited comment on HBASE-23887 at 5/8/20, 6:40 AM:

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-08 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102303#comment-17102303 ] Danil Lipovoy edited comment on HBASE-23887 at 5/8/20, 6:51 AM:

[GitHub] [hbase] Apache9 commented on pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-05-08 Thread GitBox
Apache9 commented on pull request #1640: URL: https://github.com/apache/hbase/pull/1640#issuecomment-625706210 Added a log4j.properties file for all modules which have tests. It is not necessary as the log4j.properties will be packed in the test jar. So for example, if a module

[jira] [Comment Edited] (HBASE-23938) Replicate slow/large RPC calls to HDFS

2020-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102395#comment-17102395 ] Viraj Jasani edited comment on HBASE-23938 at 5/8/20, 9:24 AM: --- While I

[GitHub] [hbase] Apache-HBase commented on pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1640: URL: https://github.com/apache/hbase/pull/1640#issuecomment-625730497 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24342) [Flakey Tests] Disable TestClusterPortAssignment.testClusterPortAssignment as it can't pass 100% of the time

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102428#comment-17102428 ] Hudson commented on HBASE-24342: Results for branch branch-2 [build #2649 on

[jira] [Commented] (HBASE-24338) [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102430#comment-17102430 ] Hudson commented on HBASE-24338: Results for branch branch-2 [build #2649 on

[jira] [Commented] (HBASE-24295) [Chaos Monkey] abstract logging through the class hierarchy

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102429#comment-17102429 ] Hudson commented on HBASE-24295: Results for branch branch-2 [build #2649 on

[jira] [Commented] (HBASE-24310) Use Slf4jRequestLog for hbase-http

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102431#comment-17102431 ] Hudson commented on HBASE-24310: Results for branch branch-2 [build #2649 on

[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625742344 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24305) Handle deprecations in ServerName

2020-05-08 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102434#comment-17102434 ] Jan Hentschel commented on HBASE-24305: --- Pushed to master. Thanks [~stack] & [~zhangduo] for the

[jira] [Updated] (HBASE-24185) Junit tests do not behave well with System.exit or Runtime.halt or JVM exits in general.

2020-05-08 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-24185: -- Fix Version/s: 2.3.0 3.0.0-alpha-1 > Junit tests do not behave well with

[jira] [Updated] (HBASE-23738) Remove deprecated createLocalHRegion from HBaseTestingUtility

2020-05-08 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-23738: -- Fix Version/s: 3.0.0-alpha-1 > Remove deprecated createLocalHRegion from HBaseTestingUtility

[jira] [Updated] (HBASE-23736) Remove deprecated getTimeStampOfLastAppliedOp from MetricsSink

2020-05-08 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-23736: -- Fix Version/s: 3.0.0-alpha-1 > Remove deprecated getTimeStampOfLastAppliedOp from MetricsSink

[jira] [Updated] (HBASE-20516) Offheap read-path needs more detail

2020-05-08 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-20516: -- Fix Version/s: 3.0.0-alpha-1 > Offheap read-path needs more detail >

[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625783196 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.

2020-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102520#comment-17102520 ] Viraj Jasani edited comment on HBASE-24327 at 5/8/20, 12:10 PM:

[GitHub] [hbase] Apache-HBase commented on pull request #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1380: URL: https://github.com/apache/hbase/pull/1380#issuecomment-625789170 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter

2020-05-08 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-23309: -- Fix Version/s: 3.0.0-alpha-1 > Add support in ChainWalEntryFilter to filter Entry if all

[GitHub] [hbase] Apache-HBase commented on pull request #1683: HBASE-24345 [ACL] renameRSGroup should require Admin level permission

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1683: URL: https://github.com/apache/hbase/pull/1683#issuecomment-625750100 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1380: URL: https://github.com/apache/hbase/pull/1380#issuecomment-625766729 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23938) Replicate slow/large RPC calls to HDFS

2020-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102427#comment-17102427 ] Viraj Jasani commented on HBASE-23938: -- Memstore + Flush + Compaction are enough. I can use Skip

[jira] [Updated] (HBASE-24305) Handle deprecations in ServerName

2020-05-08 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-24305: -- Fix Version/s: 3.0.0-alpha-1 > Handle deprecations in ServerName >

[jira] [Commented] (HBASE-24329) Remove deprecated CoprocessorService

2020-05-08 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102433#comment-17102433 ] Jan Hentschel commented on HBASE-24329: --- This comment should originally go onto HBASE-24305. Just

[jira] [Updated] (HBASE-24329) Remove deprecated CoprocessorService

2020-05-08 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-24329: -- Fix Version/s: (was: 3.0.0-alpha-1) > Remove deprecated CoprocessorService >

[jira] [Updated] (HBASE-24329) Remove deprecated CoprocessorService

2020-05-08 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-24329: -- Status: In Progress (was: Patch Available) > Remove deprecated CoprocessorService >

[jira] [Updated] (HBASE-23844) Remove deprecated Scan(byte[], Filter) from Scan

2020-05-08 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-23844: -- Fix Version/s: 3.0.0-alpha-1 > Remove deprecated Scan(byte[], Filter) from Scan >

[jira] [Commented] (HBASE-24310) Use Slf4jRequestLog for hbase-http

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102456#comment-17102456 ] Hudson commented on HBASE-24310: Results for branch branch-2.3 [build #72 on

[GitHub] [hbase] Apache-HBase commented on pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1640: URL: https://github.com/apache/hbase/pull/1640#issuecomment-625767309 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.

2020-05-08 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102520#comment-17102520 ] Viraj Jasani commented on HBASE-24327: -- [~markrmiller] Can I take this up? I have a small patch. >

[GitHub] [hbase] huaxiangsun commented on pull request #1584: HBASE-24256 When fixOverlap hits the max region limit, it is possible…

2020-05-08 Thread GitBox
huaxiangsun commented on pull request #1584: URL: https://github.com/apache/hbase/pull/1584#issuecomment-625922815 Merged the change, thanks for review. This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] ndimiduk commented on pull request #1485: HBASE-23969 Meta browser should show all `info` columns

2020-05-08 Thread GitBox
ndimiduk commented on pull request #1485: URL: https://github.com/apache/hbase/pull/1485#issuecomment-625923399 This looks good to merge. @saintstack any other concerns with the changes to `MetaTableAccessor` ? This is an

[GitHub] [hbase] Apache-HBase commented on pull request #1682: Backport: HBASE-24273 HBCK's "Orphan Regions on FileSystem" reports regions wit…

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1682: URL: https://github.com/apache/hbase/pull/1682#issuecomment-625923919 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1684: URL: https://github.com/apache/hbase/pull/1684#issuecomment-625924985 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-23927) hbck2 assigns command should accept a file containing a list of region names

2020-05-08 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-23927: Assignee: Huaxiang Sun (was: Hua Xiang) > hbck2 assigns command should accept a file

[GitHub] [hbase] saintstack edited a comment on pull request #1664: HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to…

2020-05-08 Thread GitBox
saintstack edited a comment on pull request #1664: URL: https://github.com/apache/hbase/pull/1664#issuecomment-625883657 These PRs run with -Phadoop-3.0, not -Dhadoop.profile=3.0 (see console log). They run w/ config that is not the same as nightly (an issue Nick has been talking up).

[jira] [Commented] (HBASE-23832) Old config hbase.hstore.compactionThreshold is ignored

2020-05-08 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102784#comment-17102784 ] Anoop Sam John commented on HBASE-23832: [~busbey] Ya there are 4 configs in the renamed list.

[GitHub] [hbase] Apache-HBase commented on pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1684: URL: https://github.com/apache/hbase/pull/1684#issuecomment-625891717 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625905169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625910649 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1485: HBASE-23969 Meta browser should show all `info` columns

2020-05-08 Thread GitBox
ndimiduk commented on a change in pull request #1485: URL: https://github.com/apache/hbase/pull/1485#discussion_r422252959 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java ## @@ -17,14 +17,22 @@ */ package

[GitHub] [hbase] Apache-HBase commented on pull request #1686: Backport HBASE-24345 to branch-2

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1686: URL: https://github.com/apache/hbase/pull/1686#issuecomment-625876141 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1686: Backport HBASE-24345 to branch-2

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1686: URL: https://github.com/apache/hbase/pull/1686#issuecomment-625881153 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-05-08 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102636#comment-17102636 ] Josh Elser commented on HBASE-23887: Thanks Danil! Your edits here are greatly appreciated. This

[GitHub] [hbase] Apache-HBase commented on pull request #1685: Backport "HBASE-24305 Prepare deprecations in ServerName (#1666)" to branch-2

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1685: URL: https://github.com/apache/hbase/pull/1685#issuecomment-625857286 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Reidddddd opened a new pull request #1686: Backport HBASE-24345 to branch-2

2020-05-08 Thread GitBox
Reidd opened a new pull request #1686: URL: https://github.com/apache/hbase/pull/1686 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] saintstack commented on pull request #1664: HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to…

2020-05-08 Thread GitBox
saintstack commented on pull request #1664: URL: https://github.com/apache/hbase/pull/1664#issuecomment-625883657 These PRs run with -Phadoop-3.0, not -Dhadoop.profile=3.0 (see console log). They run w/ config that is not the same as nightly (an issue Nick has been talking up). The REST

[GitHub] [hbase] Apache-HBase commented on pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1640: URL: https://github.com/apache/hbase/pull/1640#issuecomment-625865261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1686: Backport HBASE-24345 to branch-2

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1686: URL: https://github.com/apache/hbase/pull/1686#issuecomment-625878024 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1685: Backport "HBASE-24305 Prepare deprecations in ServerName (#1666)" to branch-2

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1685: URL: https://github.com/apache/hbase/pull/1685#issuecomment-625950856 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1685: Backport "HBASE-24305 Prepare deprecations in ServerName (#1666)" to branch-2

2020-05-08 Thread GitBox
Apache-HBase commented on pull request #1685: URL: https://github.com/apache/hbase/pull/1685#issuecomment-625954145 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24345) [ACL] renameRSGroup should require Admin level permission

2020-05-08 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102824#comment-17102824 ] Anoop Sam John commented on HBASE-24345: So in Master branch we are again doing the RS group

[GitHub] [hbase] bharathv commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

2020-05-08 Thread GitBox
bharathv commented on a change in pull request #1684: URL: https://github.com/apache/hbase/pull/1684#discussion_r422305113 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java ## @@ -163,7 +164,16 @@ public void

[GitHub] [hbase] saintstack commented on pull request #1482: HBASE-24152 Add ServerSsdLocalityCostFunction to StochasticLoadBalancer

2020-05-08 Thread GitBox
saintstack commented on pull request #1482: URL: https://github.com/apache/hbase/pull/1482#issuecomment-625958604 @bsglz Any comment on the @anoopsjohn remark above? File a follow-on @anoopsjohn ? This is an

[GitHub] [hbase] binlijin commented on pull request #1683: HBASE-24345 [ACL] renameRSGroup should require Admin level permission

2020-05-08 Thread GitBox
binlijin commented on pull request #1683: URL: https://github.com/apache/hbase/pull/1683#issuecomment-625648699 Add some test for it? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Reidddddd opened a new pull request #1683: HBASE-24345 [ACL] renameRSGroup should require Admin level permission

2020-05-08 Thread GitBox
Reidd opened a new pull request #1683: URL: https://github.com/apache/hbase/pull/1683 JIRA: [HBASE-24345](https://issues.apache.org/jira/browse/HBASE-24345) This is an automated message from the Apache Git Service. To

[jira] [Reopened] (HBASE-24284) [h3/jdk11] REST server won't start

2020-05-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HBASE-24284: --- Reopen to push addendum which readds jaxb to hadoop3 profile only: {code} diff --git

[jira] [Commented] (HBASE-24284) [h3/jdk11] REST server won't start

2020-05-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102902#comment-17102902 ] Michael Stack commented on HBASE-24284: --- Pushed this: {code} commit

[jira] [Commented] (HBASE-24189) Regionserver recreates region folders in HDFS after replaying WAL with removed table entries

2020-05-08 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102856#comment-17102856 ] Anoop Sam John commented on HBASE-24189: What do you think about above approach [~timoha]? >

[GitHub] [hbase] virajjasani commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

2020-05-08 Thread GitBox
virajjasani commented on a change in pull request #1684: URL: https://github.com/apache/hbase/pull/1684#discussion_r422315817 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java ## @@ -163,7 +164,16 @@ public void

[jira] [Commented] (HBASE-24152) Add ServerSsdLocalityCostFunction to StochasticLoadBalancer

2020-05-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102849#comment-17102849 ] Michael Stack commented on HBASE-24152: --- Was reviewing the PR but figured don't have enough

[jira] [Commented] (HBASE-24328) skip duplicate GCMultipleMergedRegionsProcedure while previous finished

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102852#comment-17102852 ] Hudson commented on HBASE-24328: Results for branch branch-2.2 [build #856 on

[jira] [Commented] (HBASE-24284) [h3/jdk11] REST server won't start

2020-05-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102885#comment-17102885 ] Michael Stack commented on HBASE-24284: --- This broke some of the MR tests. Stuff won't start. Saw

[GitHub] [hbase] bharathv commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

2020-05-08 Thread GitBox
bharathv commented on a change in pull request #1684: URL: https://github.com/apache/hbase/pull/1684#discussion_r422412820 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java ## @@ -163,7 +164,16 @@ public void

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1675: HBASE-24341 The region should be removed from ConfigurationManager as…

2020-05-08 Thread GitBox
anoopsjohn commented on a change in pull request #1675: URL: https://github.com/apache/hbase/pull/1675#discussion_r422327852 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationManager.java ## @@ -137,4 +138,14 @@ public int getNumObservers() {

[jira] [Commented] (HBASE-23968) Periodically check whether a system stop is requested in compaction by time.

2020-05-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102863#comment-17102863 ] Michael Stack commented on HBASE-23968: --- So, the time-based check here can get frustrated by

[jira] [Commented] (HBASE-24284) [h3/jdk11] REST server won't start

2020-05-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102909#comment-17102909 ] Michael Stack commented on HBASE-24284: --- Confirmed the REST server still starts. > [h3/jdk11]

[GitHub] [hbase] saintstack commented on a change in pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-05-08 Thread GitBox
saintstack commented on a change in pull request #1640: URL: https://github.com/apache/hbase/pull/1640#discussion_r422369449 ## File path: hbase-assembly/pom.xml ## @@ -318,5 +318,18 @@ jaxws-ri pom + Review comment: I'm asking about running an

[GitHub] [hbase] virajjasani commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

2020-05-08 Thread GitBox
virajjasani commented on a change in pull request #1684: URL: https://github.com/apache/hbase/pull/1684#discussion_r422318551 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java ## @@ -163,7 +164,16 @@ public void

[GitHub] [hbase] virajjasani commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

2020-05-08 Thread GitBox
virajjasani commented on a change in pull request #1684: URL: https://github.com/apache/hbase/pull/1684#discussion_r422339899 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java ## @@ -163,7 +164,16 @@ public void

[jira] [Resolved] (HBASE-24331) [Flakey Test] TestJMXListener rmi port clash

2020-05-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24331. --- Fix Version/s: 2.3.0 3.0.0-alpha-1 Assignee: Michael Stack

[GitHub] [hbase] virajjasani commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

2020-05-08 Thread GitBox
virajjasani commented on a change in pull request #1684: URL: https://github.com/apache/hbase/pull/1684#discussion_r422339899 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java ## @@ -163,7 +164,16 @@ public void

[jira] [Resolved] (HBASE-24284) [h3/jdk11] REST server won't start

2020-05-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24284. --- Resolution: Fixed Re-resolved after pushing above addendum. > [h3/jdk11] REST server won't

[GitHub] [hbase] Apache9 commented on a change in pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-05-08 Thread GitBox
Apache9 commented on a change in pull request #1640: URL: https://github.com/apache/hbase/pull/1640#discussion_r422440815 ## File path: hbase-assembly/pom.xml ## @@ -318,5 +318,18 @@ jaxws-ri pom + Review comment: We could do this? I'v never

[jira] [Commented] (HBASE-24152) Add ServerSsdLocalityCostFunction to StochasticLoadBalancer

2020-05-08 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103071#comment-17103071 ] Zheng Wang commented on HBASE-24152: {quote}Was reviewing the PR but figured don't have enough

[jira] [Commented] (HBASE-24284) [h3/jdk11] REST server won't start

2020-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103113#comment-17103113 ] Hudson commented on HBASE-24284: Results for branch branch-2 [build #2651 on

  1   2   >