[GitHub] [hbase] songxincun commented on a change in pull request #1803: HBASE-24468 Add region info when log meessages in HStore.

2020-06-01 Thread GitBox
songxincun commented on a change in pull request #1803: URL: https://github.com/apache/hbase/pull/1803#discussion_r433061819 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1953,8 +1950,7 @@ public boolean

[jira] [Commented] (HBASE-24436) The store file open and close thread pool should be shared at the region level

2020-06-01 Thread Junhong Xu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120776#comment-17120776 ] Junhong Xu commented on HBASE-24436: Ping [~anoop.hbase][~apurtell] the patch has been updated,

[jira] [Resolved] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction

2020-06-01 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada resolved HBASE-24479. -- Fix Version/s: 2.4.0 1.7.0 2.3.0

[jira] [Resolved] (HBASE-24346) TestWALProcedureStoreOnHDFS#testWalAbortOnLowReplicationWithQueuedWriters fails too easily.

2020-06-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24346. --- Resolution: Later Seems not flaky any more. Can reopen if it is still a problem. >

[GitHub] [hbase] bsglz commented on pull request #1799: HBASE-24455 Correct the doc of "On the number of column families"

2020-06-01 Thread GitBox
bsglz commented on pull request #1799: URL: https://github.com/apache/hbase/pull/1799#issuecomment-636726358 Thanks of all your comment. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] virajjasani commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-01 Thread GitBox
virajjasani commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r433123320 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java ## @@ -164,7 +164,11 @@ public int getReplicaId() { * @param

[jira] [Commented] (HBASE-24347) Hadoop2 profiles are both active when pre-commit PR builds run

2020-06-01 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120833#comment-17120833 ] Guanghao Zhang commented on HBASE-24347: Ok, let me cherry-pick this to branch-2.2. > Hadoop2

[GitHub] [hbase] Apache9 commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-01 Thread GitBox
Apache9 commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r433111346 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,477 @@ +/* + * + * Licensed to the Apache

[jira] [Resolved] (HBASE-24455) Correct the doc of "On the number of column families"

2020-06-01 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24455. -- Fix Version/s: 2.2.6 1.7.0 2.3.0

[jira] [Resolved] (HBASE-23952) Address thread safety issue with Map used in BufferCallBeforeInitHandler.

2020-06-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23952. --- Resolution: Won't Fix Close as won't fix. Please see the dicussion on PR. > Address thread safety

[GitHub] [hbase] Apache-HBase commented on pull request #1803: HBASE-24468 Add region info when log meessages in HStore.

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636718338 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-01 Thread GitBox
bsglz commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r433122611 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceIdAccounting.java ## @@ -440,27 +434,27 @@ boolean areAllLower(Map

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-06-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120905#comment-17120905 ] Hudson commented on HBASE-11288: Results for branch HBASE-11288.splittable-meta [build #1 on

[jira] [Resolved] (HBASE-21366) Optionally ignore edits for deleted columns when replication

2020-06-01 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-21366. Resolution: Duplicate Duolicate with HBASE-24359. > Optionally ignore edits for deleted

[GitHub] [hbase] binlijin commented on pull request #1801: HBASE-24441 CacheConfig details logged at Store open is not really u…

2020-06-01 Thread GitBox
binlijin commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636639600 So this pr rely on HBASE-24468? Others are good to me. This is an automated message from the Apache Git Service.

[GitHub] [hbase] Apache-HBase commented on pull request #1821: HBASE-24480: Deflake TestRSGroupsBasics#testClearDeadServers

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1821: URL: https://github.com/apache/hbase/pull/1821#issuecomment-636681812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1822: HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1822: URL: https://github.com/apache/hbase/pull/1822#issuecomment-636744721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-24049) "Packaging and Integration" check fails

2020-06-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120906#comment-17120906 ] Hudson commented on HBASE-24049: Results for branch HBASE-24049-packaging-integration-hadoop-2.10.0

[jira] [Created] (HBASE-24485) Backport to branch-1 HBASE-17738 BucketCache startup is slow

2020-06-01 Thread tianhang tang (Jira)
tianhang tang created HBASE-24485: - Summary: Backport to branch-1 HBASE-17738 BucketCache startup is slow Key: HBASE-24485 URL: https://issues.apache.org/jira/browse/HBASE-24485 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #1803: HBASE-24468 Add region info when log meessages in HStore.

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636653001 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23296) Add CompositeBucketCache to support tiered BC

2020-06-01 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120804#comment-17120804 ] Guanghao Zhang commented on HBASE-23296: {quote}yes, we need a bigger L1, it's not suitable to

[jira] [Comment Edited] (HBASE-23296) Add CompositeBucketCache to support tiered BC

2020-06-01 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120804#comment-17120804 ] Guanghao Zhang edited comment on HBASE-23296 at 6/1/20, 7:44 AM: -

[GitHub] [hbase] bsglz commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-01 Thread GitBox
bsglz commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r433122752 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -639,26 +641,30 @@ public int getNumLogFiles() {

[GitHub] [hbase] virajjasani commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-01 Thread GitBox
virajjasani commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r433138927 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,477 @@ +/* + * + * Licensed to the Apache

[GitHub] [hbase] bsglz commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-01 Thread GitBox
bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-636635800 @Apache9 @saintstack Could you help to review it, thanks. This is an automated message from the Apache Git Service.

[GitHub] [hbase] Apache9 commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-01 Thread GitBox
Apache9 commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r430390208 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceIdAccounting.java ## @@ -440,27 +434,27 @@ boolean

[jira] [Commented] (HBASE-24347) Hadoop2 profiles are both active when pre-commit PR builds run

2020-06-01 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120849#comment-17120849 ] Guanghao Zhang commented on HBASE-24347: [~zhangduo] branch-2.2 seems not have 

[jira] [Updated] (HBASE-24483) Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-01 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24483: --- Description: Current it is not easy to find which one is repeated if the input prefixes are not a

[jira] [Commented] (HBASE-23296) Add CompositeBucketCache to support tiered BC

2020-06-01 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120882#comment-17120882 ] Anoop Sam John commented on HBASE-23296: bq.Why don't use bigger heap as L1, because gc problem?

[jira] [Created] (HBASE-24484) Scanners for Replicas region return many HFileLink name exceptions

2020-06-01 Thread liangxiaodong (Jira)
liangxiaodong created HBASE-24484: - Summary: Scanners for Replicas region return many HFileLink name exceptions Key: HBASE-24484 URL: https://issues.apache.org/jira/browse/HBASE-24484 Project: HBase

[GitHub] [hbase] binlijin commented on a change in pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-06-01 Thread GitBox
binlijin commented on a change in pull request #1803: URL: https://github.com/apache/hbase/pull/1803#discussion_r433059865 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1953,8 +1950,7 @@ public boolean

[GitHub] [hbase] binlijin edited a comment on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-06-01 Thread GitBox
binlijin edited a comment on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636635578 Change title from [HBASE-24468]Add region info when log meessages in HStore. to HBASE-24468 Add region info when log meessages in HStore. ? remove the braces.

[GitHub] [hbase] binlijin commented on pull request #1803: [HBASE-24468]Add region info when log meessages in HStore.

2020-06-01 Thread GitBox
binlijin commented on pull request #1803: URL: https://github.com/apache/hbase/pull/1803#issuecomment-636635578 Change [HBASE-24468]Add region info when log meessages in HStore. to HBASE-24468 Add region info when log meessages in HStore. ? remove the braces.

[GitHub] [hbase] bsglz commented on pull request #1799: HBASE-24455 Correct the doc of "On the number of column families"

2020-06-01 Thread GitBox
bsglz commented on pull request #1799: URL: https://github.com/apache/hbase/pull/1799#issuecomment-636635577 @wchevreuil @virajjasani Could you help to merge it, thanks. This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #1821: HBASE-24480: Deflake TestRSGroupsBasics#testClearDeadServers

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1821: URL: https://github.com/apache/hbase/pull/1821#issuecomment-636644401 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz opened a new pull request #1822: HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-01 Thread GitBox
bsglz opened a new pull request #1822: URL: https://github.com/apache/hbase/pull/1822 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] songxincun commented on pull request #1801: HBASE-24441 CacheConfig details logged at Store open is not really u…

2020-06-01 Thread GitBox
songxincun commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636641666 > So this pr rely on HBASE-24468? Others are good to me. Yes, this pr rely the new HStore#toString() provided by HBASE-24468

[GitHub] [hbase] virajjasani commented on pull request #1821: HBASE-24480: Deflake TestRSGroupsBasics#testClearDeadServers

2020-06-01 Thread GitBox
virajjasani commented on pull request #1821: URL: https://github.com/apache/hbase/pull/1821#issuecomment-636694729 Looks like you removed them already :) This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] virajjasani merged pull request #1799: HBASE-24455 Correct the doc of "On the number of column families"

2020-06-01 Thread GitBox
virajjasani merged pull request #1799: URL: https://github.com/apache/hbase/pull/1799 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1801: HBASE-24441 CacheConfig details logged at Store open is not really u…

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1801: URL: https://github.com/apache/hbase/pull/1801#issuecomment-636700814 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-01 Thread GitBox
bsglz commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r433123740 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java ## @@ -9,7 +9,7 @@ * with the License. You

[GitHub] [hbase] virajjasani commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-01 Thread GitBox
virajjasani commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r433121670 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,477 @@ +/* + * + * Licensed to the Apache

[jira] [Commented] (HBASE-24347) Hadoop2 profiles are both active when pre-commit PR builds run

2020-06-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120897#comment-17120897 ] Duo Zhang commented on HBASE-24347: --- The code in jenkins_precommit_github_yetus.sh are in

[jira] [Created] (HBASE-24483) Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-01 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-24483: -- Summary: Add repeated prefix logging for MultipleColumnPrefixFilter Key: HBASE-24483 URL: https://issues.apache.org/jira/browse/HBASE-24483 Project: HBase Issue

[jira] [Commented] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction

2020-06-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120841#comment-17120841 ] Hudson commented on HBASE-24479: Results for branch branch-1 [build #1305 on

[jira] [Commented] (HBASE-24477) Move ConfigurationObserver and related classes to hbase-common

2020-06-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120839#comment-17120839 ] Hudson commented on HBASE-24477: Results for branch branch-1 [build #1305 on

[jira] [Commented] (HBASE-24069) Extend HBASE-16209 strategy (Provide an ExponentialBackOffPolicy sleep between failed region open requests) to region close and split requests

2020-06-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120840#comment-17120840 ] Hudson commented on HBASE-24069: Results for branch branch-1 [build #1305 on

[jira] [Commented] (HBASE-24455) Correct the doc of "On the number of column families"

2020-06-01 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120862#comment-17120862 ] Zheng Wang commented on HBASE-24455: Thanks. > Correct the doc of "On the number of column

[GitHub] [hbase] Apache9 closed pull request #1261: HBASE-23952: Address thread safety issue with Map used in BufferCallB…

2020-06-01 Thread GitBox
Apache9 closed pull request #1261: URL: https://github.com/apache/hbase/pull/1261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 closed pull request #1688: HBASE-24346: TestWALProcedureStoreOnHDFS#testWalAbortOnLowReplication…

2020-06-01 Thread GitBox
Apache9 closed pull request #1688: URL: https://github.com/apache/hbase/pull/1688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1822: HBASE-24483 Add repeated prefix logging for MultipleColumnPrefixFilter

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1822: URL: https://github.com/apache/hbase/pull/1822#issuecomment-636738546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache9 commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-01 Thread GitBox
Apache9 commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r433135098 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,477 @@ +/* + * + * Licensed to the Apache

[GitHub] [hbase] Apache9 commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion

2020-06-01 Thread GitBox
Apache9 commented on a change in pull request #1811: URL: https://github.com/apache/hbase/pull/1811#discussion_r433583919 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -258,6 +259,14 @@ public static final String

[GitHub] [hbase] Apache9 merged pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion

2020-06-01 Thread GitBox
Apache9 merged pull request #1811: URL: https://github.com/apache/hbase/pull/1811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] songxincun commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-06-01 Thread GitBox
songxincun commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-637233794 > May I recommend regionsInfo instead of regionInfos? IMO, The variable type is final RegionInfo..., it represent to a list of regioninfo, not a info of regions. So I

[jira] [Commented] (HBASE-23296) Add CompositeBucketCache to support tiered BC

2020-06-01 Thread chenxu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121511#comment-17121511 ] chenxu commented on HBASE-23296: bq. Why don't use bigger heap as L1, because gc problem? Do you mean

[GitHub] [hbase] Apache-HBase commented on pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1730: URL: https://github.com/apache/hbase/pull/1730#issuecomment-637262268 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1648: URL: https://github.com/apache/hbase/pull/1648#issuecomment-637212740 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-24184) listSnapshots returns empty when just use simple acl but not use authentication

2020-06-01 Thread tianhang tang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121480#comment-17121480 ] tianhang tang commented on HBASE-24184: --- [~binlijin] Hi, I notice that

[GitHub] [hbase] saintstack commented on a change in pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-06-01 Thread GitBox
saintstack commented on a change in pull request #1648: URL: https://github.com/apache/hbase/pull/1648#discussion_r433579358 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java ## @@ -318,38 +319,28 @@ private void preCheck() {

[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-01 Thread GitBox
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-637222180 I think the problem here is in the implementation of updateProgress? We pass updateState as false when calling it in the deserialize method, but the only place to update the

[GitHub] [hbase] Apache-HBase commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-637221760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24474) Rename LocalRegion to MasterRegion

2020-06-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24474: -- Hadoop Flags: Reviewed > Rename LocalRegion to MasterRegion > -- > >

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-01 Thread GitBox
anoopsjohn commented on a change in pull request #1825: URL: https://github.com/apache/hbase/pull/1825#discussion_r433601716 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile,

[GitHub] [hbase] Apache-HBase commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-637254074 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-637255117 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-24474) Rename LocalRegion to MasterRegion

2020-06-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24474. --- Resolution: Fixed Pushed to branch-2.3+. Thanks all for reviewing. > Rename LocalRegion to

[jira] [Work started] (HBASE-24485) Backport to branch-1 HBASE-17738 BucketCache startup is slow

2020-06-01 Thread tianhang tang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24485 started by tianhang tang. - > Backport to branch-1 HBASE-17738 BucketCache startup is slow >

[GitHub] [hbase] thangTang closed pull request #1530: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication

2020-06-01 Thread GitBox
thangTang closed pull request #1530: URL: https://github.com/apache/hbase/pull/1530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion

2020-06-01 Thread GitBox
Apache9 commented on a change in pull request #1811: URL: https://github.com/apache/hbase/pull/1811#discussion_r433584900 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1563,7 +1564,7 @@ protected void stopServiceThreads() {

[GitHub] [hbase] sguggilam opened a new pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-01 Thread GitBox
sguggilam opened a new pull request #1828: URL: https://github.com/apache/hbase/pull/1828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache9 commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion

2020-06-01 Thread GitBox
Apache9 commented on a change in pull request #1811: URL: https://github.com/apache/hbase/pull/1811#discussion_r433582964 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java ## @@ -79,14 +79,14 @@ * Notice that, you can use

[GitHub] [hbase] bsglz commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-01 Thread GitBox
bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-637243836 rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-637248419 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-24489) Rewrite TestClusterRestartFailover.test since namespace table is gone on on master

2020-06-01 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24489: - Summary: Rewrite TestClusterRestartFailover.test since namespace table is gone on on master Key: HBASE-24489 URL: https://issues.apache.org/jira/browse/HBASE-24489

[GitHub] [hbase] Apache-HBase commented on pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1828: URL: https://github.com/apache/hbase/pull/1828#issuecomment-637257780 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion

2020-06-01 Thread GitBox
ndimiduk commented on a change in pull request #1811: URL: https://github.com/apache/hbase/pull/1811#discussion_r433425854 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -450,7 +451,7 @@ public void run() { private ProcedureStore

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-01 Thread GitBox
anoopsjohn commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r433431811 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,477 @@ +/* + * + * Licensed to the Apache

[jira] [Resolved] (HBASE-7345) subprocedure zk info should be dumpable from the shell

2020-06-01 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-7345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-7345. -- Resolution: Incomplete Resolving old issue. I think its about stages of a snapshot which we

[jira] [Resolved] (HBASE-7368) Add shell tricks documentation to the refguide

2020-06-01 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-7368. -- Resolution: Incomplete Resolving old, incomplete. > Add shell tricks documentation to the

[jira] [Commented] (HBASE-23959) Fix javadoc for JDK11

2020-06-01 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121308#comment-17121308 ] Nick Dimiduk commented on HBASE-23959: -- >From a random jenkins job, {noformat} [ERROR] Failed to

[jira] [Commented] (HBASE-13541) Deprecate Scan caching in 2.0.0

2020-06-01 Thread Andrew Olson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121317#comment-17121317 ] Andrew Olson commented on HBASE-13541: -- I realize it's been over 5 years since this issue was

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2020-06-01 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121247#comment-17121247 ] Geoffrey Jacoby commented on HBASE-24440: - [~apurtell] - in HBase 2.x and above, the

[jira] [Resolved] (HBASE-7161) Table does not come out of 'enabling' state

2020-06-01 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-7161. -- Resolution: Later Resolving old issue as 'later'/no-longer-pertinent > Table does not come

[GitHub] [hbase] Apache-HBase commented on pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1825: URL: https://github.com/apache/hbase/pull/1825#issuecomment-637085971 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-06-01 Thread GitBox
huaxiangsun commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-637017304 +1 for the new diff, looks great! This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2020-06-01 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121293#comment-17121293 ] Andrew Kyle Purtell commented on HBASE-24440: - I am aware. If we do this I don’t think we

[GitHub] [hbase] saintstack commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-01 Thread GitBox
saintstack commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r433401973 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1727,6 +1727,15 @@ possible configurations would overwhelm and obscure the

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2020-06-01 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121223#comment-17121223 ] Andrew Kyle Purtell commented on HBASE-24440: - Correct [~anoop.hbase] , two versions with

[GitHub] [hbase] Apache-HBase commented on pull request #1823: HBASE-24485 Backport to branch-1 HBASE-17738 BucketCache startup is slow

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1823: URL: https://github.com/apache/hbase/pull/1823#issuecomment-637026079 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-01 Thread GitBox
virajjasani commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r433410406 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,477 @@ +/* + * + * Licensed to the Apache

[jira] [Commented] (HBASE-24347) Hadoop2 profiles are both active when pre-commit PR builds run

2020-06-01 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121248#comment-17121248 ] Nick Dimiduk commented on HBASE-24347: -- [~zghao] I think much of the CI refactoring I did to

[GitHub] [hbase] saintstack commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion

2020-06-01 Thread GitBox
saintstack commented on a change in pull request #1811: URL: https://github.com/apache/hbase/pull/1811#discussion_r433453029 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java ## @@ -284,18 +284,21 @@ public static LocalRegion

[jira] [Created] (HBASE-24487) Add 2.3 Documentation to the website

2020-06-01 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24487: Summary: Add 2.3 Documentation to the website Key: HBASE-24487 URL: https://issues.apache.org/jira/browse/HBASE-24487 Project: HBase Issue Type: Sub-task

[jira] [Commented] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration

2020-06-01 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121216#comment-17121216 ] Michael Stack commented on HBASE-20904: --- [~mmpataki] added helpful note up on the PR. I'm adding

[GitHub] [hbase] Apache-HBase commented on pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1825: URL: https://github.com/apache/hbase/pull/1825#issuecomment-637026477 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-19455) Try to re-enable a disabled BucketCache after a set timeout

2020-06-01 Thread Zach York (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121243#comment-17121243 ] Zach York commented on HBASE-19455: --- [~anoop.hbase] I probably won't be able to take this up anytime

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-01 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-637039368 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Comment Edited] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2020-06-01 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121293#comment-17121293 ] Andrew Kyle Purtell edited comment on HBASE-24440 at 6/1/20, 8:12 PM:

[jira] [Commented] (HBASE-24347) Hadoop2 profiles are both active when pre-commit PR builds run

2020-06-01 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121266#comment-17121266 ] Josh Elser commented on HBASE-24347: Thanks Duo and Guanghao :) > Hadoop2 profiles are both active

  1   2   3   >