[GitHub] [hbase] Apache-HBase commented on pull request #2496: HBASE-25151 warmupRegion frustrates registering WALs on the catalog r…

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2496: URL: https://github.com/apache/hbase/pull/2496#issuecomment-704780634 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2506: HBASE-25160 Refactor AccessController and VisibilityController

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2506: URL: https://github.com/apache/hbase/pull/2506#issuecomment-704746525 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2506: HBASE-25160 Refactor AccessController and VisibilityController

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2506: URL: https://github.com/apache/hbase/pull/2506#issuecomment-704775858 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2496: HBASE-25151 warmupRegion frustrates registering WALs on the catalog r…

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2496: URL: https://github.com/apache/hbase/pull/2496#issuecomment-704715944 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2504: HBASE-22976 [HBCK2] Add RecoveredEditsPlayer

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2504: URL: https://github.com/apache/hbase/pull/2504#issuecomment-704745438 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2399: URL: https://github.com/apache/hbase/pull/2399#issuecomment-704762208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2399: URL: https://github.com/apache/hbase/pull/2399#issuecomment-704761459 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2399: URL: https://github.com/apache/hbase/pull/2399#issuecomment-704761549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-operator-tools] VictorZeng edited a comment on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-07 Thread GitBox
VictorZeng edited a comment on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-704896842 @wchevreuil There is no `HbckService` in versions of hbase _before 2.0.3 and 2.1.1_. HBCK2 will not work against these versions. If users use Hbase 2.1.0

[jira] [Reopened] (HBASE-25106) Migrate our jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-25106: --- > Migrate our jenkins job from Hadoop to hbase > > >

[jira] [Created] (HBASE-25162) Make flaky tests run moe aggressively

2020-10-07 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25162: - Summary: Make flaky tests run moe aggressively Key: HBASE-25162 URL: https://issues.apache.org/jira/browse/HBASE-25162 Project: HBase Issue Type: Sub-task

[jira] [Commented] (HBASE-22976) [HBCK2] Add RecoveredEditsPlayer

2020-10-07 Thread Martin Braun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209390#comment-17209390 ] Martin Braun commented on HBASE-22976: -- [~stack]: I am running hbase-2.2.5 with hadoop-2.8.5 >

[jira] [Updated] (HBASE-25161) [hbase-operator-tools] HBase metadata repair tool

2020-10-07 Thread Victor Zeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor Zeng updated HBASE-25161: Summary: [hbase-operator-tools] HBase metadata repair tool (was: HBase metadata repair tool) >

[jira] [Resolved] (HBASE-25134) Migrate HBase PreCommit jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25134. --- Fix Version/s: (was: 2.2.7) (was: 1.4.14) (was:

[jira] [Resolved] (HBASE-25106) Migrate our jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25106. --- Resolution: Fixed > Migrate our jenkins job from Hadoop to hbase >

[jira] [Commented] (HBASE-25106) Migrate our jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209512#comment-17209512 ] Duo Zhang commented on HBASE-25106: --- In general, since we are still allowed to use the Hadoop nodes, I

[jira] [Updated] (HBASE-25161) HBase metadata repair tool

2020-10-07 Thread Victor Zeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor Zeng updated HBASE-25161: Component/s: (was: hbck2) hbase-operator-tools > HBase metadata repair tool

[jira] [Resolved] (HBASE-25139) The new hbase jenkins node has something wrong when running UTs

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25139. --- Resolution: Fixed > The new hbase jenkins node has something wrong when running UTs >

[jira] [Updated] (HBASE-25106) Migrate our jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25106: -- Component/s: jenkins > Migrate our jenkins job from Hadoop to hbase >

[jira] [Updated] (HBASE-25132) Migrate flaky test jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25132: -- Component/s: jenkins > Migrate flaky test jenkins job from Hadoop to hbase >

[jira] [Updated] (HBASE-25133) Migrate HBase Nightly jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25133: -- Component/s: jenkins > Migrate HBase Nightly jenkins job from Hadoop to hbase >

[jira] [Updated] (HBASE-25136) Migrate HBase-Connectors-PreCommit jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25136: -- Component/s: jenkins > Migrate HBase-Connectors-PreCommit jenkins job from Hadoop to hbase >

[jira] [Created] (HBASE-25161) HBase metadata repair tool

2020-10-07 Thread Victor Zeng (Jira)
Victor Zeng created HBASE-25161: --- Summary: HBase metadata repair tool Key: HBASE-25161 URL: https://issues.apache.org/jira/browse/HBASE-25161 Project: HBase Issue Type: Improvement

[jira] [Updated] (HBASE-25161) HBase metadata repair tool

2020-10-07 Thread Victor Zeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor Zeng updated HBASE-25161: Affects Version/s: (was: hbase-operator-tools-1.0.0)

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-704862726 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase] virajjasani commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
virajjasani commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r500842594 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -371,7 +358,11 @@ private boolean

[GitHub] [hbase-operator-tools] VictorZeng opened a new pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-07 Thread GitBox
VictorZeng opened a new pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77 fix [HBASE-25161](https://issues.apache.org/jira/browse/HBASE-25161) This is an automated message from the Apache Git

[jira] [Commented] (HBASE-25139) The new hbase jenkins node has something wrong when running UTs

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209510#comment-17209510 ] Duo Zhang commented on HBASE-25139: --- The problem is that, the infra team configured something like

[jira] [Created] (HBASE-25163) Increase the timeout value for nightly jobs

2020-10-07 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25163: - Summary: Increase the timeout value for nightly jobs Key: HBASE-25163 URL: https://issues.apache.org/jira/browse/HBASE-25163 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] Apache-HBase commented on pull request #2504: HBASE-22976 [HBCK2] Add RecoveredEditsPlayer

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2504: URL: https://github.com/apache/hbase/pull/2504#issuecomment-704813871 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-704825283 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase-operator-tools] VictorZeng commented on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-07 Thread GitBox
VictorZeng commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-704896842 @wchevreuil There is no HbckService in versions of hbase before 2.0.3 and 2.1.1. HBCK2 will not work against these versions...

[GitHub] [hbase] virajjasani commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
virajjasani commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r500845391 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterChoreScheduled.java ## @@ -114,22 +113,27 @@ public void

[GitHub] [hbase] virajjasani commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
virajjasani commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-704797742 Will try to complete another pass by EOD. This is an automated message from the Apache Git Service. To

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-704879317 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-704889550 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase-operator-tools] VictorZeng commented on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-07 Thread GitBox
VictorZeng commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-704895158 This testcase for _RegionsMerger_ run failed: [INFO] --- [INFO] T E S T S [INFO]

[jira] [Updated] (HBASE-25161) HBase metadata repair tool

2020-10-07 Thread Victor Zeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor Zeng updated HBASE-25161: Affects Version/s: (was: 2.0.2) (was: 2.0.1)

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-704848751 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[jira] [Updated] (HBASE-25107) Migrate flaky reporting jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25107: -- Component/s: jenkins > Migrate flaky reporting jenkins job from Hadoop to hbase >

[jira] [Updated] (HBASE-25163) Increase the timeout value for nightly jobs

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25163: -- Component/s: jenkins > Increase the timeout value for nightly jobs >

[jira] [Updated] (HBASE-25162) Make flaky tests run more aggressively

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25162: -- Component/s: scripts > Make flaky tests run more aggressively >

[jira] [Updated] (HBASE-25137) Migrate HBase-Operator-Tools-PreCommit jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25137: -- Component/s: jenkins > Migrate HBase-Operator-Tools-PreCommit jenkins job from Hadoop to hbase >

[jira] [Updated] (HBASE-25139) The new hbase jenkins node has something wrong when running UTs

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25139: -- Component/s: jenkins > The new hbase jenkins node has something wrong when running UTs >

[jira] [Updated] (HBASE-25162) Make flaky tests run more aggressively

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25162: -- Summary: Make flaky tests run more aggressively (was: Make flaky tests run moe aggressively) > Make

[jira] [Updated] (HBASE-25162) Make flaky tests run moe aggressively

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25162: -- Component/s: jenkins > Make flaky tests run moe aggressively > -

[jira] [Updated] (HBASE-25138) Migrate HBase-Thirdparty-PreCommit jenkins job from Hadoop to hbase

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25138: -- Component/s: jenkins > Migrate HBase-Thirdparty-PreCommit jenkins job from Hadoop to hbase >

[GitHub] [hbase-operator-tools] Apache9 commented on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-07 Thread GitBox
Apache9 commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-704914938 > Have you tried HBCK2 `addFsRegionsMissingInMeta` and `extraRegionsInMeta` functions? I believe those do the same as what you are proposing here, in other words, use

[jira] [Commented] (HBASE-25144) Add Hadoop-3.3.0 to personality hadoopcheck

2020-10-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209520#comment-17209520 ] Hudson commented on HBASE-25144: Results for branch master [build #85 on

[jira] [Updated] (HBASE-25099) Change meta replica count by altering meta table descriptor

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25099: -- Issue Type: Umbrella (was: Improvement) > Change meta replica count by altering meta table

[jira] [Updated] (HBASE-25164) Make ModifyTableProcedure support changing meta replica count

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25164: -- Description: And also make it compatible with the old way where we use a Configuration to set the

[GitHub] [hbase] saintstack commented on pull request #2504: HBASE-22976 [HBCK2] Add RecoveredEditsPlayer

2020-10-07 Thread GitBox
saintstack commented on pull request #2504: URL: https://github.com/apache/hbase/pull/2504#issuecomment-705081673 Fix tests w/ latest push. The tests were not factoring fact that now the file timestamp is considered. This

[GitHub] [hbase] Apache-HBase commented on pull request #2504: HBASE-22976 [HBCK2] Add RecoveredEditsPlayer

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2504: URL: https://github.com/apache/hbase/pull/2504#issuecomment-704957766 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25164) Make ModifyTableProcedure support changing meta replica count

2020-10-07 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25164: - Summary: Make ModifyTableProcedure support changing meta replica count Key: HBASE-25164 URL: https://issues.apache.org/jira/browse/HBASE-25164 Project: HBase

[jira] [Updated] (HBASE-25164) Make ModifyTableProcedure support changing meta replica count

2020-10-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25164: -- Component/s: read replicas meta > Make ModifyTableProcedure support changing meta

[GitHub] [hbase] saintstack commented on pull request #2496: HBASE-25151 warmupRegion frustrates registering WALs on the catalog r…

2020-10-07 Thread GitBox
saintstack commented on pull request #2496: URL: https://github.com/apache/hbase/pull/2496#issuecomment-705111813 Failures change w/ the test run. Seem unrelated (and pass locally). Let me merge to the HBASE-18070 branch.

[GitHub] [hbase] joshelser commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-07 Thread GitBox
joshelser commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705123438 > Isn't the pretty print because of HBASE-23930? Aha! Right you are. Sorry for sending you on a goose-chase.

[GitHub] [hbase] saintstack commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
saintstack commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r501291094 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/NormalizationTarget.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r501290825 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerManager.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to

[GitHub] [hbase] saintstack commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
saintstack commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r501292281 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerWorkQueue.java ## @@ -0,0 +1,244 @@ +/* + * Licensed

[jira] [Resolved] (HBASE-25151) warmupRegion frustrates registering WALs on the catalog replicationsource

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25151. --- Hadoop Flags: Reviewed Assignee: Michael Stack Resolution: Fixed Merged to

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r501269906 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerManager.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to

[jira] [Updated] (HBASE-22976) [HBCK2] Add RecoveredEditsPlayer

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-22976: -- Release Note: WALPlayer can replay the content of recovered.edits directories. Side-effect

[GitHub] [hbase] saintstack commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
saintstack commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r501292046 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerManager.java ## @@ -0,0 +1,178 @@ +/* + * Licensed

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r501303527 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -371,7 +358,11 @@ private boolean

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r501326147 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerManager.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to

[GitHub] [hbase] ndimiduk commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
ndimiduk commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r501326034 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerManager.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to

[GitHub] [hbase] saintstack commented on a change in pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
saintstack commented on a change in pull request #2454: URL: https://github.com/apache/hbase/pull/2454#discussion_r501329639 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/package-info.java ## @@ -0,0 +1,100 @@ +/* + * Licensed to the

[jira] [Updated] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-07 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25156: - Status: Patch Available (was: Open) PR Posted. > TestMasterFailover.testSimpleMasterFailover

[GitHub] [hbase] saintstack commented on a change in pull request #1727: HBASE-17756 We should have better introspection of HFiles

2020-10-07 Thread GitBox
saintstack commented on a change in pull request #1727: URL: https://github.com/apache/hbase/pull/1727#discussion_r501399549 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java ## @@ -593,6 +618,33 @@ private void

[GitHub] [hbase] saintstack commented on a change in pull request #1727: HBASE-17756 We should have better introspection of HFiles

2020-10-07 Thread GitBox
saintstack commented on a change in pull request #1727: URL: https://github.com/apache/hbase/pull/1727#discussion_r501400976 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java ## @@ -798,16 +809,15 @@ protected void finishFileInfo()

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-705293292 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m

[jira] [Resolved] (HBASE-4002) Int array based skip list

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-4002. -- Resolution: Later > Int array based skip list > - > >

[jira] [Resolved] (HBASE-13691) HTable and RPC Code Accessing Configuration each time (Blocking)

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-13691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-13691. --- Resolution: Later > HTable and RPC Code Accessing Configuration each time (Blocking) >

[jira] [Resolved] (HBASE-13690) Client Scanner Initialization Reformats strings every time

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-13690. --- Resolution: Later > Client Scanner Initialization Reformats strings every time >

[GitHub] [hbase] saintstack commented on pull request #2506: HBASE-25160 Refactor AccessController and VisibilityController

2020-10-07 Thread GitBox
saintstack commented on pull request #2506: URL: https://github.com/apache/hbase/pull/2506#issuecomment-705312761 Failure is probably not related. Let me retrip the build just in case. This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-705314172 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] saintstack commented on a change in pull request #2501: HBASE-25065 WAL archival can be batched/throttled and also done by a …

2020-10-07 Thread GitBox
saintstack commented on a change in pull request #2501: URL: https://github.com/apache/hbase/pull/2501#discussion_r501434229 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1905,8 +1906,8 @@ public boolean isOnline() {

[GitHub] [hbase] Apache-HBase commented on pull request #2508: HBASE-25165 Change 'State time' in UI so sorts

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2508: URL: https://github.com/apache/hbase/pull/2508#issuecomment-705317979 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-705319631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] brfrn169 commented on pull request #2506: HBASE-25160 Refactor AccessController and VisibilityController

2020-10-07 Thread GitBox
brfrn169 commented on pull request #2506: URL: https://github.com/apache/hbase/pull/2506#issuecomment-705323535 @saintstack Thank you very much for reviewing this. I just force-pushed a new patch to fix the checkstyle and spotbugs errors.

[GitHub] [hbase] Apache-HBase commented on pull request #1727: HBASE-17756 We should have better introspection of HFiles

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #1727: URL: https://github.com/apache/hbase/pull/1727#issuecomment-705324449 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] saintstack merged pull request #2500: HBASE-23959 Fix javadoc for JDK11

2020-10-07 Thread GitBox
saintstack merged pull request #2500: URL: https://github.com/apache/hbase/pull/2500 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HBASE-1978) Change the range/block index scheme from [start,end) to (start, end], and index range/block by endKey, specially in HFile

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-1978. -- Resolution: Later > Change the range/block index scheme from [start,end) to (start, end], and

[GitHub] [hbase] Apache-HBase commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-705330820 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Resolved] (HBASE-4040) Make HFilePrettyPrinter programmatically invocable and add JSON output

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-4040. -- Resolution: Later > Make HFilePrettyPrinter programmatically invocable and add JSON output >

[jira] [Updated] (HBASE-25092) RSGroupBalancer#assignments lost some regionPlans

2020-10-07 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-25092: --- Status: Patch Available (was: Open) > RSGroupBalancer#assignments lost some regionPlans >

[GitHub] [hbase] cuibo01 opened a new pull request #2509: [HBASE-25092]RSGroupBalancer#assignments lost some regionPlans

2020-10-07 Thread GitBox
cuibo01 opened a new pull request #2509: URL: https://github.com/apache/hbase/pull/2509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] cuibo01 closed pull request #2342: HBASE-24960 reduce invalid subprocedure task

2020-10-07 Thread GitBox
cuibo01 closed pull request #2342: URL: https://github.com/apache/hbase/pull/2342 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1727: HBASE-17756 We should have better introspection of HFiles

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #1727: URL: https://github.com/apache/hbase/pull/1727#issuecomment-705339746 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2507: HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2507: URL: https://github.com/apache/hbase/pull/2507#issuecomment-705339422 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #1727: HBASE-17756 We should have better introspection of HFiles

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #1727: URL: https://github.com/apache/hbase/pull/1727#issuecomment-705339189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #1727: HBASE-17756 We should have better introspection of HFiles

2020-10-07 Thread GitBox
saintstack commented on a change in pull request #1727: URL: https://github.com/apache/hbase/pull/1727#discussion_r501399099 ## File path: hbase-shaded/hbase-shaded-mapreduce/pom.xml ## @@ -164,6 +164,10 @@ javax.servlet.jsp

[GitHub] [hbase] Apache-HBase commented on pull request #2507: HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-07 Thread GitBox
Apache-HBase commented on pull request #2507: URL: https://github.com/apache/hbase/pull/2507#issuecomment-705284077 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-2685) Add activeMaster field to AClusterStatus record in Avro interface

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-2685. -- Resolution: Later > Add activeMaster field to AClusterStatus record in Avro interface >

[jira] [Resolved] (HBASE-2739) Master should fail to start if it cannot successfully split logs

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-2739. -- Resolution: Later > Master should fail to start if it cannot successfully split logs >

[jira] [Resolved] (HBASE-2934) Improve Example API Usage (in package-summary.html of org.apache.hadoop.hbase.client package)

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-2934. -- Resolution: Later > Improve Example API Usage (in package-summary.html of >

[jira] [Resolved] (HBASE-2690) Add support for setCacheBlocks() (regionserver level caching) and setCaching() (connector level caching) to scan operation in Avro interface

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-2690. -- Resolution: Later > Add support for setCacheBlocks() (regionserver level caching) and >

[GitHub] [hbase] jatsakthi commented on pull request #1174: HBASE-23827 [HBCK2] Add mergeRegions method to hbck service

2020-10-07 Thread GitBox
jatsakthi commented on pull request #1174: URL: https://github.com/apache/hbase/pull/1174#issuecomment-705303331 Sorry for the delay here, Stack. It would be some time before I can move this one forward due to lack of free cycles. Open for someone else picking this up if urgent.

[jira] [Resolved] (HBASE-3993) Alternatives to ConcurrentSkipListMap in MemStore

2020-10-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-3993. -- Resolution: Later > Alternatives to ConcurrentSkipListMap in MemStore >

  1   2   >